[PATCH 1/2] drm/amdgpu: use rpm_mode as runtime pm check flag

2022-11-20 Thread Guchun Chen
Driver was not calling BACO exit at all in runtime pm resume, and it caused the timing issue leading to a PCI AER error, as once system enters BACO, it's not reliable to check runtime pm mode by talking to SMU. So use rpm_mode instead as a general pm mode check to ensure driver executes BACO exit i

[PATCH 2/2] drm/amdgpu: poll BACO status after RPM BACO exits

2022-11-20 Thread Guchun Chen
After executing BACO exit, driver needs to poll the status to ensure FW has completed BACO exit sequence to prevent timing issue. Signed-off-by: Guchun Chen --- .../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c| 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/d

[PATCH 1/2] drm/amd/pm: update driver if header for smu_13_0_7

2022-11-20 Thread lyndonli
update driver if header for smu_13_0_7 Signed-off-by: lyndonli --- .../inc/pmfw_if/smu13_driver_if_v13_0_7.h | 117 -- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 2 +- 2 files changed, 81 insertions(+), 38 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/pmf

[PATCH 2/2] drm/amdgpu: add the fan abnormal detection feature

2022-11-20 Thread lyndonli
Update the SW CTF limit from existing register when there's a fan failure detected via SMU interrupt. Signed-off-by: lyndonli --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 1 + .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c| 28 +++ .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_p

RE: [PATCH] drm/amd/pm: Enable bad memory page/channel recording support for smu v13_0_0

2022-11-20 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Candice Li Sent: Saturday, November 19, 2022 12:42 To: amd-gfx@lists.freedesktop.org Cc: Li, Candice ; Quan, Evan Subject: [PATCH] drm/amd/pm: Enable bad memory p

RE: [PATCH 2/2] drm/amdgpu: add the fan abnormal detection feature

2022-11-20 Thread Zhang, Hawking
[AMD Official Use Only - General] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of lyndonli Sent: Monday, November 21, 2022 09:45 To: amd-gfx@lists.freedesktop.org Cc: Xu, Feifei ; enneth.f...@amd.com; Quan, Evan ; Li, Lyndon Subject

RE: [PATCH 2/2] drm/amdgpu: add the fan abnormal detection feature

2022-11-20 Thread Feng, Kenneth
[AMD Official Use Only - General] Series is Reviewed-by: Kenneth Feng -Original Message- From: amd-gfx On Behalf Of lyndonli Sent: Monday, November 21, 2022 9:45 AM To: amd-gfx@lists.freedesktop.org Cc: Xu, Feifei ; enneth.f...@amd.com; Quan, Evan ; Li, Lyndon Subject: [PATCH 2/2] drm

RE: [PATCH 2/2] drm/amdgpu: poll BACO status after RPM BACO exits

2022-11-20 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Chen, Guchun > Sent: Monday, November 21, 2022 8:39 AM > To: amd-gfx@lists.freedesktop.org; Deucher, Alexander > ; Zhang, Hawking > ; Lazar, Lijo ; Quan, Evan > > Cc: Chen, Guchun > Subject: [PATCH 2/2] drm/amdgpu: poll BA

Re: [PATCH 1/2] drm/amdgpu: use rpm_mode as runtime pm check flag

2022-11-20 Thread Lazar, Lijo
[AMD Official Use Only - General] Runtime PM can be disabled with a module param. BACO state is supported for non-RPM use cases also like regular suspend or a reset. Relying on RPM mode for BACO state is not the right thing to do. Thanks, Lijo From: Chen, Guchun

RE: [PATCH 1/2] drm/amd/pm: update driver if header for smu_13_0_7

2022-11-20 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: lyndonli > Sent: Monday, November 21, 2022 9:43 AM > To: amd-gfx@lists.freedesktop.org > Cc: enneth.f...@amd.com; Xu, Feifei ; Quan, Evan > ; Li, Lyndon > Subject: [PATCH 1/2] drm/amd/pm: update driver if header for smu_13_

RE: [PATCH Reivew 1/1] drm/amdgpu: fix use-after-free during gpu recovery

2022-11-20 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of > Stanley.Yang > Sent: Thursday, November 17, 2022 11:01 AM > To: amd-gfx@lists.freedesktop.org > Cc: Wang, YuBiao ; andrey.grodzov...@amd.com; > Yang, Stanley > Subject: [PATCH Re

[PATCH] drm/amdkfd: Release the topology_lock in error case

2022-11-20 Thread Ma Jun
From: Felix Kuehling Move the topology-locked part of kfd_topology_add_device into a separate function to simlpify error handling and release the topology lock consistently. Reported-by: Dan Carpenter Signed-off-by: Felix Kuehling Signed-off-by: Ma Jun --- drivers/gpu/drm/amd/amdkfd/kfd_topo