Re: [PATCH 2/5] x86/sgx: use VM_ACCESS_FLAGS

2022-10-23 Thread Jarkko Sakkinen
On Wed, Oct 19, 2022 at 11:49:42AM +0800, Kefeng Wang wrote: > Simplify VM_READ|VM_WRITE|VM_EXEC with VM_ACCESS_FLAGS. > > Cc: Jarkko Sakkinen > Cc: Dave Hansen > Signed-off-by: Kefeng Wang > --- > arch/x86/kernel/cpu/sgx/encl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [PATCH 2/5] x86/sgx: use VM_ACCESS_FLAGS

2022-10-23 Thread Jarkko Sakkinen
On Sun, Oct 23, 2022 at 11:07:47PM +0300, Jarkko Sakkinen wrote: > On Wed, Oct 19, 2022 at 11:49:42AM +0800, Kefeng Wang wrote: > > Simplify VM_READ|VM_WRITE|VM_EXEC with VM_ACCESS_FLAGS. > > > > Cc: Jarkko Sakkinen > > Cc: Dave Hansen > > Signed-off-by: Kefeng Wang > > --- > > arch/x86/kernel

Re: [PATCH] drm/amd/display: Revert logic for plane modifiers

2022-10-23 Thread Bas Nieuwenhuizen
Please also add a Cc: # 6.0.x to ensure it gets backported. On Fri, Oct 21, 2022 at 9:24 AM Joaquín Ignacio Aramendía wrote: > > This file was split in commit 5d945cbcd4b16a29d6470a80dfb19738f9a4319f > ("drm/amd/display: Create a file dedicated to planes") and the logic in > dm_plane_format_mo

RE: [PATCH] drm/amdgpu: set fb_modifiers_not_supported in vkms

2022-10-23 Thread Chen, Guchun
Maybe it's suggested to add it in amdgpu_vkms_sw_init? Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Yifan Zhang Sent: Sunday, October 23, 2022 12:03 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Yifan ; Wentland, Harry ; Koenig, Christian Subjec

[PATCH v2] drm/amdgpu: set fb_modifiers_not_supported in vkms

2022-10-23 Thread Yifan Zhang
This patch to fix the gdm3 start failure with virual display: /usr/libexec/gdm-x-session[1711]: (II) AMDGPU(0): Setting screen physical size to 270 x 203 /usr/libexec/gdm-x-session[1711]: (EE) AMDGPU(0): Failed to make import prime FD as pixmap: 22 /usr/libexec/gdm-x-session[1711]: (EE) AMDGPU(0

RE: [PATCH] drm/amdgpu: set fb_modifiers_not_supported in vkms

2022-10-23 Thread Zhang, Yifan
[AMD Official Use Only - General] Agree. Will change it in V2. Best Regards, Yifan -Original Message- From: Chen, Guchun Sent: Monday, October 24, 2022 12:38 PM To: Zhang, Yifan ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Yifan ; Wentland, Harry ; Koenig, Christia

RE: [PATCH v2] drm/amdgpu: set fb_modifiers_not_supported in vkms

2022-10-23 Thread Chen, Guchun
Acked-by: Guchun Chen Regards, Guchun -Original Message- From: Zhang, Yifan Sent: Monday, October 24, 2022 12:51 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Wentland, Harry ; Chen, Guchun ; Zhang, Yifan Subject: [PATCH v2] drm/amdgpu: set fb_mod

Re: [PATCH 08/13] drm/amdgpu: use scheduler depenencies for VM updates

2022-10-23 Thread Luben Tuikov
"dependencies" in the title. The rest looks good. I like pulling that sync free code into its own function. Regards, Luben On 2022-10-14 04:46, Christian König wrote: > Instead of putting that into the job sync object. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdg

Re: [PATCH 09/13] drm/amdgpu: use scheduler depenencies for UVD msgs

2022-10-23 Thread Luben Tuikov
Title: "dependencies". Regards, Luben On 2022-10-14 04:46, Christian König wrote: > Instead of putting that into the job sync object. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH 10/13] drm/amdgpu: use scheduler depenencies for CS

2022-10-23 Thread Luben Tuikov
Title: "dependencies" Regards, Luben On 2022-10-14 04:46, Christian König wrote: > Entirely remove the sync obj in the job. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 21 ++--- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.h | 2 ++ > driver

RE: [PATCH] drm/amdgpu: don't call drm_fb_helper_lastclose in lastclose()

2022-10-23 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, October 20, 2022 10:36 PM > To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Cc: Deucher, Alexander ; Thomas > Zimmermann > Su

RE: [PATCH v2] drm/amdgpu: disallow gfxoff until GC IP blocks complete s2idle resume

2022-10-23 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Prike Liang > Sent: Friday, October 21, 2022 10:47 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Liang, Prike > > Subject: [PATCH v2] drm/amdgpu: disallow gfxoff until GC IP blocks