Am 13.10.22 um 23:07 schrieb Fabio M. De Francesco:
The use of kmap() is being deprecated in favor of kmap_local_page().
There are two main problems with kmap(): (1) It comes with an overhead as
the mapping space is restricted and protected by a global lock for
synchronization and (2) it also re
Am 14.10.22 um 05:34 schrieb YuBiao Wang:
Update: Remove redundant comments as Christian suggests.
[Why]
If mes is not dequeued during fini, mes will be in an uncleaned state
during reload, then mes couldn't receive some commands which leads to
reload failure.
[How]
Perform MES dequeue via MMIO
RAS error address translation algorithm is common
across dGPU and A + A platform as along as the SOC
integrates the same generation of UMC IP.
UMC RAS is managed by x86 MCA on A + A platform,
umc_ras in GPU driver is not initialized at all on
A + A platform. In such case, any umc_ras callback
impl
enable thermal alart on smu_v13_0_10
Signed-off-by: Kenneth Feng
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
index 3d436e7f6e95.
update driver-if header for smu_v13_0_10 and merge with smu_v13_0_0
Signed-off-by: Kenneth Feng
---
.../inc/pmfw_if/smu13_driver_if_v13_0_0.h | 87 +++
drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 3 +-
.../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c| 6 +-
3 files change
[AMD Official Use Only - General]
+ if (ret) {
+ dev_err(adev->dev, "Failed to enable thermal alert!\n");
+ return ret;
It seems code alignment issue here, please double check before the commit
Other than that, series is
Reviewed-by: Hawking Zhang
Regards,
Hawking
-O
Setting this flag on a scheduler fence prevents pipelining of jobs
depending on this fence. In other words we always insert a full CPU
round trip before dependen jobs are pushed to the pipeline.
Signed-off-by: Christian König
CC: sta...@vger.kernel.org # 5.19+
---
drivers/gpu/drm/scheduler/sched
Make sure that we always have a CPU round trip to let the submission
code correctly decide if a TLB flush is necessary or not.
Signed-off-by: Christian König
CC: sta...@vger.kernel.org # 5.19+
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 9 -
1 file changed, 8 insertions(+), 1 delet
Hi guys,
rebased those patches on top of amd-staging-drm-next since the
amdgpu changes are quite substencial.
Please review and comment,
Christian.
Add a new function to update job dependencies from a resv obj.
Signed-off-by: Christian König
---
drivers/gpu/drm/scheduler/sched_main.c | 49 ++
include/drm/gpu_scheduler.h| 5 +++
2 files changed, 39 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/
We leaked dependency fences when processes were beeing killed.
Additional to that grab a reference to the last scheduled fence.
Signed-off-by: Christian König
---
drivers/gpu/drm/scheduler/sched_entity.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sc
Init the DRM scheduler base class while allocating the job.
This makes the whole handling much more cleaner.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 8 +--
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
This is always the job anyway.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 20
drivers/gpu/drm/amd/amdgpu/amdgpu_ids.h | 3 +--
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 4 +---
3 files changed, 10 insertions(+), 17 deletions(-)
diff --git
Use the new common scheduler functions to figure out what to wait for.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
b/drivers/gpu/drm/amd/a
Instead return the fence directly. Avoids memory allocation to store the
fence.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 42 +
drivers/gpu/drm/amd/amdgpu/amdgpu_ids.h | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 12 +++
3 file
This moves the memory allocation out of the critical code path.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 13 -
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 12 +++-
drivers/gpu/drm/amd/amdgpu/am
Instead of putting that into the job sync object.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c| 56 +++--
drivers/gpu/drm/amd/amdgpu/amdgpu_sync.h| 2 +
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 10 +++-
3 files changed, 52 insertions(+
Instead of putting that into the job sync object.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
index 8baddf79
Not used any more.
Signed-off-by: Christian König
---
drivers/gpu/drm/scheduler/sched_main.c | 26 --
include/drm/gpu_scheduler.h| 2 --
2 files changed, 28 deletions(-)
diff --git a/drivers/gpu/drm/scheduler/sched_main.c
b/drivers/gpu/drm/scheduler/sched_m
Entirely remove the sync obj in the job.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 21 ++---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.h | 2 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 9 +
drivers/gpu/drm/amd/amdgpu/amdgpu_job.h | 1 -
This now matches much better what this is doing.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 4 ++--
drivers/gpu/drm/scheduler/sched_entity.c | 4 ++--
include/drm/gpu_scheduler.h | 13 ++---
3 files changed, 10 insertions(+), 11 deletions
This was buggy because when we had to wait for entities which were
killed as well we would just deadlock.
Instead move all the dependency handling into the callbacks so that
will all happen asynchronously.
Signed-off-by: Christian König
---
drivers/gpu/drm/scheduler/sched_entity.c | 197 +++
[AMD Official Use Only - General]
> This patch results in a large number of compile errors if CONFIG_DEBUG_FS=n.
> Reverting it fixes the problem.
>
> This is an architecture independent problem.
>
> Guenter
Oops, seem to be because at amdgpu_dm.c:8328 the } should be inside the #endif
not outs
After commit 8799c0be89eb ("drm/amd/display: Fix vblank refcount in vrr
transition"), a build with CONFIG_DEBUG_FS=n is broken due to a
misplaced brace, along the lines of:
In file included from
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_trace.h:39,
from
drive
Currently, if we encounter unimplemented functions, it is difficult to
tell what caused them just by looking at dmesg and that is compounded by
the fact that it is often hard to reproduce said issues. So, to have
access to more detailed debugging information, add a WARN() to
dal_irq_service_ack() a
25 matches
Mail list logo
