[PATCH] drm/amd/pm: Init pm_attr_list when dpm is disabled

2022-10-12 Thread ZhenGuo Yin
[Why] In SRIOV multi-vf, dpm is always disabled, and pm_attr_list won't be initialized. There will be a NULL pointer call trace after removing the dpm check condition in amdgpu_pm_sysfs_fini. BUG: kernel NULL pointer dereference, address: RIP: 0010:amdgpu_device_attr_remove_groups+

[PATCH -next] drm/amdgpu/si_dma: remove unused variable in si_dma_stop()

2022-10-12 Thread Yang Yingliang
After commit 571c05365892 ("drm/amdgpu: switch sdma buffer function tear down to a helper"), the variable 'ring' is not used anymore, it can be removed. Signed-off-by: Yang Yingliang --- drivers/gpu/drm/amd/amdgpu/si_dma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/

[PATCH v3] drm/amdgpu: set vm_update_mode=0 as default for Sienna Cichlid in SRIOV case

2022-10-12 Thread Danijel Slivka
For asic with VF MMIO access protection avoid using CPU for VM table updates. CPU pagetable updates have issues with HDP flush as VF MMIO access protection blocks write to mmBIF_BX_DEV0_EPF0_VF0_HDP_MEM_COHERENCY_FLUSH_CNTL register during sriov runtime. v3: introduce virtualization capability fla

Re: [PATCH -next] drm/amdgpu/si_dma: remove unused variable in si_dma_stop()

2022-10-12 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Oct 12, 2022 at 3:37 AM Yang Yingliang wrote: > > After commit 571c05365892 ("drm/amdgpu: switch sdma buffer function > tear down to a helper"), the variable 'ring' is not used anymore, it > can be removed. > > Signed-off-by: Yang Yingliang > --- > drivers/gpu/dr

[linux-next:master] BUILD REGRESSION f843795727e4f5612c612cd178db1557978da742

2022-10-12 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: f843795727e4f5612c612cd178db1557978da742 Add linux-next specific files for 20221012 Error/Warning reports: https://lore.kernel.org/linux-mm/202210090954.ptr6m6rj-...@intel.com https

[pull] amdgpu drm-fixes-6.1

2022-10-12 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.1. The following changes since commit 65898687cf7392c372ea8d04a88617e2cb794465: Merge tag 'amd-drm-next-6.1-2022-09-30' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2022-10-04 09:42:24 +1000) are available in the Git repository at: https://git

Re: [PATCH resend v2] drm/amdgpu: fix enum conversion in display_mode_vba

2022-10-12 Thread Zeng Heng
Hi, I just wonder is there any further comment towards this patch? or anything needs to be correct? Greetings, Zeng Heng On 2022/9/22 17:18, Zeng Heng wrote: Fix below compile warning when open enum-conversion option check (compiled with -Wenum-conversion): drivers/gpu/drm/amd/amdgpu/../di

Re: [PATCH v3] drm/amdgpu: set vm_update_mode=0 as default for Sienna Cichlid in SRIOV case

2022-10-12 Thread Felix Kuehling
Am 2022-10-12 um 09:20 schrieb Danijel Slivka: For asic with VF MMIO access protection avoid using CPU for VM table updates. CPU pagetable updates have issues with HDP flush as VF MMIO access protection blocks write to mmBIF_BX_DEV0_EPF0_VF0_HDP_MEM_COHERENCY_FLUSH_CNTL register during sriov ru

[PATCH] drm/amdkfd: enable cooperative launch for gfx10.3

2022-10-12 Thread Jonathan Kim
FW fix available to enable cooperative launch for GFX10.3. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c index be7a

[PATCH V3 1/3] drm/amd/pm: fulfill SMU13.0.0 cstate control interface

2022-10-12 Thread Evan Quan
Fulfill the functionality for cstate control. Signed-off-by: Evan Quan Reviewed-by: Hawking Zhang Change-Id: I2b7253898503b8051bbf90f429b46221410146b0 --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/amd/pm

[PATCH V3 2/3] drm/amd/pm: fulfill SMU13.0.7 cstate control interface

2022-10-12 Thread Evan Quan
Fulfill the functionality for cstate control. Signed-off-by: Evan Quan Reviewed-by: Hawking Zhang Change-Id: I3e7ec7d0434d3b34855a9267ab1989a3b85d5206 --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/amd/p

[PATCH V3 3/3] drm/amd/pm: disable cstate feature for gpu reset scenario

2022-10-12 Thread Evan Quan
Suggested by PMFW team and same as what did for gfxoff feature. This can address some Mode1Reset failures observed on SMU13.0.0. Signed-off-by: Evan Quan Reviewed-by: Hawking Zhang Change-Id: Ieb4e204c49abd405b1dce559c2ff75bb3887b6f9 -- v1->v2: - revise the code comments(Alex) - limit this t

Re: [PATCH V3 3/3] drm/amd/pm: disable cstate feature for gpu reset scenario

2022-10-12 Thread Lazar, Lijo
On 10/13/2022 7:01 AM, Evan Quan wrote: Suggested by PMFW team and same as what did for gfxoff feature. This can address some Mode1Reset failures observed on SMU13.0.0. Signed-off-by: Evan Quan Reviewed-by: Hawking Zhang Change-Id: Ieb4e204c49abd405b1dce559c2ff75bb3887b6f9 -- v1->v2: - r

RE: [PATCH V3 3/3] drm/amd/pm: disable cstate feature for gpu reset scenario

2022-10-12 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, October 13, 2022 12:14 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Zhang, Hawking > > Subject: Re: [PATCH V3 3/3] drm/amd/pm: disable cstate feature for gpu >

[PATCH 2/2] drm/amd/pm: add SMU IP v13.0.4 IF version define to V7

2022-10-12 Thread Tim Huang
The pmfw has changed the driver interface version, so keep same with the fw. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h b/drivers/gpu/drm/amd/pm/swsmu/

[PATCH 1/2] drm/amd/pm: update SMU IP v13.0.4 driver interface version

2022-10-12 Thread Tim Huang
Update the SMU driver interface version to V7. Signed-off-by: Tim Huang --- .../swsmu/inc/pmfw_if/smu13_driver_if_v13_0_4.h | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_4.h b/drivers/gpu/drm

Re: [PATCH 2/4] drm/amdgpu: Add software ring callbacks for gfx9 (v8)

2022-10-12 Thread Luben Tuikov
Inlined: On 2022-10-10 02:07, jiadong@amd.com wrote: > From: "Jiadong.Zhu" > > Set ring functions with software ring callbacks on gfx9. > > The software ring could be tested by debugfs_test_ib case. > > v2: Set sw_ring 2 to enable software ring by default. > v3: Remove the parameter for so