Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-30 Thread Sharma, Shashank
On 9/30/2022 7:08 AM, Lazar, Lijo wrote: On 9/30/2022 12:02 AM, Alex Deucher wrote: On Thu, Sep 29, 2022 at 10:14 AM Lazar, Lijo wrote: On 9/29/2022 7:30 PM, Sharma, Shashank wrote: On 9/29/2022 3:37 PM, Lazar, Lijo wrote: To be clear your understanding - Nothing is automatic in P

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-30 Thread Lazar, Lijo
On 9/30/2022 2:07 PM, Sharma, Shashank wrote: On 9/30/2022 7:08 AM, Lazar, Lijo wrote: On 9/30/2022 12:02 AM, Alex Deucher wrote: On Thu, Sep 29, 2022 at 10:14 AM Lazar, Lijo wrote: On 9/29/2022 7:30 PM, Sharma, Shashank wrote: On 9/29/2022 3:37 PM, Lazar, Lijo wrote: To be clea

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-30 Thread Sharma, Shashank
On 9/30/2022 11:13 AM, Lazar, Lijo wrote: On 9/30/2022 2:07 PM, Sharma, Shashank wrote: On 9/30/2022 7:08 AM, Lazar, Lijo wrote: On 9/30/2022 12:02 AM, Alex Deucher wrote: On Thu, Sep 29, 2022 at 10:14 AM Lazar, Lijo wrote: On 9/29/2022 7:30 PM, Sharma, Shashank wrote: On 9/29

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-30 Thread Lazar, Lijo
On 9/30/2022 2:52 PM, Sharma, Shashank wrote: On 9/30/2022 11:13 AM, Lazar, Lijo wrote: On 9/30/2022 2:07 PM, Sharma, Shashank wrote: On 9/30/2022 7:08 AM, Lazar, Lijo wrote: On 9/30/2022 12:02 AM, Alex Deucher wrote: On Thu, Sep 29, 2022 at 10:14 AM Lazar, Lijo wrote: On 9/29

Re: [PATCH v3 5/5] drm/amdgpu: switch workload context to/from compute

2022-09-30 Thread Sharma, Shashank
On 9/30/2022 11:54 AM, Lazar, Lijo wrote: On 9/30/2022 2:52 PM, Sharma, Shashank wrote: On 9/30/2022 11:13 AM, Lazar, Lijo wrote: On 9/30/2022 2:07 PM, Sharma, Shashank wrote: On 9/30/2022 7:08 AM, Lazar, Lijo wrote: On 9/30/2022 12:02 AM, Alex Deucher wrote: On Thu, Sep 29, 2022

[PATCH] drm/amd/display: disable psr whenever applicable

2022-09-30 Thread Shirish S
[Why] psr feature continues to be enabled for non capable links. [How] disable the feature on links that are not capable of the same. Signed-off-by: Shirish S --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a

[PATCH] drm/amdgpu: Enable F32_WPTR_POLL_ENABLE in mqd

2022-09-30 Thread Ji, Ruili
From: Ruili Ji This patch is to fix the SDMA user queue doorbell missing issue on SDMA 6.0. F32_WPTR_POLL_ENABLE has to be set if doorbell mode is used. Otherwise ringing SDMA user queue doorbell can't wake up system from gfxoff. Signed-off-by: Yifan Zhang Signed-off-by: Ruili Ji Change-Id: Ic

RE: [PATCH] drm/amdgpu: Enable F32_WPTR_POLL_ENABLE in mqd

2022-09-30 Thread Zhang, Yifan
[Public] This patch is Reviewed-by: Yifan Zhang -Original Message- From: Ji, Ruili Sent: Friday, September 30, 2022 7:31 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Zhang, Yifan ; Liu, Aaron ; Deucher, Alexander ; Ji, Ruili ; Ji, Ruili Subject: [PATCH] drm/amdgpu:

Re: [PATCH] drm/amd/display: disable psr whenever applicable

2022-09-30 Thread Harry Wentland
+Leo On 9/30/22 06:27, Shirish S wrote: > [Why] > psr feature continues to be enabled for non capable links. > Do you have more info on what issues you're seeing with this? > [How] > disable the feature on links that are not capable of the same. > > Signed-off-by: Shirish S > --- > drivers/

Re: [PATCH v8] drm/sched: Add FIFO sched policy to run queue

2022-09-30 Thread Andrey Grodzovsky
Thanks for helping with review and good improvement ideas. Pushed to drm-misc-next. Andrey On 2022-09-30 00:12, Luben Tuikov wrote: From: Andrey Grodzovsky When many entities are competing for the same run queue on the same scheduler, we observe an unusually long wait times and some jobs get

Re: [PATCH v3 0/6] Add support for atomic async page-flips

2022-09-30 Thread Harry Wentland
On 9/29/22 14:43, Simon Ser wrote: > This series adds support for DRM_MODE_PAGE_FLIP_ASYNC for atomic > commits, aka. "immediate flip" (which might result in tearing). > The feature was only available via the legacy uAPI, however for > gaming use-cases it may be desirable to enable it via the at

Re: [PATCH] drm/amd/display: disable psr whenever applicable

2022-09-30 Thread S, Shirish
On 9/30/2022 6:59 PM, Harry Wentland wrote: +Leo On 9/30/22 06:27, Shirish S wrote: [Why] psr feature continues to be enabled for non capable links. Do you have more info on what issues you're seeing with this? Code wise without this change we end up setting "vblank_disable_immediate" par

Re: [PATCH v3 3/6] drm: introduce drm_mode_config.atomic_async_page_flip_not_supported

2022-09-30 Thread Ville Syrjälä
On Thu, Sep 29, 2022 at 06:43:42PM +, Simon Ser wrote: > This new field indicates whether the driver has the necessary logic > to support async page-flips via the atomic uAPI. This is leveraged by > the next commit to allow user-space to use this functionality. > > All atomic drivers setting d

Re: [PATCH v3 0/6] Add support for atomic async page-flips

2022-09-30 Thread Ville Syrjälä
On Thu, Sep 29, 2022 at 06:43:15PM +, Simon Ser wrote: > This series adds support for DRM_MODE_PAGE_FLIP_ASYNC for atomic > commits, aka. "immediate flip" (which might result in tearing). > The feature was only available via the legacy uAPI, however for > gaming use-cases it may be desirable to

Re: [PATCH v3 3/6] drm: introduce drm_mode_config.atomic_async_page_flip_not_supported

2022-09-30 Thread Simon Ser
On Friday, September 30th, 2022 at 15:53, Ville Syrjälä wrote: > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > index 44235345fd57..7500e82cf06a 100644 > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > +

[pull] amdgpu drm-fixes-6.0

2022-09-30 Thread Alex Deucher
Hi Dave, Daniel, Sorry, some last minute changes to deal with updated firmwares/bioses and board revisions containing new IPs added in this cycle. It required pulling in some cleanup patches for the RLC firmware handing, but they are only applied to GC 11 in this case. I figured that would be cl

RE: [PATCH 00/36] DC Patches September 26, 2022

2022-09-30 Thread Wheeler, Daniel
[AMD Official Use Only - General] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Sapphire Pulse RX5700XT Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on

Re: [PATCH v3 3/6] drm: introduce drm_mode_config.atomic_async_page_flip_not_supported

2022-09-30 Thread Ville Syrjälä
On Fri, Sep 30, 2022 at 01:56:25PM +, Simon Ser wrote: > On Friday, September 30th, 2022 at 15:53, Ville Syrjälä > wrote: > > > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > index 44235345fd57..7500e82cf06a 1

Re: [PATCH v3 1/8] drm/amd/display: Introduce KUnit tests for fixed31_32 library

2022-09-30 Thread Harry Wentland
On 9/12/22 11:59, Maíra Canal wrote: > From: Tales Aparecida > > The fixed31_32 library performs a lot of the mathematical operations > involving fixed-point arithmetic and the conversion of integers to > fixed-point representation. > > This unit tests intend to assure the proper functioning

Re: [PATCH 2/7] mm: Free device private pages have zero refcount

2022-09-30 Thread Alistair Popple
Dan Williams writes: > Alistair Popple wrote: >> >> Jason Gunthorpe writes: >> >> > On Mon, Sep 26, 2022 at 04:03:06PM +1000, Alistair Popple wrote: >> >> Since 27674ef6c73f ("mm: remove the extra ZONE_DEVICE struct page >> >> refcount") device private pages have no longer had an extra referen

[PATCH -next 2/2] drm/amd/display: clean up one inconsistent indenting

2022-09-30 Thread Yang Li
clean up one inconsistent indenting Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2321 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/displ

[PATCH -next] drm/amd/display: Removed unused variable 'sdp_stream_enable'

2022-09-30 Thread Dong Chenchen
Kernel test robot throws below warning -> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c: In function 'dcn31_hpo_dp_stream_enc_update_dp_info_packets': drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c:439:14: warning: variable 'sdp_stre

Re: [PATCH 2/7] mm: Free device private pages have zero refcount

2022-09-30 Thread Dan Williams
Alistair Popple wrote: > > Dan Williams writes: > > > Alistair Popple wrote: > >> > >> Jason Gunthorpe writes: > >> > >> > On Mon, Sep 26, 2022 at 04:03:06PM +1000, Alistair Popple wrote: > >> >> Since 27674ef6c73f ("mm: remove the extra ZONE_DEVICE struct page > >> >> refcount") device private

[PATCH -next 1/2] drm/amd/display: clean up one inconsistent indenting

2022-09-30 Thread Yang Li
clean up one inconsistent indenting Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2238 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dcn321/dcn321_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/displ

Re: [PATCH v3 0/6] Add support for atomic async page-flips

2022-09-30 Thread Ville Syrjälä
On Fri, Sep 30, 2022 at 04:52:56PM +0300, Ville Syrjälä wrote: > On Thu, Sep 29, 2022 at 06:43:15PM +, Simon Ser wrote: > > This series adds support for DRM_MODE_PAGE_FLIP_ASYNC for atomic > > commits, aka. "immediate flip" (which might result in tearing). > > The feature was only available via

Re: [PATCH 2/2] drm/amdgpu: remove unnecessary judgement in sdma reg offest calculaton

2022-09-30 Thread Alex Deucher
Series is: Acked-by: Alex Deucher On Fri, Sep 30, 2022 at 2:17 AM Yifan Zhang wrote: > > clean sdma_v6_0_get_reg_offset function. > > Signed-off-by: Yifan Zhang > --- > drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers

Re: [PATCH -next] drm/amd/display: change to enc314_stream_encoder_dp_blank static

2022-09-30 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Sep 29, 2022 at 4:46 AM Yang Yingliang wrote: > > enc314_stream_encoder_dp_blank is only used in dcn314_dio_stream_encoder.c > now, > change it to static. > > Fixes: c9c2ff53cc20 ("drm/amd/display: Add explicit FIFO disable for DP > blank") > Signed-off-by: Yang

Re: [PATCH v2] drivers/amd/pm: check the return value of amdgpu_bo_kmap

2022-09-30 Thread Alex Deucher
On Sat, Sep 24, 2022 at 6:20 PM Li Zhong wrote: > > amdgpu_bo_kmap() returns error when fails to map buffer object. Add the > error check and propagate the error. > > Signed-off-by: Li Zhong > --- > > v2: revise the compile error Applied. Thanks! > > drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c

Re: [PATCH -next 2/2] drm/amd/display: clean up one inconsistent indenting

2022-09-30 Thread Alex Deucher
Applied the series. Thanks! On Fri, Sep 30, 2022 at 1:39 AM Yang Li wrote: > > clean up one inconsistent indenting > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2321 > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c

Re: [PATCH] drm/amd/display: Fix mutex lock in dcn10

2022-09-30 Thread Hamza Mahfooz
Applied. Thanks! On 2022-09-25 17:53, Daniel Gomez wrote: Removal of DC_FP_* wrappers from dml (9696679bf7ac) provokes a mutex lock [2] on the amdgpu driver. Re-arrange the dcn10 code to avoid locking the mutex by placing the DC_FP_* wrappers around the proper functions. This fixes the followin

Re: [PATCH -next] drm/amdgpu/sdma: add missing release_firmware() in amdgpu_sdma_init_microcode()

2022-09-30 Thread Alex Deucher
Applied. Thanks. On Thu, Sep 29, 2022 at 10:04 AM Yang Yingliang wrote: > > In some error path in amdgpu_sdma_init_microcode(), release_firmware() is > not called, the memory allocated in request_firmware() will be leaked, > calling amdgpu_sdma_destroy_inst_ctx() which calls release_firmware() t

Re: [PATCH 1/2] drm/amdkfd: correct RB_SIZE in SDMA0_QUEUE0_RB_CNTL

2022-09-30 Thread Felix Kuehling
Am 2022-09-30 um 02:16 schrieb Yifan Zhang: In SDMA0_QUEUE0_RB_CNTL, queue size is 2^RB_SIZE, not 2^(RB_SIZE +1). Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v11.c | 2 +- 2 files changed, 2 insertions(

Re: [PATCH v3 0/6] Add support for atomic async page-flips

2022-09-30 Thread Ville Syrjälä
On Fri, Sep 30, 2022 at 05:19:07PM +0300, Ville Syrjälä wrote: > On Fri, Sep 30, 2022 at 04:52:56PM +0300, Ville Syrjälä wrote: > > On Thu, Sep 29, 2022 at 06:43:15PM +, Simon Ser wrote: > > > This series adds support for DRM_MODE_PAGE_FLIP_ASYNC for atomic > > > commits, aka. "immediate flip"

KMS atomic state sets, full vs. minimal (Re: [PATCH v3 0/6] Add support for atomic async page-flips)

2022-09-30 Thread Pekka Paalanen
On Fri, 30 Sep 2022 18:09:55 +0300 Ville Syrjälä wrote: > That would actively discourage people from even attempting the > "just dump all the state into the ioctl" approach with async flips > since even the props whose value isn't even changing would be rejected. About that. To me it looks like

Re: KMS atomic state sets, full vs. minimal (Re: [PATCH v3 0/6] Add support for atomic async page-flips)

2022-09-30 Thread Ville Syrjälä
On Fri, Sep 30, 2022 at 06:37:00PM +0300, Pekka Paalanen wrote: > On Fri, 30 Sep 2022 18:09:55 +0300 > Ville Syrjälä wrote: > > > That would actively discourage people from even attempting the > > "just dump all the state into the ioctl" approach with async flips > > since even the props whose va

Re: KMS atomic state sets, full vs. minimal (Re: [PATCH v3 0/6] Add support for atomic async page-flips)

2022-09-30 Thread Ville Syrjälä
On Fri, Sep 30, 2022 at 06:45:09PM +0300, Ville Syrjälä wrote: > On Fri, Sep 30, 2022 at 06:37:00PM +0300, Pekka Paalanen wrote: > > On Fri, 30 Sep 2022 18:09:55 +0300 > > Ville Syrjälä wrote: > > > > > That would actively discourage people from even attempting the > > > "just dump all the state

[pull] amdgpu, amdkfd drm-next-6.1

2022-09-30 Thread Alex Deucher
Hi Dave, Daniel, A few fixes for 6.1. The following changes since commit 3e43b760c9e14fc0b7bd553efb01d9ca825cf338: drm/amdgpu: Fix amdgpu_vm_pt_free warning (2022-09-21 15:25:52 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-next

[PATCH] drm/amdgpu: Enable VCN PG on GC11_0_1

2022-09-30 Thread Sonny Jiang
Enable VCN PG on GC11_0_1 Signed-off-by: Sonny Jiang --- drivers/gpu/drm/amd/amdgpu/soc21.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c b/drivers/gpu/drm/amd/amdgpu/soc21.c index 16b757664a35..795706b3b092 100644 --- a/drivers/gpu/drm/amd/amdgpu/soc21.

Re: [pull] amdgpu drm-fixes-6.0

2022-09-30 Thread Daniel Vetter
On Fri, Sep 30, 2022 at 09:58:10AM -0400, Alex Deucher wrote: > Hi Dave, Daniel, > > Sorry, some last minute changes to deal with updated firmwares/bioses and > board revisions containing new IPs added in this cycle. It required > pulling in some cleanup patches for the RLC firmware handing, but

[pull] amdgpu drm-fixes-6.0

2022-09-30 Thread Alex Deucher
Hi Dave, Daniel, Sorry, some last minute changes to deal with updated firmwares/bioses and board revisions containing new IPs added in this cycle. It required pulling in some cleanup patches for the RLC firmware handing, but they are only applied to GC 11 in this case. I figured that would be cl

Re: [PATCH] drm/amdgpu: Enable VCN PG on GC11_0_1

2022-09-30 Thread Alex Deucher
On Fri, Sep 30, 2022 at 4:27 PM Sonny Jiang wrote: > > Enable VCN PG on GC11_0_1 > > Signed-off-by: Sonny Jiang Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/soc21.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c > b/drivers/gpu/drm/am

[RFC PATCH 1/1] drm/amdgpu: Fix null-ptr-deref in amdgpu_device_fini_sw()

2022-09-30 Thread Zhang Boyang
After amdgpu_device_init() failed, adev->reset_domain may be NULL. Thus subsequent call to amdgpu_device_fini_sw() may result in null-ptr-deref. This patch fixes the problem by adding a NULL pointer check around the code of releasing adev->reset_domain in amdgpu_device_fini_sw(). Fixes: cfbb6b004

[RFC PATCH 0/1] drm/amdgpu: Fix NULL-deref in amdgpu_device_fini_sw()

2022-09-30 Thread Zhang Boyang
Hi, There are several reports of "Fatal error during GPU init" will cause NULL-deref in amdgpu_device_fini_sw(). Although the NULL-deref is result instead of reason, this NULL-deref will confuse user. https://lore.kernel.org/lkml/a8bce489-8ccc-aa95-3de6-f854e03ad...@suddenlinkmail.com/ https://lo

Re: [pull] amdgpu drm-fixes-6.0

2022-09-30 Thread Daniel Vetter
On Fri, Sep 30, 2022 at 05:04:54PM -0400, Alex Deucher wrote: > Hi Dave, Daniel, > > Sorry, some last minute changes to deal with updated firmwares/bioses and > board revisions containing new IPs added in this cycle. It required > pulling in some cleanup patches for the RLC firmware handing, but

[linux-next:master] BUILD REGRESSION 274d7803837da78dfc911bcda0d593412676fc20

2022-09-30 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 274d7803837da78dfc911bcda0d593412676fc20 Add linux-next specific files for 20220930 Error/Warning reports: https://lore.kernel.org/linux-mm/202209150141.wgbakqmx-...@intel.com https