[PATCH] Revert "drm/amd/amdgpu: add pipe1 hardware support"

2022-08-16 Thread Michel Dänzer
From: Michel Dänzer This reverts commit 4c7631800e6bf0eced08dd7b4f793fcd972f597d. Triggered GFX hangs with GNOME Wayland on Navi 21. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2117 Signed-off-by: Michel Dänzer --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +- 1 file changed, 1 inse

Radeon HD 2600 XT, DVI outputs

2022-08-16 Thread Andriy Gapon
Out of necessity I had to use an ancient Radeon HD 2600 XT card. It has two DVI outputs (and one S-video). I noticed a curious problem, if I attach a monitor to either of the DVI outputs, then initially there is video output but as soon as radeonkms driver attaches the monitor goes blank. Bu

Re: Radeon HD 2600 XT, DVI outputs

2022-08-16 Thread Christian König
Hi Andriy, well first of all can you please test that with Linux? If this works on Linux then there is probably just something missing on the FreeBSD port. Regards, Christian. Am 16.08.22 um 10:48 schrieb Andriy Gapon: Out of necessity I had to use an ancient Radeon HD 2600 XT card. It has

Re: [PATCH] Revert "drm/amd/amdgpu: add pipe1 hardware support"

2022-08-16 Thread Michel Dänzer
On 2022-08-16 10:44, Michel Dänzer wrote: > From: Michel Dänzer > > This reverts commit 4c7631800e6bf0eced08dd7b4f793fcd972f597d. > > Triggered GFX hangs with GNOME Wayland on Navi 21. > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2117 Don't get me wrong, I'm really looking forward

Re: [PATCH v2 1/3] Documentation/gpu: Add info table for ASICs

2022-08-16 Thread Alex Deucher
On Thu, Aug 11, 2022 at 3:45 PM Rodrigo Siqueira Jordao wrote: > > Hi Kent, > > First of all, thanks for your feedback. > See my comments inline. > > On 2022-08-11 12:02, Russell, Kent wrote: > > [AMD Official Use Only - General] > > > > I noticed that you added DCE and VCE/UVD prefixes in the col

Re: [PATCHv2] drm/amdgpu: Fix interrupt handling on ih_soft ring

2022-08-16 Thread Felix Kuehling
Am 2022-08-15 um 15:25 schrieb Mukul Joshi: There are no backing hardware registers for ih_soft ring. As a result, don't try to access hardware registers for read and write pointers when processing interrupts on the IH soft ring. Signed-off-by: Mukul Joshi Reviewed-by: Felix Kuehling ---

[linux-next:master] BUILD REGRESSION e1084bacab44f570691c0fdaa1259acf93ed0098

2022-08-16 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: e1084bacab44f570691c0fdaa1259acf93ed0098 Add linux-next specific files for 20220816 Error/Warning reports: https://lore.kernel.org/linux-doc/202208162058.7appivkl-...@intel.com Error/Warning

Re: [BUG][5.20] refcount_t: underflow; use-after-free

2022-08-16 Thread Mikhail Gavrilov
On Mon, Aug 15, 2022 at 3:37 PM Mikhail Gavrilov wrote: > > Thanks, I tested this patch. > But with this patch use-after-free problem happening in another place: Does anyone have an idea why the second use-after-free happened? >From the trace I don't understand which code is related. I don't quit

Re: [PATCH] drm/amdgpu: Fix use-after-free on amdgpu_bo_list mutex

2022-08-16 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Aug 15, 2022 at 10:56 AM Melissa Wen wrote: > > On 08/15, Maíra Canal wrote: > > If amdgpu_cs_vm_handling returns r != 0, then it will unlock the > > bo_list_mutex inside the function amdgpu_cs_vm_handling and again on > > amdgpu_cs_parser_fini. This problem result

Re: [PATCH] Revert "drm/amd/amdgpu: add pipe1 hardware support"

2022-08-16 Thread Alex Deucher
On Tue, Aug 16, 2022 at 5:12 AM Michel Dänzer wrote: > > On 2022-08-16 10:44, Michel Dänzer wrote: > > From: Michel Dänzer > > > > This reverts commit 4c7631800e6bf0eced08dd7b4f793fcd972f597d. > > > > Triggered GFX hangs with GNOME Wayland on Navi 21. > > > > Bug: https://gitlab.freedesktop.org/d

Re: build failure of next-20220811 due to b1a63a0b48ad ("drm/amd/display: consider DSC pass-through during mode validation")

2022-08-16 Thread Stephen Rothwell
Hi all, On Fri, 12 Aug 2022 09:07:31 +1000 Stephen Rothwell wrote: > > On Thu, 11 Aug 2022 18:10:48 +0100 "Sudip Mukherjee (Codethink)" > wrote: > > > > Not sure if it has been reported, builds of riscv, alpha, s390, arm, > > arm64, xtensa, mips, csky allmodconfig have failed to build next-2022

RE: [PATCH] drm/amdgpu: TA unload messages are not actually sent to psp when amdgpu is uninstalled

2022-08-16 Thread Chai, Thomas
[AMD Official Use Only - General] Hi Alex: When removing an amdgpu device, it may be difficult to change the order of psp_hw_fini calls. 1. The drm_dev_unplug call is at the beginning in the amdgpu_pci_remove function, which makes the gpu device inaccessible for userspace operations. If th

[PATCH] drm/amdkfd: add family_id property for kfd_node

2022-08-16 Thread Lang Yu
Then we can remove the burden of maintaining codes to parse family_id from gfx version in rocr, i.e., remove DevIDToAddrLibFamily(). Signed-off-by: Lang Yu --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 3 +++ drivers/gpu/drm/amd/amdkfd/kfd_topology.h | 1 + 2 files changed, 4 insertions(+) di

[PATCH] drm/amdgpu: enable GFXOFF allow control for GC IP v11.0.1

2022-08-16 Thread Tim Huang
Enable GFXOFF allow control when set the GFX power gating. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c index 158d87e6805d

[PATCH V2 1/2] drm/amdgpu: Move psp_xgmi_terminate call from amdgpu_xgmi_remove_device to psp_hw_fini

2022-08-16 Thread YiPeng Chai
V1: The amdgpu_xgmi_remove_device function will send unload command to psp through psp ring to terminate xgmi, but psp ring has been destroyed in psp_hw_fini. V2: 1. Change the commit title. 2. Restore amdgpu_xgmi_remove_device to its original calling location. Move psp_xgmi_terminate call from

[PATCH V2 2/2] drm/amdgpu: fix hive reference leak when adding xgmi device

2022-08-16 Thread YiPeng Chai
Only amdgpu_get_xgmi_hive but no amdgpu_put_xgmi_hive which will leak the hive reference. Signed-off-by: YiPeng Chai --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgp