Re: [Linaro-mm-sig] [PATCH v2 3/5] dma-buf: Move all dma-bufs to dynamic locking specification

2022-08-11 Thread Dmitry Osipenko
On 8/10/22 21:25, Christian König wrote: > Am 10.08.22 um 19:49 schrieb Dmitry Osipenko: >> On 8/10/22 14:30, Christian König wrote: >>> Am 25.07.22 um 17:18 schrieb Dmitry Osipenko: This patch moves the non-dynamic dma-buf users over to the dynamic locking specification. The strict locki

[PATCH] drm/amd/pm: add mode1 support on smu_v13_0_7

2022-08-11 Thread Kenneth Feng
add mode1 support since it's missing on smu_v13_0_7 Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/sm

[Patch V3] drm/amdgpu: Increase tlb flush timeout for sriov

2022-08-11 Thread Dusica Milinkovic
[Why] During multi-vf executing benchmark (Luxmark) observed kiq error timeout. It happenes because all of VFs do the tlb invalidation at the same time. Although each VF has the invalidate register set, from hardware side the invalidate requests are queue to execute. [How] In case of 12 VF increas

Re: [PATCH 0/8] drm/amd/display: Introduce KUnit to Display Mode Library

2022-08-11 Thread Christian König
Am 11.08.22 um 02:40 schrieb Tales Aparecida: Hello, This series is the consolidation of an RFC sent earlier this year [RFC] bringing unit testing to the AMDPGU driver. [gsoc] Our main goal is to bring unit testing to the AMD display driver; in particular, we'll focus on the Display Mode Lib

RE: [PATCH] drm/amd/pm: add mode1 support on smu_v13_0_7

2022-08-11 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] -Original Message- From: amd-gfx On Behalf Of Kenneth Feng Sent: Thursday, August 11, 2022 4:40 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH] drm/amd/pm: add mode1 support on smu_v13_0_7 add mode1 support since it's missing on

[PATCH] drm/amdkfd: reserve 2 queues for sdma 6.0.1

2022-08-11 Thread Yifan Zhang
There is only one engine in sdma 6.0.1, current code reserve 4 queues togather w/ 6.0.0 and 6.0.2, which is not necessary. Shrink it to 2. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/

RE: [PATCH] drm/amdkfd: reserve 2 queues for sdma 6.0.1

2022-08-11 Thread Zhang, Yifan
[AMD Official Use Only - General] The comment is not correct. Please ignore this one and review v2. Best Regards, Yifan -Original Message- From: Zhang, Yifan Sent: Thursday, August 11, 2022 8:30 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Kuehling, Felix ; Joshi, Muk

[PATCH v2] drm/amdkfd: reserve 2 queues for sdma 6.0.1

2022-08-11 Thread Yifan Zhang
There is only one engine in sdma 6.0.1, the total number of reserved queues should be 2. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd

[PATCH] drm/radeon: add a force flush to delay work when radeon

2022-08-11 Thread Zhenneng Li
Although radeon card fence and wait for gpu to finish processing current batch rings, there is still a corner case that radeon lockup work queue may not be fully flushed, and meanwhile the radeon_suspend_kms() function has called pci_set_power_state() to put device in D3hot state. Per PCI spec r

Re: [PATCH v2 2/3] drm/amd/display: consider DSC pass-through during mode validation

2022-08-11 Thread Anders Roxell
onfig kernel from todays next tag, next-20220811. I can see the following build error. ERROR: modpost: "dc_dsc_compute_bandwidth_range" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERROR: modpost: "dc_dsc_get_policy_for_timing" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefine

[PATCH] drm/amdgpu: use native mode for dp aux transfer

2022-08-11 Thread Zhenneng Li
When using amdgpu for e8860, the monitor sometimes haven't any signal, and the kernel reports some errors: [ 17.317302][ 2] [ T1045] [drm:amdgpu_atombios_dp_link_train [amdgpu]] *ERROR* channel eq failed: 5 tries [ 17.326963][ 2] [ T1045] [drm:amdgpu_atombios_dp_link_train [amdgpu]] *ERROR* c

Re: [PATCH 0/8] drm/amd/display: Introduce KUnit to Display Mode Library

2022-08-11 Thread Maíra Canal
On 8/11/22 08:22, Christian König wrote: Am 11.08.22 um 02:40 schrieb Tales Aparecida: Hello, This series is the consolidation of an RFC sent earlier this year [RFC] bringing unit testing to the AMDPGU driver. [gsoc] Our main goal is to bring unit testing to the AMD display driver; in par

Re: [PATCH 7/7] drm/amdgpu: enable ATHUB IP v3.0.1 Clock Gating

2022-08-11 Thread Deucher, Alexander
[Public] Series is: Reviewed-by: Alex Deucher From: Huang, Tim Sent: Thursday, August 11, 2022 12:58 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Yifan ; Du, Xiaojian ; Huang, Tim Subject: [PATCH 7/7] drm/amdgpu: enable ATHUB IP v3.0.1

Re: [PATCH 1/8] drm/amd/display: Introduce KUnit tests for fixed31_32 library

2022-08-11 Thread Maíra Canal
On 8/11/22 04:19, David Gow wrote: On Thu, Aug 11, 2022 at 11:05 AM 'Daniel Latypov' via KUnit Development wrote: On Wed, Aug 10, 2022 at 5:40 PM Tales Aparecida wrote: The fixed31_32 library performs a lot of the mathematical operations involving fixed-point arithmetic and the conversio

Re: [PATCH 7/8] drm/amd/display: Introduce KUnit tests to dc_dmub_srv library

2022-08-11 Thread Maíra Canal
On 8/11/22 04:37, David Gow wrote: On Thu, Aug 11, 2022 at 8:41 AM Tales Aparecida wrote: From: Maíra Canal Add unit test to the SubVP feature in order to avoid possible regressions and assure the code robustness. Signed-off-by: Maíra Canal Signed-off-by: Tales Aparecida --- FYI: Thi

[PATCH] drm/amdgpu: fix reset domain xgmi hive info reference leak

2022-08-11 Thread Jonathan Kim
When an xgmi node is added to the hive, it takes another hive reference for its reset domain. This extra reference was not dropped on device removal from the hive so drop it. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [PATCH] drm/amdgpu: use native mode for dp aux transfer

2022-08-11 Thread Alex Deucher
On Thu, Aug 11, 2022 at 7:32 AM Zhenneng Li wrote: > > When using amdgpu for e8860, the monitor sometimes haven't any signal, > and the kernel reports some errors: > [ 17.317302][ 2] [ T1045] [drm:amdgpu_atombios_dp_link_train [amdgpu]] > *ERROR* channel eq failed: 5 tries > [ 17.326963][ 2]

RE: [Patch V3] drm/amdgpu: Increase tlb flush timeout for sriov

2022-08-11 Thread Liu, Shaoyun
[AMD Official Use Only - General] >From HW point of view , the maximum VF number can reach 16 instead of 12 . >Although currently no product will use the 16 VFs together, not sure about >the future. You can added Acked-by me. I will let Alex & Christion decide whether accept this change.

Re: [Patch V3] drm/amdgpu: Increase tlb flush timeout for sriov

2022-08-11 Thread Alex Deucher
On Thu, Aug 11, 2022 at 10:16 AM Liu, Shaoyun wrote: > > [AMD Official Use Only - General] > > From HW point of view , the maximum VF number can reach 16 instead of 12 . > Although currently no product will use the 16 VFs together, not sure about > the future. > You can added Acked-by me.

Re: [PATCH] drm/amdkfd: Try to schedule bottom half on same core

2022-08-11 Thread Felix Kuehling
Am 2022-08-10 um 19:41 schrieb Felix Kuehling: On systems that support SMT (hyperthreading) schedule the bottom half of the KFD interrupt handler on the same core. This makes it possible to reserve a core for interrupt handling and have the bottom half run on that same core. On systems without S

Re: [PATCH] drm/amdgpu: fix reset domain xgmi hive info reference leak

2022-08-11 Thread Felix Kuehling
Am 2022-08-11 um 09:42 schrieb Jonathan Kim: When an xgmi node is added to the hive, it takes another hive reference for its reset domain. This extra reference was not dropped on device removal from the hive so drop it. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c

[PATCH AUTOSEL 5.19 011/105] drm/amd/display: fix system hang when PSR exits

2022-08-11 Thread Sasha Levin
From: David Zhang [ Upstream commit 6cc5c77300afbb285c4f41e04f3435ae3c484c40 ] [why] When DC driver send PSR exit dmub command to DMUB FW, it might not wait until PSR exit. Then it may hit the following deadlock situation. 1. DC driver send HW LOCK command to DMUB FW due to frame update 2. DMUB

[PATCH AUTOSEL 5.19 012/105] drm/amd/display: Detect dpcd_rev when hotplug mst monitor

2022-08-11 Thread Sasha Levin
From: Wayne Lin [ Upstream commit 453b0016a054df0f442fda8a145b97a33816cab9 ] [Why] Once mst topology is constructed, later on new connected monitors are reported to source by CSN message. Within CSN, there is no carried info of DPCD_REV comparing to LINK_ADDRESS reply. As the result, we might le

[PATCH AUTOSEL 5.19 016/105] drm/amd/display: Correct min comp buffer size

2022-08-11 Thread Sasha Levin
From: Duncan Ma [ Upstream commit 0c56705d8aae9696348cc320b71d531ede001b79 ] [Why] In 3-way mpo pipes, there is a case that we overbook the CRB buffer size. At rare instances, overbooking the crb will cause underflow. This only happens when det_size changes dynamically based on pipe_cnt. [How]

[PATCH AUTOSEL 5.19 017/105] drm/amd/display: Fix dpp dto for disabled pipes

2022-08-11 Thread Sasha Levin
From: Duncan Ma [ Upstream commit d4965c53b95d7533dfc2309d2fc25838bd33220e ] [Why] When switching from 1 pipe to 4to1 mpc combine, DppDtoClk aren't enabled for the disabled pipes pior to programming the pipes. Upon optimizing bandwidth, DppDto are enabled causing intermittent underflow. [How] U

[PATCH AUTOSEL 5.19 019/105] drm/radeon: integer overflow in radeon_mode_dumb_create()

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit feb54650bae25f2a2adfc493e3e254e7c27a3fba ] Similar to the handling of amdgpu_mode_dumb_create in commit 54ef0b5461c0 ("drm/amdgpu: integer overflow in amdgpu_mode_dumb_create()"), we thought a patch might be needed here as well. args->size is a u64. arg->p

[PATCH AUTOSEL 5.19 018/105] drm/amd/display: Reduce frame size in the bouding box for DCN20

2022-08-11 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit c55300ad4a1814bac9191a4d2c7b0d74273aec7c ] GCC throw warnings for the function dcn20_update_bounding_box due to its frame size that looks like this: error: the frame size of 1936 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] This commit

[PATCH AUTOSEL 5.19 020/105] drm/radeon: Initialize fences array entries in radeon_sa_bo_next_hole

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit 0381ac3ca2e727d4dfb7264d9416a8ba6bb6c18b ] Similar to the handling of amdgpu_sa_bo_next_hole in commit 6a15f3ff19a8 ("drm/amdgpu: Initialize fences array entries in amdgpu_sa_bo_next_hole"), we thought a patch might be needed here as well. The entries were

[PATCH AUTOSEL 5.19 025/105] drm/amd/display: Fix monitor flash issue

2022-08-11 Thread Sasha Levin
From: Shah Dharati [ Upstream commit b840b64bc8ed3fc46f6d6aa7f97c43862a33bea5 ] [Why & How] For a some specific monitors, when connected on boot or hot plug, monitor flash for 1/2 seconds can happen during first HDCP query operation. Ading some delay in the init sequence for these monitors fixes

[PATCH AUTOSEL 5.19 044/105] drm/amdkfd: Free queue after unmap queue success

2022-08-11 Thread Sasha Levin
From: Philip Yang [ Upstream commit ab8529b0cdb271d9b222cbbddb2641f3fca5df8f ] After queue unmap or remove from MES successfully, free queue sysfs entries, doorbell and remove from queue list. Otherwise, application may destroy queue again, cause below kernel warning or crash backtrace. For out

[PATCH AUTOSEL 5.19 045/105] amdgpu/pm: Fix possible array out-of-bounds if SCLK levels != 2

2022-08-11 Thread Sasha Levin
From: Darren Powell [ Upstream commit ceb180361e3851007547c55035cd1de03f108f75 ] [v2] simplified fix after Lijo's feedback removed clocks.num_levels from calculation of loop count removed unsafe accesses to shim table freq_values retained corner case output only min,now if clocks.num_le

[PATCH AUTOSEL 5.19 052/105] drm/amdgpu/display/dc: Fix null pointer exception

2022-08-11 Thread Sasha Levin
From: Rahul Kumar [ Upstream commit 1c4dae3e4639540fb567e570cc56a3c292afb6fe ] We observed hard hang due to NULL derefrence This issue is seen after running system all the time after two or three days struct dc *dc = plane_state->ctx->dc; Randomly in long run we found plane_state or plane_state

[PATCH AUTOSEL 5.19 057/105] drm/amdgpu: skip whole ras bad page framework on sriov

2022-08-11 Thread Sasha Levin
From: "Stanley.Yang" [ Upstream commit e0e146d5567317d6ba7d0169bed55d1d9ea05a61 ] It should not init whole ras bad page framework on sriov guest side due to it is handled on host side. Signed-off-by: Stanley.Yang Reviewed-by: Hawking Zhang Reviewed-by: Tao Zhou Signed-off-by: Alex Deucher S

[PATCH AUTOSEL 5.19 058/105] drm/amd/display: Guard against ddc_pin being NULL for AUX

2022-08-11 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit bc19909f19fdc8253d720d11c948935786fbfa08 ] [Why] In the case where we don't support DMUB aux but we have DPIA links in the configuration we might try to message AUX using the legacy path - where DDC pin is NULL. This causes a NULL pointer dereference.

RE: [PATCH] drm/amdgpu: fix reset domain xgmi hive info reference leak

2022-08-11 Thread Kim, Jonathan
[Public] > -Original Message- > From: Kuehling, Felix > Sent: August 11, 2022 11:19 AM > To: amd-gfx@lists.freedesktop.org; Kim, Jonathan > Subject: Re: [PATCH] drm/amdgpu: fix reset domain xgmi hive info reference > leak > > Am 2022-08-11 um 09:42 schrieb Jonathan Kim: > > When an xgmi

[PATCH AUTOSEL 5.19 059/105] drm/amd/display: Fix dmub soft hang for PSR 1

2022-08-11 Thread Sasha Levin
From: Fangzhi Zuo [ Upstream commit 22676bc500c27d987a0b42cbe162aebf783f1c38 ] [Why] Unexpected change of aux hw mapping causes dmub soft hang when initiate aux transation at wrong aux channel. ddc_channel stands for hw dp aux index which is from vbios, but link_index is pure software concept f

[PATCH AUTOSEL 5.19 060/105] drm/amd/display: disable otg toggle w/a on boot

2022-08-11 Thread Sasha Levin
From: Dmytro Laktyushkin [ Upstream commit 8a077d9caa3a274de36ee2fe7b608041f5690343 ] This w/a has a bad interaction with seamless boot toggling an active stream. Most panels recover, however some fail leading to display corruption. Reviewed-by: Charlene Liu Acked-by: Rodrigo Siqueira Signed-

[PATCH AUTOSEL 5.19 064/105] drm/amdgpu: Fix one list corruption when create queue fails

2022-08-11 Thread Sasha Levin
From: xinhui pan [ Upstream commit cc3cb791f19ad0c4f951f38c98aa513b042ab329 ] Queue would be freed when create_queue_cpsch fails So lets do queue cleanup otherwise various list and memory issues happen. Signed-off-by: xinhui pan Reviewed-by: Philip Yang Signed-off-by: Alex Deucher Signed-off

[PATCH AUTOSEL 5.19 070/105] drm/amdgpu: fix file permissions on some files

2022-08-11 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 0a94608f0f7de9b1135ffea3546afe68eafef57f ] Drop execute. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2085 Reviewed-by: Guchun Chen Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/inclu

[PATCH AUTOSEL 5.19 075/105] drm/amdgpu: Call trace info was found in dmesg when loading amdgpu

2022-08-11 Thread Sasha Levin
From: lin cao [ Upstream commit 748262eb400e809aa13e3485f4983c3db3d0ebb3 ] In the case of SRIOV, the register smnMp1_PMI_3_FIFO will get an invalid value which will cause the "shift out of bound". In Ubuntu22.04, this issue will be checked an related call trace will be reported in dmesg. Signed

[PATCH AUTOSEL 5.19 091/105] drm/amdkfd: Correct mmu_notifier_get failure handling

2022-08-11 Thread Sasha Levin
From: Philip Yang [ Upstream commit 0593ad215359d51514c1e6c81ce28ea598efed6b ] If process has signal pending, mmu_notifier_get_locked fails and calls ops->free_notifier, kfd_process_free_notifier will schedule kfd_process_wq_release as process refcount is 1, but process structure is already free

[PATCH AUTOSEL 5.19 092/105] drm/amdkfd: Process notifier release callback don't take mutex

2022-08-11 Thread Sasha Levin
From: Philip Yang [ Upstream commit 74097f9fd2f5ebdae04fcba59da345386415cbf3 ] Move process queues cleanup to deferred work kfd_process_wq_release, to avoid potential deadlock circular locking warning: WARNING: possible circular locking dependency detected the existing dependenc

[PATCH AUTOSEL 5.18 11/93] drm/amd/display: fix system hang when PSR exits

2022-08-11 Thread Sasha Levin
From: David Zhang [ Upstream commit 6cc5c77300afbb285c4f41e04f3435ae3c484c40 ] [why] When DC driver send PSR exit dmub command to DMUB FW, it might not wait until PSR exit. Then it may hit the following deadlock situation. 1. DC driver send HW LOCK command to DMUB FW due to frame update 2. DMUB

[PATCH AUTOSEL 5.18 12/93] drm/amd/display: Detect dpcd_rev when hotplug mst monitor

2022-08-11 Thread Sasha Levin
From: Wayne Lin [ Upstream commit 453b0016a054df0f442fda8a145b97a33816cab9 ] [Why] Once mst topology is constructed, later on new connected monitors are reported to source by CSN message. Within CSN, there is no carried info of DPCD_REV comparing to LINK_ADDRESS reply. As the result, we might le

[PATCH AUTOSEL 5.18 16/93] drm/amd/display: Fix dpp dto for disabled pipes

2022-08-11 Thread Sasha Levin
From: Duncan Ma [ Upstream commit d4965c53b95d7533dfc2309d2fc25838bd33220e ] [Why] When switching from 1 pipe to 4to1 mpc combine, DppDtoClk aren't enabled for the disabled pipes pior to programming the pipes. Upon optimizing bandwidth, DppDto are enabled causing intermittent underflow. [How] U

[PATCH AUTOSEL 5.18 17/93] drm/amd/display: Reduce frame size in the bouding box for DCN20

2022-08-11 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit c55300ad4a1814bac9191a4d2c7b0d74273aec7c ] GCC throw warnings for the function dcn20_update_bounding_box due to its frame size that looks like this: error: the frame size of 1936 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] This commit

[PATCH AUTOSEL 5.18 18/93] drm/radeon: integer overflow in radeon_mode_dumb_create()

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit feb54650bae25f2a2adfc493e3e254e7c27a3fba ] Similar to the handling of amdgpu_mode_dumb_create in commit 54ef0b5461c0 ("drm/amdgpu: integer overflow in amdgpu_mode_dumb_create()"), we thought a patch might be needed here as well. args->size is a u64. arg->p

[PATCH AUTOSEL 5.18 19/93] drm/radeon: Initialize fences array entries in radeon_sa_bo_next_hole

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit 0381ac3ca2e727d4dfb7264d9416a8ba6bb6c18b ] Similar to the handling of amdgpu_sa_bo_next_hole in commit 6a15f3ff19a8 ("drm/amdgpu: Initialize fences array entries in amdgpu_sa_bo_next_hole"), we thought a patch might be needed here as well. The entries were

[PATCH AUTOSEL 5.18 24/93] drm/amd/display: Fix monitor flash issue

2022-08-11 Thread Sasha Levin
From: Shah Dharati [ Upstream commit b840b64bc8ed3fc46f6d6aa7f97c43862a33bea5 ] [Why & How] For a some specific monitors, when connected on boot or hot plug, monitor flash for 1/2 seconds can happen during first HDCP query operation. Ading some delay in the init sequence for these monitors fixes

[PATCH AUTOSEL 5.18 41/93] amdgpu/pm: Fix possible array out-of-bounds if SCLK levels != 2

2022-08-11 Thread Sasha Levin
From: Darren Powell [ Upstream commit ceb180361e3851007547c55035cd1de03f108f75 ] [v2] simplified fix after Lijo's feedback removed clocks.num_levels from calculation of loop count removed unsafe accesses to shim table freq_values retained corner case output only min,now if clocks.num_le

[PATCH AUTOSEL 5.18 47/93] drm/amdgpu/display/dc: Fix null pointer exception

2022-08-11 Thread Sasha Levin
From: Rahul Kumar [ Upstream commit 1c4dae3e4639540fb567e570cc56a3c292afb6fe ] We observed hard hang due to NULL derefrence This issue is seen after running system all the time after two or three days struct dc *dc = plane_state->ctx->dc; Randomly in long run we found plane_state or plane_state

[PATCH AUTOSEL 5.18 51/93] drm/amdgpu: skip whole ras bad page framework on sriov

2022-08-11 Thread Sasha Levin
From: "Stanley.Yang" [ Upstream commit e0e146d5567317d6ba7d0169bed55d1d9ea05a61 ] It should not init whole ras bad page framework on sriov guest side due to it is handled on host side. Signed-off-by: Stanley.Yang Reviewed-by: Hawking Zhang Reviewed-by: Tao Zhou Signed-off-by: Alex Deucher S

[PATCH AUTOSEL 5.18 52/93] drm/amd/display: Guard against ddc_pin being NULL for AUX

2022-08-11 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit bc19909f19fdc8253d720d11c948935786fbfa08 ] [Why] In the case where we don't support DMUB aux but we have DPIA links in the configuration we might try to message AUX using the legacy path - where DDC pin is NULL. This causes a NULL pointer dereference.

[PATCH AUTOSEL 5.18 53/93] drm/amd/display: Fix dmub soft hang for PSR 1

2022-08-11 Thread Sasha Levin
From: Fangzhi Zuo [ Upstream commit 22676bc500c27d987a0b42cbe162aebf783f1c38 ] [Why] Unexpected change of aux hw mapping causes dmub soft hang when initiate aux transation at wrong aux channel. ddc_channel stands for hw dp aux index which is from vbios, but link_index is pure software concept f

[PATCH v2 0/3] Expand amdgpu documentation

2022-08-11 Thread Rodrigo Siqueira
This patchset introduces some new AMDGPU documentation. You will find: 1. A CSV table that maps which component version is part of some ASIC families. This can be useful to narrow down bugs; 2. Some explanation about AMD Display Pipeline; 3. An explanation of Multiple Plane Overlay, which can

[PATCH v2 1/3] Documentation/gpu: Add info table for ASICs

2022-08-11 Thread Rodrigo Siqueira
Amdgpu driver is used in an extensive range of devices, and each ASIC has some specific configuration. As a result of this variety, sometimes it is hard to identify the correct block that might cause the issue. This commit expands the amdgpu kernel-doc to alleviate this issue by introducing one ASI

[PATCH v2 2/3] Documentation/gpu: Add an explanation about the DCN pipeline

2022-08-11 Thread Rodrigo Siqueira
In the DCN code, we constantly talk about hardware pipeline, pipeline, or even just pipes, which is a concept that is not obvious to everyone. For this reason, this commit expands the DCN overview explanation by adding a new section that describes what a pipeline is from the DCN perspective. Chang

[PATCH v2 3/3] Documentation/gpu: Add Multiplane Overlay doc

2022-08-11 Thread Rodrigo Siqueira
Multiple plane overlay is a feature supported by AMD hardware, but it has specific details that deserve proper documentation. This commit introduces a documentation that describes some of the features, limitations, and use cases for this feature. Part of this documentation came from some discussion

[PATCH AUTOSEL 5.18 54/93] drm/amd/display: disable otg toggle w/a on boot

2022-08-11 Thread Sasha Levin
From: Dmytro Laktyushkin [ Upstream commit 8a077d9caa3a274de36ee2fe7b608041f5690343 ] This w/a has a bad interaction with seamless boot toggling an active stream. Most panels recover, however some fail leading to display corruption. Reviewed-by: Charlene Liu Acked-by: Rodrigo Siqueira Signed-

[PATCH AUTOSEL 5.18 63/93] drm/amdgpu: fix file permissions on some files

2022-08-11 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 0a94608f0f7de9b1135ffea3546afe68eafef57f ] Drop execute. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2085 Reviewed-by: Guchun Chen Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/inclu

[PATCH AUTOSEL 5.18 67/93] drm/amdgpu: Call trace info was found in dmesg when loading amdgpu

2022-08-11 Thread Sasha Levin
From: lin cao [ Upstream commit 748262eb400e809aa13e3485f4983c3db3d0ebb3 ] In the case of SRIOV, the register smnMp1_PMI_3_FIFO will get an invalid value which will cause the "shift out of bound". In Ubuntu22.04, this issue will be checked an related call trace will be reported in dmesg. Signed

[PATCH AUTOSEL 5.18 82/93] drm/amdkfd: Correct mmu_notifier_get failure handling

2022-08-11 Thread Sasha Levin
From: Philip Yang [ Upstream commit 0593ad215359d51514c1e6c81ce28ea598efed6b ] If process has signal pending, mmu_notifier_get_locked fails and calls ops->free_notifier, kfd_process_free_notifier will schedule kfd_process_wq_release as process refcount is 1, but process structure is already free

[PATCH AUTOSEL 5.18 83/93] drm/amdkfd: Process notifier release callback don't take mutex

2022-08-11 Thread Sasha Levin
From: Philip Yang [ Upstream commit 74097f9fd2f5ebdae04fcba59da345386415cbf3 ] Move process queues cleanup to deferred work kfd_process_wq_release, to avoid potential deadlock circular locking warning: WARNING: possible circular locking dependency detected the existing dependenc

[PATCH AUTOSEL 5.15 11/69] drm/amd/display: fix system hang when PSR exits

2022-08-11 Thread Sasha Levin
From: David Zhang [ Upstream commit 6cc5c77300afbb285c4f41e04f3435ae3c484c40 ] [why] When DC driver send PSR exit dmub command to DMUB FW, it might not wait until PSR exit. Then it may hit the following deadlock situation. 1. DC driver send HW LOCK command to DMUB FW due to frame update 2. DMUB

[PATCH AUTOSEL 5.15 12/69] drm/amd/display: Detect dpcd_rev when hotplug mst monitor

2022-08-11 Thread Sasha Levin
From: Wayne Lin [ Upstream commit 453b0016a054df0f442fda8a145b97a33816cab9 ] [Why] Once mst topology is constructed, later on new connected monitors are reported to source by CSN message. Within CSN, there is no carried info of DPCD_REV comparing to LINK_ADDRESS reply. As the result, we might le

[PATCH AUTOSEL 5.15 15/69] drm/amd/display: Fix dpp dto for disabled pipes

2022-08-11 Thread Sasha Levin
From: Duncan Ma [ Upstream commit d4965c53b95d7533dfc2309d2fc25838bd33220e ] [Why] When switching from 1 pipe to 4to1 mpc combine, DppDtoClk aren't enabled for the disabled pipes pior to programming the pipes. Upon optimizing bandwidth, DppDto are enabled causing intermittent underflow. [How] U

[PATCH AUTOSEL 5.15 16/69] drm/radeon: integer overflow in radeon_mode_dumb_create()

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit feb54650bae25f2a2adfc493e3e254e7c27a3fba ] Similar to the handling of amdgpu_mode_dumb_create in commit 54ef0b5461c0 ("drm/amdgpu: integer overflow in amdgpu_mode_dumb_create()"), we thought a patch might be needed here as well. args->size is a u64. arg->p

[PATCH AUTOSEL 5.15 17/69] drm/radeon: Initialize fences array entries in radeon_sa_bo_next_hole

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit 0381ac3ca2e727d4dfb7264d9416a8ba6bb6c18b ] Similar to the handling of amdgpu_sa_bo_next_hole in commit 6a15f3ff19a8 ("drm/amdgpu: Initialize fences array entries in amdgpu_sa_bo_next_hole"), we thought a patch might be needed here as well. The entries were

[PATCH AUTOSEL 5.15 20/69] drm/amd/display: Fix monitor flash issue

2022-08-11 Thread Sasha Levin
From: Shah Dharati [ Upstream commit b840b64bc8ed3fc46f6d6aa7f97c43862a33bea5 ] [Why & How] For a some specific monitors, when connected on boot or hot plug, monitor flash for 1/2 seconds can happen during first HDCP query operation. Ading some delay in the init sequence for these monitors fixes

[PATCH AUTOSEL 5.15 36/69] amdgpu/pm: Fix possible array out-of-bounds if SCLK levels != 2

2022-08-11 Thread Sasha Levin
From: Darren Powell [ Upstream commit ceb180361e3851007547c55035cd1de03f108f75 ] [v2] simplified fix after Lijo's feedback removed clocks.num_levels from calculation of loop count removed unsafe accesses to shim table freq_values retained corner case output only min,now if clocks.num_le

[PATCH AUTOSEL 5.15 41/69] drm/amdgpu/display/dc: Fix null pointer exception

2022-08-11 Thread Sasha Levin
From: Rahul Kumar [ Upstream commit 1c4dae3e4639540fb567e570cc56a3c292afb6fe ] We observed hard hang due to NULL derefrence This issue is seen after running system all the time after two or three days struct dc *dc = plane_state->ctx->dc; Randomly in long run we found plane_state or plane_state

[PATCH AUTOSEL 5.15 43/69] drm/amdgpu: skip whole ras bad page framework on sriov

2022-08-11 Thread Sasha Levin
From: "Stanley.Yang" [ Upstream commit e0e146d5567317d6ba7d0169bed55d1d9ea05a61 ] It should not init whole ras bad page framework on sriov guest side due to it is handled on host side. Signed-off-by: Stanley.Yang Reviewed-by: Hawking Zhang Reviewed-by: Tao Zhou Signed-off-by: Alex Deucher S

[PATCH AUTOSEL 5.15 44/69] drm/amd/display: Guard against ddc_pin being NULL for AUX

2022-08-11 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit bc19909f19fdc8253d720d11c948935786fbfa08 ] [Why] In the case where we don't support DMUB aux but we have DPIA links in the configuration we might try to message AUX using the legacy path - where DDC pin is NULL. This causes a NULL pointer dereference.

RE: [PATCH v2 1/3] Documentation/gpu: Add info table for ASICs

2022-08-11 Thread Russell, Kent
[AMD Official Use Only - General] I noticed that you added DCE and VCE/UVD prefixes in the columns, but not GC or SDMA. E.g. CHIP DCE GC VCE SDMA BONAIRE DCE 8 7VCE 2 / UVD 4.21 For consistency, should we

[PATCH AUTOSEL 5.15 60/69] drm/amdkfd: Correct mmu_notifier_get failure handling

2022-08-11 Thread Sasha Levin
From: Philip Yang [ Upstream commit 0593ad215359d51514c1e6c81ce28ea598efed6b ] If process has signal pending, mmu_notifier_get_locked fails and calls ops->free_notifier, kfd_process_free_notifier will schedule kfd_process_wq_release as process refcount is 1, but process structure is already free

[PATCH AUTOSEL 5.10 08/46] drm/amd/display: Detect dpcd_rev when hotplug mst monitor

2022-08-11 Thread Sasha Levin
From: Wayne Lin [ Upstream commit 453b0016a054df0f442fda8a145b97a33816cab9 ] [Why] Once mst topology is constructed, later on new connected monitors are reported to source by CSN message. Within CSN, there is no carried info of DPCD_REV comparing to LINK_ADDRESS reply. As the result, we might le

[PATCH AUTOSEL 5.10 09/46] drm/amd/display: Fix dpp dto for disabled pipes

2022-08-11 Thread Sasha Levin
From: Duncan Ma [ Upstream commit d4965c53b95d7533dfc2309d2fc25838bd33220e ] [Why] When switching from 1 pipe to 4to1 mpc combine, DppDtoClk aren't enabled for the disabled pipes pior to programming the pipes. Upon optimizing bandwidth, DppDto are enabled causing intermittent underflow. [How] U

[PATCH AUTOSEL 5.10 11/46] drm/radeon: Initialize fences array entries in radeon_sa_bo_next_hole

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit 0381ac3ca2e727d4dfb7264d9416a8ba6bb6c18b ] Similar to the handling of amdgpu_sa_bo_next_hole in commit 6a15f3ff19a8 ("drm/amdgpu: Initialize fences array entries in amdgpu_sa_bo_next_hole"), we thought a patch might be needed here as well. The entries were

[PATCH AUTOSEL 5.10 10/46] drm/radeon: integer overflow in radeon_mode_dumb_create()

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit feb54650bae25f2a2adfc493e3e254e7c27a3fba ] Similar to the handling of amdgpu_mode_dumb_create in commit 54ef0b5461c0 ("drm/amdgpu: integer overflow in amdgpu_mode_dumb_create()"), we thought a patch might be needed here as well. args->size is a u64. arg->p

[PATCH AUTOSEL 5.10 14/46] drm/amd/display: Fix monitor flash issue

2022-08-11 Thread Sasha Levin
From: Shah Dharati [ Upstream commit b840b64bc8ed3fc46f6d6aa7f97c43862a33bea5 ] [Why & How] For a some specific monitors, when connected on boot or hot plug, monitor flash for 1/2 seconds can happen during first HDCP query operation. Ading some delay in the init sequence for these monitors fixes

[PATCH AUTOSEL 5.10 29/46] drm/amdgpu/display/dc: Fix null pointer exception

2022-08-11 Thread Sasha Levin
From: Rahul Kumar [ Upstream commit 1c4dae3e4639540fb567e570cc56a3c292afb6fe ] We observed hard hang due to NULL derefrence This issue is seen after running system all the time after two or three days struct dc *dc = plane_state->ctx->dc; Randomly in long run we found plane_state or plane_state

[PATCH AUTOSEL 5.4 07/25] drm/radeon: integer overflow in radeon_mode_dumb_create()

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit feb54650bae25f2a2adfc493e3e254e7c27a3fba ] Similar to the handling of amdgpu_mode_dumb_create in commit 54ef0b5461c0 ("drm/amdgpu: integer overflow in amdgpu_mode_dumb_create()"), we thought a patch might be needed here as well. args->size is a u64. arg->p

[PATCH AUTOSEL 5.4 08/25] drm/radeon: Initialize fences array entries in radeon_sa_bo_next_hole

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit 0381ac3ca2e727d4dfb7264d9416a8ba6bb6c18b ] Similar to the handling of amdgpu_sa_bo_next_hole in commit 6a15f3ff19a8 ("drm/amdgpu: Initialize fences array entries in amdgpu_sa_bo_next_hole"), we thought a patch might be needed here as well. The entries were

[PATCH AUTOSEL 4.19 02/14] drm/radeon: integer overflow in radeon_mode_dumb_create()

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit feb54650bae25f2a2adfc493e3e254e7c27a3fba ] Similar to the handling of amdgpu_mode_dumb_create in commit 54ef0b5461c0 ("drm/amdgpu: integer overflow in amdgpu_mode_dumb_create()"), we thought a patch might be needed here as well. args->size is a u64. arg->p

[PATCH AUTOSEL 4.19 03/14] drm/radeon: Initialize fences array entries in radeon_sa_bo_next_hole

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit 0381ac3ca2e727d4dfb7264d9416a8ba6bb6c18b ] Similar to the handling of amdgpu_sa_bo_next_hole in commit 6a15f3ff19a8 ("drm/amdgpu: Initialize fences array entries in amdgpu_sa_bo_next_hole"), we thought a patch might be needed here as well. The entries were

[PATCH AUTOSEL 4.14 03/14] drm/radeon: Initialize fences array entries in radeon_sa_bo_next_hole

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit 0381ac3ca2e727d4dfb7264d9416a8ba6bb6c18b ] Similar to the handling of amdgpu_sa_bo_next_hole in commit 6a15f3ff19a8 ("drm/amdgpu: Initialize fences array entries in amdgpu_sa_bo_next_hole"), we thought a patch might be needed here as well. The entries were

[PATCH AUTOSEL 4.14 02/14] drm/radeon: integer overflow in radeon_mode_dumb_create()

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit feb54650bae25f2a2adfc493e3e254e7c27a3fba ] Similar to the handling of amdgpu_mode_dumb_create in commit 54ef0b5461c0 ("drm/amdgpu: integer overflow in amdgpu_mode_dumb_create()"), we thought a patch might be needed here as well. args->size is a u64. arg->p

[PATCH AUTOSEL 4.9 02/12] drm/radeon: Initialize fences array entries in radeon_sa_bo_next_hole

2022-08-11 Thread Sasha Levin
From: Xiaohui Zhang [ Upstream commit 0381ac3ca2e727d4dfb7264d9416a8ba6bb6c18b ] Similar to the handling of amdgpu_sa_bo_next_hole in commit 6a15f3ff19a8 ("drm/amdgpu: Initialize fences array entries in amdgpu_sa_bo_next_hole"), we thought a patch might be needed here as well. The entries were

[PATCH] drm/amd/display: fix DSC related non-x86/PPC64 compilation issue

2022-08-11 Thread Hamza Mahfooz
Need to protect DSC code with CONFIG_DRM_AMD_DC_DCN. Fixes the following build errors on arm64: ERROR: modpost: "dc_dsc_get_policy_for_timing" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERROR: modpost: "dc_dsc_compute_bandwidth_range" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! Fixe

Re: [PATCH] drm/amd/display: fix DSC related non-x86/PPC64 compilation issue

2022-08-11 Thread Alex Deucher
On Thu, Aug 11, 2022 at 12:24 PM Hamza Mahfooz wrote: > > Need to protect DSC code with CONFIG_DRM_AMD_DC_DCN. > Fixes the following build errors on arm64: > ERROR: modpost: "dc_dsc_get_policy_for_timing" > [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > ERROR: modpost: "dc_dsc_compute_bandwi

Re: [PATCH] drm/amdgpu: fix reset domain xgmi hive info reference leak

2022-08-11 Thread Andrey Grodzovsky
On 2022-08-11 11:34, Kim, Jonathan wrote: [Public] -Original Message- From: Kuehling, Felix Sent: August 11, 2022 11:19 AM To: amd-gfx@lists.freedesktop.org; Kim, Jonathan Subject: Re: [PATCH] drm/amdgpu: fix reset domain xgmi hive info reference leak Am 2022-08-11 um 09:42 schrieb

Re: [PATCH v4 00/41] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-08-11 Thread Daniel Vetter
On Wed, Aug 03, 2022 at 04:13:05PM -0400, Jason Baron wrote: > > > On 8/3/22 15:56, jim.cro...@gmail.com wrote: > > On Wed, Jul 20, 2022 at 9:32 AM Jim Cromie wrote: > >> > > > >> Hi Jason, Greg, DRM-folk, > >> > >> This adds 'typed' "class FOO" support to dynamic-debug, where 'typed' > >> mean

Re: build failure of next-20220811 due to b1a63a0b48ad ("drm/amd/display: consider DSC pass-through during mode validation")

2022-08-11 Thread Alex Deucher
On Thu, Aug 11, 2022 at 1:11 PM Sudip Mukherjee (Codethink) wrote: > > Hi All, > > Not sure if it has been reported, builds of riscv, alpha, s390, arm, > arm64, xtensa, mips, csky allmodconfig have failed to build next-20220811 > with the error: > > ERROR: modpost: "d

build failure of next-20220811 due to b1a63a0b48ad ("drm/amd/display: consider DSC pass-through during mode validation")

2022-08-11 Thread Sudip Mukherjee (Codethink)
Hi All, Not sure if it has been reported, builds of riscv, alpha, s390, arm, arm64, xtensa, mips, csky allmodconfig have failed to build next-20220811 with the error: ERROR: modpost: "dc_dsc_compute_bandwidth_range" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERRO

RE: [PATCH v3 2/3] drm/amdgpu_dm: Rely on split out luminance calculation function

2022-08-11 Thread Deucher, Alexander
[Public] > -Original Message- > From: amd-gfx On Behalf Of Jani > Nikula > Sent: Thursday, August 4, 2022 5:55 AM > To: Jouni Högander ; dri- > de...@lists.freedesktop.org; intel-...@lists.freedesktop.org; amd- > g...@lists.freedesktop.org > Cc: Siqueira, Rodrigo ; Li, Roman > ; Manasi Na

Re: build failure of next-20220811 due to b1a63a0b48ad ("drm/amd/display: consider DSC pass-through during mode validation")

2022-08-11 Thread Sudip Mukherjee
On Thu, Aug 11, 2022 at 6:16 PM Alex Deucher wrote: > > On Thu, Aug 11, 2022 at 1:11 PM Sudip Mukherjee (Codethink) > wrote: > > > > Hi All, > > > > Not sure if it has been reported, builds of riscv, alpha, s390, arm, > > arm64, xtensa, mips, csky allmodco

[PATCH v2] drm/amd/display: fix DSC related non-x86/PPC64 compilation issue

2022-08-11 Thread Hamza Mahfooz
Need to protect DSC code with CONFIG_DRM_AMD_DC_DCN. Fixes the following build errors on arm64: ERROR: modpost: "dc_dsc_get_policy_for_timing" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERROR: modpost: "dc_dsc_compute_bandwidth_range" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! Fixe

Re: [PATCH v2] drm/amd/display: fix DSC related non-x86/PPC64 compilation issue

2022-08-11 Thread Sudip Mukherjee
On Thu, Aug 11, 2022 at 7:00 PM Hamza Mahfooz wrote: > > Need to protect DSC code with CONFIG_DRM_AMD_DC_DCN. > Fixes the following build errors on arm64: > ERROR: modpost: "dc_dsc_get_policy_for_timing" > [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > ERROR: modpost: "dc_dsc_compute_bandwid

Re: [PATCH v2] drm/amd/display: fix DSC related non-x86/PPC64 compilation issue

2022-08-11 Thread Anders Roxell
On Thu, 11 Aug 2022 at 20:00, Hamza Mahfooz wrote: > > Need to protect DSC code with CONFIG_DRM_AMD_DC_DCN. > Fixes the following build errors on arm64: > ERROR: modpost: "dc_dsc_get_policy_for_timing" > [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > ERROR: modpost: "dc_dsc_compute_bandwidth

Re: [PATCH v2] drm/amd/display: fix DSC related non-x86/PPC64 compilation issue

2022-08-11 Thread Alex Deucher
On Thu, Aug 11, 2022 at 2:00 PM Hamza Mahfooz wrote: > > Need to protect DSC code with CONFIG_DRM_AMD_DC_DCN. > Fixes the following build errors on arm64: > ERROR: modpost: "dc_dsc_get_policy_for_timing" > [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > ERROR: modpost: "dc_dsc_compute_bandwid

  1   2   >