With this patch applied on Linus's tree 5.18-rc7 I get the following warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1367:20: warning:
unused variable 'pd' [-Wunused-variable]
struct amdgpu_bo *pd = vm->root.bo;
^
1 warning generated.
It does fix the null
I was told that this patch replaces the patch you mentioned
https://patchwork.freedesktop.org/series/106078/ and it the one
that'll hopefully land in Linus's tree
On Tue, 19 Jul 2022 at 03:33, Chen, Guchun wrote:
>
> Patch https://patchwork.freedesktop.org/series/106024/ should fix this.
>
> Rega
The feature is ready with latest firmwares.
Signed-off-by: Evan Quan
Reviewed-by: Hawking Zhang
Acked-by: Alex Deucher
Change-Id: I581a7aae2618134a9d196cd383cdabf3516efec0
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu
To fit the latest 78.49.0 PMFW. Also, bump the version
to 0x2B.
Signed-off-by: Evan Quan
Reviewed-by: Hawking Zhang
Acked-by: Alex Deucher
Change-Id: Icbf79cca25dbfd2850425e9e4afbb77cf1ff28db
---
.../drm/amd/pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_0.h| 4 ++--
drivers/gpu/drm/amd/pm/sws
Only PP_MP1_STATE_UNLOAD is supported for now. For other mp1 state, we
should just ignore it. Otherwise, there will be errors coming out.
Signed-off-by: Evan Quan
Reviewed-by: Hawking Zhang
Acked-by: Alex Deucher
Change-Id: I15427d6daf14d5c82a6e7f9d32fdea60a80fd0ec
---
.../drm/amd/pm/swsmu/smu
The current approach breaks S3/S4 as asic reset is needed for them.
And putting SMU out of service(via SMU_MSG_PrepareMp1ForUnload) will make
that(asic reset) failed. Considering with current designs, there is
actually also asic reset involved on driver reloading. That can make
asic back to a clean
This patch set splits out static hdr metadata backlight range parsing
from gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c into gpu/drm/drm-edid.c
as a new function. This new function is then used during edid parsing
when HDR static metadata block parsing.
Calculated values are stored in a new struct dr
Split luminance min/max calculation using static hdr metadata from
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:update_connector_ext_caps
into drm/drm_edid.c and use it during edid parsing. Calculated range is
stored into connector->display_info->luminance_range.
Add new data structure (drm_l
Luminance range calculation was split out into drm_edid.c and is now
part of edid parsing. Rely on values calculated during edid parsing and
use these for caps->aux_max_input_signal and caps->aux_min_input_signal.
v2: Use values calculated during edid parsing
Cc: Roman Li
Cc: Rodrigo Siqueira
C
Instead of using fixed 0 - 512 range use luminance range calculated
as a part of edid parsing. As a backup fall back to static 0 - 512.
v3: Clean-ups suggested by Jani Nikula
v2: Use values calculated during edid parsing
Cc: Lyude Paul
Cc: Mika Kahola
Cc: Jani Nikula
Cc: Manasi Navare
Signed-
On 7/18/22 16:02, Alex Deucher wrote:
> On Thu, Jul 14, 2022 at 12:46 PM Maíra Canal wrote:
>>
>> The parameters WritebackPixelFormat and WritebackVRatio are removed as
>> they are not used on the function dml30_CalculateWriteBackDISPCLK.
>
> Maybe this is done for consistency with other dml code
On Tue, Jul 19, 2022 at 1:40 PM Mike Lothian wrote:
>
> I was told that this patch replaces the patch you mentioned
> https://patchwork.freedesktop.org/series/106078/ and it the one
> that'll hopefully land in Linus's tree
>
Great, I confirm that both patches solve the issue.
As I understand the
Am 16.07.22 um 05:57 schrieb Jason Wang:
The double `have' is duplicated in line 696, remove one.
Signed-off-by: Jason Wang
Reviewed-by: Christian König
---
drivers/gpu/drm/radeon/radeon_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/rad
Am 16.07.22 um 06:28 schrieb Jason Wang:
The double `to' is duplicated in the comment, remove one.
Signed-off-by: Jason Wang
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/a
The double `have' is duplicated in line 696, remove one.
Signed-off-by: Jason Wang
---
drivers/gpu/drm/radeon/radeon_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_gem.c
b/drivers/gpu/drm/radeon/radeon_gem.c
index 84843b3b3aef..261fcbae88
Local variable 'rq' is initialized by an address
of field of drm_sched_job, so it does not make
sense to compare 'rq' with NULL.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Andrey Strachuk
Fixes: 7c6e68c777f1 ("drm/amdgpu: Avoid HW GPU reset for RAS.")
---
d
On Fri, Jul 15, 2022 at 9:53 AM Dmitry Osipenko
wrote:
>
> Hello,
>
> This series moves all drivers to a dynamic dma-buf locking specification.
> From now on all dma-buf importers are made responsible for holding
> dma-buf's reservation lock around all operations performed over dma-bufs.
> This co
On 18.07.22 22:32, Andrew Morton wrote:
> On Mon, 18 Jul 2022 12:56:29 +0200 David Hildenbrand wrote:
>
>>> /*
>>> * Try to move out any movable page before pinning the range.
>>> */
>>> @@ -1919,7 +1948,8 @@ static long check_and_migrate_movable_pages(unsign
The double `to' is duplicated in the comment, remove one.
Signed-off-by: Jason Wang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index e3d13970816
On Tue, Jul 19, 2022 at 6:49 AM Maíra Canal wrote:
>
> On 7/18/22 16:02, Alex Deucher wrote:
> > On Thu, Jul 14, 2022 at 12:46 PM Maíra Canal wrote:
> >>
> >> The parameters WritebackPixelFormat and WritebackVRatio are removed as
> >> they are not used on the function dml30_CalculateWriteBackDISP
enable gfx ulv and gpo on smu_v13_0_7
Signed-off-by: Kenneth Feng
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
index 6f
On Tue, Jul 19, 2022 at 9:17 AM Kenneth Feng wrote:
>
> enable gfx ulv and gpo on smu_v13_0_7
>
> Signed-off-by: Kenneth Feng
Acked-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/pm
Well what's the background for this?
So far MCBP isn't a validated feature, we just added some debugfs
interface for testing it.
Regards,
Christian.
Am 19.07.22 um 04:09 schrieb jiadong@amd.com:
From: "Jiadong.Zhu"
1. Use unmap_queue package to trigger preemption on gfx9
Add traili
Make existing documentation comments available through the
sphinx docs, and add new high-level documentation for
AMDKFD features
From: David Francis
Add six long comments outlining the basic features of the
driver, to aid new developers.
Signed-off-by: David Francis
Reviewed-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 74 +++
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 25
From: David Francis
Add a new series of documentation entries in the AMDGPU
section describing AMDKFD, the compute driver for AMD
GPUs
Signed-off-by: David Francis
Reviewed-by: Felix Kuehling
---
Documentation/gpu/amdgpu/index.rst | 1 +
Documentation/gpu/amdgpu/kfd/index.rst |
From: David Francis
The kernel documentation system requires things to be just so
in order to incorporate documentation into the sphinx system.
There were some comments in amdkfd which didn't meet that
standard. Tweak them so they do.
Signed-off-by: David Francis
Reviewed-by: Felix Kuehling
-
[AMD Official Use Only - General]
Reviewed-by: Yang Wang
Best Regards,
Kevin
From: amd-gfx on behalf of Kenneth Feng
Sent: Tuesday, July 19, 2022 9:17 PM
To: amd-gfx@lists.freedesktop.org
Cc: Feng, Kenneth
Subject: [PATCH] drm/amd/pm: enable gfx ulv and gpo
On Tue, Jul 19, 2022 at 4:26 PM Mikhail Gavrilov
wrote:
> In the kernel log there is no error so it is most likely a user space issue ,
> but I am not
> sure about it.
But I am confused by the message in the kernel log:
[ 1962.000909] amdgpu: HIQ MQD's queue_doorbell_id0 is not 0, Queue
preempti
From: Roman Li
[Why]
DCN 3.1.4 uses dmub not dmcu. Attempt to identify
dmcu firmware for dcn314 results in dm init error:
"Unsupported ASIC type"
[How]
Add dcn314 to the list of asics that don't require dmcu
Signed-off-by: Roman Li
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +
From: Roman Li
Adding dm ip block to enable display on dcn 3.1.4.
Signed-off-by: Roman Li
---
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
index 0
Series is:
Reviewed-by: Alex Deucher
On Tue, Jul 19, 2022 at 2:26 PM wrote:
>
> From: Roman Li
>
> Adding dm ip block to enable display on dcn 3.1.4.
>
> Signed-off-by: Roman Li
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/driv
amdgpu_device_asic_has_dc_support() just checks the asic itself.
amdgpu_device_has_dc_support() is a runtime check which not
only checks the asic, but also other things in the driver
like whether virtual display is enabled. We want the latter
here.
Signed-off-by: Alex Deucher
---
drivers/gpu/dr
virtual display is enabled unconditionally in SR-IOV, but
without specifying the virtual_display module, the number
of crtcs defaults to 0. Set a single display by default
for SR-IOV if the virtual_display parameter is not set.
Only enable virtual display by default on SR-IOV on asics
which actual
There are several places where we don't want to check
if a particular asic could support DC, but rather, if
DC is enabled. Set a flag if DC is enabled and check
for that rather than if a device supports DC or not.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h |
Move it into the DCE code for each generation. This avoids
confusion with the different display paths.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 35 +
drivers/gpu/drm/amd/amdgpu/amdgpu_display.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c |
The new vkms virtual display code is atomic so there is
no need to call drm_helper_disable_unused_functions()
when it is enabled. Doing so can result in a segfault.
When the driver switched from the old virtual display code
to the new atomic virtual display code, it was missed that
we enable virtu
On 2022-07-19 14:26, roman...@amd.com wrote:
> From: Roman Li
>
> [Why]
> DCN 3.1.4 uses dmub not dmcu. Attempt to identify
> dmcu firmware for dcn314 results in dm init error:
> "Unsupported ASIC type"
>
> [How]
> Add dcn314 to the list of asics that don't require dmcu
>
> Signed-off-by: Roman
On Tue, Jul 19, 2022 at 4:32 AM Mike Lothian wrote:
>
> With this patch applied on Linus's tree 5.18-rc7 I get the following warning:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1367:20: warning:
> unused variable 'pd' [-Wunused-variable]
>struct amdgpu_bo *pd = vm->root.bo;
>
Applied. Thanks!
On Tue, Jul 19, 2022 at 8:33 AM Christian König
wrote:
>
> Am 16.07.22 um 05:57 schrieb Jason Wang:
> > The double `have' is duplicated in line 696, remove one.
> >
> > Signed-off-by: Jason Wang
>
> Reviewed-by: Christian König
>
> > ---
> > drivers/gpu/drm/radeon/radeon_gem
Applied. Thanks!
On Tue, Jul 19, 2022 at 8:34 AM Christian König
wrote:
>
> Am 16.07.22 um 06:28 schrieb Jason Wang:
> > The double `to' is duplicated in the comment, remove one.
> >
> > Signed-off-by: Jason Wang
>
> Reviewed-by: Christian König
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgp
Ping on this series.
Alex
On Fri, Jul 8, 2022 at 6:56 PM Alex Deucher wrote:
>
> Use the former pad element to store the IP versions from the
> IP discovery table. This allows userspace to get the IP
> version from the kernel to better align with hardware IP
> versions.
>
> Proposed mesa patch:
On 7/15/22 09:59, Dmitry Osipenko wrote:
> On 7/15/22 09:50, Christian König wrote:
>> Am 15.07.22 um 02:52 schrieb Dmitry Osipenko:
>>> Intel i915 GPU driver uses wait-wound mutex to lock multiple GEMs on the
>>> attachment to the i915 dma-buf. In order to let all drivers utilize
>>> shared
>>> wa
Move additional dummy structures off the stack and into
the dummy vars structure.
Fixes the following:
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In
function
'DISPCLKDPPCLKDCFCLKDeepSleepPrefetchParametersWatermarksAndPerformanceCalculation':
drivers/gpu/drm/amd/am
[AMD Official Use Only - General]
Hi Christian,
There is an imbed project based on xen. One of the guest vm with high priority
jobs needs to send preemption against the other vm.
There are some works in other component including umd and qemu, etc. For kmd,
we just modify the mcbp related functi
Reviewed-by: Marek Olšák
for the series.
Marek
On Tue, Jul 19, 2022 at 3:53 PM Alex Deucher wrote:
> Ping on this series.
>
> Alex
>
> On Fri, Jul 8, 2022 at 6:56 PM Alex Deucher
> wrote:
> >
> > Use the former pad element to store the IP versions from the
> > IP discovery table. This allow
Add ras eeprom i2c function for smu13 v13_0_0.
Signed-off-by: YiPeng Chai
Acked-by: Evan Quan
Acked-by: Alex Deucher
---
.../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 157 ++
1 file changed, 157 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
When using amdgpu for e8860, the monitor sometimes haven't any signal,
and the kernel reports some errors:
[ 17.317302][ 2] [ T1045] [drm:amdgpu_atombios_dp_link_train [amdgpu]]
*ERROR* channel eq failed: 5 tries
[ 17.326963][ 2] [ T1045] [drm:amdgpu_atombios_dp_link_train [amdgpu]]
*ERROR* c
[AMD Official Use Only - General]
Reviewed-by: Hawing Zhang
Regards,
Hawking
-Original Message-
From: Chai, Thomas
Sent: Wednesday, July 20, 2022 10:49
To: amd-gfx@lists.freedesktop.org
Cc: Chai, Thomas ; Zhang, Hawking ;
Zhou1, Tao ; Clements, John ; Li,
Candice ; Chai, Thomas ; Qua
[AMD Official Use Only - General]
Fix typo.
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Zhang,
Hawking
Sent: Wednesday, July 20, 2022 11:26
To: Chai, Thomas ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Zhou1, Tao
; Clements, John ; Quan, Evan
; Li, Cand
50 matches
Mail list logo
