I can't see any issues with this now so:
Reviewed-by: Alistair Popple
Alex Sierra writes:
> With DEVICE_COHERENT, we'll soon have vm_normal_pages() return
> device-managed anonymous pages that are not LRU pages. Although they
> behave like normal pages for purposes of mapping in CPU page, an
On 6/8/2022 11:06 AM, Mohammad Zafar Ziya wrote:
Add jpeg vmid update under IB submit
Signed-off-by: Mohammad Zafar Ziya
Acked-by: Christian König
Reviewed-by: Lijo Lazar
Thanks,
Lijo
---
drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 6 +-
drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.h | 1
Am 07.06.22 um 17:19 schrieb Xiaohui Zhang:
Similar to the handling of amdgpu_sa_bo_next_hole in commit 6a15f3ff19a8
("drm/amdgpu: Initialize fences array entries in amdgpu_sa_bo_next_hole"),
we thought a patch might be needed here as well.
The entries were only initialized once in radeon_sa_bo_
add interface to deallocate power_context for smu_v13_0_7
Signed-off-by: Kenneth Feng
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_
enable BACO on smu_v13_0_7
Signed-off-by: Kenneth Feng
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c| 1 +
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 7 +++
2 files changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
b/drivers/gpu/drm/amd
update the driver if header for smu_v13_0_7
Signed-off-by: Kenneth Feng
---
.../inc/pmfw_if/smu13_driver_if_v13_0_7.h | 62 +--
drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 2 +-
2 files changed, 45 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu
enable gfxoff on smu_v13_0_7
Signed-off-by: Kenneth Feng
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
index dc614befcdf5
support BAMACO reset on smu_v13_0_7, take BAMACO as a subset of BACO
for the low latency, and it only happens on specific platforms.
Signed-off-by: Kenneth Feng
---
drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 1 +
.../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 57 ++-
2 fil
On 6/8/2022 2:35 PM, Kenneth Feng wrote:
enable BACO on smu_v13_0_7
Signed-off-by: Kenneth Feng
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c| 1 +
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 7 +++
2 files changed, 8 insertions(+)
diff --git a/drivers/gpu/drm
[AMD Official Use Only - General]
[AMD Official Use Only - General]
Yeah, synced to the latest code. Somehow ‘drm/amd/pm: drop redundant
declarations’was reverted somehow at a point.
Thanks.
Best wishes
Kenneth Feng
发件人: Lazar, Lijo
日期: 星期三, 2022年6月8日 17:14
收件人: Feng, Kenneth , amd-gfx@list
[AMD Official Use Only - General]
Series is
Reviewed-by: Yang Wang
Best Regards,
Kevin
From: amd-gfx on behalf of Kenneth Feng
Sent: Wednesday, June 8, 2022 5:05 PM
To: amd-gfx@lists.freedesktop.org
Cc: Feng, Kenneth
Subject: [PATCH 1/5] drm/amd/pm: add int
The field is redundant and does not serve any functional role
Signed-off-by: Ramesh Errabolu
---
drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 --
drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 -
drivers/gpu/drm/amd/amdkfd/kfd_topology.h | 1 -
3 files changed, 4 deletions(-)
diff --git a/drive
[AMD Official Use Only - General]
Ignore the patch sent a bit early.
Regards,
Ramesh
-Original Message-
From: Errabolu, Ramesh
Sent: Wednesday, June 8, 2022 5:07 PM
To: amd-gfx@lists.freedesktop.org
Cc: Errabolu, Ramesh
Subject: [PATCH] drm/amdkfd: Remove field io_link_count from stru
In existing code MMIO and DOORBELL BOs are unpinned without ensuring the
condition that their map count has reached zero. Unpinning without checking
this constraint could lead to an error while BO is being freed. The patch
fixes this issue.
Signed-off-by: Ramesh Errabolu
---
drivers/gpu/drm/amd/
The field is redundant and does not serve any functional role
Signed-off-by: Ramesh Errabolu
---
drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 --
drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 -
drivers/gpu/drm/amd/amdkfd/kfd_topology.h | 1 -
3 files changed, 4 deletions(-)
diff --git a/drive
Reviewed-by:JamesZhuforthis patch James
On 2022-06-08 1:36 a.m., Mohammad Zafar Ziya wrote:
Add jpeg vmid update under IB submit
Signed-off-by: Mohammad Zafar Ziya
Acked-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 6 +-
drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.h | 1 +
On 2022-06-07 13:58, Aurabindo Pillai wrote:
On 2022-06-07 11:34, Leo wrote:
On 2022-06-07 05:40, Chandan Vurdigere Nataraj wrote:
[Why]
Getting below errors:
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:1414:5:
error: implicit conversion from enumeration typ
Am 2022-06-07 um 22:21 schrieb Lang Yu:
On 06/07/ , Felix Kuehling wrote:
Am 2022-06-07 um 05:59 schrieb Lang Yu:
This will remove some redundant codes.
Signed-off-by: Lang Yu
The redundancy is quite small, and amdgpu_amdkfd_gpuvm_validate_pt_pd_bos
and amdgpu_amdkfd_bo_validate are quite a
Hi,
>>
>>
>> On 2022-06-07 05:40, Chandan Vurdigere Nataraj wrote:
>>> [Why]
>>> Getting below errors:
>>> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:1414:5:
>>> error: implicit conversion from enumeration type 'enum
>>> scan_direction_class' to different enumerat
I need to look into this more deeply when I'm back from sick leave.
Till then this workaround should be sufficient since VCN3 is the only
callback which tries to adjust the instance.
Regards,
Christian.
Am 07.06.22 um 22:22 schrieb Alex Deucher:
We'll need to implement the parse callbacks fo
On 2022-06-07 13:58, Aurabindo Pillai wrote:
>
>
> On 2022-06-07 11:34, Leo wrote:
>>
>>
>> On 2022-06-07 05:40, Chandan Vurdigere Nataraj wrote:
>>> [Why]
>>> Getting below errors:
>>> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:1414:5:
>>> error: implicit conver
Am 07.06.22 um 22:27 schrieb Alex Deucher:
On Fri, Jun 3, 2022 at 9:05 AM Christian König
wrote:
The TLB on GFX8 stores each block of 8 PTEs where any of the valid bits
are set.
Signed-off-by: Christian König
Reviewed-by: Alex Deucher
Alex could you push this? It's an important fix, but I
yes. will do.
Alex
On Wed, Jun 8, 2022 at 9:58 AM Christian König
wrote:
>
> Am 07.06.22 um 22:27 schrieb Alex Deucher:
> > On Fri, Jun 3, 2022 at 9:05 AM Christian König
> > wrote:
> >> The TLB on GFX8 stores each block of 8 PTEs where any of the valid bits
> >> are set.
> >>
> >> Signed-off-b
I'll push this with the TLB fix.
Alex
On Wed, Jun 8, 2022 at 9:47 AM Christian König
wrote:
>
> I need to look into this more deeply when I'm back from sick leave.
>
> Till then this workaround should be sufficient since VCN3 is the only
> callback which tries to adjust the instance.
>
> Regards
Hi Roman:
Can the panel achieve the max peak luminance
if it is limited in frame-average luminance?
Regards,
Aaron
On Mon, Jun 06, 2022 at 08:59:36AM -0600, jim.cro...@gmail.com wrote:
> On Wed, May 25, 2022 at 9:02 AM Daniel Vetter wrote:
>
> > On Mon, May 16, 2022 at 04:56:13PM -0600, Jim Cromie wrote:
> > > DRM.debug API is 23 macros, issuing 10 exclusive categories of debug
> > > messages. By rough count
From: Leo Li
[Why]
There is a theoretical problem in prior patches for reducing the stack
size of *update_bw_bounding_box() functions.
By modifying the soc.clock_limits[n] struct directly, this can cause
unintended behavior as the for loop attempts to swap rows in
clock_limits[n]. A temporary s
[AMD Official Use Only - General]
Isnt it cleaner to revert the original patch which removed the temporary
variable and then instead allocate the clock_limits array on heap, and later
freed at the end of the function?
--
Regards,
Jay
From: Li, Sun peng (Leo)
S
On 2022-06-08 13:25, Pillai, Aurabindo wrote:
> [AMD Official Use Only - General]
>
>
> Isnt it cleaner to revert the original patch which removed the temporary
> variable and then instead allocate the clock_limits array on heap, and later
> freed at the end of the function?
>
> --
I don't
On 2022-06-08 13:47, Leo wrote:
On 2022-06-08 13:25, Pillai, Aurabindo wrote:
[AMD Official Use Only - General]
Isnt it cleaner to revert the original patch which removed the temporary
variable and then instead allocate the clock_limits array on heap, and later
freed at the end of the fu
On 2022-06-08 12:48, sunpeng...@amd.com wrote:
> From: Leo Li
>
> [Why]
>
> There is a theoretical problem in prior patches for reducing the stack
> size of *update_bw_bounding_box() functions.
>
> By modifying the soc.clock_limits[n] struct directly, this can cause
> unintended behavior as
On 2022-06-08 13:47, Leo wrote:
On 2022-06-08 13:25, Pillai, Aurabindo wrote:
[AMD Official Use Only - General]
Isnt it cleaner to revert the original patch which removed the temporary
variable and then instead allocate the clock_limits array on heap, and later
freed at the end of the fu
[AMD Official Use Only - General]
Hi Aaron,
Yes, the panel brightness should reach max after we send max-fall value as
backlight current peak.
Thanks,
Roman
> -Original Message-
> From: Aaron Ma
> Sent: Wednesday, June 8, 2022 6:02 AM
> To: Mahfooz, Hamza ; Li, Roman
>
> Cc: Pillai,
On 2022-06-07 18:50, Graham Sider wrote:
Make MES/RS64 CP enablement and MES scheduler/MES KIQ versions available
through sysfs.
Signed-off-by: Graham Sider
Why do we need to expose this to user mode applications? They don't
interact directly with the scheduler or the KIQ. I cannot think of
On 2022-06-08 07:51, Ramesh Errabolu wrote:
In existing code MMIO and DOORBELL BOs are unpinned without ensuring the
condition that their map count has reached zero. Unpinning without checking
this constraint could lead to an error while BO is being freed. The patch
fixes this issue.
Signed-of
On 2022-06-08 07:51, Ramesh Errabolu wrote:
The field is redundant and does not serve any functional role
Signed-off-by: Ramesh Errabolu
Reviewed-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 --
drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 -
drivers/gpu/drm/a
[AMD Official Use Only - General]
My response is inline.
Regards,
Ramesh
-Original Message-
From: Kuehling, Felix
Sent: Thursday, June 9, 2022 1:10 AM
To: amd-gfx@lists.freedesktop.org; Errabolu, Ramesh
Subject: Re: [PATCH] drm/amdgpu: Unpin MMIO and DOORBELL BOs only after map
count
[AMD Official Use Only - General]
I was originally using the MES scheduler version in Thunk to check whether to
use userptr or non-paged memory for the queue allocation. Just today though
I've changed this to always use non-paged so this isn't needed anymore. Maybe
instead we can think about ad
Hi Dave, Daniel,
Fixes for 5.19.
The following changes since commit bf23729c7a5f44f0e863666b9364a64741fd3241:
Merge tag 'amd-drm-next-5.19-2022-05-26-2' of
https://gitlab.freedesktop.org/agd5f/linux into drm-next (2022-06-01 10:56:11
+1000)
are available in the Git repository at:
https:/
On 2022-06-08 16:03, Errabolu, Ramesh wrote:
[AMD Official Use Only - General]
My response is inline.
Regards,
Ramesh
-Original Message-
From: Kuehling, Felix
Sent: Thursday, June 9, 2022 1:10 AM
To: amd-gfx@lists.freedesktop.org; Errabolu, Ramesh
Subject: Re: [PATCH] drm/amdgpu: Unp
On 2022-05-04 03:47, Christian König wrote:
Avoids quite a bit of logic and kmalloc overhead.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 5 +-
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 303 +++---
drivers/gpu/drm/amd/amdgpu/amdgp
On 2022-05-04 03:47, Christian König wrote:
This adds the infrastructure for an execution context for GEM buffers
which is similar to the existinc TTMs execbuf util and intended to replace
it in the long term.
The basic functionality is that we abstracts the necessary loop to lock
many differe
For SMU IP v13.0.4, the smnMP1_FIRMWARE_FLAGS address is different,
we need this to correct the reading address.
Signed-off-by: Tim Huang
Reviewed-by: Yifan Zhang
---
drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 1 +
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 12 ++--
2 files
The EnableGfxImu message will be issued in the set_gfx_power_up_by_imu.
Signed-off-by: Tim Huang
Reviewed-by: Yifan Zhang
---
.../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c| 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/
44 matches
Mail list logo
