[PATCH] drm/amdgpu: suppress the compile warning about 64 bit type

2022-05-30 Thread Evan Quan
Suppress the compile warning below: drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:1292 gfx_v11_0_rlc_backdoor_autoload_copy_ucode() warn: should '1 << id' be a 64 bit type? Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Evan Quan Change-Id: If5f83daeb4039d87c5b47c221f9c963c9

RE: [PATCH] drm/amdgpu: suppress the compile warning about 64 bit type

2022-05-30 Thread Chen, Guchun
Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Evan Quan Sent: Monday, May 30, 2022 3:07 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan ; kernel test robot ; Dan Carpenter Subject: [PATCH] drm/amdgpu: suppress the comp

Re: [PATCH] drm/amdgpu: suppress compile warnings

2022-05-30 Thread Christian König
Am 30.05.22 um 08:50 schrieb Evan Quan: Suppress the compile warnings below: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1407:12: warning: stack frame size (1040) exceeds limit (1024) in 'smu_v13_0_7_get_power_profile_mode' [-Wframe-larger-than] drivers/gpu/drm/amd/amdgpu/gfx

Re: [PATCH] drm/amdgpu: suppress the compile warning about 64 bit type

2022-05-30 Thread Christian König
Am 30.05.22 um 09:06 schrieb Evan Quan: Suppress the compile warning below: drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:1292 gfx_v11_0_rlc_backdoor_autoload_copy_ucode() warn: should '1 << id' be a 64 bit type? Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Evan Quan A

[linux-next:master 13949/14198] drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1133 amdgpu_discovery_reg_base_init() error: testing array offset 'adev->vcn.num_vcn_inst' after use.

2022-05-30 Thread Dan Carpenter
[ This is one of those weird things where the kbuild bot sends the warning to -mm instead of the AMD list. It will likely try send a duplicate warning to the AMD list in a few days. I would have sent this warning in a couple hours from my devel system as well. -dan] tree: https://git.ker

Re: [PATCH v3 2/7] drm/amdgpu: Cache result of last reset at reset domain level.

2022-05-30 Thread Christian König
Am 25.05.22 um 21:04 schrieb Andrey Grodzovsky: Will be read by executors of async reset like debugfs. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 -- drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h

Re: [PATCH v3 3/7] drm/admgpu: Serialize RAS recovery work directly into reset domain queue.

2022-05-30 Thread Christian König
Am 25.05.22 um 21:04 schrieb Andrey Grodzovsky: Save the extra usless work schedule. Signed-off-by: Andrey Grodzovsky Acked-by: Christian König Maybe Luben want to take a look as well, he has done some RAS review in the past. Thanks, Christian. --- drivers/gpu/drm/amd/amdgpu/amdgpu_r

Re: [PATCH v3 4/7] drm/amdgpu: Add work_struct for GPU reset from debugfs

2022-05-30 Thread Christian König
Am 25.05.22 um 21:04 schrieb Andrey Grodzovsky: We need to have a work_struct to cancel this reset if another already in progress. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 19 +-- 2

Re: [PATCH v3 5/7] drm/amdgpu: Add work_struct for GPU reset from kfd.

2022-05-30 Thread Christian König
Am 25.05.22 um 21:04 schrieb Andrey Grodzovsky: We need to have a work_struct to cancel this reset if another already in progress. Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 15 ++- drivers/gpu/drm/amd/amdgpu/am

Re: [PATCH v3 6/7] drm/amdgpu: Rename amdgpu_device_gpu_recover_imp back to amdgpu_device_gpu_recover

2022-05-30 Thread Christian König
Am 25.05.22 um 21:04 schrieb Andrey Grodzovsky: We removed the wrapper that was queueing the recover function into reset domain queue who was using this name. Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +- drivers/gpu

Re: [PATCH v3 7/7] drm/amdgpu: Stop any pending reset if another in progress.

2022-05-30 Thread Christian König
Am 25.05.22 um 21:04 schrieb Andrey Grodzovsky: We skip rest requests if another one is already in progress. Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 27 ++ 1 file changed, 27 insertions(+) diff -

Re: [PATCH v6 04/22] drm/panfrost: Fix shrinker list corruption by madvise IOCTL

2022-05-30 Thread Steven Price
On 27/05/2022 00:50, Dmitry Osipenko wrote: > Calling madvise IOCTL twice on BO causes memory shrinker list corruption > and crashes kernel because BO is already on the list and it's added to > the list again, while BO should be removed from from the list before it's > re-added. Fix it. > > Cc: st

Re: [PATCH] drm/amdkfd: don't add DOORBELL and MMIO BOs to validate list

2022-05-30 Thread Christian König
Am 26.05.22 um 00:17 schrieb Felix Kuehling: On 2022-05-25 06:37, Christian König wrote: Am 25.05.22 um 11:25 schrieb Lang Yu: On 05/25/ , Christian König wrote: Am 25.05.22 um 10:43 schrieb Lang Yu: DOORBELL and MMIO BOs never move once created. No need to validate them after that. Yeah, bu

[PATCH] BACKPORT: drm/amdgpu/disply: set num_crtc earlier

2022-05-30 Thread Ryan Lin
From: Alex Deucher To avoid a recently added warning: Bogus possible_crtcs: [ENCODER:65:TMDS-65] possible_crtcs=0xf (full crtc mask=0x7) WARNING: CPU: 3 PID: 439 at drivers/gpu/drm/drm_mode_config.c:617 drm_mode_config_validate+0x178/0x200 [drm] In this case the warning is harmless, but confu

[bug report] drm/radeon: add dpm support for CI dGPUs (v2)

2022-05-30 Thread Dan Carpenter
[ Ancient code. No idea why it's only being reported as a bug now. -dan ] Hello Alex Deucher, The patch cc8dbbb4f62a: "drm/radeon: add dpm support for CI dGPUs (v2)" from Aug 14, 2013, leads to the following Smatch static checker warning: drivers/gpu/drm/radeon/ci_dpm.c:5695 ci_dpm_init() warn

[PATCH] drm/amdgpu: delete duplicate condition in gfx_v11_0_soft_reset()

2022-05-30 Thread Dan Carpenter
We know that "grbm_soft_reset" is true because we're already inside an if (grbm_soft_reset) condition. No need to test again. Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/dr

[PATCH AUTOSEL 5.18 023/159] drm/amd/display: Disabling Z10 on DCN31

2022-05-30 Thread Sasha Levin
From: Saaem Rizvi [ Upstream commit 5d5af34072c8b11f60960c3bea57ff9de5877791 ] [WHY] Z10 is should not be enabled by default on DCN31. [HOW] Using DC debug flags to disable Z10 by default on DCN31. Reviewed-by: Eric Yang Acked-by: Pavle Kotarac Signed-off-by: Saaem Rizvi Signed-off-by: Alex

[PATCH AUTOSEL 5.18 042/159] drm/amdgpu/pm: fix the null pointer while the smu is disabled

2022-05-30 Thread Sasha Levin
From: Huang Rui [ Upstream commit eea5c7b3390c6e006ba4cbd906447dd8cea8cfbf ] It needs to check if the pp_funcs is initialized while release the context, otherwise it will trigger null pointer panic while the software smu is not enabled. [ 1109.404555] BUG: kernel NULL pointer dereference, addre

[PATCH AUTOSEL 5.18 043/159] drm/amd/pm: fix double free in si_parse_power_table()

2022-05-30 Thread Sasha Levin
From: Keita Suzuki [ Upstream commit f3fa2becf2fc25b6ac7cf8d8b1a2e4a86b3b72bd ] In function si_parse_power_table(), array adev->pm.dpm.ps and its member is allocated. If the allocation of each member fails, the array itself is freed and returned with an error code. However, the array is later fr

[PATCH AUTOSEL 5.18 059/159] drm/amdgpu/sdma: Fix incorrect calculations of the wptr of the doorbells

2022-05-30 Thread Sasha Levin
From: Haohui Mai [ Upstream commit 7dba6e838e741caadcf27ef717b6dcb561e77f89 ] This patch fixes the issue where the driver miscomputes the 64-bit values of the wptr of the SDMA doorbell when initializing the hardware. SDMA engines v4 and later on have full 64-bit registers for wptr thus they shou

[PATCH AUTOSEL 5.18 066/159] drm/amdkfd: Fix circular lock dependency warning

2022-05-30 Thread Sasha Levin
From: Mukul Joshi [ Upstream commit b179fc28d521379ba7e0a38eec1a4c722e7ea634 ] [ 168.544078] == [ 168.550309] WARNING: possible circular locking dependency detected [ 168.556523] 5.16.0-kfd-fkuehlin #148 Tainted: GE [ 168.562558

[PATCH AUTOSEL 5.18 067/159] drm/amd/pm: fix the compile warning

2022-05-30 Thread Sasha Levin
From: Evan Quan [ Upstream commit 555238d92ac32dbad2d77ad2bafc48d17391990c ] Fix the compile warning below: drivers/gpu/drm/amd/amdgpu/../pm/legacy-dpm/kv_dpm.c:1641 kv_get_acp_boot_level() warn: always true condition '(table->entries[i]->clk >= 0) => (0-u32max >= 0)' Reported-by: kernel test

[PATCH AUTOSEL 5.18 083/159] drm/amdgpu/ucode: Remove firmware load type check in amdgpu_ucode_free_bo

2022-05-30 Thread Sasha Levin
From: Alice Wong [ Upstream commit ab0cd4a9ae5b4679b714d8dbfedc0901fecdce9f ] When psp_hw_init failed, it will set the load_type to AMDGPU_FW_LOAD_DIRECT. During amdgpu_device_ip_fini, amdgpu_ucode_free_bo checks that load_type is AMDGPU_FW_LOAD_DIRECT and skips deallocating fw_buf causing memor

[PATCH AUTOSEL 5.18 082/159] drm/amdgpu/psp: move PSP memory alloc from hw_init to sw_init

2022-05-30 Thread Sasha Levin
From: Alex Deucher [ Upstream commit b95b5391684b39695887afb4a13cccee7820f5d6 ] Memory allocations should be done in sw_init. hw_init should just be hardware programming needed to initialize the IP block. This is how most other IP blocks work. Move the GPU memory allocations from psp hw_init t

[PATCH AUTOSEL 5.17 019/135] drm/amd/display: Disabling Z10 on DCN31

2022-05-30 Thread Sasha Levin
From: Saaem Rizvi [ Upstream commit 5d5af34072c8b11f60960c3bea57ff9de5877791 ] [WHY] Z10 is should not be enabled by default on DCN31. [HOW] Using DC debug flags to disable Z10 by default on DCN31. Reviewed-by: Eric Yang Acked-by: Pavle Kotarac Signed-off-by: Saaem Rizvi Signed-off-by: Alex

[PATCH AUTOSEL 5.17 035/135] drm/amd/pm: fix double free in si_parse_power_table()

2022-05-30 Thread Sasha Levin
From: Keita Suzuki [ Upstream commit f3fa2becf2fc25b6ac7cf8d8b1a2e4a86b3b72bd ] In function si_parse_power_table(), array adev->pm.dpm.ps and its member is allocated. If the allocation of each member fails, the array itself is freed and returned with an error code. However, the array is later fr

[PATCH AUTOSEL 5.17 049/135] drm/amdgpu/sdma: Fix incorrect calculations of the wptr of the doorbells

2022-05-30 Thread Sasha Levin
From: Haohui Mai [ Upstream commit 7dba6e838e741caadcf27ef717b6dcb561e77f89 ] This patch fixes the issue where the driver miscomputes the 64-bit values of the wptr of the SDMA doorbell when initializing the hardware. SDMA engines v4 and later on have full 64-bit registers for wptr thus they shou

[PATCH AUTOSEL 5.17 108/135] drm/amd/pm: update smartshift powerboost calc for smu12

2022-05-30 Thread Sasha Levin
From: Sathishkumar S [ Upstream commit 138292f1dc00e7e0724f44769f9da39cf2f3bf0b ] smartshift apu and dgpu power boost are reported as percentage with respect to their power limits. This value[0-100] reflects the boost for the respective device. Signed-off-by: Sathishkumar S Reviewed-by: Lijo L

[PATCH AUTOSEL 5.17 109/135] drm/amd/pm: update smartshift powerboost calc for smu13

2022-05-30 Thread Sasha Levin
From: Sathishkumar S [ Upstream commit cdf4c8ec39872a61a58d62f19b4db80f0f7bc586 ] smartshift apu and dgpu power boost are reported as percentage with respect to their power limits. adjust the units of power before calculating the percentage of boost. Signed-off-by: Sathishkumar S Reviewed-by:

[PATCH AUTOSEL 5.18 131/159] drm/amdgpu: Move mutex_init(&smu->message_lock) to smu_early_init()

2022-05-30 Thread Sasha Levin
From: Hans de Goede [ Upstream commit 4b9caaa0281972ca5ea4e1cdac2e12b9df1ae00b ] Lockdep complains about the smu->message_lock mutex being used before it is initialized through the following call path: amdgpu_device_init() amdgpu_dpm_mode2_reset() smu_mode2_reset() smu_v12_0_mode2_reset()

[PATCH AUTOSEL 5.18 129/159] drm/amd/pm: update smartshift powerboost calc for smu12

2022-05-30 Thread Sasha Levin
From: Sathishkumar S [ Upstream commit 138292f1dc00e7e0724f44769f9da39cf2f3bf0b ] smartshift apu and dgpu power boost are reported as percentage with respect to their power limits. This value[0-100] reflects the boost for the respective device. Signed-off-by: Sathishkumar S Reviewed-by: Lijo L

[PATCH AUTOSEL 5.15 047/109] drm/amd/pm: fix the compile warning

2022-05-30 Thread Sasha Levin
From: Evan Quan [ Upstream commit 555238d92ac32dbad2d77ad2bafc48d17391990c ] Fix the compile warning below: drivers/gpu/drm/amd/amdgpu/../pm/legacy-dpm/kv_dpm.c:1641 kv_get_acp_boot_level() warn: always true condition '(table->entries[i]->clk >= 0) => (0-u32max >= 0)' Reported-by: kernel test

[PATCH AUTOSEL 5.15 057/109] drm/amdgpu/psp: move PSP memory alloc from hw_init to sw_init

2022-05-30 Thread Sasha Levin
From: Alex Deucher [ Upstream commit b95b5391684b39695887afb4a13cccee7820f5d6 ] Memory allocations should be done in sw_init. hw_init should just be hardware programming needed to initialize the IP block. This is how most other IP blocks work. Move the GPU memory allocations from psp hw_init t

[PATCH AUTOSEL 5.15 058/109] drm/amdgpu/ucode: Remove firmware load type check in amdgpu_ucode_free_bo

2022-05-30 Thread Sasha Levin
From: Alice Wong [ Upstream commit ab0cd4a9ae5b4679b714d8dbfedc0901fecdce9f ] When psp_hw_init failed, it will set the load_type to AMDGPU_FW_LOAD_DIRECT. During amdgpu_device_ip_fini, amdgpu_ucode_free_bo checks that load_type is AMDGPU_FW_LOAD_DIRECT and skips deallocating fw_buf causing memor

[PATCH AUTOSEL 5.15 088/109] drm/amd/pm: update smartshift powerboost calc for smu12

2022-05-30 Thread Sasha Levin
From: Sathishkumar S [ Upstream commit 138292f1dc00e7e0724f44769f9da39cf2f3bf0b ] smartshift apu and dgpu power boost are reported as percentage with respect to their power limits. This value[0-100] reflects the boost for the respective device. Signed-off-by: Sathishkumar S Reviewed-by: Lijo L

[PATCH AUTOSEL 5.15 089/109] drm/amd/pm: update smartshift powerboost calc for smu13

2022-05-30 Thread Sasha Levin
From: Sathishkumar S [ Upstream commit cdf4c8ec39872a61a58d62f19b4db80f0f7bc586 ] smartshift apu and dgpu power boost are reported as percentage with respect to their power limits. adjust the units of power before calculating the percentage of boost. Signed-off-by: Sathishkumar S Reviewed-by:

[PATCH AUTOSEL 5.10 19/76] drm/amd/pm: fix double free in si_parse_power_table()

2022-05-30 Thread Sasha Levin
From: Keita Suzuki [ Upstream commit f3fa2becf2fc25b6ac7cf8d8b1a2e4a86b3b72bd ] In function si_parse_power_table(), array adev->pm.dpm.ps and its member is allocated. If the allocation of each member fails, the array itself is freed and returned with an error code. However, the array is later fr

[PATCH AUTOSEL 5.10 34/76] drm/amd/pm: fix the compile warning

2022-05-30 Thread Sasha Levin
From: Evan Quan [ Upstream commit 555238d92ac32dbad2d77ad2bafc48d17391990c ] Fix the compile warning below: drivers/gpu/drm/amd/amdgpu/../pm/legacy-dpm/kv_dpm.c:1641 kv_get_acp_boot_level() warn: always true condition '(table->entries[i]->clk >= 0) => (0-u32max >= 0)' Reported-by: kernel test

[PATCH AUTOSEL 5.4 13/55] drm/amd/pm: fix double free in si_parse_power_table()

2022-05-30 Thread Sasha Levin
From: Keita Suzuki [ Upstream commit f3fa2becf2fc25b6ac7cf8d8b1a2e4a86b3b72bd ] In function si_parse_power_table(), array adev->pm.dpm.ps and its member is allocated. If the allocation of each member fails, the array itself is freed and returned with an error code. However, the array is later fr

[PATCH AUTOSEL 5.4 24/55] drm/amd/pm: fix the compile warning

2022-05-30 Thread Sasha Levin
From: Evan Quan [ Upstream commit 555238d92ac32dbad2d77ad2bafc48d17391990c ] Fix the compile warning below: drivers/gpu/drm/amd/amdgpu/../pm/legacy-dpm/kv_dpm.c:1641 kv_get_acp_boot_level() warn: always true condition '(table->entries[i]->clk >= 0) => (0-u32max >= 0)' Reported-by: kernel test

[PATCH AUTOSEL 5.4 31/55] drm/amdgpu/ucode: Remove firmware load type check in amdgpu_ucode_free_bo

2022-05-30 Thread Sasha Levin
From: Alice Wong [ Upstream commit ab0cd4a9ae5b4679b714d8dbfedc0901fecdce9f ] When psp_hw_init failed, it will set the load_type to AMDGPU_FW_LOAD_DIRECT. During amdgpu_device_ip_fini, amdgpu_ucode_free_bo checks that load_type is AMDGPU_FW_LOAD_DIRECT and skips deallocating fw_buf causing memor

[PATCH AUTOSEL 4.14 08/29] drm/amd/pm: fix double free in si_parse_power_table()

2022-05-30 Thread Sasha Levin
From: Keita Suzuki [ Upstream commit f3fa2becf2fc25b6ac7cf8d8b1a2e4a86b3b72bd ] In function si_parse_power_table(), array adev->pm.dpm.ps and its member is allocated. If the allocation of each member fails, the array itself is freed and returned with an error code. However, the array is later fr

[PATCH AUTOSEL 4.14 14/29] drm/amd/pm: fix the compile warning

2022-05-30 Thread Sasha Levin
From: Evan Quan [ Upstream commit 555238d92ac32dbad2d77ad2bafc48d17391990c ] Fix the compile warning below: drivers/gpu/drm/amd/amdgpu/../pm/legacy-dpm/kv_dpm.c:1641 kv_get_acp_boot_level() warn: always true condition '(table->entries[i]->clk >= 0) => (0-u32max >= 0)' Reported-by: kernel test

[PATCH AUTOSEL 4.9 08/24] drm/amd/pm: fix double free in si_parse_power_table()

2022-05-30 Thread Sasha Levin
From: Keita Suzuki [ Upstream commit f3fa2becf2fc25b6ac7cf8d8b1a2e4a86b3b72bd ] In function si_parse_power_table(), array adev->pm.dpm.ps and its member is allocated. If the allocation of each member fails, the array itself is freed and returned with an error code. However, the array is later fr

[PATCH AUTOSEL 4.9 12/24] drm/amd/pm: fix the compile warning

2022-05-30 Thread Sasha Levin
From: Evan Quan [ Upstream commit 555238d92ac32dbad2d77ad2bafc48d17391990c ] Fix the compile warning below: drivers/gpu/drm/amd/amdgpu/../pm/legacy-dpm/kv_dpm.c:1641 kv_get_acp_boot_level() warn: always true condition '(table->entries[i]->clk >= 0) => (0-u32max >= 0)' Reported-by: kernel test

Re: [PATCH v6 14/22] dma-buf: Introduce new locking convention

2022-05-30 Thread Christian König
Hi Dmitry, Am 30.05.22 um 15:26 schrieb Dmitry Osipenko: Hello Christian, On 5/30/22 09:50, Christian König wrote: Hi Dmitry, First of all please separate out this patch from the rest of the series, since this is a complex separate structural change. I assume all the patches will go via the

[PATCH AUTOSEL 4.19 19/38] drm/amd/pm: fix the compile warning

2022-05-30 Thread Sasha Levin
From: Evan Quan [ Upstream commit 555238d92ac32dbad2d77ad2bafc48d17391990c ] Fix the compile warning below: drivers/gpu/drm/amd/amdgpu/../pm/legacy-dpm/kv_dpm.c:1641 kv_get_acp_boot_level() warn: always true condition '(table->entries[i]->clk >= 0) => (0-u32max >= 0)' Reported-by: kernel test

[PATCH AUTOSEL 4.19 10/38] drm/amd/pm: fix double free in si_parse_power_table()

2022-05-30 Thread Sasha Levin
From: Keita Suzuki [ Upstream commit f3fa2becf2fc25b6ac7cf8d8b1a2e4a86b3b72bd ] In function si_parse_power_table(), array adev->pm.dpm.ps and its member is allocated. If the allocation of each member fails, the array itself is freed and returned with an error code. However, the array is later fr

[PATCH 1/2] drm/amdkfd: Use mmget_not_zero in MMU notifier

2022-05-30 Thread Philip Yang
MMU notifier callback may pass in mm with mm->mm_users==0 when process is exiting, use mmget_no_zero to avoid accessing invalid mm in deferred list work after mm is gone. Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dr

[PATCH 2/2] drm/amdgpu: schedule fault recover work to another CPU

2022-05-30 Thread Philip Yang
Flooding GPU vm fault interrupt may hold CPU and delay the scheduled recover work to handle vm fault, schedule recover work to another CPU of same NUMA node. Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 13 +++-- drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 13

Re: [PATCH v3 4/7] drm/amdgpu: Add work_struct for GPU reset from debugfs

2022-05-30 Thread Andrey Grodzovsky
+ Monk On 2022-05-30 03:52, Christian König wrote: Am 25.05.22 um 21:04 schrieb Andrey Grodzovsky: We need to have a work_struct to cancel this reset if another already in progress. Signed-off-by: Andrey Grodzovsky ---   drivers/gpu/drm/amd/amdgpu/amdgpu.h   |  2 ++   drivers/gpu/drm/am

Re: [PATCH 1/2] drm/amdkfd: Use mmget_not_zero in MMU notifier

2022-05-30 Thread Felix Kuehling
Am 2022-05-30 um 10:57 schrieb Philip Yang: MMU notifier callback may pass in mm with mm->mm_users==0 when process is exiting, use mmget_no_zero to avoid accessing invalid mm in deferred list work after mm is gone. Signed-off-by: Philip Yang Reviewed-by: Felix Kuehling --- drivers/gpu/d

[PATCH] drm/amdgpu: enable tmz by default for skyrim

2022-05-30 Thread Sunil Khatri
Enable tmz feature by default for skyrim i.e IP GC 10.3.7 Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c index 798c5

Re: [PATCH] drm/amdgpu: enable tmz by default for skyrim

2022-05-30 Thread Ernst Sjöstrand
Skyrim is maybe not the best code name ever for a GPU, perhaps not include it upstream if it's not official? Regards //Ernst Den mån 30 maj 2022 kl 20:03 skrev Sunil Khatri : > Enable tmz feature by default for skyrim > i.e IP GC 10.3.7 > > Signed-off-by: Sunil Khatri > --- > drivers/gpu/drm/a

[PATCH] drm/amdgpu: enable tmz by default for GC 10.3.7

2022-05-30 Thread Sunil Khatri
Add IP GC 10.3.7 in the list of target to have tmz enabled by default. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.

RE: [PATCH] drm/amdgpu: enable tmz by default for skyrim

2022-05-30 Thread Khatri, Sunil
[AMD Official Use Only - General] @Ernst Sjöstrand Make sense. Thanks for Review. Pushed another patch without any such names. Regards Sunil khatri From: Ernst Sjöstrand Sent: Tuesday, May 31, 2022 1:47 AM To: Khatri, Sunil Cc: Deucher, Alexander ; amd-gfx mailing list

Re: [PATCH v3 3/7] drm/admgpu: Serialize RAS recovery work directly into reset domain queue.

2022-05-30 Thread Luben Tuikov
On 2022-05-30 03:49, Christian König wrote: > Am 25.05.22 um 21:04 schrieb Andrey Grodzovsky: >> Save the extra usless work schedule. >> >> Signed-off-by: Andrey Grodzovsky > > Acked-by: Christian König > > Maybe Luben want to take a look as well, he has done some RAS review in > the past. Lo