[PATCH 0/3] drm: Allow simpledrm to setup its emulated FB as firmware provided

2022-05-02 Thread Javier Martinez Canillas
Hello, This series contain patches suggested by Thomas Zimmermannas a feedback for "[RFC PATCH v4 00/11] Fix some race between sysfb device registration and drivers probe" [0]. Since other changes in [0] were more controversial, I decided to just split this part in a new patch-set and revisit the

[PATCH 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter

2022-05-02 Thread Javier Martinez Canillas
By default the bits per pixel for the emulated framebuffer device is set to dev->mode_config.preferred_depth, but some devices need another value. Since this second parameter is only used by a few drivers, and to allow drivers to use it for passing other configurations when registering the fbdev,

Re: [PATCH 0/3] drm: Allow simpledrm to setup its emulated FB as firmware provided

2022-05-02 Thread Thomas Zimmermann
Hi Javier Am 02.05.22 um 10:48 schrieb Javier Martinez Canillas: Hello, This series contain patches suggested by Thomas Zimmermannas a feedback for "[RFC PATCH v4 00/11] Fix some race between sysfb device registration and drivers probe" [0]. Since other changes in [0] were more controversial,

Re: [PATCH 0/3] drm: Allow simpledrm to setup its emulated FB as firmware provided

2022-05-02 Thread Javier Martinez Canillas
Hello Thomas, On 5/2/22 12:35, Thomas Zimmermann wrote: > Hi Javier > > Am 02.05.22 um 10:48 schrieb Javier Martinez Canillas: >> Hello, >> >> This series contain patches suggested by Thomas Zimmermannas a feedback for Ups, I missed a space here. I meant to write "Zimmermann as a feedback..." >

Re: [PATCH 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter

2022-05-02 Thread Laurent Pinchart
Hi Javier, Thank you for the patch. On Mon, May 02, 2022 at 10:48:29AM +0200, Javier Martinez Canillas wrote: > By default the bits per pixel for the emulated framebuffer device is set > to dev->mode_config.preferred_depth, but some devices need another value. > > Since this second parameter is

RE: [Intel-gfx] [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-05-02 Thread Jani Nikula
On Fri, 29 Apr 2022, "Murthy, Arun R" wrote: >> +static int output_bpc_show(struct seq_file *m, void *data) { > > Can we have a meaningful name instead of 'm' ? > Upon changing this parameter name, you can have my > Reviewed-By: Arun R Murthy Please keep 'm'. It's by far the most common name for

[RFC PATCH] drm/amdgpu: fix EFAULT return value for debugfs ctrl parse data

2022-05-02 Thread Niels Dossche
amdgpu_ras_debugfs_ctrl_parse_data is reachable from a debug fs write. A write is supposed to return EFAULT when the user buffer is outside the address space. Right now it returns EINVAL. Change the EINVAL to EFAULT. Fixes: 96ebb3073275 ("drm/amdgpu: add human readable debugfs control support (v2

Re: [PATCH 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter

2022-05-02 Thread Javier Martinez Canillas
Hello Laurent, On 5/2/22 13:34, Laurent Pinchart wrote: > Hi Javier, > > Thank you for the patch. > Thanks a lot for your feedback. [snip] >> +++ b/drivers/gpu/drm/drm_fb_helper.c >> @@ -2501,8 +2501,16 @@ static const struct drm_client_funcs >> drm_fbdev_client_funcs = { >> /** >> * drm_

Re: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-02 Thread Modem, Bhanuprakash
On Fri-29-04-2022 08:02 pm, Murthy, Arun R wrote: -Original Message- From: Intel-gfx On Behalf Of Bhanuprakash Modem Sent: Monday, April 11, 2022 3:21 PM To: intel-...@lists.freedesktop.org; dri-de...@lists.freedesktop.org; amd- g...@lists.freedesktop.org; jani.nik...@linux.intel.com;

Re: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-02 Thread Harry Wentland
On 2022-05-02 09:28, Modem, Bhanuprakash wrote: > On Fri-29-04-2022 08:02 pm, Murthy, Arun R wrote: >> >> >>> -Original Message- >>> From: Intel-gfx On Behalf Of >>> Bhanuprakash Modem >>> Sent: Monday, April 11, 2022 3:21 PM >>> To: intel-...@lists.freedesktop.org; dri-de...@lists.free

Re: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-02 Thread Modem, Bhanuprakash
On Mon-02-05-2022 07:08 pm, Harry Wentland wrote: On 2022-05-02 09:28, Modem, Bhanuprakash wrote: On Fri-29-04-2022 08:02 pm, Murthy, Arun R wrote: -Original Message- From: Intel-gfx On Behalf Of Bhanuprakash Modem Sent: Monday, April 11, 2022 3:21 PM To: intel-...@lists.freedeskt

Re: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-02 Thread Harry Wentland
On 2022-05-02 10:27, Modem, Bhanuprakash wrote: > On Mon-02-05-2022 07:08 pm, Harry Wentland wrote: >> >> >> On 2022-05-02 09:28, Modem, Bhanuprakash wrote: >>> On Fri-29-04-2022 08:02 pm, Murthy, Arun R wrote: > -Original Message- > From: Intel-gfx On Behalf Of >

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-05-02 Thread Gong, Richard
Hi Paul, On 5/1/2022 2:08 AM, Paul Menzel wrote: Dear Richard, Sorry for the late reply. Am 26.04.22 um 15:53 schrieb Gong, Richard: On 4/21/2022 12:35 AM, Paul Menzel wrote: Am 21.04.22 um 03:12 schrieb Gong, Richard: On 4/20/2022 3:29 PM, Paul Menzel wrote: Am 19.04.22 um 23:46 sc

Re: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-05-02 Thread Mike Lothian
On Wed, 27 Apr 2022 at 12:55, Mike Lothian wrote: > > On Tue, 26 Apr 2022 at 17:36, Christian König > wrote: > > > > Hi Mike, > > > > sounds like somehow stitching together the SG table for PRIME doesn't > > work any more with this patch. > > > > Can you try with P2P DMA disabled? > > -CONFIG_PC

Re: [PATCHv5] drm/amdgpu: vi: disable ASPM on Intel Alder Lake based systems

2022-05-02 Thread Gong, Richard
Hi Paul, On 5/1/2022 2:14 AM, Paul Menzel wrote: Dear Richard, Am 29.04.22 um 18:06 schrieb Richard Gong: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD Volcanic Islands (VI) GFX cards, such as the WX3200 and RX640, that do not work with ASPM-en

[PATCH v2 0/3] drm: Allow simpledrm to setup its emulated FB as firmware provided

2022-05-02 Thread Javier Martinez Canillas
Hello, This series contain patches suggested by Thomas Zimmermann as a feedback for "[RFC PATCH v4 00/11] Fix some race between sysfb device registration and drivers probe" [0]. Since other changes in [0] were more controversial, I decided to just split this part in a new patch-set and revisit th

[PATCH v2 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter

2022-05-02 Thread Javier Martinez Canillas
By default the bits per pixel for the emulated framebuffer device is set to dev->mode_config.preferred_depth, but some devices need another value. Since this second parameter is only used by a few drivers, and to allow drivers to use it for passing other configurations when registering the fbdev,

Re: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-05-02 Thread Arunpravin Paneer Selvam
On 5/2/2022 8:41 PM, Mike Lothian wrote: On Wed, 27 Apr 2022 at 12:55, Mike Lothian wrote: On Tue, 26 Apr 2022 at 17:36, Christian König wrote: Hi Mike, sounds like somehow stitching together the SG table for PRIME doesn't work any more with this patch. Can you try with P2P DMA disabled?

Re: [PATCH v2 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter

2022-05-02 Thread Laurent Pinchart
Hi Javier, Thank you for the patch. On Mon, May 02, 2022 at 05:38:59PM +0200, Javier Martinez Canillas wrote: > By default the bits per pixel for the emulated framebuffer device is set > to dev->mode_config.preferred_depth, but some devices need another value. > > Since this second parameter is

RE: [PATCH 0/8] DC Patches April 27, 2022

2022-05-02 Thread Wheeler, Daniel
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Leno

Re: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-05-02 Thread Mike Lothian
On Mon, 2 May 2022 at 16:54, Arunpravin Paneer Selvam wrote: > > > > On 5/2/2022 8:41 PM, Mike Lothian wrote: > > On Wed, 27 Apr 2022 at 12:55, Mike Lothian wrote: > >> On Tue, 26 Apr 2022 at 17:36, Christian König > >> wrote: > >>> Hi Mike, > >>> > >>> sounds like somehow stitching together th

Re: [PATCH v2 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter

2022-05-02 Thread Javier Martinez Canillas
On 5/2/22 18:07, Laurent Pinchart wrote: > Hi Javier, > > Thank you for the patch. > > On Mon, May 02, 2022 at 05:38:59PM +0200, Javier Martinez Canillas wrote: >> By default the bits per pixel for the emulated framebuffer device is set >> to dev->mode_config.preferred_depth, but some devices nee

[RESEND PATCH v2 1/2] drm/edid: parse DRM VESA dsc bpp target

2022-05-02 Thread Yaroslav Bolyukin
As per DisplayID v2.0 Errata E9 spec "DSC pass-through timing support" VESA vendor-specific data block may contain target DSC bits per pixel fields Signed-off-by: Yaroslav Bolyukin --- drivers/gpu/drm/drm_edid.c | 33 ++--- include/drm/drm_connector.h | 6 ++ in

[RESEND PATCH v2 2/2] drm/amd: use fixed dsc bits-per-pixel from edid

2022-05-02 Thread Yaroslav Bolyukin
VESA vendor header from DisplayID spec may contain fixed bit per pixel rate, it should be respected by drm driver Signed-off-by: Yaroslav Bolyukin Reviewed-by: Wayne Lin --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 ++ drivers/gpu/drm/amd/display/dc/core/dc_stream.c

Re: [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-05-02 Thread Harry Wentland
On 2022-04-11 05:51, Bhanuprakash Modem wrote: > It's useful to know the connector's max supported bpc for IGT > testing. Expose it via a debugfs file on the connector "output_bpc". > > Example: cat /sys/kernel/debug/dri/0/DP-1/output_bpc > > V2: > * Fix typo in comments (Harry) > > Cc: Jani Nik

Re: [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-02 Thread Harry Wentland
On 2022-04-11 05:51, Bhanuprakash Modem wrote: > As drm_connector already have the display_info, instead of creating > "output_bpc" debugfs in vendor specific driver, move the logic to > the drm layer. > > This patch will also move "Current" bpc to the crtc debugfs from > connector debugfs, sin

Re: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-02 Thread Harry Wentland
On 2022-05-02 10:29, Harry Wentland wrote: > > > On 2022-05-02 10:27, Modem, Bhanuprakash wrote: >> On Mon-02-05-2022 07:08 pm, Harry Wentland wrote: >>> >>> >>> On 2022-05-02 09:28, Modem, Bhanuprakash wrote: On Fri-29-04-2022 08:02 pm, Murthy, Arun R wrote: > > >> -Origi

[PATCH 3/3] drm/amdgpu/discovery: add SDMA v6_0 ip block

2022-05-02 Thread Alex Deucher
From: Likun Gao Add SDMA v6 ip block for asics which support it. Signed-off-by: Stanley Yang Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_disc

[PATCH 2/3] drm/amdgpu: add initial support for sdma v6.0

2022-05-02 Thread Alex Deucher
From: Stanley Yang Add functions for SDMA version 6. Signed-off-by: Stanley Yang Signed-off-by: Likun Gao Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/Makefile|3 +- drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 1687 driv

[PATCH 03/11] drm/amdgpu: move out asic specific definition from common header

2022-05-02 Thread Alex Deucher
From: James Zhu Move out asic specific definition from common header. Acked-by: Alex Deucher Reviewed-by: Leo Liu Reviewed-by: Sonny Jiang Signed-off-by: James Zhu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 2 -- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 3 ++

[PATCH 02/11] drm/amdgpu: make software ring functions reuseable for newer VCN

2022-05-02 Thread Alex Deucher
From: Leo Liu Software ring will be supported only from VCN4 Signed-off-by: Leo Liu Reviewed-by: James Zhu Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 23 +++ drivers/gpu/drm/amd/amdgpu/vcn_v3_0.h | 12 2

[PATCH 06/11] drm/amdgpu/jpeg: add jpeg support for VCN4_0_0

2022-05-02 Thread Alex Deucher
From: James Zhu Add jpeg support for VCN4_0_0. Reviewed-by: Leo Liu Reviewed-by: Sonny Jiang Acked-by: Alex Deucher Signed-off-by: James Zhu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/Makefile| 3 +- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c | 609 +++

[PATCH 00/11] VCN 4.x support

2022-05-02 Thread Alex Deucher
This adds support for VCN (Video Codec Next) media blocks v 4.x. The first patch is very large as it adds register headers and as such is too large for the mailing list. James Zhu (7): drm/amdgpu: move out asic specific definition from common header drm/amdgpu: add irq sources for vcn v4_0 d

[PATCH 07/11] drm/amdgpu: enable VCN4 PG and CG for VCN4_0_0

2022-05-02 Thread Alex Deucher
From: Sonny Jiang Most of the tiles can be power/clock gated. Reviewed-by: Sonny Jiang Signed-off-by: Leo Liu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc21.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c b/dri

[PATCH 05/11] drm/amdgpu: add VCN4 ip block support

2022-05-02 Thread Alex Deucher
From: Leo Liu Add VCN 4.0 initialization and decoder/encoder ring functions. Signed-off-by: Leo Liu Reviewed-by: James Zhu Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/Makefile |1 + drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 19 +- drivers/g

[PATCH 11/11] drm/amdgpu/discovery: add VCN 4.0 Support

2022-05-02 Thread Alex Deucher
From: James Zhu Enable VCN 4.0 on asics where it is present. Signed-off-by: James Zhu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/am

[PATCH 08/11] drm/amdgpu/jpeg: enable JPEG PG and CG for VCN4_0_0

2022-05-02 Thread Alex Deucher
From: James Zhu Enable JPEG PG and CG for VCN4_0_0. Reviewed-by: Leo Liu Reviewed-by: Sonny Jiang Acked-by: Alex Deucher Signed-off-by: James Zhu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc21.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH 09/11] drm/amdgpu/vcn: enable vcn4 dpg mode

2022-05-02 Thread Alex Deucher
From: James Zhu Enable vcn4 dpg mode. Signed-off-by: James Zhu Reviewed-by: Leo Liu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc21.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c b/drivers/gpu/drm/amd/amdgpu/soc21.c index 66309992f9

[PATCH 10/11] drm/amdgpu: add vcn_4_0_0 video codec query

2022-05-02 Thread Alex Deucher
From: James Zhu Add vcn_4_0_0 video codec query. Signed-off-by: James Zhu Reviewed-by: Leo Liu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc21.c | 44 ++ 1 file changed, 44 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c b/drivers/

[PATCH 04/11] drm/amdgpu: add irq sources for vcn v4_0

2022-05-02 Thread Alex Deucher
From: James Zhu Add the interrupt source packet definitions for VCN4. Signed-off-by: James Zhu Reviewed-by: Leo Liu Signed-off-by: Alex Deucher --- .../amd/include/ivsrcid/vcn/irqsrcs_vcn_4_0.h | 41 +++ 1 file changed, 41 insertions(+) create mode 100644 drivers/gpu/drm/amd

Re: [PATCH 02/11] drm/amdgpu: make software ring functions reuseable for newer VCN

2022-05-02 Thread Christian König
Maybe we should make nails with heads and move that into an amdgpu_vnc_sw_ring.c file since it is completely IP version independend now. Regards, Christian. Am 02.05.22 um 21:07 schrieb Alex Deucher: From: Leo Liu Software ring will be supported only from VCN4 Signed-off-by: Leo Liu Review

Do we really need to increase/decrease MST VC payloads?

2022-05-02 Thread Lyude Paul
Hi! So I kinda hate to ask this, but finding this in amdgpu completely took me by surprise and unfortunately is (while technically correct) an enormous pain and not really necessary as far as I'm aware. So: it seems that amdgpu is currently the only driver that not only allocates/deallocates paylo

RE: [PATCHv5] drm/amdgpu: vi: disable ASPM on Intel Alder Lake based systems

2022-05-02 Thread Limonciello, Mario
[Public] > -Original Message- > From: Alex Deucher > Sent: Friday, April 29, 2022 11:14 > To: Gong, Richard > Cc: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; Dave > Airlie ; Daniel Vetter ; amd-gfx list g...@lists.freedesktop.org>; kernel test robot ; LKML ker...@vger.ke

[PATCH] drm/amdgpu: fix drm-next merge fallout

2022-05-02 Thread Christian König
That hunk somehow got missing while solving the conflict between the TTM and AMDGPU changes for drm-next. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.