[PATCH] tests/drm_buddy: Add drm buddy test cases

2022-04-11 Thread Arunpravin Paneer Selvam
Add a set of drm buddy test cases to validate the drm/drm_buddy.c memory allocator. Signed-off-by: Arunpravin Paneer Selvam --- tests/drm_buddy.c | 14 ++ tests/meson.build | 1 + 2 files changed, 15 insertions(+) create mode 100644 tests/drm_buddy.c diff --git a/tests/drm_buddy.c

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-11 Thread Paul Menzel
Dear Richard, Thank you for your response, but please reply to your own reply next time. Am 11.04.22 um 02:37 schrieb Gong, Richard: On 4/8/2022 7:19 PM, Paul Menzel wrote: Thank you for your patch. Am 08.04.22 um 21:05 schrieb Richard Gong: Active State Power Management (ASPM) feature is

[PATCH v3] drm: add a check to verify the size alignment

2022-04-11 Thread Arunpravin Paneer Selvam
Add a simple check to reject any size not aligned to the min_page_size. when size is not aligned to min_page_size, driver module should handle in their own way either to round_up() the size value to min_page_size or just to enable WARN_ON(). If we dont handle the alignment properly, we may hit th

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-11 Thread Paul Menzel
[Cc: +] Dear Richard, Am 11.04.22 um 02:27 schrieb Gong, Richard: On 4/8/2022 7:19 PM, Paul Menzel wrote: Am 08.04.22 um 21:05 schrieb Richard Gong: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD GFX cards (such as WX3200 and RX640) that cann

[PATCH] drm/amd/pm: fix the deadlock issue observed on SI

2022-04-11 Thread Evan Quan
By placing those unrelated code outside of adev->pm.mutex protections or restructuring the call flow, we can eliminate the deadlock issue. This comes with no real logics change. Fixes: 3712e7a49459 ("drm/amd/pm: unified lock protections in amdgpu_dpm.c") Signed-off-by: Evan Quan Change-Id: I75de

Re: AMDGPU: regression on 5.17.1

2022-04-11 Thread Michele Ballabio
On Tue, 5 Apr 2022 10:23:16 -0400 Alex Deucher wrote: > On Mon, Apr 4, 2022 at 3:39 PM Michele Ballabio > wrote: > > > > On Mon, 4 Apr 2022 13:03:41 -0400 > > Alex Deucher wrote: > > > > > On Sun, Apr 3, 2022 at 10:19 AM Michele Ballabio > > > wrote: > > > > > > > > Hi, > > > > I've hi

Re: AMDGPU: regression on 5.17.1 #forregzbot

2022-04-11 Thread Thorsten Leemhuis
TWIMC: this mail is primarily send for documentation purposes and for regzbot, my Linux kernel regression tracking bot. These mails usually contain '#forregzbot' in the subject, to make them easy to spot and filter. On 09.04.22 18:28, Michele Ballabio wrote: > On Tue, 5 Apr 2022 10:23:16 -0400 > A

Re: [PATCH] drm/amdgpu: Senseless code and unnecessary memset

2022-04-11 Thread Grigory Vasilyev
Christian König in fact the compiler will very often replace {0} with a memset call. I don't see a problem using {0} for local arrays with primitive types. There should also be no problem with memory alignment. Because the compiler understands it. Using sizeof is also not a good idea. More often ev

[PATCH] drm/radeon: remove r600_blit_shaders.[c|h]

2022-04-11 Thread Tom Rix
The only use of the global variables in r600_blit_shaders.c were in the old drivers/gpu/drm/radeon/r600_blit.c This file was removed in commit 8333f607a631 ("drm/radeon: remove UMS support") So remove the r600_blit_shaders.[c|h] files Signed-off-by: Tom Rix --- drivers/gpu/drm/radeon/Makefile

Re: [EXTERNAL] [PATCH 2/2] drm/amdkfd: Add PCIe Hotplug Support for AMDKFD

2022-04-11 Thread Shuotao Xu
> On Apr 8, 2022, at 11:28 PM, Andrey Grodzovsky > wrote: > > [Some people who received this message don't often get email from > andrey.grodzov...@amd.com. Learn why this is important at > http://aka.ms/LearnAboutSenderIdentification.] > > On 2022-04-08 04:45, Shuotao Xu wrote: >> Adding

Re: [PATCH] drm/amdgpu: Fix NULL pointer dereference

2022-04-11 Thread Grigory Vasilyev
Christian König, Simon Ser In fact, the code looks strange, we return the return code, but for some reason we also write false and 0. In my opinion, the caller should do this. Of course, you are right, but I look from the position that nothing should fall in the user system. There may be strange er

Re: [PATCH] drm/amd/pm: fix the deadlock issue observed on SI

2022-04-11 Thread Paul Menzel
Dear Evan, It would have been nice, if you put me in Cc as I also reported the regression. Am 11.04.22 um 09:47 schrieb Evan Quan: By placing those unrelated code outside of adev->pm.mutex protections or restructuring the call flow, we can eliminate the deadlock issue. This comes with no rea

[PATCH V2] drm/amd/pm: fix the deadlock issue observed on SI

2022-04-11 Thread Evan Quan
The adev->pm.mutx is already held at the beginning of amdgpu_dpm_compute_clocks/amdgpu_dpm_enable_uvd/amdgpu_dpm_enable_vce. But on their calling path, amdgpu_display_bandwidth_update will be called and thus its sub functions amdgpu_dpm_get_sclk/mclk. They will then try to acquire the same adev->pm

RE: [PATCH] drm/amd/pm: fix the deadlock issue observed on SI

2022-04-11 Thread Quan, Evan
[AMD Official Use Only] Please check the V2 version. Thanks, Evan > -Original Message- > From: Paul Menzel > Sent: Monday, April 11, 2022 3:59 PM > To: Quan, Evan > Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander > ; arthur.ma...@internode.on.net; > regressi...@lists.linux.dev > S

Re: [PATCH] drm/amd/pm: fix the deadlock issue observed on SI

2022-04-11 Thread Lazar, Lijo
On 4/11/2022 1:17 PM, Evan Quan wrote: By placing those unrelated code outside of adev->pm.mutex protections or restructuring the call flow, we can eliminate the deadlock issue. This comes with no real logics change. Fixes: 3712e7a49459 ("drm/amd/pm: unified lock protections in amdgpu_dpm.c")

RE: [PATCH] drm/amd/pm: fix the deadlock issue observed on SI

2022-04-11 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Monday, April 11, 2022 5:05 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; > arthur.ma...@internode.on.net > Subject: Re: [PATCH] drm/amd/pm: fix the deadlock issue observed on SI >

Re: [PATCH] tests/drm_buddy: Add drm buddy test cases

2022-04-11 Thread Matthew Auld
On 11/04/2022 08:28, Arunpravin Paneer Selvam wrote: Add a set of drm buddy test cases to validate the drm/drm_buddy.c memory allocator. Signed-off-by: Arunpravin Paneer Selvam --- tests/drm_buddy.c | 14 ++ tests/meson.build | 1 + 2 files changed, 15 insertions(+) create mo

Re: [PATCH] drm/amd/pm: fix the deadlock issue observed on SI

2022-04-11 Thread Lazar, Lijo
On 4/11/2022 2:55 PM, Quan, Evan wrote: [AMD Official Use Only] -Original Message- From: Lazar, Lijo Sent: Monday, April 11, 2022 5:05 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; arthur.ma...@internode.on.net Subject: Re: [PATCH] drm/amd/pm: fix the

Re: [PATCH v3] drm: add a check to verify the size alignment

2022-04-11 Thread Matthew Auld
On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote: Add a simple check to reject any size not aligned to the min_page_size. when size is not aligned to min_page_size, driver module should handle in their own way either to round_up() the size value to min_page_size or just to enable WARN_ON().

[V2 0/3] Expose max and current bpc via debugfs

2022-04-11 Thread Bhanuprakash Modem
This series will expose the Connector's max supported bpc via connector debugfs and Crtc's current bpc via crtc debugfs. Also move the existing vendor specific "output_bpc" logic to drm. Test-with: 20220411094147.1650859-2-bhanuprakash.mo...@intel.com Bhanuprakash Modem (3): drm/debug: Expose c

[V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-04-11 Thread Bhanuprakash Modem
It's useful to know the connector's max supported bpc for IGT testing. Expose it via a debugfs file on the connector "output_bpc". Example: cat /sys/kernel/debug/dri/0/DP-1/output_bpc V2: * Fix typo in comments (Harry) Cc: Jani Nikula Cc: Ville Syrjälä Cc: Harry Wentland Signed-off-by: Bhanup

[V2 2/3] drm/i915/display/debug: Expose crtc current bpc via debugfs

2022-04-11 Thread Bhanuprakash Modem
This new debugfs will expose the currently using bpc by crtc. It is very useful for verifying whether we enter the correct output color depth from IGT. This patch will also add the connector's max supported bpc to "i915_display_info" debugfs. Example: cat /sys/kernel/debug/dri/0/crtc-0/i915_curre

[V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-04-11 Thread Bhanuprakash Modem
As drm_connector already have the display_info, instead of creating "output_bpc" debugfs in vendor specific driver, move the logic to the drm layer. This patch will also move "Current" bpc to the crtc debugfs from connector debugfs, since we are getting this info from crtc_state. Cc: Harry Wentla

Re: [PATCH V2] drm/amd/pm: fix the deadlock issue observed on SI

2022-04-11 Thread Lazar, Lijo
On 4/11/2022 2:24 PM, Evan Quan wrote: The adev->pm.mutx is already held at the beginning of amdgpu_dpm_compute_clocks/amdgpu_dpm_enable_uvd/amdgpu_dpm_enable_vce. But on their calling path, amdgpu_display_bandwidth_update will be called and thus its sub functions amdgpu_dpm_get_sclk/mclk. The

[PATCH 1/3] drm/amdgpu: add poison consumption flag for RAS IH

2022-04-11 Thread Tao Zhou
So we can distinguish RAS poison consumption interrupt from UE interrupt. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h index 606df8

[PATCH 2/3] drm/amdgpu: implement RAS interrupt handler for non-poison type

2022-04-11 Thread Tao Zhou
Prepare for the implementation of poison interrupt handler. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 62 ++--- 1 file changed, 35 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/am

[PATCH 3/3] drm/amdgpu: add RAS poison consumption handler

2022-04-11 Thread Tao Zhou
Add support for common RAS posion consumption handler. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 39 - drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 1 + 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amd

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-11 Thread Gong, Richard
Hi Lijo, On 4/10/2022 11:15 PM, Lazar, Lijo wrote: On 4/9/2022 12:35 AM, Richard Gong wrote: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD GFX cards (such as WX3200 and RX640) that cannot be used with Intel AlderLake based systems to enable ASP

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-11 Thread Gong, Richard
Hi Paul, On 4/11/2022 2:41 AM, Paul Menzel wrote: [Cc: +] Dear Richard, Am 11.04.22 um 02:27 schrieb Gong, Richard: On 4/8/2022 7:19 PM, Paul Menzel wrote: Am 08.04.22 um 21:05 schrieb Richard Gong: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are so

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-11 Thread Paul Menzel
Dear Richard, Am 11.04.22 um 13:38 schrieb Gong, Richard: On 4/11/2022 2:41 AM, Paul Menzel wrote: [Cc: +] Am 11.04.22 um 02:27 schrieb Gong, Richard: On 4/8/2022 7:19 PM, Paul Menzel wrote: Am 08.04.22 um 21:05 schrieb Richard Gong: Active State Power Management (ASPM) feature is ena

Re: [PATCH v3] drm: add a check to verify the size alignment

2022-04-11 Thread Christian König
Am 11.04.22 um 11:47 schrieb Matthew Auld: On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote: Add a simple check to reject any size not aligned to the min_page_size. when size is not aligned to min_page_size, driver module should handle in their own way either to round_up() the size value t

[PATCH] drm/amdgpu: Release memory when psp sw_init is failed

2022-04-11 Thread Ma Jun
Release the memory (psp->cmd) when psp initialization is failed in psp_sw_init Signed-off-by: Ma Jun Change-Id: I2f88b5919142d55dd7d3820a7da94823286db235 --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/dr

Re: [PATCH] drm/amdgpu: Release memory when psp sw_init is failed

2022-04-11 Thread Paul Menzel
Dear Ma, Thank you for your patch. Am 11.04.22 um 14:42 schrieb Ma Jun: Release the memory (psp->cmd) when psp initialization is failed in psp_sw_init s/is failed/fails/ Period/full stop at the end of sentences, and it still fits into 75 characters per line. Next time you could also add

Re: [PATCH] drm/amdkfd: Asynchronously free events

2022-04-11 Thread philip yang
On 2022-04-07 22:39, Felix Kuehling wrote: The synchronize_rcu call in destroy_events can take several ms, which noticeably slows down applications destroying many events. Use kfree_rcu to free the event structure asynchronously and eliminate the synchronize_

Patch "drm/amdkfd: Create file descriptor after client is added to smi_clients list" has been added to the 5.15-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/amdkfd: Create file descriptor after client is added to smi_clients list to the 5.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename

Patch "drm/amdkfd: Create file descriptor after client is added to smi_clients list" has been added to the 5.10-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/amdkfd: Create file descriptor after client is added to smi_clients list to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename

Re: [PATCH] drm/amd/pm: fix the deadlock issue observed on SI

2022-04-11 Thread Thorsten Leemhuis
On 11.04.22 09:59, Paul Menzel wrote: > Am 11.04.22 um 09:47 schrieb Evan Quan: > > As it’s a regression, please follow the documentation, and add the > related tags. Yes please, otherwise you break tools that reply on this, like my regression tracking efforts. > Fixes: 3712e7a49459 ("drm/amd/pm:

Patch "drm/amdkfd: Create file descriptor after client is added to smi_clients list" has been added to the 5.17-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/amdkfd: Create file descriptor after client is added to smi_clients list to the 5.17-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename

Patch "drm/amdkfd: Create file descriptor after client is added to smi_clients list" has been added to the 5.16-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/amdkfd: Create file descriptor after client is added to smi_clients list to the 5.16-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename

Re: [PATCH] drm/amdgpu: Release memory when psp sw_init is failed

2022-04-11 Thread Wang, Yang(Kevin)
[AMD Official Use Only] From: amd-gfx on behalf of Ma Jun Sent: Monday, April 11, 2022 8:42 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Zhang, Hawking Subject: [PATCH] drm/amdgpu: Release memory when psp sw_init is faile

RE: DC Patches Apri 6, 2022

2022-04-11 Thread Wheeler, Daniel
[AMD Official Use Only] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to

Re: [PATCH v3] drm: add a check to verify the size alignment

2022-04-11 Thread Matthew Auld
On 11/04/2022 13:42, Christian König wrote: Am 11.04.22 um 11:47 schrieb Matthew Auld: On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote: Add a simple check to reject any size not aligned to the min_page_size. when size is not aligned to min_page_size, driver module should handle in their o

[PATCH v2] drm/amd/pm: Disable fan control if not supported

2022-04-11 Thread Elena Sakhnovitch
On Sienna Cichild, not all platforms use PMFW based fan control. On such ASICs fan control by PMFW will be disabled in PPTable. Disable hwmon knobs for fan control also as it is not possible to report or control fan speed on such platforms through driver. v2: FEATURE_FAN_CONTROL_MASK is replaced wi

Re: [PATCH v3] drm: add a check to verify the size alignment

2022-04-11 Thread Arunpravin Paneer Selvam
On 11/04/22 7:02 pm, Matthew Auld wrote: > On 11/04/2022 13:42, Christian König wrote: >> >> Am 11.04.22 um 11:47 schrieb Matthew Auld: >>> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote: Add a simple check to reject any size not aligned to the min_page_size. when size i

Re: [PATCH v3] drm: add a check to verify the size alignment

2022-04-11 Thread Christian König
Am 11.04.22 um 15:49 schrieb Arunpravin Paneer Selvam: On 11/04/22 7:02 pm, Matthew Auld wrote: On 11/04/2022 13:42, Christian König wrote: Am 11.04.22 um 11:47 schrieb Matthew Auld: On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote: Add a simple check to reject any size not aligned to

[PATCH] drm/amd/amdgpu: Not request init data for MS_HYPERV with vega10

2022-04-11 Thread Yongqiang Sun
MS_HYPERV with vega10 doesn't have the interface to process request init data msg. Check hypervisor type to not send the request for MS_HYPERV. Signed-off-by: Yongqiang Sun --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --gi

Re: [PATCH v2] drm/amd/pm: Disable fan control if not supported

2022-04-11 Thread Lazar, Lijo
On 4/11/2022 7:02 PM, Elena Sakhnovitch wrote: On Sienna Cichild, not all platforms use PMFW based fan control. On such ASICs fan control by PMFW will be disabled in PPTable. Disable hwmon knobs for fan control also as it is not possible to report or control fan speed on such platforms through

[PATCH] drm/amd/amdgpu: Not request init data for MS_HYPERV with vega10

2022-04-11 Thread Yongqiang Sun
MS_HYPERV with vega10 doesn't have the interface to process request init data msg. Check hypervisor type to not send the request for MS_HYPERV. Signed-off-by: Yongqiang Sun --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --gi

Re: [PATCH] drm/amdkfd: Asynchronously free events

2022-04-11 Thread Felix Kuehling
Am 2022-04-11 um 08:52 schrieb philip yang: On 2022-04-07 22:39, Felix Kuehling wrote: The synchronize_rcu call in destroy_events can take several ms, which noticeably slows down applications destroying many events. Use kfree_rcu to free the event structure asynchronously and eliminate the syn

回复: [PATCH 1/3] drm/amdgpu: add poison consumption flag for RAS IH

2022-04-11 Thread Yang, Stanley
[AMD Official Use Only] Hi Tao, According to the series patches, I have one question, is the ras_ih_flag set according to poison mode configuration, if yes, driver will handle poison once get ecc_irq interrupt, but at this moment there may no app to consumes it, this seems conflict the poison

[PATCH ] drm/amdgpu: fix discovery ip failed

2022-04-11 Thread Zhang, Jesse(Jie)
[AMD Official Use Only] Fix discovery ip failed, and the log: 56.129549] [drm:amdgpu_discovery_validate_ip [amdgpu]] *ERROR* Unexpected number_instance (64) from ip discovery blob [ 56.130129] [drm:amdgpu_discovery_validate_ip [amdgpu]] *ERROR* Unexpected hw_id (45056) from ip discovery blo

Re: [PATCH v2] drm/amd/pm: Disable fan control if not supported

2022-04-11 Thread Paul Menzel
Dear Elena, Am 11.04.22 um 15:32 schrieb Elena Sakhnovitch: On Sienna Cichild, not all platforms use PMFW based fan control. On such ASICs fan control by PMFW will be disabled in PPTable. Disable hwmon knobs for fan control also as it is not possible to report or control fan speed on such platf

Re: [PATCH ] drm/amdgpu: fix discovery ip failed

2022-04-11 Thread Paul Menzel
Dear Jie, Thank you for your patch. Am 11.04.22 um 17:15 schrieb Zhang, Jesse(Jie): You might want to add a space before the (. [AMD Official Use Only] Please send a patch with `git format-patch` or similar. Fix discovery ip failed, and the log: On what system? 56.129549] [drm:a

Re: [PATCH] drm/amd/amdgpu: Not request init data for MS_HYPERV with vega10

2022-04-11 Thread Alex Deucher
On Mon, Apr 11, 2022 at 9:52 AM Yongqiang Sun wrote: > > MS_HYPERV with vega10 doesn't have the interface to process > request init data msg. > Check hypervisor type to not send the request for MS_HYPERV. > > Signed-off-by: Yongqiang Sun > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 12

RE: [PATCH v2 ] drm/amdgpu: fix discovery ip failed

2022-04-11 Thread Zhang, Jesse(Jie)
[AMD Official Use Only] + Deucher, Alexander From: Zhang, Jesse(Jie) Sent: Monday, 11 April 2022 11:15 pm To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray ; Zhang, Yifan Subject: [PATCH ] drm/amdgpu: fix discovery ip failed [AMD Official Use Only] Fix discovery ip failed, and the log: 56.1

Re: [PATCH v2 ] drm/amdgpu: fix discovery ip failed

2022-04-11 Thread Alex Deucher
On Mon, Apr 11, 2022 at 11:25 AM Zhang, Jesse(Jie) wrote: > > [AMD Official Use Only] > > > > + Deucher, Alexander > > > > From: Zhang, Jesse(Jie) > Sent: Monday, 11 April 2022 11:15 pm > To: amd-gfx@lists.freedesktop.org > Cc: Huang, Ray ; Zhang, Yifan > Subject: [PATCH ] drm/amdgpu: fix discove

Re: [PATCH] drm/amd/amdgpu: Not request init data for MS_HYPERV with vega10

2022-04-11 Thread Paul Menzel
Dear Yongqiang, Thank you for your patch. Am 11.04.22 um 15:59 schrieb Yongqiang Sun: MS_HYPERV with vega10 doesn't have the interface to process request init data msg. Should some Hyper-V folks be added to the reviewers list too? Check hypervisor type to not send the request for MS_HYPERV

Re: [EXTERNAL] [PATCH 2/2] drm/amdkfd: Add PCIe Hotplug Support for AMDKFD

2022-04-11 Thread Andrey Grodzovsky
On 2022-04-08 21:28, Shuotao Xu wrote: On Apr 8, 2022, at 11:28 PM, Andrey Grodzovsky wrote: [Some people who received this message don't often get email from andrey.grodzov...@amd.com. Learn why this is important at http://aka.ms/LearnAboutSenderIdentification.] On 2022-04-08 04:45, Sh

Re: [PATCH] drm/amd/amdgpu: Not request init data for MS_HYPERV with vega10

2022-04-11 Thread Alex Deucher
On Mon, Apr 11, 2022 at 11:28 AM Paul Menzel wrote: > > Dear Yongqiang, > > > Thank you for your patch. > > Am 11.04.22 um 15:59 schrieb Yongqiang Sun: > > MS_HYPERV with vega10 doesn't have the interface to process > > request init data msg. > > Should some Hyper-V folks be added to the reviewers

[PATCH 5.4 0/2] Fix two instances of -Wstrict-prototypes in drm/amd

2022-04-11 Thread Nathan Chancellor
Hi everyone, These two patches resolve two instances of -Wstrict-prototypes with newer versions of clang that are present in 5.4. The main Makefile makes this a hard error. The first patch is upstream commit 63617d8b125e ("drm/amdkfd: add missing void argument to function kgd2kfd_init"), which sh

[PATCH 5.4 1/2] drm/amdkfd: add missing void argument to function kgd2kfd_init

2022-04-11 Thread Nathan Chancellor
From: Colin Ian King commit 63617d8b125ed9f674133dd000b6df58d6b2965a upstream. Function kgd2kfd_init is missing a void argument, add it to clean up the non-ANSI function declaration. Acked-by: Randy Dunlap Signed-off-by: Colin Ian King Signed-off-by: Alex Deucher Signed-off-by: Nathan Chance

[PATCH 5.4 2/2] drm/amdkfd: Fix -Wstrict-prototypes from amdgpu_amdkfd_gfx_10_0_get_functions()

2022-04-11 Thread Nathan Chancellor
This patch is for linux-5.4.y only, it has no equivalent change upstream. When building x86_64 allmodconfig with tip of tree clang, there is an instance of -Wstrict-prototypes: drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c:168:59: error: a function declaration without a prototype is depre

RE: [PATCH 5.4 0/2] Fix two instances of -Wstrict-prototypes in drm/amd

2022-04-11 Thread Deucher, Alexander
[Public] > -Original Message- > From: Nathan Chancellor > Sent: Monday, April 11, 2022 12:43 PM > To: Greg Kroah-Hartman ; Sasha Levin > > Cc: Kuehling, Felix ; Deucher, Alexander > ; Nick Desaulniers > ; amd-gfx@lists.freedesktop.org; > l...@lists.linux.dev; sta...@vger.kernel.org; Nath

Patch "drm/amdkfd: add missing void argument to function kgd2kfd_init" has been added to the 5.4-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/amdkfd: add missing void argument to function kgd2kfd_init to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch i

Re: [PATCH 5.4 0/2] Fix two instances of -Wstrict-prototypes in drm/amd

2022-04-11 Thread Greg Kroah-Hartman
On Mon, Apr 11, 2022 at 09:43:06AM -0700, Nathan Chancellor wrote: > Hi everyone, > > These two patches resolve two instances of -Wstrict-prototypes with > newer versions of clang that are present in 5.4. The main Makefile makes > this a hard error. > > The first patch is upstream commit 63617d8b

Patch "drm/amdkfd: Fix -Wstrict-prototypes from amdgpu_amdkfd_gfx_10_0_get_functions()" has been added to the 5.4-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/amdkfd: Fix -Wstrict-prototypes from amdgpu_amdkfd_gfx_10_0_get_functions() to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filen

Re: [PATCH] drm/radeon: remove r600_blit_shaders.[c|h]

2022-04-11 Thread Alex Deucher
On Sat, Apr 9, 2022 at 1:11 PM Tom Rix wrote: > > The only use of the global variables in r600_blit_shaders.c > were in the old drivers/gpu/drm/radeon/r600_blit.c > This file was removed in > commit 8333f607a631 ("drm/radeon: remove UMS support") > > So remove the r600_blit_shaders.[c|h] files > >

[linux-next:master] BUILD REGRESSION d12d7e1cfe38e0c36d28c7a9fbbc436ad0d17c14

2022-04-11 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: d12d7e1cfe38e0c36d28c7a9fbbc436ad0d17c14 Add linux-next specific files for 20220411 Error/Warning reports: https://lore.kernel.org/linux-mm/202203160358.yulpl6b4-...@intel.com https

Re: AMDGPU: regression on 5.17.1

2022-04-11 Thread Alex Deucher
On Sat, Apr 9, 2022 at 12:28 PM Michele Ballabio wrote: > > On Tue, 5 Apr 2022 10:23:16 -0400 > Alex Deucher wrote: > > > On Mon, Apr 4, 2022 at 3:39 PM Michele Ballabio > > wrote: > > > > > > On Mon, 4 Apr 2022 13:03:41 -0400 > > > Alex Deucher wrote: > > > > > > > On Sun, Apr 3, 2022 at 10:19

[igt-dev] [PATCH i-g-t v2] tests/drm_buddy: Add drm buddy test cases

2022-04-11 Thread Arunpravin Paneer Selvam
Add a set of drm buddy test cases to validate the drm/drm_buddy.c memory allocator. v2: sorted in alphabetical order Signed-off-by: Arunpravin Paneer Selvam Reviewed-by: Matthew Auld --- tests/drm_buddy.c | 14 ++ tests/meson.build | 1 + 2 files changed, 15 insertions(+) create

Vega 56 failing to process EDID from VR Headset

2022-04-11 Thread James Dutton
Hi, I have an Oculus Rift S, that I am trying to get working in Linux. I have an AMD Vega 56 graphics card. The VR headset plugs into a display port of the Vega56. The amdgpu driver sees the connection, and tries to process it. The problem is it cannot process the EDID, so fails to recognise the

gcc inserts __builtin_popcount, causes 'modpost: "__popcountdi2" ... amdgpu.ko] undefined'

2022-04-11 Thread Sergei Trofimovich
Current linux-5.17.1 on fresh gcc-12 fails to build with errors like: ERROR: modpost: "__popcountdi2" [drivers/net/ethernet/broadcom/bnx2x/bnx2x.ko] undefined! ERROR: modpost: "__popcountdi2" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! It is occasionally seen by others on previous

Re: gcc inserts __builtin_popcount, causes 'modpost: "__popcountdi2" ... amdgpu.ko] undefined'

2022-04-11 Thread Jakub Jelinek
On Mon, Apr 11, 2022 at 10:08:15PM +0100, Sergei Trofimovich wrote: > Current linux-5.17.1 on fresh gcc-12 fails to build with errors like: > > ERROR: modpost: "__popcountdi2" > [drivers/net/ethernet/broadcom/bnx2x/bnx2x.ko] undefined! > ERROR: modpost: "__popcountdi2" [drivers/gpu/drm/am

Re: AMDGPU: RX 6500 XT: System reset when loading module [SOLVED]

2022-04-11 Thread Cal Peake
Hi all, I wanted to put a capper on this just in case anyone was interested, or in case any future people find this thread, because I did find a resolution. Turns out the way to stop the system from crashing was to disable Global C-State Control in the BIOS. Christian, Alex, you guys seem to h

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-11 Thread kernel test robot
Hi Richard, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on v5.18-rc2 next-20220411] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as doc

Re: [PATCH 1/2] drm/amdkfd: Cleanup IO links during KFD device removal

2022-04-11 Thread Felix Kuehling
Am 2022-04-08 um 04:45 schrieb Shuotao Xu: Currently, the IO-links to the device being removed from topology, are not cleared. As a result, there would be dangling links left in the KFD topology. This patch aims to fix the following: 1. Cleanup all IO links to the device being removed. 2. Ensure

Re: [PATCH] drm/amdkfd: Cleanup IO links during KFD device removal

2022-04-11 Thread Felix Kuehling
Am 2022-04-07 um 12:15 schrieb Mukul Joshi: Currently, the IO-links to the device being removed from topology, are not cleared. As a result, there would be dangling links left in the KFD topology. This patch aims to fix the following: 1. Cleanup all IO links to the device being removed. 2. Ensure

[PATCH AUTOSEL 5.17 02/49] drm/amd: Add USBC connector ID

2022-04-11 Thread Sasha Levin
From: Aurabindo Pillai [ Upstream commit c5c948aa894a831f96fccd025e47186b1ee41615 ] [Why&How] Add a dedicated AMDGPU specific ID for use with newer ASICs that support USB-C output Signed-off-by: Aurabindo Pillai Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin

[PATCH AUTOSEL 5.17 05/49] drm/amdgpu: conduct a proper cleanup of PDB bo

2022-04-11 Thread Sasha Levin
From: Guchun Chen [ Upstream commit 2d505453f38e18d42ba7d5428aaa17aaa7752c65 ] Use amdgpu_bo_free_kernel instead of amdgpu_bo_unref to perform a proper cleanup of PDB bo. v2: update subject to be more accurate Signed-off-by: Guchun Chen Reviewed-by: Christian König Signed-off-by: Alex Deuche

[PATCH AUTOSEL 5.17 06/49] drm/amdgpu/gmc: use PCI BARs for APUs in passthrough

2022-04-11 Thread Sasha Levin
From: Alex Deucher [ Upstream commit b818a5d374542ccec73dcfe578a081574029820e ] If the GPU is passed through to a guest VM, use the PCI BAR for CPU FB access rather than the physical address of carve out. The physical address is not valid in a guest. v2: Fix HDP handing as suggested by Michel

[PATCH AUTOSEL 5.17 07/49] drm/amd/display: fix audio format not updated after edid updated

2022-04-11 Thread Sasha Levin
From: Charlene Liu [ Upstream commit 5e8a71cf13bc9184fee915b2220be71b4c6cac74 ] [why] for the case edid change only changed audio format. driver still need to update stream. Reviewed-by: Alvin Lee Reviewed-by: Aric Cyr Acked-by: Alex Hung Signed-off-by: Charlene Liu Tested-by: Daniel Wheele

[PATCH AUTOSEL 5.17 08/49] drm/amd/display: FEC check in timing validation

2022-04-11 Thread Sasha Levin
From: Chiawen Huang [ Upstream commit 7d56a154e22ffb3613fdebf83ec34d5225a22993 ] [Why] disable/enable leads FEC mismatch between hw/sw FEC state. [How] check FEC status to fastboot on/off. Reviewed-by: Anthony Koo Acked-by: Alex Hung Signed-off-by: Chiawen Huang Tested-by: Daniel Wheeler S

[PATCH AUTOSEL 5.17 09/49] drm/amd/display: Update VTEM Infopacket definition

2022-04-11 Thread Sasha Levin
From: "Leo (Hanghong) Ma" [ Upstream commit c9fbf6435162ed5fb7201d1d4adf6585c6a8c327 ] [Why & How] The latest HDMI SPEC has updated the VTEM packet structure, so change the VTEM Infopacket defined in the driver side to align with the SPEC. Reviewed-by: Chris Park Acked-by: Alex Hung Signed-of

[PATCH AUTOSEL 5.17 10/49] drm/amdkfd: Fix Incorrect VMIDs passed to HWS

2022-04-11 Thread Sasha Levin
From: Tushar Patel [ Upstream commit b7dfbd2e601f3fee545bc158feceba4f340fe7cf ] Compute-only GPUs have more than 8 VMIDs allocated to KFD. Fix this by passing correct number of VMIDs to HWS v2: squash in warning fix (Alex) Signed-off-by: Tushar Patel Reviewed-by: Felix Kuehling Signed-off-by

[PATCH AUTOSEL 5.17 11/49] drm/amdgpu/vcn: improve vcn dpg stop procedure

2022-04-11 Thread Sasha Levin
From: Tianci Yin [ Upstream commit 6ea239adc2a712eb318f04f5c29b018ba65ea38a ] Prior to disabling dpg, VCN need unpausing dpg mode, or VCN will hang in S3 resuming. Reviewed-by: James Zhu Signed-off-by: Tianci Yin Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/am

[PATCH AUTOSEL 5.17 12/49] drm/amdkfd: Check for potential null return of kmalloc_array()

2022-04-11 Thread Sasha Levin
From: QintaoShen [ Upstream commit ebbb7bb9e80305820dc2328a371c1b35679f2667 ] As the kmalloc_array() may return null, the 'event_waiters[i].wait' would lead to null-pointer dereference. Therefore, it is better to check the return value of kmalloc_array() to avoid this confusion. Signed-off-by

[PATCH AUTOSEL 5.17 35/49] drm/amd/display: Correct Slice reset calculation

2022-04-11 Thread Sasha Levin
From: Chris Park [ Upstream commit 862a876c3a6372f2fa9d0c6510f1976ac94fc857 ] [Why] Once DSC slice cannot fit pixel clock, we incorrectly reset min slices to 0 and allow max slice to operate, even when max slice itself cannot fit the pixel clock properly. [How] Change the sequence such that we

[PATCH AUTOSEL 5.17 36/49] drm/amd/display: Enable power gating before init_pipes

2022-04-11 Thread Sasha Levin
From: Roman Li [ Upstream commit 58e16c752e9540b28a873c44c3bee83e022007c1 ] [Why] In init_hw() we call init_pipes() before enabling power gating. init_pipes() tries to power gate dsc but it may fail because required force-ons are not released yet. As a result with dsc config the following errors

[PATCH AUTOSEL 5.17 37/49] drm/amd/display: Revert FEC check in validation

2022-04-11 Thread Sasha Levin
From: Martin Leung [ Upstream commit b2075fce104b88b789c15ef1ed2b91dc94198e26 ] why and how: causes failure on install on certain machines Reviewed-by: George Shen Acked-by: Alex Hung Signed-off-by: Martin Leung Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Lev

[PATCH AUTOSEL 5.17 38/49] drm/amd/display: Fix allocate_mst_payload assert on resume

2022-04-11 Thread Sasha Levin
From: Roman Li [ Upstream commit f4346fb3edf7720db3f7f5e1cab1f667cd024280 ] [Why] On resume we do link detection for all non-MST connectors. MST is handled separately. However the condition for telling if connector is on mst branch is not enough for mst hub case. Link detection for mst branch li

[PATCH AUTOSEL 5.15 01/41] drm/amd: Add USBC connector ID

2022-04-11 Thread Sasha Levin
From: Aurabindo Pillai [ Upstream commit c5c948aa894a831f96fccd025e47186b1ee41615 ] [Why&How] Add a dedicated AMDGPU specific ID for use with newer ASICs that support USB-C output Signed-off-by: Aurabindo Pillai Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin

[PATCH AUTOSEL 5.15 04/41] drm/amdgpu: conduct a proper cleanup of PDB bo

2022-04-11 Thread Sasha Levin
From: Guchun Chen [ Upstream commit 2d505453f38e18d42ba7d5428aaa17aaa7752c65 ] Use amdgpu_bo_free_kernel instead of amdgpu_bo_unref to perform a proper cleanup of PDB bo. v2: update subject to be more accurate Signed-off-by: Guchun Chen Reviewed-by: Christian König Signed-off-by: Alex Deuche

[PATCH AUTOSEL 5.15 05/41] drm/amdgpu/gmc: use PCI BARs for APUs in passthrough

2022-04-11 Thread Sasha Levin
From: Alex Deucher [ Upstream commit b818a5d374542ccec73dcfe578a081574029820e ] If the GPU is passed through to a guest VM, use the PCI BAR for CPU FB access rather than the physical address of carve out. The physical address is not valid in a guest. v2: Fix HDP handing as suggested by Michel

[PATCH AUTOSEL 5.15 06/41] drm/amd/display: fix audio format not updated after edid updated

2022-04-11 Thread Sasha Levin
From: Charlene Liu [ Upstream commit 5e8a71cf13bc9184fee915b2220be71b4c6cac74 ] [why] for the case edid change only changed audio format. driver still need to update stream. Reviewed-by: Alvin Lee Reviewed-by: Aric Cyr Acked-by: Alex Hung Signed-off-by: Charlene Liu Tested-by: Daniel Wheele

[PATCH AUTOSEL 5.15 07/41] drm/amd/display: FEC check in timing validation

2022-04-11 Thread Sasha Levin
From: Chiawen Huang [ Upstream commit 7d56a154e22ffb3613fdebf83ec34d5225a22993 ] [Why] disable/enable leads FEC mismatch between hw/sw FEC state. [How] check FEC status to fastboot on/off. Reviewed-by: Anthony Koo Acked-by: Alex Hung Signed-off-by: Chiawen Huang Tested-by: Daniel Wheeler S

[PATCH AUTOSEL 5.15 08/41] drm/amd/display: Update VTEM Infopacket definition

2022-04-11 Thread Sasha Levin
From: "Leo (Hanghong) Ma" [ Upstream commit c9fbf6435162ed5fb7201d1d4adf6585c6a8c327 ] [Why & How] The latest HDMI SPEC has updated the VTEM packet structure, so change the VTEM Infopacket defined in the driver side to align with the SPEC. Reviewed-by: Chris Park Acked-by: Alex Hung Signed-of

[PATCH AUTOSEL 5.15 09/41] drm/amdkfd: Fix Incorrect VMIDs passed to HWS

2022-04-11 Thread Sasha Levin
From: Tushar Patel [ Upstream commit b7dfbd2e601f3fee545bc158feceba4f340fe7cf ] Compute-only GPUs have more than 8 VMIDs allocated to KFD. Fix this by passing correct number of VMIDs to HWS v2: squash in warning fix (Alex) Signed-off-by: Tushar Patel Reviewed-by: Felix Kuehling Signed-off-by

[PATCH AUTOSEL 5.15 10/41] drm/amdgpu/vcn: improve vcn dpg stop procedure

2022-04-11 Thread Sasha Levin
From: Tianci Yin [ Upstream commit 6ea239adc2a712eb318f04f5c29b018ba65ea38a ] Prior to disabling dpg, VCN need unpausing dpg mode, or VCN will hang in S3 resuming. Reviewed-by: James Zhu Signed-off-by: Tianci Yin Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/am

[PATCH AUTOSEL 5.15 11/41] drm/amdkfd: Check for potential null return of kmalloc_array()

2022-04-11 Thread Sasha Levin
From: QintaoShen [ Upstream commit ebbb7bb9e80305820dc2328a371c1b35679f2667 ] As the kmalloc_array() may return null, the 'event_waiters[i].wait' would lead to null-pointer dereference. Therefore, it is better to check the return value of kmalloc_array() to avoid this confusion. Signed-off-by

[PATCH AUTOSEL 5.15 29/41] drm/amd/display: Enable power gating before init_pipes

2022-04-11 Thread Sasha Levin
From: Roman Li [ Upstream commit 58e16c752e9540b28a873c44c3bee83e022007c1 ] [Why] In init_hw() we call init_pipes() before enabling power gating. init_pipes() tries to power gate dsc but it may fail because required force-ons are not released yet. As a result with dsc config the following errors

  1   2   >