It must check asic whether support smu
before call smu powerplay function, otherwise
it may cause null point on no support smu asic.
Change-Id: Ib86f3d4c88317b23eb1040b9ce1c5c8dcae42488
Signed-off-by: Stanley.Yang
---
drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 6 ++
1 file changed, 6 insertions(+
On 16/03/22 5:01 pm, Matthew Auld wrote:
> On 16/03/2022 06:34, Arunpravin Paneer Selvam wrote:
>> handle a situation in the condition order-- == min_order,
>> when order = 0 and min_order = 0, leading to order = -1,
>> it now won't exit the loop. To avoid this problem,
>> added a order check in
add a simple check to reject any size not aligned to the
min_page_size.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/drm_buddy.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_buddy.c b/drivers/gpu/drm/drm_buddy.c
index 72f52f293249..b503c88786b0 100644
[AMD Official Use Only]
Reviewed-by: Evan Quan
> -Original Message-
> From: Stanley.Yang
> Sent: Monday, March 21, 2022 1:46 PM
> To: amd-gfx@lists.freedesktop.org; Zhang, Hawking
> ; Zhou1, Tao ; Li,
> Candice ; Quan, Evan
> Cc: Yang, Stanley
> Subject: [PATCH Review 1/1] drm/amdgpu/
On 16/03/22 12:28 pm, Paul Menzel wrote:
> Dear Arunprivin,
>
>
> Am 16.03.22 um 07:49 schrieb Arunpravin Paneer Selvam:
>
>> On 15/03/22 9:14 pm, Paul Menzel wrote:
>
>>> Am 15.03.22 um 16:42 schrieb Arunpravin:
>>>
On 15/03/22 2:35 pm, Paul Menzel wrote:
>>>
> Am 15.03.22 um 10:01
On 16/03/22 6:02 pm, Christian König wrote:
> Am 16.03.22 um 12:31 schrieb Matthew Auld:
>> On 16/03/2022 06:34, Arunpravin Paneer Selvam wrote:
>>> handle a situation in the condition order-- == min_order,
>>> when order = 0 and min_order = 0, leading to order = -1,
>>> it now won't exit the lo
Dear Stanley,
Thank you for your patch.
Am 21.03.22 um 06:45 schrieb Stanley.Yang:
Some nits:
Could you please remove the dot from the name:
$ git config --global user.name "Stanley Yang"
$ git commit --amend -s --author="Stanley Yang "
The prefix drm/amd/pm seems to be more common
Dear Arunpravin,
Am 21.03.22 um 06:59 schrieb Arunpravin Paneer Selvam:
add a simple check to reject any size not aligned to the
min_page_size.
Nit: I’d start sentences with a capital letter.
Could you please add a summary of the discussion to the commit message,
so the question “Why?” is a
