Re: [PATCH 07/13] drm/amd/display: [FW Promotion] Release 0.0.109.0

2022-03-19 Thread Paul Menzel
Dear Alex, dear Anthony, Thank you for the patch. Am 18.03.22 um 22:47 schrieb Alex Hung: From: Anthony Koo Without a commit message a person not involved in AMD graphics development has no idea, what this version bump is useful for, and what “FW Promotion” is. Could you please add one,

Re: [PATCH 01/13] drm/amd/display: HDCP SEND AKI INIT error

2022-03-19 Thread Paul Menzel
Dear Alex, dear Ahmad, Thank you for the patch. Am 18.03.22 um 22:47 schrieb Alex Hung: From: Ahmad Othman Could you please make the commit message summary/title a statement by adding a verb (imperative mood) [1]. Maybe: drm/amd/display: Fix HDCP SEND AKI INIT error [why] HDCP sends AK

Re: [PATCH 04/13] drm/amd/display: FEC check in timing validation

2022-03-19 Thread Paul Menzel
Dear Alex, dear Chiawen, Thank you for your patch. Am 18.03.22 um 22:47 schrieb Alex Hung: From: Chiawen Huang [Why] disable/enable leads fec mismatch between hw/sw fec state. 1. Disable/enable of what? 2. How can this be reproduced? 3. s/fec/FEC/ [How] check fec status to fastboot on

Re: [PATCH 05/13] drm/amd/display: Add fSMC_MSG_SetDtbClk support

2022-03-19 Thread Paul Menzel
Dear Alex, dear Oliver, Am 18.03.22 um 22:47 schrieb Alex Hung: From: Oliver Logush [why] Needed to support dcn315 Please elaborate. What is wrong with `dcn315_smu_get_smu_fclk()`? Reviewed-by: Charlene Liu Acked-by: Alex Hung Signed-off-by: Oliver Logush --- .../display/dc/clk_mgr/d

Re: [PATCH 06/13] drm/amd/display: Update VTEM Infopacket definition

2022-03-19 Thread Paul Menzel
Dear Alex, dear Leo, Am 18.03.22 um 22:47 schrieb Alex Hung: From: "Leo (Hanghong) Ma" [Why & How] The latest HDMI SPEC has updated the VTEM packet structure, Please add the exact version, as “latest” is relative. so change the VTEM Infopacket defined in the driver side to align with the

Re: [PATCH 10/13] drm/amd/display: remove destructive verify link for TMDS

2022-03-19 Thread Paul Menzel
Dear Alex, dear Charlene, Thank you for the patch. Am 18.03.22 um 22:47 schrieb Alex Hung: From: Charlene Liu [why and how] TMDS not need destructive verify link According to whom? Please document the source for that claim. Is that just to be spec compliant, or does it cause an actual pro

Re: [PATCH 11/13] drm/amd/dicplay: move FPU related code from dcn31 to dml/dcn31 folder

2022-03-19 Thread Paul Menzel
Dear Alex, dear Melissa, Thank you for the patch. Am 18.03.22 um 22:47 schrieb Alex Hung: From: Melissa Wen Typo in the commit message summary: di*s*play Creates FPU files in dml/dcn31 folder to centralize FPU operations from 3.1x drivers and moves all FPU-associated code from dcn31 driv