RE: [PATCH 2/3] drm/amdgpu: add utcl2 RAS poison functions for Aldebaran

2022-03-15 Thread Zhou1, Tao
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Monday, March 14, 2022 5:44 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang, > Hawking ; Yang, Stanley > ; Chai, Thomas > Subject: Re: [PATCH 2/3] drm/amdgpu: add utcl2 RAS poison functions for > Aldeba

[PATCH 1/2] drm/amdgpu: prevent memory wipe in suspend/shutdown stage

2022-03-15 Thread Guchun Chen
On GPUs with RAS enabled, below call trace is observed when suspending or shutting down device. The cause is we have enabled memory wipe flag for BOs on such GPUs by default, and such BOs will go to memory wipe by amdgpu_fill_buffer, however, because ring is off already, it fails to clean up the me

RE: [PATCH 1/3] drm/amdkfd: update parameter for event_interrupt_poison_consumption

2022-03-15 Thread Zhou1, Tao
[AMD Official Use Only] > -Original Message- > From: Kuehling, Felix > Sent: Tuesday, March 15, 2022 2:25 AM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang, > Hawking ; Yang, Stanley > ; Chai, Thomas > Subject: Re: [PATCH 1/3] drm/amdkfd: update parameter for > event_interrupt

[PATCH 2/2] drm/amdgpu: fix pin count leak of PDB bo when unref

2022-03-15 Thread Guchun Chen
Use amdgpu_bo_free_kernel instead of amdgpu_bo_unref to perform a clean unreference job. Signed-off-by: Guchun Chen --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gm

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-15 Thread Dave Airlie
On Tue, 15 Mar 2022 at 00:23, Alex Deucher wrote: > > On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen wrote: > > > > On Thu, 10 Mar 2022 11:56:41 -0800 > > Rob Clark wrote: > > > > > For something like just notifying a compositor that a gpu crash > > > happened, perhaps drm_event is more suitable

Re: [PATCH] drm/amdgpu: only allow secure submission on rings which support that

2022-03-15 Thread Christian König
Am 15.03.22 um 06:45 schrieb Lang Yu: Only GFX ring, SDMA ring and VCN decode ring support secure submission at the moment. Suggested-by: Christian König Signed-off-by: Lang Yu Good work, patch is Reviewed-by: Christian König . --- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 4 ++-- driv

Re: [PATCH 2/2] drm/amdgpu: fix pin count leak of PDB bo when unref

2022-03-15 Thread Christian König
Am 15.03.22 um 08:11 schrieb Guchun Chen: Use amdgpu_bo_free_kernel instead of amdgpu_bo_unref to perform a clean unreference job. I think the subject is incorrect. This doesn't leak the pin count, but rather produces a warning that the BO needs a proper cleanup. Signed-off-by: Guchun Chen

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-15 Thread Simon Ser
On Tuesday, March 15th, 2022 at 08:13, Dave Airlie wrote: > Just one thing comes to mind reading this, racy PID reuse. > > process 1234 does something bad to GPU. > process 1234 dies in parallel to sysfs notification being sent. > other process 1234 reuses the pid > new process 1234 gets destroye

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-15 Thread Christian König
Am 15.03.22 um 08:13 schrieb Dave Airlie: On Tue, 15 Mar 2022 at 00:23, Alex Deucher wrote: On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen wrote: On Thu, 10 Mar 2022 11:56:41 -0800 Rob Clark wrote: For something like just notifying a compositor that a gpu crash happened, perhaps drm_event

RE: [PATCH 3/3] drm/amdkfd: add RAS poison consumption support for utcl2

2022-03-15 Thread Zhou1, Tao
[AMD Official Use Only] > -Original Message- > From: Kuehling, Felix > Sent: Tuesday, March 15, 2022 2:41 AM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang, > Hawking ; Yang, Stanley > ; Chai, Thomas > Subject: Re: [PATCH 3/3] drm/amdkfd: add RAS poison consumption support for

RE: [PATCH 2/2] drm/amdgpu: fix pin count leak of PDB bo when unref

2022-03-15 Thread Chen, Guchun
Thanks for your review, Christian. I will send an updated patch set soon. How about patch 1 in my series "[PATCH 1/2] drm/amdgpu: prevent memory wipe in suspend/shutdown stage"? Regards, Guchun -Original Message- From: Koenig, Christian Sent: Tuesday, March 15, 2022 3:22 PM To: Chen,

Re: [PATCH 1/2] drm/amdgpu: prevent memory wipe in suspend/shutdown stage

2022-03-15 Thread Christian König
Am 15.03.22 um 08:09 schrieb Guchun Chen: On GPUs with RAS enabled, below call trace is observed when suspending or shutting down device. The cause is we have enabled memory wipe flag for BOs on such GPUs by default, and such BOs will go to memory wipe by amdgpu_fill_buffer, however, because r

RE: [PATCH 3/3] drm/amdkfd: add RAS poison consumption support for utcl2

2022-03-15 Thread Zhou1, Tao
[AMD Official Use Only] > -Original Message- > From: Zhang, Hawking > Sent: Monday, March 14, 2022 7:14 PM > To: Zhang, Hawking ; Zhou1, Tao > ; amd-gfx@lists.freedesktop.org; Yang, Stanley > ; Chai, Thomas ; Kuehling, > Felix > Subject: RE: [PATCH 3/3] drm/amdkfd: add RAS poison consu

RE: [PATCH 1/2] drm/amdgpu: prevent memory wipe in suspend/shutdown stage

2022-03-15 Thread Chen, Guchun
I used two tabs in VIM. Let me update this later. Regards, Guchun -Original Message- From: Koenig, Christian Sent: Tuesday, March 15, 2022 3:35 PM To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Pan, Xinhui ; Deucher, Alexander Subject: Re: [PATCH 1/2] drm/amdgpu:

Re: [PATCH 1/2] drm/amdgpu: prevent memory wipe in suspend/shutdown stage

2022-03-15 Thread Christian König
Try installing the linuxsty vim pluging. It should give you the correct coding style setting for vim. I'm using it for years and can only recommend it. Regards, Christian. Am 15.03.22 um 08:49 schrieb Chen, Guchun: I used two tabs in VIM. Let me update this later. Regards, Guchun -Origi

RE: [PATCH 3/3] drm/amdkfd: add RAS poison consumption support for utcl2

2022-03-15 Thread Zhou1, Tao
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Monday, March 14, 2022 5:52 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang, > Hawking ; Yang, Stanley > ; Chai, Thomas > Subject: Re: [PATCH 3/3] drm/amdkfd: add RAS poison consumption support for > ut

[PATCH 1/2] drm/amdgpu: prevent memory wipe in suspend/shutdown stage

2022-03-15 Thread Guchun Chen
On GPUs with RAS enabled, below call trace is observed when suspending or shutting down device. The cause is we have enabled memory wipe flag for BOs on such GPUs by default, and such BOs will go to memory wipe by amdgpu_fill_buffer, however, because ring is off already, it fails to clean up the me

[PATCH 2/2] drm/amdgpu: conduct a proper cleanup of PDB bo

2022-03-15 Thread Guchun Chen
Use amdgpu_bo_free_kernel instead of amdgpu_bo_unref to perform a proper cleanup of PDB bo. v2: update subject to be more accurate Signed-off-by: Guchun Chen Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Paul Menzel
Dear Arunpravin, Am 14.03.22 um 20:40 schrieb Arunpravin: handle a situation in the condition order-- == min_order, when order = 0, leading to order = -1, it now won't exit the loop. To avoid this problem, added a order check in the same condition, (i.e) when order is 0, we return -ENOSPC Sign

Re: [PATCH 01/12] drm/amd/display: Add I2C escape to support query device exist.

2022-03-15 Thread Paul Menzel
Dear Augustin, Am 10.03.22 um 23:20 schrieb Agustin Gutierrez: From: "JinZe.Xu" Please remove the dot/period and use Jin Ze Xu. Also please remove the dot/period at the end of the git commit message summary. [How] 1. Search OEM I2C info from BIOS and compare with input parameter. 2. If

Re: [PATCH 04/12] drm/amd/display: Update engine ddc

2022-03-15 Thread Paul Menzel
Dear Agustin, Am 10.03.22 um 23:20 schrieb Agustin Gutierrez: From: Jing Zhou [Why] Crash caused by a ddc update failure Please give more details. What setup is it? Did Linux crash or just print a stack trace? Also *Update engine ddc* should be more concrete. [How] Update engine ddc be

Re: [PATCH 00/30] fix typos in comments

2022-03-15 Thread Martin K. Petersen
Julia, > drivers/scsi/aic7xxx/aicasm/aicasm.c|2 +- > drivers/scsi/elx/libefc_sli/sli4.c |2 +- > drivers/scsi/lpfc/lpfc_mbox.c |2 +- > drivers/scsi/qla2xxx/qla_gs.c |2 +- Applied patches 2, 17, 24, a

Re: [PATCH 3/3] drm/amdkfd: add RAS poison consumption support for utcl2

2022-03-15 Thread Lazar, Lijo
On 3/15/2022 1:22 PM, Zhou1, Tao wrote: [AMD Official Use Only] -Original Message- From: Lazar, Lijo Sent: Monday, March 14, 2022 5:52 PM To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Yang, Stanley ; Chai, Thomas Subject: Re: [PATCH 3/3] drm/amdkfd: add RAS poi

Re: [PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Arunpravin
On 15/03/22 1:49 pm, Paul Menzel wrote: > Dear Arunpravin, > > > Am 14.03.22 um 20:40 schrieb Arunpravin: >> handle a situation in the condition order-- == min_order, >> when order = 0, leading to order = -1, it now won't exit >> the loop. To avoid this problem, added a order check in >> the s

RE: [PATCH 3/3] drm/amdkfd: add RAS poison consumption support for utcl2

2022-03-15 Thread Zhou1, Tao
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Tuesday, March 15, 2022 4:43 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang, > Hawking ; Yang, Stanley > ; Chai, Thomas > Subject: Re: [PATCH 3/3] drm/amdkfd: add RAS poison consumption support for > u

Re: [PATCH 12/12] drm/amd/display: 3.2.177

2022-03-15 Thread Paul Menzel
Dear Agustin, dear Aric, Am 10.03.22 um 23:20 schrieb Agustin Gutierrez: From: Aric Cyr It’d be great if you could make the git commit message summary a statement. Maybe: > drm/amd/display: Increment DC version from 3.2.176 to 3.2.177 This version brings along following fixes:

Re: [PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Paul Menzel
Dear Arunpravin, Am 15.03.22 um 10:01 schrieb Arunpravin: On 15/03/22 1:49 pm, Paul Menzel wrote: Am 14.03.22 um 20:40 schrieb Arunpravin: handle a situation in the condition order-- == min_order, when order = 0, leading to order = -1, it now won't exit the loop. To avoid this problem, add

Re: [PATCH] drm/amdgpu/vcn: fix vcn ring test failure in igt reload test

2022-03-15 Thread Paul Menzel
Dear Tianci, Am 15.03.22 um 03:33 schrieb Tianci Yin: From: "Tianci.Yin" Please remove the dot/period in the name. (`git config --global user.name "Tianci Yin"`. [why] On Renoir, vcn ring test failed on the second time insmod in the reload test. Does Linux log a warning/error? Please p

[PATCH] drm/amdgpu: Use ternary operator in `vcn_v1_0_start()`

2022-03-15 Thread Paul Menzel
Remove the boilerplate of declaring a variable and using an if else statement by using the ternary operator. Signed-off-by: Paul Menzel --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/

Re: [PATCH 06/12] drm/amd/display: Add new enum for EDID status

2022-03-15 Thread Paul Menzel
Dear Agustin, dear Dale, Am 10.03.22 um 23:20 schrieb Agustin Gutierrez: From: Dale Zhao [Why] We must support a new type of partial edid return in the future What changed, that you need to support it now? The exact DisplayCore(?) version should be documented returning this. Anyway, plea

[PATCH] drm/amdgpu/pm: fix the Stable pstate Test in amdgpu_test

2022-03-15 Thread Yifan Zhang
If GFX DPM is disbaled, Stable pstate Test in amdgpu_test fails. Check GFX DPM statue before change clock level Log: [ 46.595274] [drm] Initialized amdgpu 3.46.0 20150101 for :02:00.0 on minor 0 [ 46.599929] fbcon: amdgpudrmfb (fb0) is primary device [ 46.785753] Console: switching to c

Re: [Intel-gfx] [PATCH] drm/i915: round_up the size to the alignment value

2022-03-15 Thread Matthew Auld
On Mon, 14 Mar 2022 at 19:32, Arunpravin wrote: > > handle instances when size is not aligned with the min_page_size. > Unigine Heaven has allocation requests for example required pages > are 161 and alignment request is 128. To allocate the left over > 33 pages, continues the iteration to find th

Re: [PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Matthew Auld
On 14/03/2022 19:40, Arunpravin wrote: handle a situation in the condition order-- == min_order, when order = 0, leading to order = -1, it now won't exit the loop. To avoid this problem, added a order check in the same condition, (i.e) when order is 0, we return -ENOSPC Signed-off-by: Arunpravin

Re: [PATCH] drm/amdgpu/vcn: fix vcn ring test failure in igt reload test

2022-03-15 Thread James Zhu
This patch is Reviewed-by: James Zhu On 2022-03-14 10:33 p.m., Tianci Yin wrote: From: "Tianci.Yin" [why] On Renoir, vcn ring test failed on the second time insmod in the reload test. After invetigation, it proves that vcn only can disable dpg under dpg unpause mode (dpg unpause mode is defau

Re: [PATCH] drm/amdgpu/pm: fix the Stable pstate Test in amdgpu_test

2022-03-15 Thread Huang Rui
On Tue, Mar 15, 2022 at 06:25:51PM +0800, Zhang, Yifan wrote: > If GFX DPM is disbaled, Stable pstate Test in amdgpu_test fails. > Check GFX DPM statue before change clock level > > Log: > [ 46.595274] [drm] Initialized amdgpu 3.46.0 20150101 for :02:00.0 on > minor 0 > [ 46.599929] fbcon

RE: [PATCH] drm/amdgpu/pm: fix the Stable pstate Test in amdgpu_test

2022-03-15 Thread Zhang, Yifan
[AMD Official Use Only] I think It is a swsmu issue rather than a smu 13.0.5 specific one, in current swsmu implementation, smu->adev->pm.dpm_enabled is always true after smu_hw_init, doesn't reflect the real DPM status; smu->pm_enabled indicates SMU functionality, also always true except in sr

Re: [PATCH] drm/amdgpu: Use ternary operator in `vcn_v1_0_start()`

2022-03-15 Thread James Zhu
This patch is Reviewed-by: James Zhu On 2022-03-15 5:29 a.m., Paul Menzel wrote: Remove the boilerplate of declaring a variable and using an if else statement by using the ternary operator. Signed-off-by: Paul Menzel --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 9 ++--- 1 file changed,

Re: (subset) [PATCH 00/30] fix typos in comments

2022-03-15 Thread Mark Brown
On Mon, 14 Mar 2022 12:53:24 +0100, Julia Lawall wrote: > Various spelling mistakes in comments. > Detected with the help of Coccinelle. > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [21/30] spi: sun4i: fix typos in comments commit: 20

[PATCH] drm/amd/pm: Disable fan control if not supported

2022-03-15 Thread Elena Sakhnovitch
On Sienna Cichild, not all platforms use PMFW based fan control. On such ASICs fan control by PMFW will be disabled in PPTable. Disable hwmon knobs for fan control also as it is not possible to report or control fan speed on such platforms through driver. Signed-off-by: Elena Sakhnovitch Change-

Re: [PATCH] drm/amdgpu/vcn: fix vcn ring test failure in igt reload test

2022-03-15 Thread Yin, Tianci (Rico)
[AMD Official Use Only] Thank you for reviewing James! Regards, Rico From: Zhu, James Sent: Tuesday, March 15, 2022 20:01 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Chen, Guchun ; Zhu, James ; Wang, Yu (Charlie) Subject: Re: [PATCH] drm/amdgpu

[PATCH 1/2] drm/amdgpu: Merge get_reserved_allocation to get_vbios_allocations.

2022-03-15 Thread Yongqiang Sun
Some ASICs need reserved memory for firmware or other components, which is not allowed to be used by driver. amdgpu_gmc_get_reserved_allocation is to handle additional areas. To avoid any missing calling, merged amdgpu_gmc_get_reserved_allocation to amdgpu_gmc_get_vbios_allocations. Signed-off-by:

[PATCH 2/2] drm/amdgpu: Add stolen reserved memory for MI25 SRIOV.

2022-03-15 Thread Yongqiang Sun
MI25 SRIOV guest driver loading failed due to allocated memory overlaps with firmware reserved area. Allocate stolen reserved memory for MI25 SRIOV specifically to avoid the memory overlap. Signed-off-by: Yongqiang Sun Change-Id: Ia1d1c4392fb792fa0186250dfc6270f35ffd6bed --- drivers/gpu/drm/amd/

Re: [PATCH 2/2] drm/amdgpu: Add stolen reserved memory for MI25 SRIOV.

2022-03-15 Thread Deucher, Alexander
[Public] Series is: Reviewed-by: Alex Deucher From: Sun, Yongqiang Sent: Tuesday, March 15, 2022 10:11 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Sun, Yongqiang Subject: [PATCH 2/2] drm/amdgpu: Add stolen reserved memory for MI25 SRIOV. MI2

Re: [PATCH 1/2] drm/amdgpu: Merge get_reserved_allocation to get_vbios_allocations.

2022-03-15 Thread Christian König
Am 15.03.22 um 15:11 schrieb Yongqiang Sun: Some ASICs need reserved memory for firmware or other components, which is not allowed to be used by driver. amdgpu_gmc_get_reserved_allocation is to handle additional areas. To avoid any missing calling, merged amdgpu_gmc_get_reserved_allocation to amd

Re: [PATCH 1/1] drm/amdkfd: evict svm bo worker handle error

2022-03-15 Thread philip yang
On 2022-03-14 3:58 p.m., Felix Kuehling wrote: Am 2022-03-14 um 10:50 schrieb Philip Yang: Migrate vram to ram may fail to find the vma if process is exiting and vma is removed, evict svm bo worker sets prange->svm_bo

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-15 Thread Alex Deucher
On Mon, Mar 14, 2022 at 11:26 AM Pekka Paalanen wrote: > > On Mon, 14 Mar 2022 10:23:27 -0400 > Alex Deucher wrote: > > > On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen wrote: > > > > > > On Thu, 10 Mar 2022 11:56:41 -0800 > > > Rob Clark wrote: > > > > > > > For something like just notifying a

[PATCH V2 1/1] drm/amdkfd: evict svm bo worker handle error

2022-03-15 Thread philip yang
Migrate vram to ram may fail to find the vma if process is exiting and vma is removed, evict svm bo worker sets prange->svm_bo to NULL and warn svm_bo ref count != 1 only if migrating vram to ram successfully. Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c

Re: [PATCH V2 1/1] drm/amdkfd: evict svm bo worker handle error

2022-03-15 Thread Felix Kuehling
Am 2022-03-15 um 11:05 schrieb philip yang: Migrate vram to ram may fail to find the vma if process is exiting and vma is removed, evict svm bo worker sets prange->svm_bo to NULL and warn svm_bo ref count != 1 only if migrating vram to ram successfully. Signed-off-by: Philip Yang --- drivers/g

Re: [Intel-gfx] [PATCH] drm/i915: round_up the size to the alignment value

2022-03-15 Thread Arunpravin
On 15/03/22 4:56 pm, Matthew Auld wrote: > On Mon, 14 Mar 2022 at 19:32, Arunpravin > wrote: >> >> handle instances when size is not aligned with the min_page_size. >> Unigine Heaven has allocation requests for example required pages >> are 161 and alignment request is 128. To allocate the left

Re: [PATCH 1/1] drm/amdkfd: evict svm bo worker handle error

2022-03-15 Thread Felix Kuehling
Am 2022-03-15 um 10:44 schrieb philip yang: On 2022-03-14 3:58 p.m., Felix Kuehling wrote: Am 2022-03-14 um 10:50 schrieb Philip Yang: Migrate vram to ram may fail to find the vma if process is exiting and vma is removed, evict svm bo worker sets prange->svm_bo to NULL and warn svm_bo ref c

Re: [PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Arunpravin
On 15/03/22 2:35 pm, Paul Menzel wrote: > Dear Arunpravin, > > > Am 15.03.22 um 10:01 schrieb Arunpravin: > >> On 15/03/22 1:49 pm, Paul Menzel wrote: > >>> Am 14.03.22 um 20:40 schrieb Arunpravin: handle a situation in the condition order-- == min_order, when order = 0, leading to

Re: [PATCH 1/2] drm/amdgpu: prevent memory wipe in suspend/shutdown stage

2022-03-15 Thread Felix Kuehling
Am 2022-03-15 um 03:54 schrieb Guchun Chen: On GPUs with RAS enabled, below call trace is observed when suspending or shutting down device. The cause is we have enabled memory wipe flag for BOs on such GPUs by default, and such BOs will go to memory wipe by amdgpu_fill_buffer, however, because ri

Re: [PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Paul Menzel
Dear Arunpravin, Am 15.03.22 um 16:42 schrieb Arunpravin: On 15/03/22 2:35 pm, Paul Menzel wrote: Am 15.03.22 um 10:01 schrieb Arunpravin: On 15/03/22 1:49 pm, Paul Menzel wrote: Am 14.03.22 um 20:40 schrieb Arunpravin: handle a situation in the condition order-- == min_order, when or

Re: [PATCH] drm/amdgpu: fixed the warnings reported by kernel test robot

2022-03-15 Thread Alex Deucher
Applied. Thanks! On Mon, Mar 14, 2022 at 2:28 AM Zhou1, Tao wrote: > > [AMD Official Use Only] > > Reviewed-by: Tao Zhou > > > -Original Message- > > From: Chai, Thomas > > Sent: Monday, March 14, 2022 1:52 PM > > To: amd-gfx@lists.freedesktop.org > > Cc: Chai, Thomas ; Zhang, Hawking

Re: [PATCH 01/30] drm/amd/pm: fix typos in comments

2022-03-15 Thread Alex Deucher
Applied. Thanks! On Mon, Mar 14, 2022 at 8:01 AM Julia Lawall wrote: > > Various spelling mistakes in comments. > Detected with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/gpu/drm/amd/pm/amdgpu_pm.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > di

Re: [PATCH 29/30] drm/amdgpu: fix typos in comments

2022-03-15 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Mar 14, 2022 at 8:01 AM Julia Lawall wrote: > > Various spelling mistakes in comments. > Detected with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c |4 ++-- > 1 file changed, 2 insertions(+), 2 delet

Re: [PATCH 23/30] drm/amdgpu/dc: fix typos in comments

2022-03-15 Thread Alex Deucher
Applied. Thanks! On Mon, Mar 14, 2022 at 8:01 AM Julia Lawall wrote: > > Various spelling mistakes in comments. > Detected with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/gpu/drm/amd/display/dc/bios/command_table.c |6 +++--- > 1 file changed, 3 insertions(+)

Re: [PATCH] drm/amd/pm: fix indenting in __smu_cmn_reg_print_error()

2022-03-15 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Mar 14, 2022 at 12:06 PM Luben Tuikov wrote: > > Thanks! > > Reviewed-by: Luben Tuikov > > Regards, > Luben > > On 2022-03-14 10:04, Dan Carpenter wrote: > > Smatch complains that the dev_err_ratelimited() is indented one tab more > > than the surrounding lines. >

Re: [PATCH 02/22] drm/amdgpu: Remove pointless on stack mode copies

2022-03-15 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Feb 18, 2022 at 11:28 AM Harry Wentland wrote: > > > > On 2022-02-18 05:03, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > These on stack copies of the modes appear to be pointless. > > Just look at the originals directly. > > > > Cc: Harry Wentland > > Cc:

Re: [PATCH] drm/amdgpu: Use ternary operator in `vcn_v1_0_start()`

2022-03-15 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Mar 15, 2022 at 8:49 AM James Zhu wrote: > > This patch is Reviewed-by: James Zhu > > On 2022-03-15 5:29 a.m., Paul Menzel wrote: > > Remove the boilerplate of declaring a variable and using an if else > > statement by using the ternary operator. > > > > Signed-of

Re: [PATCH v3] drm/amdgpu: add workarounds for VCN TMZ issue on CHIP_RAVEN

2022-03-15 Thread Paul Menzel
Dear Lang, Am 14.03.22 um 03:45 schrieb Lang Yu: Thank you for your patch. A shorter commit message summary would be: > drm/amdgpu: Work around VNC TMZ issue on CHIP_RAVEN It is a hardware issue that VCN can't handle a GTT backing stored TMZ buffer on CHIP_RAVEN series ASIC. Where is that

Re: [PATCH] drm/amdgpu: fixed the warnings reported by kernel test robot

2022-03-15 Thread Paul Menzel
Dear Yi Peng, Am 14.03.22 um 06:52 schrieb yipechai: Please use imperative mood in the commit message summary: > drm/amdgpu: Fix kernel test robot warnings But, for the reader of `git log --oneline` it’s totally unclear, what these warnings are, and they need to take a look at the patch. For

[PATCH 1/3] drm/amdgpu: make amdgpu_display_framebuffer_init() static

2022-03-15 Thread Alex Deucher
It's not used outside of amdgpu_display.c. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 13 + drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h| 4 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_displ

[PATCH 2/3] drm/amdgpu: drop amdgpu_display_gem_fb_init()

2022-03-15 Thread Alex Deucher
Unused. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 25 - drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h| 4 2 files changed, 29 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_d

[PATCH 3/3] drm/amdgpu: make amdgpu_display_gem_fb_verify_and_init() static

2022-03-15 Thread Alex Deucher
Unused outside of amdgpu_display.c. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 9 + drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h| 5 - 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/driv

[PATCH] drm/amdgpu/gmc: use PCI BARs for APUs in passthrough

2022-03-15 Thread Alex Deucher
If the GPU is passed through to a guest VM, use the PCI BAR for CPU FB access rather than the physical address of carve out. The physical address is not valid in a guest. v2: Fix HDP handing as suggested by Michel Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +

Re: [PATCH 05/22] drm/radeon: Use drm_mode_copy()

2022-03-15 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Feb 18, 2022 at 5:04 AM Ville Syrjala wrote: > > From: Ville Syrjälä > > struct drm_display_mode embeds a list head, so overwriting > the full struct with another one will corrupt the list > (if the destination mode is on a list). Use drm_mode_copy() > instead whi

Re: [PATCH 04/22] drm/amdgpu: Use drm_mode_copy()

2022-03-15 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Feb 18, 2022 at 11:32 AM Harry Wentland wrote: > > > > On 2022-02-18 05:03, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > struct drm_display_mode embeds a list head, so overwriting > > the full struct with another one will corrupt the list > > (if the desti

Re: [PATCH 00/22] drm: Review of mode copies

2022-03-15 Thread Alex Deucher
On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä wrote: > > On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: > > drm: Add drm_mode_init() > > drm/bridge: Use drm_mode_copy() > > drm/imx: Use drm_mode_duplicate() > > drm/panel: Use drm_mode_duplicate() > > drm/vc4: Use drm_mode

[PATCH] drm/amd: Add USBC connector ID

2022-03-15 Thread Aurabindo Pillai
[Why&How] Add a dedicated AMDGPU specific ID for use with newer ASICs that support USB-C output Signed-off-by: Aurabindo Pillai Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/ObjectID.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/ObjectID.h b/driver

Re: [PATCH 1/3] drm/amdgpu: make amdgpu_display_framebuffer_init() static

2022-03-15 Thread Aurabindo Pillai
Series is Reviewed-by: Aurabindo Pillai On 2022-03-15 13:09, Alex Deucher wrote: It's not used outside of amdgpu_display.c. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 13 + drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h| 4 2 files chang

[PATCH] drm/amdgpu: Fix spelling mistake "regiser" -> "register"

2022-03-15 Thread Colin Ian King
There is a spelling mistake in a dev_error error message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c in

Re: [PATCH] WIP: drm/dp_mst: Add support for dumping topology ref histories from debugfs

2022-03-15 Thread Lyude Paul
(Adding this back to the dri-devel mailing list since I didn't notice it got dropped from there) Hm, some comments on this issue down below. Sorry for the delayed response, I was going to try this right after I finished the MST legacy removal but that's ending up taking longer than I hoped. On Tu

RE: [PATCH 1/3] drm/amdgpu: make amdgpu_display_framebuffer_init() static

2022-03-15 Thread Chen, Guchun
Series are: Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, March 16, 2022 1:09 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 1/3] drm/amdgpu: make amdgpu_display_framebuffer_init() stati

[linux-next:master] BUILD REGRESSION a32cd981a6da2373c093d471ee4405a915e217d5

2022-03-15 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: a32cd981a6da2373c093d471ee4405a915e217d5 Add linux-next specific files for 20220315 Error/Warning reports: https://lore.kernel.org/linux-doc/202202240704.pqd40a9l-...@intel.com https

Re: [PATCH v3] drm/amdgpu: add workarounds for VCN TMZ issue on CHIP_RAVEN

2022-03-15 Thread Paul Menzel
Dear Lang, Am 16.03.22 um 02:27 schrieb Lang Yu: On 03/15/ , Paul Menzel wrote: Am 14.03.22 um 03:45 schrieb Lang Yu: Thank you for your patch. A shorter commit message summary would be: drm/amdgpu: Work around VNC TMZ issue on CHIP_RAVEN It is a hardware issue that VCN can't handle a

Re: [PATCH v3] drm/amdgpu: add workarounds for VCN TMZ issue on CHIP_RAVEN

2022-03-15 Thread Lang Yu
On 03/16/ , Paul Menzel wrote: > Dear Lang, > > > Am 16.03.22 um 02:27 schrieb Lang Yu: > > On 03/15/ , Paul Menzel wrote: > > > > Am 14.03.22 um 03:45 schrieb Lang Yu: > > > > > > Thank you for your patch. A shorter commit message summary would be: > > > > > > > drm/amdgpu: Work around VNC TM

[PATCH v2] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Arunpravin Paneer Selvam
handle a situation in the condition order-- == min_order, when order = 0 and min_order = 0, leading to order = -1, it now won't exit the loop. To avoid this problem, added a order check in the same condition, (i.e) when order is 0, we return -ENOSPC v2: use full name in email program and in Signed

Re: [PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Arunpravin Paneer Selvam
On 15/03/22 9:14 pm, Paul Menzel wrote: > Dear Arunpravin, > > > Am 15.03.22 um 16:42 schrieb Arunpravin: > >> On 15/03/22 2:35 pm, Paul Menzel wrote: > >>> Am 15.03.22 um 10:01 schrieb Arunpravin: >>> On 15/03/22 1:49 pm, Paul Menzel wrote: >>> > Am 14.03.22 um 20:40 schrieb Arunpr

[PATCH] drm/amdgpu: drop redundant check of harvest info

2022-03-15 Thread Guchun Chen
Harvest bit setting in IP data structure promises this, so no need to set it explicitly. Signed-off-by: Guchun Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amd

Re: [PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Paul Menzel
Dear Arunprivin, Am 16.03.22 um 07:49 schrieb Arunpravin Paneer Selvam: On 15/03/22 9:14 pm, Paul Menzel wrote: Am 15.03.22 um 16:42 schrieb Arunpravin: On 15/03/22 2:35 pm, Paul Menzel wrote: Am 15.03.22 um 10:01 schrieb Arunpravin: On 15/03/22 1:49 pm, Paul Menzel wrote: Am 14.0