Re: [PATCH 1/2] drm: Add GPU reset sysfs event

2022-03-09 Thread Christian König
Am 08.03.22 um 16:37 schrieb Somalapuram, Amaranath: On 3/8/2022 5:26 PM, Sharma, Shashank wrote: On 3/8/2022 11:32 AM, Christian König wrote: Am 08.03.22 um 10:31 schrieb Sharma, Shashank: On 3/8/2022 8:06 AM, Christian König wrote: Am 07.03.22 um 17:26 schrieb Shashank Sharma: From: S

Re: [PATCH 1/2] drm: Add GPU reset sysfs event

2022-03-09 Thread Christian König
Am 08.03.22 um 17:40 schrieb Sharma, Shashank: On 3/8/2022 12:56 PM, Sharma, Shashank wrote: On 3/8/2022 11:32 AM, Christian König wrote: Am 08.03.22 um 10:31 schrieb Sharma, Shashank: On 3/8/2022 8:06 AM, Christian König wrote: Am 07.03.22 um 17:26 schrieb Shashank Sharma: From: Shash

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-09 Thread Christian König
Am 08.03.22 um 19:04 schrieb Shashank Sharma: From: Shashank Sharma This patch adds a new sysfs event, which will indicate the userland about a GPU reset, and can also provide some information like: - process ID of the process involved with the GPU reset - process name of the involved process -

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-09 Thread Pierre-Eric Pelloux-Prayer
Hi Shashank, On 08/03/2022 19:04, Shashank Sharma wrote: > From: Shashank Sharma > > This patch adds a new sysfs event, which will indicate > the userland about a GPU reset, and can also provide > some information like: > - process ID of the process involved with the GPU reset > - process name o

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-09 Thread Simon Ser
On Wednesday, March 9th, 2022 at 10:56, Pierre-Eric Pelloux-Prayer wrote: > Would it be possible to include the app parameters as well? Can all processes read sysfs events? There might be security implications here. The app parameters might contain sensitive information, like passwords or toke

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-09 Thread Christian König
Am 09.03.22 um 11:10 schrieb Simon Ser: On Wednesday, March 9th, 2022 at 10:56, Pierre-Eric Pelloux-Prayer wrote: Would it be possible to include the app parameters as well? Can all processes read sysfs events? No, but application parameters are usually not secret. There might be securit

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-09 Thread Simon Ser
On Wednesday, March 9th, 2022 at 11:24, Christian König wrote: > Am 09.03.22 um 11:10 schrieb Simon Ser: > > On Wednesday, March 9th, 2022 at 10:56, Pierre-Eric Pelloux-Prayer > > wrote: > > > >> Would it be possible to include the app parameters as well? > > Can all processes read sysfs event

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-09 Thread Pierre-Eric Pelloux-Prayer
On 09/03/2022 11:24, Christian König wrote: > Am 09.03.22 um 11:10 schrieb Simon Ser: >> On Wednesday, March 9th, 2022 at 10:56, Pierre-Eric Pelloux-Prayer >> wrote: >> >>> Would it be possible to include the app parameters as well? >> Can all processes read sysfs events? > > No, but applicat

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-09 Thread Sharma, Shashank
On 3/9/2022 8:47 AM, Simon Ser wrote: Hi, Maybe it would be a good idea to state the intended use-case in the commit message? It was added in the second patch, but yeah, it makes more sense to add a cover-letter probably. And explain why the current (driver-specific IIRC) APIs aren't e

RE: [PATCH] drm/amdkfd: CRIU export dmabuf handles for GTT BOs

2022-03-09 Thread Bhardwaj, Rajneesh
[AMD Official Use Only] Reviewed-by: Rajneesh Bhardwaj -Original Message- From: amd-gfx On Behalf Of David Yat Sin Sent: Tuesday, March 8, 2022 2:12 PM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: Kuehling, Felix ; Yat Sin, David Subject: [PATCH] drm/amdkfd:

RE: [PATCH v2] drm/amdkfd: CRIU export dmabuf handles for GTT BOs

2022-03-09 Thread Bhardwaj, Rajneesh
[AMD Official Use Only] Please ignore the previous email, that was sent in error. This one is with the minor version bump so this looks good. Reviewed-by : Rajneesh Bhardwaj -Original Message- From: amd-gfx On Behalf Of David Yat Sin Sent: Tuesday, March 8, 2022 4:08 PM To: amd-gfx@li

RE: [PATCH v2] drm/amdkfd: CRIU export dmabuf handles for GTT BOs

2022-03-09 Thread Yat Sin, David
This is the link to the user mode change: https://github.com/checkpoint-restore/criu/pull/1709 Regards, David > -Original Message- > From: Kuehling, Felix > Sent: Tuesday, March 8, 2022 4:20 PM > To: Yat Sin, David ; amd-gfx@lists.freedesktop.org; > dri-de...@lists.freedesktop.org > Subj

[PATCH v2] drm/amdgpu: Add support for drm_privacy_screen

2022-03-09 Thread Sean Paul
From: Sean Paul This patch adds the necessary hooks to make amdgpu aware of privacy screens. On devices with privacy screen drivers (such as thinkpad-acpi), the amdgpu driver will defer probe until it's ready and then sync the sw and hw state on each commit the connector is involved and enabled.

Re: [PATCH v2] drm/amdgpu: Add support for drm_privacy_screen

2022-03-09 Thread Hans de Goede
Hi, On 3/9/22 16:06, Sean Paul wrote: > From: Sean Paul > > This patch adds the necessary hooks to make amdgpu aware of privacy > screens. On devices with privacy screen drivers (such as thinkpad-acpi), > the amdgpu driver will defer probe until it's ready and then sync the sw > and hw state on

[PATCH] drm/amdkfd: Set handle to invalid for non GTT/VRAM BOs

2022-03-09 Thread David Yat Sin
Set dmabuf handle to invalid for BOs that cannot be accessed using SDMA during checkpoint/restore. Signed-off-by: David Yat Sin --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 8 ++-- include/uapi/linux/kfd_ioctl.h | 2 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2] drm/amdgpu: Add support for drm_privacy_screen

2022-03-09 Thread Alex Deucher
On Wed, Mar 9, 2022 at 12:54 PM Rajat Jain wrote: > > On Wed, Mar 9, 2022 at 7:06 AM Sean Paul wrote: > > > > From: Sean Paul > > > > This patch adds the necessary hooks to make amdgpu aware of privacy > > screens. On devices with privacy screen drivers (such as thinkpad-acpi), > > the amdgpu dr

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-09 Thread Rob Clark
On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma wrote: > > From: Shashank Sharma > > This patch adds a new sysfs event, which will indicate > the userland about a GPU reset, and can also provide > some information like: > - process ID of the process involved with the GPU reset > - process name of

Re: [PATCH v2] drm/amkfd: bail out early if no get_atc_vmid_pasid_mapping_info

2022-03-09 Thread Nathan Chancellor
On Wed, Mar 09, 2022 at 10:22:42AM +0800, Yifan Zhang wrote: > it makes no sense to continue with an undefined vmid. > > Fixes: d21bcfc01eb1 (drm/amdkfd: judge get_atc_vmid_pasid_mapping_info before > call) > > Signed-off-by: Yifan Zhang > Reported-by: Nathan Chancellor Thank you for the quic

[PATCH] drm/amdgpu/display: enable scatter/gather display for DCN 3.1.6

2022-03-09 Thread Alex Deucher
Enable scatter/gather display for DCN 3.1.6. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index a4737005

Re: [PATCH] drm/amdgpu/display: enable scatter/gather display for DCN 3.1.6

2022-03-09 Thread Harry Wentland
On 2022-03-09 13:58, Alex Deucher wrote: > Enable scatter/gather display for DCN 3.1.6. > > Signed-off-by: Alex Deucher Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd

[PATCH] drm/amd/display: Add pstate verification and recovery for DCN31

2022-03-09 Thread Nicholas Kazlauskas
[Why] To debug when p-state is being blocked and avoid PMFW hangs when it does occur. [How] Re-use the DCN10 hardware sequencer by adding a new interface for verifying p-state high on the hubbub. The interface is mostly the same as the DCN10 interface, but the bit definitions have changed for the

[PATCH] drm/amdgpu: only check for _PR3 on dGPUs

2022-03-09 Thread Alex Deucher
We don't support runtime pm on APUs. They support more dynamic power savings using clock and powergating. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device

Re: [PATCH v2] drm/amdgpu: Add support for drm_privacy_screen

2022-03-09 Thread kernel test robot
Hi Sean, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next next-20220309] [cannot apply to tegra-drm/drm/tegra/for-next airlied/drm-next v5.17-rc7] [If your

Re: [PATCH] drm/amd/display: Add pstate verification and recovery for DCN31

2022-03-09 Thread Harry Wentland
On 2022-03-09 14:19, Nicholas Kazlauskas wrote: > [Why] > To debug when p-state is being blocked and avoid PMFW hangs when > it does occur. > > [How] > Re-use the DCN10 hardware sequencer by adding a new interface for > verifying p-state high on the hubbub. The interface is mostly the > same as th

[PATCH 2/2] drm/amdgpu: Dump STB during ASIC reset.

2022-03-09 Thread Andrey Grodzovsky
This should provide more debug info for the driver. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 7abdf5e3

[PATCH 1/2] drm/amd/pm: Add STB dump function.

2022-03-09 Thread Andrey Grodzovsky
It will be used during GPU reset. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 10 +++ drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h | 3 +++ drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 26 +++ drivers/gpu/drm/amd/pm/swsmu/inc/amdg

Re: [PATCH] drm/amdkfd: Set handle to invalid for non GTT/VRAM BOs

2022-03-09 Thread Felix Kuehling
On 2022-03-09 12:41, David Yat Sin wrote: Set dmabuf handle to invalid for BOs that cannot be accessed using SDMA during checkpoint/restore. Signed-off-by: David Yat Sin --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 8 ++-- include/uapi/linux/kfd_ioctl.h | 2 ++ 2 files chang

[PATCH] fixup! drm/amdkfd: CRIU export dmabuf handles for GTT BOs

2022-03-09 Thread David Yat Sin
Signed-off-by: David Yat Sin --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 6 ++ include/uapi/linux/kfd_ioctl.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c index e1e2362841f8..607f65ab39

Re: [PATCH] drm/amdkfd: Set handle to invalid for non GTT/VRAM BOs

2022-03-09 Thread Alex Deucher
On Wed, Mar 9, 2022 at 4:10 PM Felix Kuehling wrote: > > On 2022-03-09 12:41, David Yat Sin wrote: > > Set dmabuf handle to invalid for BOs that cannot be accessed using SDMA > > during checkpoint/restore. > > > > Signed-off-by: David Yat Sin > > --- > > drivers/gpu/drm/amd/amdkfd/kfd_chardev.c

Re: [PATCH] fixup! drm/amdkfd: CRIU export dmabuf handles for GTT BOs

2022-03-09 Thread Felix Kuehling
On 2022-03-09 16:20, David Yat Sin wrote: Signed-off-by: David Yat Sin Please add the commit description back. And let's wait for Alex to confirm that the fixup-method is OK. With that fixed, the patch is Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 6 +++

Re: [PATCH] drm/amdkfd: Set handle to invalid for non GTT/VRAM BOs

2022-03-09 Thread Alex Deucher
On Wed, Mar 9, 2022 at 4:21 PM Alex Deucher wrote: > > On Wed, Mar 9, 2022 at 4:10 PM Felix Kuehling wrote: > > > > On 2022-03-09 12:41, David Yat Sin wrote: > > > Set dmabuf handle to invalid for BOs that cannot be accessed using SDMA > > > during checkpoint/restore. > > > > > > Signed-off-by: D

Re: [PATCH] fixup! drm/amdkfd: CRIU export dmabuf handles for GTT BOs

2022-03-09 Thread Alex Deucher
No problem. squashed in: https://gitlab.freedesktop.org/agd5f/linux/-/commit/74041e46982cd627e7b52f9c3ed37d23a4973b5f Alex Alex On Wed, Mar 9, 2022 at 4:23 PM Felix Kuehling wrote: > > On 2022-03-09 16:20, David Yat Sin wrote: > > Signed-off-by: David Yat Sin > > Please add the commit descri

Re: drm/amdgpu: only check for _PR3 on dGPUs

2022-03-09 Thread Limonciello, Mario
On 3/9/2022 14:12, Alex Deucher wrote: We don't support runtime pm on APUs. They support more dynamic power savings using clock and powergating. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH] amdgpu/pm: Don't show `smartshift_*_power` files for APUs

2022-03-09 Thread Mario Limonciello
`smartshift_*_power` files are showing up on some OEM programs on the APU instead of the dGPU. Adjust the logic to the function `ss_power_attr_update` to detect whether or not the attributes should be exported. The existing checks that are dropped are already included in `amdgpu_device_support_sm

Re: [pull] amdgpu, amdkfd drm-next-5.18

2022-03-09 Thread Dave Airlie
On Tue, 8 Mar 2022 at 06:08, Alex Deucher wrote: > > Hi Dave, Daniel, > > Same PR as last week, just fixed up a bad Fixes tag. > > The following changes since commit 38a15ad9488e21cad8f42d3befca20f91e5b2874: > > Merge tag 'amd-drm-next-5.18-2022-02-25' of > https://gitlab.freedesktop.org/agd5f/

Re: [pull] amdgpu, amdkfd drm-next-5.18

2022-03-09 Thread Alex Deucher
On Wed, Mar 9, 2022 at 5:12 PM Dave Airlie wrote: > > On Tue, 8 Mar 2022 at 06:08, Alex Deucher wrote: > > > > Hi Dave, Daniel, > > > > Same PR as last week, just fixed up a bad Fixes tag. > > > > The following changes since commit 38a15ad9488e21cad8f42d3befca20f91e5b2874: > > > > Merge tag 'am

[PATCH] drm/amdgpu: fix aldebaran xgmi topology for vf

2022-03-09 Thread Jonathan Kim
VFs must also distinguish whether or not the TA supports full duplex or half duplex link records in order to report the correct xGMI topology. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers

Re: [pull] amdgpu, amdkfd drm-next-5.18

2022-03-09 Thread Dave Airlie
On Thu, 10 Mar 2022 at 08:16, Alex Deucher wrote: > > On Wed, Mar 9, 2022 at 5:12 PM Dave Airlie wrote: > > > > On Tue, 8 Mar 2022 at 06:08, Alex Deucher wrote: > > > > > > Hi Dave, Daniel, > > > > > > Same PR as last week, just fixed up a bad Fixes tag. > > > > > > The following changes since c

[pull] amdgpu, amdkfd drm-next-5.18

2022-03-09 Thread Alex Deucher
Hi Dave, Daniel, Same PR from last week with fixed Fixes tag, clang warning fix, and a CS rework regression fix. The following changes since commit 38a15ad9488e21cad8f42d3befca20f91e5b2874: Merge tag 'amd-drm-next-5.18-2022-02-25' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2

Re: [PATCH] drm/amdgpu: fix aldebaran xgmi topology for vf

2022-03-09 Thread Felix Kuehling
On 2022-03-09 17:16, Jonathan Kim wrote: VFs must also distinguish whether or not the TA supports full duplex or half duplex link records in order to report the correct xGMI topology. Signed-off-by: Jonathan Kim I think I'm missing something here. Your condition for setting supports_extended_d

RE: [PATCH] drm/amdgpu: fix aldebaran xgmi topology for vf

2022-03-09 Thread Kim, Jonathan
[Public] > -Original Message- > From: Kuehling, Felix > Sent: March 9, 2022 6:12 PM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Cc: Liu, Shaoyun > Subject: Re: [PATCH] drm/amdgpu: fix aldebaran xgmi topology for vf > > On 2022-03-09 17:16, Jonathan Kim wrote: > > VFs must also

RE: [PATCH] drm/amdgpu: fix aldebaran xgmi topology for vf

2022-03-09 Thread Liu, Shaoyun
[Public] Yes, we need the correct setting in both bare-metal and sriov to populate the correct xgmi link info. Move the setting to a common place that not be affect by SRIOV or not make sense to me. The change is reviewed by : Shaoyun.liu -Original Message- From: Kim, Jonathan

[PATCH 3/4] umr: Consistent indentation in switch

2022-03-09 Thread Luben Tuikov
A mix of multiple spaces and TAB char was being used in this switch. This commit makes the usage of indent chars consistent, i.e. leading-TAB only. Cc: Alex Deucher Cc: Tom StDenis Signed-off-by: Luben Tuikov --- src/lib/ih_decode_vectors.c | 80 ++--- 1 file ch

[PATCH 1/4] umr: Print errors to stderr

2022-03-09 Thread Luben Tuikov
Print the following error message, Invalid gca config data header to stderr, since printing it to stdout, confuses parser scripts. Also modify this message to be clearer. For instance, Invalid or unknown GCA config data header version:4 Cc: Alex Deucher Cc: Tom StDenis Signed-off-by: Lube

[PATCH 2/4] umr: Fix ring-stream segmentation fault

2022-03-09 Thread Luben Tuikov
Fix a segmentation fault when running --ring-stream for a ring and no bounds are specified. For instance "umr --ring-stream sdma0" on Sienna Cichlid, generates the following segmentation fault: Core was generated by `umr --ring-stream sdma0'. Program terminated with signal SIGSEGV, Segmentation fa

[PATCH 4/4] umr: Fix unhandled enumeration value in switch

2022-03-09 Thread Luben Tuikov
Add a default case in the switch, instead of the last unhandled value, FAMILY_CONFIGURE. This solves the case when in the future other families are not handled--they'll all fall into the default case. Also, in the diagnostic print, print the value of the unhandled enumeration--this could help debu

Re: [PATCH] drm/amdgpu: fix aldebaran xgmi topology for vf

2022-03-09 Thread Felix Kuehling
On 2022-03-09 18:31, Kim, Jonathan wrote: [Public] -Original Message- From: Kuehling, Felix Sent: March 9, 2022 6:12 PM To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org Cc: Liu, Shaoyun Subject: Re: [PATCH] drm/amdgpu: fix aldebaran xgmi topology for vf On 2022-03-09 17:16, Jonath

Re: [PATCH 1/2] drm/amd/pm: Add STB dump function.

2022-03-09 Thread Lazar, Lijo
On 3/10/2022 2:33 AM, Andrey Grodzovsky wrote: It will be used during GPU reset. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 10 +++ drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h | 3 +++ drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 26 +++

Re: [PATCH] amdgpu/pm: Don't show `smartshift_*_power` files for APUs

2022-03-09 Thread Lazar, Lijo
On 3/10/2022 3:35 AM, Mario Limonciello wrote: `smartshift_*_power` files are showing up on some OEM programs on the APU instead of the dGPU. Adjust the logic to the function `ss_power_attr_update` to detect whether or not the attributes should be exported. The existing checks that are dropp

[PATCH 0/4] Patchset to enable soft reset

2022-03-09 Thread Victor Zhao
This patch set is to enable soft reset on Sienna Cichlid on sdma and vcn. Sequence is enabled to satisfy the request of a faster and soft solution for multi-container environment. In order to get a more accurate engine hang detection, get hang from timeout job instead of register status. In order t

[PATCH 1/4] drm/amdgpu: add param soft_reset_enable

2022-03-09 Thread Victor Zhao
add parameter soft_reset_enable to control the enablement of soft reset Signed-off-by: Victor Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 9 + drivers/gpu/drm/amd/amdgpu/nv.c | 5 - 3 files changed, 14 insertions(+), 1 del

[PATCH 3/4] drm/amdgpu: add sdma v5_2 soft reset

2022-03-09 Thread Victor Zhao
enable sdma v5_2 soft reset Signed-off-by: Victor Zhao --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 79 +- 1 file changed, 78 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c index 4d4d1aa51b8a..f9

[PATCH 4/4] drm/amdgpu: add vcn v3_0 soft reset

2022-03-09 Thread Victor Zhao
add soft reset sequence for vcn v3_0 Signed-off-by: Victor Zhao --- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 87 ++- 1 file changed, 85 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c index da11ceba

[PATCH 2/4] drm/amdgpu: pass job to check soft reset

2022-03-09 Thread Victor Zhao
In order to get more accurate engine hang detection, pass the hang job to check_soft_reset to find the hang engine instead of check register status. Signed-off-by: Victor Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- driv