Re: [PATCH] drm/amdgpu: check vm bo eviction valuable at last

2022-02-20 Thread Qiang Yu
On Fri, Feb 18, 2022 at 6:24 PM Christian König wrote: > > Am 18.02.22 um 11:16 schrieb Qiang Yu: > > [SNIP] > >>> If amdgpu_vm_ready() use evicting flag, it's still not equivalent to check > >>> vm idle: true -> vm idle, false -> vm may be idle or busy. > >> Yeah, but why should that be relevant?

RE: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-20 Thread Gu, JiaWei (Will)
[AMD Official Use Only] Pinging. -Original Message- From: Jiawei Gu Sent: Thursday, February 17, 2022 6:44 PM To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Koenig, Christian ; Grodzovsky, Andrey ; Liu, Monk ; Deng, Emily ; Chen, Horace Cc: Gu, JiaWei (Will) Su

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-20 Thread Andrey Grodzovsky
On 2022-02-20 22:32, Gu, JiaWei (Will) wrote: [AMD Official Use Only] Pinging. -Original Message- From: Jiawei Gu Sent: Thursday, February 17, 2022 6:44 PM To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Koenig, Christian ; Grodzovsky, Andrey ; Liu, Monk ; Deng,

Re: [PATCH] drm/amdgpu: Initialize value of r in amdgpu_fill_buffer()

2022-02-20 Thread Christian König
Am 18.02.22 um 19:53 schrieb Souptick Joarder: From: "Souptick Joarder (HPE)" Kernel test robot reported warning -> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:2129:2: warning: Undefined or garbage value returned to caller [clang-analyzer-core. uninitialized.UndefReturn] Good catch, but that fix

Re: [PATCH] drm/amdkfd: rework criu_restore_bos error handling

2022-02-20 Thread Christian König
Am 18.02.22 um 19:35 schrieb Felix Kuehling: Am 2022-02-18 um 12:39 schrieb t...@redhat.com: From: Tom Rix Clang static analysis reports this problem kfd_chardev.c:2327:2: warning: 1st function call argument    is an uninitialized value    kvfree(bo_privs);    ^~~~ If the copy_fro

[PATCH v8 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-20 Thread Somalapuram Amaranath
List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 114 2 files changed, 118 insertions(+) diff --git a/drivers/gpu/

[PATCH v8 2/2] drm/amdgpu: add reset register dump trace on GPU reset

2022-02-20 Thread Somalapuram Amaranath
Dump the list of register values to trace event on GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 14 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16 2 files changed, 30 insertions(+) diff --git a/drivers/gpu/drm