[PATCH] drm/amdgpu: loose check for umc poison mode

No need to check poison setting for each channel, check for umc0 channel0 is enough. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/umc_v6_7.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v6_7.c b/drivers/gpu/drm/

Re: [PATCH] drm/amdgpu: Fix compile error.

Am 10.02.22 um 08:06 schrieb Christian König: Am 10.02.22 um 04:17 schrieb Andrey Grodzovsky: Seems I forgot to add this to the relevant commit when submitting. Rebase/merge issue? Looks like it. Signed-off-by: Andrey Grodzovsky Reported-by: kernel test robot Reviewed-by: Christian Köni

Re: [PATCH 03/27] mm: remove pointless includes from

On Thu, Feb 10, 2022 at 3:28 PM Christoph Hellwig wrote: > > hmm.h pulls in the world for no good reason at all. Remove the > includes and push a few ones into the users instead. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Logan Gunthorpe > Reviewed-by: Jason Gunthorpe > Reviewed-by: C

RE: [PATCH] drm/amdgpu: loose check for umc poison mode

[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Thursday, February 10, 2022 16:23 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Yang, Stanley ; Chai, Thomas ; Clements, John Cc: Zhou1, Tao Subject: [PATCH] drm/amdg

RE: [PATCH] drm/amdgpu: no rlcg read access in SRIOV case for gfx v9

[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Chen, Guchun Sent: Thursday, February 10, 2022 14:40 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Zhou, Peng Ju ; Koenig, Christian ; Deucher, Alexander Cc: Chen, Guchun Subject: [PA

Re: [PATCH 13/27] mm: move the migrate_vma_* device migration code into it's own file

I got the following build error: /data/source/linux/mm/migrate_device.c: In function ‘migrate_vma_collect_pmd’: /data/source/linux/mm/migrate_device.c:242:3: error: implicit declaration of function ‘flush_tlb_range’; did you mean ‘flush_pmd_tlb_range’? [-Werror=implicit-function-declaration] 2

Re: [PATCH 14/27] mm: build migrate_vma_* for all configs with ZONE_DEVICE support

Thanks, it's also better than more stubbed functions. Reviewed-by: Alistair Popple On Thursday, 10 February 2022 6:28:15 PM AEDT Christoph Hellwig wrote: > This code will be used for device coherent memory as well in a bit, > so relax the ifdef a bit. > > Signed-off-by: Christoph Hellwig > ---

Re: [PATCH 12/27] mm: refactor the ZONE_DEVICE handling in migrate_vma_pages

Reviewed-by: Alistair Popple On Thursday, 10 February 2022 6:28:13 PM AEDT Christoph Hellwig wrote: > Make the flow a little more clear and prepare for adding a new > ZONE_DEVICE memory type. > > Signed-off-by: Christoph Hellwig > --- > mm/migrate.c | 27 --- > 1 file c

Re: [PATCH 11/27] mm: refactor the ZONE_DEVICE handling in migrate_vma_insert_page

Reviewed-by: Alistair Popple On Thursday, 10 February 2022 6:28:12 PM AEDT Christoph Hellwig wrote: > Make the flow a little more clear and prepare for adding a new > ZONE_DEVICE memory type. > > Signed-off-by: Christoph Hellwig > --- > mm/migrate.c | 31 +++ > 1 fi

RE: [PATCH] drm/amdgpu: no rlcg read access in SRIOV case for gfx v9

[AMD Official Use Only] Hi Guchun, RLCG read is available on Aldebaran if amdgpu_sriov_reg_indirect_gc() flag is set. Instead of adding a new function, I think we should simply add a check inside amdgpu_virt_get_rlcg_reg_access_flag(): diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/

Re: start sorting out the ZONE_DEVICE refcount mess v2

On Thursday, 10 February 2022 6:28:01 PM AEDT Christoph Hellwig wrote: [...] > Changes since v1: > - add a missing memremap.h include in memcontrol.c > - include rebased versions of the device coherent support and >device coherent migration support series as well as additional >cleanup

Re: [PATCH 2/2] drm/amdgpu: add reset register trace function on GPU reset

On 2/10/2022 6:29 AM, Somalapuram, Amaranath wrote: On 2/9/2022 1:17 PM, Christian König wrote: Am 08.02.22 um 16:28 schrieb Alex Deucher: On Tue, Feb 8, 2022 at 3:17 AM Somalapuram Amaranath wrote: Dump the list of register values to trace event on GPU reset. Signed-off-by: Somalapuram

Re: [PATCH 2/2] drm/amdgpu: add reset register trace function on GPU reset

Am 10.02.22 um 12:59 schrieb Sharma, Shashank: On 2/10/2022 6:29 AM, Somalapuram, Amaranath wrote: On 2/9/2022 1:17 PM, Christian König wrote: Am 08.02.22 um 16:28 schrieb Alex Deucher: On Tue, Feb 8, 2022 at 3:17 AM Somalapuram Amaranath wrote: Dump the list of register values to trace e

Re: [PATCH 2/2] drm/amdgpu: add reset register trace function on GPU reset

On 2/10/2022 8:38 AM, Christian König wrote: Am 10.02.22 um 08:34 schrieb Somalapuram, Amaranath: On 2/10/2022 12:39 PM, Christian König wrote: Am 10.02.22 um 06:29 schrieb Somalapuram, Amaranath: On 2/9/2022 1:17 PM, Christian König wrote: Am 08.02.22 um 16:28 schrieb Alex Deucher: On

[PATCH v2] drm/amdgpu: skipping SDMA hw_init and hw_fini for S0ix.

[Why] SDMA ring buffer test failed if suspend is aborted during S0i3 resume. [How] If suspend is aborted for some reason during S0i3 resume cycle, it follows SDMA ring test failing and errors in amdgpu resume. For RN/CZN/Picasso, SMU saves and restores SDMA registers during S0ix cycle. So, skippin

RE: [PATCH v2] drm/amdgpu: skipping SDMA hw_init and hw_fini for S0ix.

[Public] > -Original Message- > From: Mahapatra, Rajib > Sent: Thursday, February 10, 2022 07:35 > To: Liang, Prike ; Limonciello, Mario > ; Deucher, Alexander > > Cc: amd-gfx@lists.freedesktop.org; S, Shirish ; > Mahapatra, Rajib > Subject: [PATCH v2] drm/amdgpu: skipping SDMA hw_ini

Re: [PATCH 2/2] drm/amdgpu: add reset register trace function on GPU reset

Am 10.02.22 um 14:18 schrieb Sharma, Shashank: On 2/10/2022 8:38 AM, Christian König wrote: Am 10.02.22 um 08:34 schrieb Somalapuram, Amaranath: On 2/10/2022 12:39 PM, Christian König wrote: Am 10.02.22 um 06:29 schrieb Somalapuram, Amaranath: On 2/9/2022 1:17 PM, Christian König wrote:

Re: [PATCH 2/2] drm/amdgpu: add reset register trace function on GPU reset

On 2/10/2022 3:05 PM, Christian König wrote: Am 10.02.22 um 14:18 schrieb Sharma, Shashank: On 2/10/2022 8:38 AM, Christian König wrote: Am 10.02.22 um 08:34 schrieb Somalapuram, Amaranath: On 2/10/2022 12:39 PM, Christian König wrote: Am 10.02.22 um 06:29 schrieb Somalapuram, Amaranath

Re: [PATCH v2 2/3] mm/gup.c: Migrate device coherent pages when pinning instead of failing

On 10.02.22 12:39, Alistair Popple wrote: > On Thursday, 10 February 2022 9:53:38 PM AEDT David Hildenbrand wrote: >> On 07.02.22 05:26, Alistair Popple wrote: >>> Currently any attempts to pin a device coherent page will fail. This is >>> because device coherent pages need to be managed by a devic

[PATCH] gpu: drm: radeon: use time_after_eq() instead of jiffies judgment

From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/gpu/drm/radeon/radeon_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/rad

Re: [PATCH v2 2/3] mm/gup.c: Migrate device coherent pages when pinning instead of failing

On Thursday, 10 February 2022 9:53:38 PM AEDT David Hildenbrand wrote: > On 07.02.22 05:26, Alistair Popple wrote: > > Currently any attempts to pin a device coherent page will fail. This is > > because device coherent pages need to be managed by a device driver, and > > pinning them would prevent

Re: [PATCH 05/23] drm/amd/display: Fix color encoding mismatch

Hi Harry, On Mon, Feb 07, 2022 at 01:59:38PM -0500, Harry Wentland wrote: > On 2022-02-07 13:57, Harry Wentland wrote: > > On 2022-02-07 11:34, Maxime Ripard wrote: > >> The amdgpu KMS driver calls drm_plane_create_color_properties() with a > >> default encoding set to BT709. > >> > >> However, th

Re: [PATCH v2 2/3] mm/gup.c: Migrate device coherent pages when pinning instead of failing

On 07.02.22 05:26, Alistair Popple wrote: > Currently any attempts to pin a device coherent page will fail. This is > because device coherent pages need to be managed by a device driver, and > pinning them would prevent a driver from migrating them off the device. > > However this is no reason to

Re: [PATCH] drm/amdgpu: Fix compile error.

On 2022-02-10 02:06, Christian König wrote: Am 10.02.22 um 04:17 schrieb Andrey Grodzovsky: Seems I forgot to add this to the relevant commit when submitting. Rebase/merge issue? Looks like it. It looks more like I forgot to add the header file change to the commit after updating with you

Re: [PATCH 05/23] drm/amd/display: Fix color encoding mismatch

On 2022-02-10 03:42, Maxime Ripard wrote: > Hi Harry, > > On Mon, Feb 07, 2022 at 01:59:38PM -0500, Harry Wentland wrote: >> On 2022-02-07 13:57, Harry Wentland wrote: >>> On 2022-02-07 11:34, Maxime Ripard wrote: The amdgpu KMS driver calls drm_plane_create_color_properties() with a

Re: [PATCH] drm/amdgpu: add support for GC 10.1.4

[Public] Reviewed-by: Alex Deucher From: Yu, Lang Sent: Thursday, February 10, 2022 1:20 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Yu, Lang Subject: [PATCH] drm/amdgpu: add support for GC 10.1.4 Add basic support for GC 10.1.4

Re: [PATCH] drm/amdgpu: no rlcg read access in SRIOV case for gfx v9

[AMD Official Use Only] For better future proofing maybe adjust the check to look for pre-gfx10 rather than checking for specific IP versions? E.g., adev->ip_versions[MP0_HWIP][0] < IP_VERSION(10, 0, 0) From: Chen, Guchun Sent: Thursday, February 10, 2022 1:40

[PATCH] drm/amdgpu: Add unique_id support for sienna cichlid

This is being added to SMU Metrics, so add the required tie-ins in the kernel Signed-off-by: Kent Russell --- .../pmfw_if/smu11_driver_if_sienna_cichlid.h | 12 +-- .../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 33 +++ 2 files changed, 43 insertions(+), 2 deletions(-) dif

Re: [PATCH 13/27] mm: move the migrate_vma_* device migration code into it's own file

On Thu, Feb 10, 2022 at 09:35:10PM +1100, Alistair Popple wrote: > I got the following build error: > > /data/source/linux/mm/migrate_device.c: In function ‘migrate_vma_collect_pmd’: > /data/source/linux/mm/migrate_device.c:242:3: error: implicit declaration of > function ‘flush_tlb_range’; did y

Re: [PATCH v2] drm/amdgpu: skipping SDMA hw_init and hw_fini for S0ix.

On Thu, Feb 10, 2022 at 9:04 AM Limonciello, Mario wrote: > > [Public] > > > > > -Original Message- > > From: Mahapatra, Rajib > > Sent: Thursday, February 10, 2022 07:35 > > To: Liang, Prike ; Limonciello, Mario > > ; Deucher, Alexander > > > > Cc: amd-gfx@lists.freedesktop.org; S, Shir

Re: [Patch V2] drm/amdgpu: Handle the GPU recovery failure in SRIOV environment.

Reviewed-by: Andrey Grodzovsky Andrey On 2022-02-03 21:45, Surbhi Kakarya wrote: This patch handles the GPU recovery failure in sriov environment by retrying the reset if the first reset fails. To determine the condition of retry, a new macro AMDGPU_RETRY_SRIOV_RESET is added which returns tru

RE: [PATCH v2] drm/amdgpu: skipping SDMA hw_init and hw_fini for S0ix.

[Public] > -Original Message- > From: Alex Deucher > Sent: Thursday, February 10, 2022 09:28 > To: Limonciello, Mario > Cc: Mahapatra, Rajib ; Liang, Prike > ; Deucher, Alexander ; > amd-gfx@lists.freedesktop.org; S, Shirish > Subject: Re: [PATCH v2] drm/amdgpu: skipping SDMA hw_init

[PATCH] drm/amdgpu: Add unique_id support for sienna cichlid

This is being added to SMU Metrics, so add the required tie-ins in the kernel. Also create the corresponding unique_id sysfs file. Signed-off-by: Kent Russell --- drivers/gpu/drm/amd/pm/amdgpu_pm.c| 3 +- .../pmfw_if/smu11_driver_if_sienna_cichlid.h | 12 +-- .../amd/pm/swsmu/s

Re: [PATCH v2] drm/amdgpu: skipping SDMA hw_init and hw_fini for S0ix.

On Thu, Feb 10, 2022 at 10:42 AM Limonciello, Mario wrote: > > [Public] > > > > > -Original Message- > > From: Alex Deucher > > Sent: Thursday, February 10, 2022 09:28 > > To: Limonciello, Mario > > Cc: Mahapatra, Rajib ; Liang, Prike > > ; Deucher, Alexander ; > > amd-gfx@lists.freedesk

Re: [PATCH 2/2] drm/amdgpu: add reset register trace function on GPU reset

On Thu, Feb 10, 2022 at 9:11 AM Sharma, Shashank wrote: > > > > On 2/10/2022 3:05 PM, Christian König wrote: > > Am 10.02.22 um 14:18 schrieb Sharma, Shashank: > >> > >> > >> On 2/10/2022 8:38 AM, Christian König wrote: > >>> Am 10.02.22 um 08:34 schrieb Somalapuram, Amaranath: > > On 2/

RE: [PATCH v2] drm/amdgpu: skipping SDMA hw_init and hw_fini for S0ix.

[Public] > > VG doesn't do s0i3 right? > > Right. > > > No, YC should not take a similar fix.YC had an architectural change and > > to > > avoid a "similar" problem takes > 26db706a6d77b9e184feb11725e97e53b7a89519. > > Isn't that likely just a workaround for the same issue? This seems cle

Re: [PATCH v11 1/5] drm: improve drm_buddy_alloc function

On 27/01/2022 14:11, Arunpravin wrote: - Make drm_buddy_alloc a single function to handle range allocation and non-range allocation demands - Implemented a new function alloc_range() which allocates the requested power-of-two block comply with range limitations - Moved order computation a

Re: [PATCH v2] drm/amdgpu: skipping SDMA hw_init and hw_fini for S0ix.

On Thu, Feb 10, 2022 at 11:08 AM Limonciello, Mario wrote: > > [Public] > > > > VG doesn't do s0i3 right? > > > > Right. > > > > > No, YC should not take a similar fix.YC had an architectural change > > > and to > > > avoid a "similar" problem takes > > 26db706a6d77b9e184feb11725e97e53b7a8951

Upstream This Patch

[AMD Official Use Only] >From 488cc792021a60300df3659de204ebef954ba2bb Mon Sep 17 00:00:00 2001 From: Oliver Logush ollog...@amd.com Date: Wed, 9 Feb 2022 14:25:13 -0500 Subject: [PATCH] drm/amd/display: extend dcn201 support Signed-off-by: Oliver Logush ollog...@amd.com<

Re: Upstream This Patch

Subject is wrong. Should be: drm/amd/display: extend dcn201 support On Thu, Feb 10, 2022 at 11:53 AM Logush, Oliver wrote: > > [AMD Official Use Only] > > > From 488cc792021a60300df3659de204ebef954ba2bb Mon Sep 17 00:00:00 2001 > > From: Oliver Logush ollog...@amd.com > > Date: Wed, 9 Feb 2022 1

[PATCH] drm/amdkfd: fix loop error handling

From: Tom Rix Clang static analysis reports this problem kfd_chardev.c:2594:16: warning: The expression is an uninitialized value. The computed value will also be garbage while (ret && i--) { ^~~ i is a loop variable and this block unwinds a problem in the loop. W

[PATCH] amdgpu/pm: Disable managing hwmon sysfs attributes for ONEVF mode

This patch prohibits performing of set commands on all hwmon attributes through sysfs in ONEVF mode. Signed-off-by: Danijel Slivka --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm

Re: start sorting out the ZONE_DEVICE refcount mess v2

Christoph, Thanks a lot for rebase our patches. I just ran our amdgpu hmm-tests with this series and all passed. Regards, Alex Sierra On 2/10/2022 1:28 AM, Christoph Hellwig wrote: Hi all, this series removes the offset by one refcount for ZONE_DEVICE pages that are freed back to the driver

Re: [PATCH v11 5/5] drm/amdgpu: add drm buddy support to amdgpu

On 08/02/2022 11:20, Arunpravin wrote: On 04/02/22 6:53 pm, Christian König wrote: Am 04.02.22 um 12:22 schrieb Arunpravin: On 28/01/22 7:48 pm, Matthew Auld wrote: On Thu, 27 Jan 2022 at 14:11, Arunpravin wrote: - Remove drm_mm references and replace with drm buddy functionalities - Add r

[PATCH] drm/amd/display: extend dcn201 support

[AMD Official Use Only] >From 488cc792021a60300df3659de204ebef954ba2bb Mon Sep 17 00:00:00 2001 From: Oliver Logush ollog...@amd.com Date: Wed, 9 Feb 2022 14:25:13 -0500 Subject: [PATCH] drm/amd/display: extend dcn201 support Signed-off-by: Oliver Logush ollog...@amd.com<

Re: [PATCH] drm/amdkfd: fix loop error handling

Am 2022-02-10 um 12:04 schrieb t...@redhat.com: From: Tom Rix Clang static analysis reports this problem kfd_chardev.c:2594:16: warning: The expression is an uninitialized value. The computed value will also be garbage while (ret && i--) { ^~~ i is a loop var

Re: [PATCH 6/8] mm: don't include in

Am 2022-02-09 um 12:48 schrieb Christoph Hellwig: On Mon, Feb 07, 2022 at 04:19:29PM -0500, Felix Kuehling wrote: Am 2022-02-07 um 01:32 schrieb Christoph Hellwig: Move the check for the actual pgmap types that need the free at refcount one behavior into the out of line helper, and thus avoid

[PATCH v2 3/9] PCI: drop `is_thunderbolt` attribute

The `is_thunderbolt` attribute is currently a dumping ground for a variety of things. Instead use the driver core removable attribute to indicate the detail a device is attached to a thunderbolt or USB4 chain. Signed-off-by: Mario Limonciello --- drivers/pci/pci.c | 2 +- drive

[PATCH v2 0/9] Overhaul is_thunderbolt

Various drivers in the kernel use `is_thunderbolt` or `pci_is_thunderbolt_attached` to designate behaving differently from a device that is internally in the machine. This relies upon checks for a specific capability only set on Intel controllers. Non-Intel USB4 designs should also match this desi

[PATCH v2 2/9] PCI: Move `is_thunderbolt` check for lack of command completed to a quirk

The `is_thunderbolt` check is currently used to indicate the lack of command completed support for a number of older Thunderbolt devices. This however is heavy handed and should have been done via a quirk. Move the affected devices outlined in commit 493fb50e958c ("PCI: pciehp: Assume NoCompl+ fo

[PATCH v2 4/9] PCI: mark USB4 devices as removable

USB4 class devices are also removable like Intel Thunderbolt devices. Drivers of downstream devices use this information to declare functional differences in how the drivers perform by knowing that they are connected to an upstream TBT/USB4 port. Signed-off-by: Mario Limonciello --- drivers/pci

[PATCH v2 5/9] drm/amd: drop the use of `pci_is_thunderbolt_attached`

Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. The PCI core now marks such devices as removable and downstream drivers can use this instead. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- drivers/gpu/drm/amd/am

[PATCH v2 1/9] thunderbolt: move definition of PCI_CLASS_SERIAL_USB_USB4

This PCI class definition of the USB4 device is currently located only in the thunderbolt driver. It will be needed by a few other drivers for upcoming changes. Move it into the common include file. Acked-by: Alex Deucher Signed-off-by: Mario Limonciello --- drivers/thunderbolt/nhi.h | 2 -- i

[PATCH v2 8/9] platform/x86: amd-gmux: drop the use of `pci_is_thunderbolt_attached`

Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. The PCI core now marks such devices as removable and downstream drivers can use this instead. Signed-off-by: Mario Limonciello --- drivers/platform/x86/apple-gmux.c | 2 +- 1 file changed, 1 insertion(

[PATCH v2 9/9] PCI: drop `pci_is_thunderbolt_attached`

Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. As all drivers now look at the removable attribute, drop this function. Signed-off-by: Mario Limonciello --- include/linux/pci.h | 22 -- 1 file changed, 22 deletions(-) diff --git

[PATCH v2 6/9] drm/nouveau: drop the use of `pci_is_thunderbolt_attached`

Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. The PCI core now marks such devices as removable and downstream drivers can use this instead. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/nouveau/nouveau_vga.c | 4 ++-- 1 file changed, 2 inse

[PATCH v2 7/9] drm/radeon: drop the use of `pci_is_thunderbolt_attached`

Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. The PCI core now marks such devices as removable and downstream drivers can use this instead. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/radeon/radeon_device.c | 4 ++-- drivers/gpu/drm/radeo

RE: [PATCH] drm/amdgpu: no rlcg read access in SRIOV case for gfx v9

[Public] Hi Victor, I thought about that before sending the patch, as there is indeed a hack in gfx9 old code. So my idea is not to impact asics with gfx10, so add the check in the caller. Anyway, I will double verify your suggestion on ASICs with gfx10. If it's fine, I will submit a v2 patch

RE: [PATCH] drm/amdgpu: add support for GC 10.1.4

[Public] Reviewed-by: Huang Rui From: Deucher, Alexander Sent: Thursday, February 10, 2022 10:57 PM To: Yu, Lang ; amd-gfx@lists.freedesktop.org Cc: Huang, Ray Subject: Re: [PATCH] drm/amdgpu: add support for GC 10.1.4 [Public] Reviewed-by: Alex Deucher mailto:alexander.deuc...@amd.com>> _

[PATCH] drm/amdkfd: CRIU fix extra whitespace and block comment warnings

Fix checkpatch reported warning for a quoted line and block line comments. Signed-off-by: Rajneesh Bhardwaj --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm

[PATCH] drm/amdkfd: Fix prototype warning for get_process_num_bos

Fix the warning: no previous prototype for 'get_process_num_bos' [-Wmissing-prototypes] Reported-by: kernel test robot Signed-off-by: Rajneesh Bhardwaj --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd

RE: [PATCH] drm/amdgpu: Add unique_id support for sienna cichlid

[AMD Official Use Only] If this is only available with the latest pmfw, you might need to add some version guard there. Otherwise, garbage data might be got with latest driver + old pmfw. Also, the "metrics_lock" was already dropped from latest drm-next. So, it seems you worked with an outdated

[PATCH] drm/amdgpu: no rlcg legacy read in SRIOV case

rlcg legacy read is not available in SRIOV configration. Otherwise, gmc_v9_0_flush_gpu_tlb will always complain timeout and finally breaks driver load. v2: bypass read in amdgpu_virt_get_rlcg_reg_access_flag (from Victor) Fixes: 0dc4a7e75581("drm/amdgpu: switch to get_rlcg_reg_access_flag for gfx

RE: [PATCH v2] drm/amdgpu: skipping SDMA hw_init and hw_fini for S0ix.

> -Original Message- > From: Limonciello, Mario > Sent: Friday, February 11, 2022 12:09 AM > To: Alex Deucher ; Liang, Prike > > Cc: Mahapatra, Rajib ; Deucher, Alexander > ; amd-gfx@lists.freedesktop.org; S, Shirish > > Subject: RE: [PATCH v2] drm/amdgpu: skipping SDMA hw_init and hw_

RE: [PATCH] drm/amdgpu: no rlcg legacy read in SRIOV case

[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Chen, Guchun Sent: Friday, February 11, 2022 13:39 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Zhou, Peng Ju ; Koenig, Christian ; Deucher, Alexander ; Skvortsov, Victor Cc: Chen,

[PATCH Review 1/1] drm/amdgpu: Reset OOB table error count info

The OOB table error count info should be reset after reset eeprom table Change-Id: I2a39e0e44b7b1a5ab7d6b4d4b73ebe48264396b7 Signed-off-by: Stanley.Yang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras

RE: [PATCH Review 1/1] drm/amdgpu: Reset OOB table error count info

[AMD Official Use Only] Reviewed-by: Tao Zhou > -Original Message- > From: Stanley.Yang > Sent: Friday, February 11, 2022 3:04 PM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking > ; Clements, John ; > Zhou1, Tao > Cc: Yang, Stanley > Subject: [PATCH Review 1/1] drm/amdgpu: Reset O

[PATCH 01/12] drm/amd/pm: drop unused structure members

Drop those members which get never used. Signed-off-by: Evan Quan Change-Id: Iec70ad1dfe2059be26843f378588e6c894e9cae8 --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h b/drivers/gpu/drm/amd/pm/sw

[PATCH 02/12] drm/amd/pm: drop unused interfaces

Drop those interfaces which never get used. Signed-off-by: Evan Quan Change-Id: Ia22d395145a1003faca5ac792dca6a30ef2cae54 --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 13 - drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 5 drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 4

[PATCH 03/12] drm/amd/pm: drop unneeded !smu->pm_enabled check

As smu->pm_enabled is a prerequisite for adev->pm.dpm_enabled. So, with adev->pm.dpm_enabled set, it can be guarded that smu->pm_enabled is also set. Thus the extra check for "!smu->pm_enabled" is totally unnecessary. Signed-off-by: Evan Quan Change-Id: I6ff67137d447e6a3d8cc627b397428fed22753f3 -

[PATCH 04/12] drm/amd/pm: use adev->pm.dpm_enabled for dpm enablement check

adev->pm.dpm_enabled instead of hwmgr->pm_en can better reflect whether the dpm features are actually enabled. Signed-off-by: Evan Quan Change-Id: I6896dcee19bb473d26115cdcb12b6efd554b30f9 --- drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c| 39 +++--- drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c

[PATCH 05/12] drm/amd/pm: move the check for dpm enablement to amdgpu_dpm.c

Instead of checking this in every instance(framework), moving that check to amdgpu_dpm.c is more proper. And that can make code clean and tidy. Signed-off-by: Evan Quan Change-Id: I2f83a3b860e8aa12cc86f119011f520fbe21a301 --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 5 +- drivers/gpu/dr

[PATCH 08/12] drm/amd/pm: add proper check for amdgpu_dpm before granting pp_dpm_load_fw

Make sure the interface get granted only when amdgpu_dpm enabled. Signed-off-by: Evan Quan Change-Id: Ia1d1123470fab89b41b24ea80dcb319570aa7438 --- drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 6 ++ drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c | 3 --- 2 files changed, 6 insertions

[PATCH 06/12] drm/amd/pm: correct the checks for sriov(pp_one_vf)

By setting pm_enabled as false for non pp_one_vf sriov case, we can avoid the check for (amdgpu_sriov_vf(adev) && !amdgpu_sriov_is_pp_one_vf(adev)) in every routine. Signed-off-by: Evan Quan Change-Id: I3859529183cd26dce98c57dc87eab5273ecc949b --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 21 +

[PATCH 07/12] drm/amd/pm: correct the checks for granting gpu reset APIs

Those gpu reset APIs can be granted when: - System is up and dpm features are enabled. - System is under resuming and dpm features are not yet enabled. Under such scenario, the PMFW is already alive and can support those gpu reset functionalities. Signed-off-by: Evan Quan Change-Id: I

[PATCH 09/12] drm/amd/pm: drop redundant !pp_funcs check

As it can be covered by the "!adev->pm.dpm_enabled" check. As long as "adev->pm.dpm_enabled != NULL", "pp_funcs != NULL" can be also guarded. Signed-off-by: Evan Quan Change-Id: Iec801f18a0069ad5fd384c4133016977fb2b67e8 --- drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 22 ++ 1 file

[PATCH 10/12] drm/amd/pm: drop nonsense !smu->ppt_funcs check

Since the "smu->ppt_funcs" was already well installed at early_init phase, the checks afterwards make nonsense. Signed-off-by: Evan Quan Change-Id: I07a945035a87b23032e4911bba768edacbd5e65a --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 20 +--- drivers/gpu/drm/amd/pm/swsmu/sm

[PATCH 11/12] drm/amd/pm: drop extra non-necessary null pointers checks

They are totally redundant. The checks before them can guard they cannot be NULL. Signed-off-by: Evan Quan Change-Id: I9f31734f49a8093582fc321ef3d93233946006e3 --- .../gpu/drm/amd/pm/powerplay/amd_powerplay.c | 182 ++ .../amd/pm/powerplay/hwmgr/hardwaremanager.c | 42 ..

[PATCH 12/12] drm/amd/pm: revise the implementations for asic reset

Instead of having an interface for every reset method, we replace them with a new interface which can support all reset methods. Signed-off-by: Evan Quan Change-Id: I4c8a7121dd65c2671085673dd7c13cf7e4286f3d --- drivers/gpu/drm/amd/amdgpu/aldebaran.c| 2 +- drivers/gpu/drm/amd/amdgpu/am

Re: [PATCH 01/12] drm/amd/pm: drop unused structure members

Nice cleanup. Can't say much about the rest, but this patch and patch #2 are Reviewed-by: Christian König Regards, Christian. Am 11.02.22 um 08:51 schrieb Evan Quan: Drop those members which get never used. Signed-off-by: Evan Quan Change-Id: Iec70ad1dfe2059be26843f378588e6c894e9cae8 ---