RE: [PATCH] drm/amdgpu: Add judgement to avoid infinite loop

2022-01-29 Thread Chai, Thomas
It have solution to solve this defect, I am debugging the modifications. -Original Message- From: Zhou1, Tao Sent: Saturday, January 29, 2022 3:54 PM To: Chai, Thomas ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Clements, John Subject: RE: [PATCH] drm/amdgpu: Add judgement t

[PATCH 2/2] drm/radeon/uvd: Fix forgotten unmap buffer objects

2022-01-29 Thread zhanglianjie
after the buffer object is successfully mapped, call radeon_bo_kunmap before the function returns. Signed-off-by: zhanglianjie diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c index 377f9cdb5b53..c5482f7793db 100644 --- a/drivers/gpu/drm/radeon/radeon_uvd.

[PATCH -next] drm/amd/display: clean up some inconsistent indenting

2022-01-29 Thread Yang Li
Eliminate the follow smatch warning: drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c:2246 dp_perform_8b_10b_link_training() warn: inconsistent indenting Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 10 +- 1 file changed, 5 inser

[PATCH v2] drm/amd/display: Force link_rate as LINK_RATE_RBR2 for 2018 15" Apple Retina panels

2022-01-29 Thread Aditya Garg
From: Aun-Ali Zaidi The eDP link rate reported by the DP_MAX_LINK_RATE dpcd register (0xa) is contradictory to the highest rate supported reported by EDID (0xc = LINK_RATE_RBR2). The effects of this compounded with commit '4a8ca46bae8a ("drm/amd/display: Default max bpc to 16 for eDP")' results

[PATCH 1/2] drm/amd/amdgpu/amdgpu_uvd: Fix forgotten unmap buffer object

2022-01-29 Thread zhanglianjie
after the buffer object is successfully mapped, call amdgpu_bo_kunmap before the function returns. Signed-off-by: zhanglianjie diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c index 6f8de11a17f1..9cc23b220537 100644 --- a/drivers/gpu/drm/amd/amdgpu

Re: [PATCH RESEND] drm/amd/display: Force link_rate as LINK_RATE_RBR2 for 2018 15" Apple Retina panels

2022-01-29 Thread Aditya Garg
> On 28-Jan-2022, at 8:33 PM, Harry Wentland wrote: > > I think either leaving the 2017 quirk in its original place or moving it down > works. I don't have a strong preference. I’d better leave it in the original place then > > With the comment style addressed this patch is Sending a v2 now w

[PATCH 1/2] drm/amdgpu: Fixed the defect of soft lock caused by infinite loop

2022-01-29 Thread yipechai
1. The infinite loop case only occurs on multiple cards support ras functions. 2. The explanation of root cause refer to 76641cbbf196523b5752c6cf68f86. 3. Create new node to manage each unique ras instance to guarantee each device .ras_list is completely independent. 4. Fixes:7a6b8ab3231b5119

[PATCH 2/2] Revert "drm/amdgpu: Add judgement to avoid infinite loop"

2022-01-29 Thread yipechai
The commit 8583c8983f1b ("drm/amdgpu: Fixed the defect of soft lock caused by infinite loop") had fixed this defect. Revert workaround commit 76641cbbf196 ("drm/amdgpu: Add judgement to avoid infinite loop"). Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 1 file c

RE: [PATCH] drm/amdgpu: Fix uninitialized variable use warning

2022-01-29 Thread Chen, Guchun
[Public] Reviewed-by: Guchun Chen Hi @Lijo Lazar, Can you pls submit your patch to drm-next soon? This indeed fixs the regession by rlc indiect reg access related patches. Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Friday, January 28, 2022 2:40 PM

RE: [PATCH 1/2] drm/amdgpu: Fixed the defect of soft lock caused by infinite loop

2022-01-29 Thread Zhou1, Tao
[AMD Official Use Only] > -Original Message- > From: Chai, Thomas > Sent: Saturday, January 29, 2022 8:34 PM > To: amd-gfx@lists.freedesktop.org > Cc: Chai, Thomas ; Zhang, Hawking > ; Zhou1, Tao ; Clements, > John ; Chai, Thomas > Subject: [PATCH 1/2] drm/amdgpu: Fixed the defect of s

RE: [PATCH 1/2] drm/amdgpu: Fixed the defect of soft lock caused by infinite loop

2022-01-29 Thread Chai, Thomas
OK -Original Message- From: Zhou1, Tao Sent: Sunday, January 30, 2022 11:20 AM To: Chai, Thomas ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Clements, John Subject: RE: [PATCH 1/2] drm/amdgpu: Fixed the defect of soft lock caused by infinite loop [AMD Official Use Only] >

[PATCH V2 1/2] drm/amdgpu: Fixed the defect of soft lock caused by infinite loop

2022-01-29 Thread yipechai
1. The infinite loop case only occurs on multiple cards support ras functions. 2. The explanation of root cause refer to commit 76641cbbf196 ("drm/amdgpu: Add judgement to avoid infinite loop"). 3. Create new node to manage each unique ras instance to guarantee each device .ras_list is com

[PATCH V2 2/2] Revert "drm/amdgpu: Add judgement to avoid infinite loop"

2022-01-29 Thread yipechai
The commit 8583c8983f1b ("drm/amdgpu: Fixed the defect of soft lock caused by infinite loop") had fixed this defect. Revert workaround commit 76641cbbf196 ("drm/amdgpu: Add judgement to avoid infinite loop"). Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 1 file c

RE: [PATCH V2 1/2] drm/amdgpu: Fixed the defect of soft lock caused by infinite loop

2022-01-29 Thread Zhou1, Tao
[AMD Official Use Only] The series is: Reviewed-by: Tao Zhou -Original Message- > From: Chai, Thomas > Sent: Sunday, January 30, 2022 3:12 PM > To: amd-gfx@lists.freedesktop.org > Cc: Chai, Thomas ; Zhang, Hawking > ; Zhou1, Tao ; Clements, > John ; Chai, Thomas > Subject: [PATCH V2 1/

[PATCH] drm/amdgpu: fix list add issue in vram reserve

2022-01-29 Thread Tao Zhou
The parameter order in the list_add_tail is incorrect, it causes the reuse of ras reserved page. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c b/drivers/gp

[PATCH] drm/amdkfd: use unmap all queues for poison consumption

2022-01-29 Thread Tao Zhou
Replace reset queue for specific PASID with unmap all queues, reset queue could break CP scheduler. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c b