On 01/24/ , Lazar, Lijo wrote:
>
>
> On 1/24/2022 12:13 PM, Lang Yu wrote:
> > Some clients(e.g., kfd) query sclk/mclk through this function.
> >
> > Before this patch:
> > # /opt/rocm/opencl/bin/clinfo
> >
> > Max clock frequency: 0Mhz
> >
> > After this patch:
>
On 1/24/2022 1:48 PM, Lang Yu wrote:
On 01/24/ , Lazar, Lijo wrote:
On 1/24/2022 12:13 PM, Lang Yu wrote:
Some clients(e.g., kfd) query sclk/mclk through this function.
Before this patch:
# /opt/rocm/opencl/bin/clinfo
Max clock frequency: 0Mhz
After this
Some clients(e.g., kfd) query sclk/mclk through this function.
Because cyan skillfish don't support dpm. For sclk, set min/max
to CYAN_SKILLFISH_SCLK_MIN/CYAN_SKILLFISH_SCLK_MAX(to maintain the
existing logic).For others, set both min and max to current value.
Before this patch:
# /opt/rocm/openc
On 1/24/2022 2:42 PM, Lang Yu wrote:
Some clients(e.g., kfd) query sclk/mclk through this function.
Because cyan skillfish don't support dpm. For sclk, set min/max
to CYAN_SKILLFISH_SCLK_MIN/CYAN_SKILLFISH_SCLK_MAX(to maintain the
existing logic).For others, set both min and max to current val
[why]
pm sysfs should be writable in one VF mode as is in passthrough
[how]
do not remove write access on pm sysfs if device is in one VF mode
Fixes: 4436ea3c43a7 ("amdgpu/pm: Make sysfs pm attributes as read-only for VFs")
Signed-off-by: Yiqing Yao
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 ++
From: Ira Weiny
kmap() is being deprecated and these instances are easy to convert to
kmap_local_page().
Furthermore, in gma_crtc_cursor_set() use the memcpy_from_page() helper
instead of an open coded use of kmap_local_page().
Signed-off-by: Ira Weiny
---
drivers/gpu/drm/gma500/gma_display.c
Hi Lijo,
> Could you provide the pp_dpm_* values in sysfs with and without the
> patch? Also, could you try forcing PCIE to gen3 (through pp_dpm_pcie)
> if it's not in gen3 when the issue happens?
AFAICT, I can't access those values while the AMD GPU PCI devices are
bound to `vfio-pci`. However,
From: Ira Weiny
kmap() is being deprecated. These maps are thread local and can be
replaced with kmap_local_page().
Replace kmap() with kmap_local_page()
Signed-off-by: Ira Weiny
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff -
From: Ira Weiny
kmap() is being deprecated. So this comment could be misleading in the
future.
Change this comment to point to using kmap_local_page(). While here
remove 'we' from the comment.
Signed-off-by: Ira Weiny
---
drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++--
1 file changed, 2 inse
From: Ira Weiny
The default case leaves the buffer object mapped in error.
Add amdgpu_bo_kunmap() to that case to ensure the mapping is cleaned up.
Signed-off-by: Ira Weiny
---
NOTE: It seems like this function could use a fair bit of refactoring
but this is the easiest way to fix the actual
From: Ira Weiny
Changes from V1:
Use memcpy_to_page() where appropriate
Rebased to latest
The kmap() call may cause issues with work being done with persistent memory.
For this and other reasons it is being deprecated.
This series starts by converting the last easy kmap() uses i
From: Ira Weiny
kmap() is being deprecated and this usage is local to the thread. Use
kmap_local_page() instead.
Signed-off-by: Ira Weiny
---
drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c
b/driv
From: Tom Rix
The enum MIGRATION_COPY_DIR type has 2 values. So
the else-if can be converted to an else.
Signed-off-by: Tom Rix
---
drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
b/driver
From: Ira Weiny
The default case leaves the buffer object mapped in error.
Add radeon_bo_kunmap() to that case to ensure the mapping is cleaned up.
Signed-off-by: Ira Weiny
---
NOTE: It seems like this function could use a fair bit of refactoring
but this is the easiest way to fix the actual
From: Ira Weiny
kmap() is being deprecated and these usages are all local to the thread
so there is no reason kmap_local_page() can't be used.
Replace kmap() calls with kmap_local_page().
Signed-off-by: Ira Weiny
---
Changes for V2:
From Christoph Helwig
Prefer the use of memc
On Sun, 23 Jan 2022, Geert Uytterhoeven wrote:
Below is the list of build error/warning regressions/improvements in
v5.17-rc1[1] compared to v5.16[2].
Summarized:
- build errors: +17/-2
- build warnings: +23/-25
Note that there may be false regressions, as some logs are incomplete.
Still, the
On 01/24/ , Lazar, Lijo wrote:
>
>
> On 1/24/2022 2:42 PM, Lang Yu wrote:
> > Some clients(e.g., kfd) query sclk/mclk through this function.
> > Because cyan skillfish don't support dpm. For sclk, set min/max
> > to CYAN_SKILLFISH_SCLK_MIN/CYAN_SKILLFISH_SCLK_MAX(to maintain the
> > existing logi
Am 24.01.22 um 02:54 schrieb ira.we...@intel.com:
From: Ira Weiny
Changes from V1:
Use memcpy_to_page() where appropriate
Rebased to latest
The kmap() call may cause issues with work being done with persistent memory.
For this and other reasons it is being deprecated.
I'm rea
From: Tom Rix
clang static analysis reports this represenative problem
amdgpu_smu.c:144:18: warning: The left operand of '*' is a garbage value
return clk_freq * 100;
^
If there is no get_dpm_ultimate_freq function,
smu_get_dpm_freq_range returns success without s
[AMD Official Use Only]
Hi all,
This week this patchset was tested on the following systems:
Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display
types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C
to DP/HDMI), 1680*1050 60hz (via USB-C to D
Some clients(e.g., kfd) query sclk/mclk through this function.
Because cyan skillfish doesn't support dpm. For sclk, set min/max
to CYAN_SKILLFISH_SCLK_MIN/CYAN_SKILLFISH_SCLK_MAX(to maintain the
existing logic).For others, set both min and max to current value.
Before this patch:
# /opt/rocm/ope
This breaks HDMI audio.
This reverts commit 9413b23fadad3861f5afd626ac44ef83ad8068ab.
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1536
Signed-off-by: Alex Deucher
Cc: Martin Tsai
Cc: Bindu Ramamurthy
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 8 +++-
1 file changed, 7
[Public]
Not able to relate to how it affects gfx/mem DPM alone. Unless Alex has other
ideas, would you be able to enable drm debug messages and share the log?
Enabling verbose debug messages is done through the drm.debug
parameter, each category being enabled by a bit:
drm.deb
On 1/24/2022 7:22 PM, t...@redhat.com wrote:
From: Tom Rix
clang static analysis reports this represenative problem
amdgpu_smu.c:144:18: warning: The left operand of '*' is a garbage value
return clk_freq * 100;
^
If there is no get_dpm_ultimate_freq functi
On 1/24/2022 7:46 PM, Lang Yu wrote:
Some clients(e.g., kfd) query sclk/mclk through this function.
Because cyan skillfish doesn't support dpm. For sclk, set min/max
to CYAN_SKILLFISH_SCLK_MIN/CYAN_SKILLFISH_SCLK_MAX(to maintain the
existing logic).For others, set both min and max to current v
On 2022-01-21 20:23, Randy Dunlap wrote:
> Change a static function's comment from "/**" (indicating kernel-doc
> notation) to "/*" (indicating a regular C language comment).
> This prevents multiple kernel-doc warnings:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:4343: warnin
On Sun, Jan 23, 2022 at 05:54:05PM -0800, ira.we...@intel.com wrote:
> From: Ira Weiny
>
> kmap() is being deprecated and these instances are easy to convert to
> kmap_local_page().
>
> Furthermore, in gma_crtc_cursor_set() use the memcpy_from_page() helper
> instead of an open coded use of kmap
You probably can add the STB dump we worked on a while ago to your info
dump - a reminder
on the feature is here https://www.spinics.net/lists/amd-gfx/msg70751.html
Andrey
On 2022-01-21 15:34, Sharma, Shashank wrote:
From 899ec6060eb7d8a3d4d56ab439e4e6cdd74190a4 Mon Sep 17 00:00:00 2001
From:
Hey Andrey,
That seems like a good idea, may I know if there is a trigger for STB
dump ? or is it just the infrastructure which one can use when they feel
a need to dump info ? Also, how reliable is the STB infra during a reset ?
Regards
Shashank
On 1/24/2022 5:32 PM, Andrey Grodzovsky wrote:
Hello Christian,
Thank for your comments, please fine mine inline:
On 1/24/2022 8:15 AM, Christian König wrote:
Am 21.01.22 um 21:34 schrieb Sharma, Shashank:
From 1c5c552eeddaffd9fb3e7d45ece1b2b28fccc575 Mon Sep 17 00:00:00 2001
From: Somalapuram Amaranath
Date: Fri, 21 Jan 2022 14:19:10 +053
On 1/24/2022 8:17 AM, Christian König wrote:
Am 21.01.22 um 21:37 schrieb Sharma, Shashank:
From c598dd586dd15fc5ae0a883a2e6f4094ec024085 Mon Sep 17 00:00:00 2001
From: Shashank Sharma
Date: Fri, 21 Jan 2022 17:33:10 +0100
Subject: [PATCH 2/4] drm/amdgpu: add work function for GPU reset
Thi
Am 24.01.22 um 17:45 schrieb Sharma, Shashank:
Hello Christian,
Thank for your comments, please fine mine inline:
On 1/24/2022 8:15 AM, Christian König wrote:
Am 21.01.22 um 21:34 schrieb Sharma, Shashank:
From 1c5c552eeddaffd9fb3e7d45ece1b2b28fccc575 Mon Sep 17 00:00:00 2001
From: Somalapuram
Am 24.01.22 um 17:46 schrieb Sharma, Shashank:
On 1/24/2022 8:17 AM, Christian König wrote:
Am 21.01.22 um 21:37 schrieb Sharma, Shashank:
From c598dd586dd15fc5ae0a883a2e6f4094ec024085 Mon Sep 17 00:00:00 2001
From: Shashank Sharma
Date: Fri, 21 Jan 2022 17:33:10 +0100
Subject: [PATCH 2/4
On 1/24/2022 8:18 AM, Christian König wrote:
Am 21.01.22 um 21:34 schrieb Sharma, Shashank:
From 899ec6060eb7d8a3d4d56ab439e4e6cdd74190a4 Mon Sep 17 00:00:00 2001
From: Somalapuram Amaranath
Date: Fri, 21 Jan 2022 14:19:42 +0530
Subject: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handle
On 1/24/2022 5:49 PM, Christian König wrote:
Am 24.01.22 um 17:46 schrieb Sharma, Shashank:
On 1/24/2022 8:17 AM, Christian König wrote:
Am 21.01.22 um 21:37 schrieb Sharma, Shashank:
From c598dd586dd15fc5ae0a883a2e6f4094ec024085 Mon Sep 17 00:00:00 2001
From: Shashank Sharma
Date: Fri
Acked-by: Alex Deucher
On Mon, Jan 24, 2022 at 1:45 AM Victor Zhao wrote:
>
> add determine for passthrough mode under arm64 by reading
> CurrentEL register
>
> Signed-off-by: Victor Zhao
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
On 1/24/2022 5:48 PM, Christian König wrote:
Am 24.01.22 um 17:45 schrieb Sharma, Shashank:
Hello Christian,
Thank for your comments, please fine mine inline:
On 1/24/2022 8:15 AM, Christian König wrote:
Am 21.01.22 um 21:34 schrieb Sharma, Shashank:
From 1c5c552eeddaffd9fb3e7d45ece1b2b28f
On Sat, Jan 22, 2022 at 4:38 PM James Turner
wrote:
>
> Hi Lijo,
>
> > Could you provide the pp_dpm_* values in sysfs with and without the
> > patch? Also, could you try forcing PCIE to gen3 (through pp_dpm_pcie)
> > if it's not in gen3 when the issue happens?
>
> AFAICT, I can't access those valu
On Mon, 24 Jan 2022 08:55:40 +0100 (CET) Geert Uytterhoeven wrote:
> > + /kisskb/src/drivers/net/ethernet/freescale/fec_mpc52xx.c: error: passing
> > argument 2 of 'mpc52xx_fec_set_paddr' discards 'const' qualifier from
> > pointer target type [-Werror=discarded-qualifiers]: => 659:29
>
> po
Am 24.01.22 um 18:00 schrieb Sharma, Shashank:
On 1/24/2022 5:48 PM, Christian König wrote:
Am 24.01.22 um 17:45 schrieb Sharma, Shashank:
Hello Christian,
Thank for your comments, please fine mine inline:
On 1/24/2022 8:15 AM, Christian König wrote:
Am 21.01.22 um 21:34 schrieb Sharma,
It's just an infrastructure you use when you need.
I never tested it during reset i think but, we deliberately did it very
self reliant where you simply iterate a FIFO of the dump through PMI3
registers interface and dump out the content. It currently supposed to
work for the NV family.
In ca
On 1/24/2022 6:07 PM, Christian König wrote:
Am 24.01.22 um 18:00 schrieb Sharma, Shashank:
On 1/24/2022 5:48 PM, Christian König wrote:
Am 24.01.22 um 17:45 schrieb Sharma, Shashank:
Hello Christian,
Thank for your comments, please fine mine inline:
On 1/24/2022 8:15 AM, Christian Kön
On 1/24/2022 6:08 PM, Andrey Grodzovsky wrote:
It's just an infrastructure you use when you need.
I never tested it during reset i think but, we deliberately did it very
self reliant where you simply iterate a FIFO of the dump through PMI3
registers interface and dump out the content. It cur
On Mon, 24 Jan 2022 09:04:33 -0800 Jakub Kicinski wrote:
> On Mon, 24 Jan 2022 08:55:40 +0100 (CET) Geert Uytterhoeven wrote:
> > > + /kisskb/src/drivers/net/ethernet/freescale/fec_mpc52xx.c: error:
> > > passing argument 2 of 'mpc52xx_fec_set_paddr' discards 'const' qualifier
> > > from pointer
On Mon, 24 Jan 2022 12:04:18 -0500
Alex Deucher wrote:
> On Sat, Jan 22, 2022 at 4:38 PM James Turner
> wrote:
> >
> > Hi Lijo,
> >
> > > Could you provide the pp_dpm_* values in sysfs with and without the
> > > patch? Also, could you try forcing PCIE to gen3 (through pp_dpm_pcie)
> > > if it'
Newer hardware has a discovery table in hardware that the kernel will
rely on instead of header files for things like IP offsets. This
sysfs entry adds a simple to parse table of IP instances and segment
offsets.
Produces output that looks like:
$ cat ip_discovery_text
ATHUB{0} v2.0.0: 0c00
On Mon, Jan 24, 2022 at 01:08:26PM +0100, Christian König wrote:
> Am 24.01.22 um 02:54 schrieb ira.we...@intel.com:
> > From: Ira Weiny
> >
> > Changes from V1:
> > Use memcpy_to_page() where appropriate
> > Rebased to latest
> >
> > The kmap() call may cause issues with work being done
On Mon, Jan 24, 2022 at 5:25 AM Geert Uytterhoeven wrote:
>
> On Sun, 23 Jan 2022, Geert Uytterhoeven wrote:
> > Below is the list of build error/warning regressions/improvements in
> > v5.17-rc1[1] compared to v5.16[2].
> >
> > Summarized:
> > - build errors: +17/-2
> > - build warnings: +23/-2
[Why]
A porting error resulted in the stream assignment for the link
being retained without being released - a memory leak.
[How]
Fix the porting error by adding back the dc_stream_release() intended
as part of the original patch.
Fixes: 2e45b19dd882 ("drm/amd/display: retain/release at proper pl
Hi Alex,
On Mon, Jan 24, 2022 at 7:52 PM Alex Deucher wrote:
> On Mon, Jan 24, 2022 at 5:25 AM Geert Uytterhoeven
> wrote:
> > On Sun, 23 Jan 2022, Geert Uytterhoeven wrote:
> > > + /kisskb/src/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:
> > > error: control reaches end of non-void f
On 1/24/2022 12:57, Nicholas Kazlauskas wrote:
[Why]
A porting error resulted in the stream assignment for the link
being retained without being released - a memory leak.
[How]
Fix the porting error by adding back the dc_stream_release() intended
as part of the original patch.
Fixes: 2e45b19dd8
On 2022-01-24 13:57, Nicholas Kazlauskas wrote:
> [Why]
> A porting error resulted in the stream assignment for the link
> being retained without being released - a memory leak.
>
> [How]
> Fix the porting error by adding back the dc_stream_release() intended
> as part of the original patch.
>
>
Applied. Thanks!
Alex
On Mon, Jan 24, 2022 at 12:05 PM Zhou Qingyang wrote:
>
> In calculate_bandwidth(), the tag free_sclk and free_yclk are reversed,
> which could lead to a memory leak of yclk.
>
> Fix this bug by changing the location of free_sclk and free_yclk.
>
> This bug was found by a
Applied. Thanks!
Alex
On Mon, Jan 24, 2022 at 12:05 PM Zhou Qingyang wrote:
>
> In amdgpu_dm_connector_add_common_modes(), amdgpu_dm_create_common_mode()
> is assigned to mode and is passed to drm_mode_probed_add() directly after
> that. drm_mode_probed_add() passes &mode->head to list_add_tail
Applied the series. Thanks!
Alex
On Sun, Jan 23, 2022 at 7:23 PM Bas Nieuwenhuizen
wrote:
>
> Mirrors the logic for dcn30. Cue lots of WARNs and some
> kernel panics without this fix.
>
> Signed-off-by: Bas Nieuwenhuizen
> ---
> .../gpu/drm/amd/display/dc/dcn301/dcn301_resource.c | 11 +
On Fri, Jan 21, 2022 at 11:17 AM Eric Huang wrote:
>
> It is to meet the requirement for memory allocation
> optimization on MI50.
>
> Signed-off-by: Eric Huang
Assuming there is no firmware version requirement, the patch is:
Acked-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_chard
On 1/24/22 10:55, Geert Uytterhoeven wrote:
> Hi Alex,
>
> On Mon, Jan 24, 2022 at 7:52 PM Alex Deucher wrote:
>> On Mon, Jan 24, 2022 at 5:25 AM Geert Uytterhoeven
>> wrote:
>>> On Sun, 23 Jan 2022, Geert Uytterhoeven wrote:
+ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topol
From: Tom Rix
clang static analysis reports this represenative problem
amdgpu_smu.c:144:18: warning: The left operand of '*' is a garbage value
return clk_freq * 100;
^
If there is no get_dpm_ultimate_freq function,
smu_get_dpm_freq_range returns success without s
svm_deferred_list work should continue to handle deferred_range_list
which maybe split to child range to avoid child range leak, and remove
ranges mmu interval notifier to avoid mm mm_count leak. So taking mm
reference when adding range to deferred list, to ensure mm is valid in
the scheduled defer
kfd_process_notifier_release flush svm_range_restore_work
which calls svm_range_list_lock_and_flush_work to flush deferred_list
work, but if deferred_list work mmput release the last user, it will
call exit_mmap -> notifier_release, it is deadlock with below backtrace.
Move flush svm_range_restore
When we disable manual clock setting, we need to restore the cclks
as well as the gfxclk.
Signed-off-by: Alex Deucher
---
.../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 20 ++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vango
On 2022-01-24 09:17, Alex Deucher wrote:
> This breaks HDMI audio.
>
Do we have more info? This is DP code, but maybe the display is connected via a
DP-HDMI adapter? Or via a n MST or USB-C hub?
As Siqueira mentioned, we couldn't reproduce the issue and the original change
was intended to fix
Applied. Thanks!
Alex
On Mon, Jan 24, 2022 at 3:18 PM wrote:
>
> From: Tom Rix
>
> clang static analysis reports this represenative problem
> amdgpu_smu.c:144:18: warning: The left operand of '*' is a garbage value
> return clk_freq * 100;
> ^
>
> If there is no
Applied. Thanks!
Alex
On Mon, Jan 24, 2022 at 3:21 PM Nick Desaulniers
wrote:
>
> On Wed, Jan 19, 2022 at 2:46 PM Colin Ian King wrote:
> >
> > The pointer reg is being assigned a value that is not read, the
> > exit path via label 'out' never accesses it. The assignment is
> > redundant and c
Applied. Thanks!
Alex
On Mon, Jan 24, 2022 at 10:25 AM Harry Wentland wrote:
>
> On 2022-01-21 20:23, Randy Dunlap wrote:
> > Change a static function's comment from "/**" (indicating kernel-doc
> > notation) to "/*" (indicating a regular C language comment).
> > This prevents multiple kernel-d
Am 2022-01-24 um 16:11 schrieb Philip Yang:
svm_deferred_list work should continue to handle deferred_range_list
which maybe split to child range to avoid child range leak, and remove
ranges mmu interval notifier to avoid mm mm_count leak. So taking mm
reference when adding range to deferred list
Am 2022-01-24 um 14:11 schrieb Randy Dunlap:
On 1/24/22 10:55, Geert Uytterhoeven wrote:
Hi Alex,
On Mon, Jan 24, 2022 at 7:52 PM Alex Deucher wrote:
On Mon, Jan 24, 2022 at 5:25 AM Geert Uytterhoeven wrote:
On Sun, 23 Jan 2022, Geert Uytterhoeven wrote:
+ /kisskb/src/drivers/gpu/drm/a
I made a related fix for HDP flushing under SRIOV a while ago, and that
was confirmed to be working at the time. What changed since then? Is
this on different HW or with a different BIOS? Or are you missing this
patch? For reference:
commit 6295c4064d8d18c4480636076dbd5afb48885c02
Author: Feli
[AMD Official Use Only]
Acked-by: Evan Quan
> -Original Message-
> From: amd-gfx On Behalf Of Alex
> Deucher
> Sent: Tuesday, January 25, 2022 5:13 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: [PATCH] drm/amdgpu/smu11.5: restore cclks in
> vangogh_set_perf
Hello Laurent-san
Thank you for your reviews and advices.
I'll fix this patch series following your advice.
Thanks,
Esaki
On 2022/01/24 7:50, Laurent Pinchart wrote:
Hello Esaki-san,
On Fri, Jan 14, 2022 at 07:17:51PM +0900, Tomohito Esaki wrote:
If only linear modifier is advertised, since
[Why]
configure_dp_hpo_throttled_vcp_size() was missing promotion before, but it was
covered by
not calling the missing function hook in the old interface
hpo_dp_link_encoder->funcs.
Recent refactor replaces with new caller link_hwss->set_throttled_vcp_size
which needs that hook, and that causes
71 matches
Mail list logo
