Re: [Patch v3] drm/amdgpu: add vram check function for GMC

2022-01-16 Thread Huang Rui
On Fri, Jan 14, 2022 at 05:23:38PM +0800, Du, Xiaojian wrote: > This will add vram check function for GMC block. > It will write pattern data to the vram and then read back from the vram, > so that to verify the work status of vram. > This patch will cover gmc v6/7/8/9/10. > > Signed-off-by: Xiao

Re: [RFC PATH 1/3] drm: add support modifiers for drivers whose planes only support linear layout

2022-01-16 Thread Esaki Tomohito
Thank you for your reviews. On 2022/01/15 1:50, Daniel Vetter wrote: On Wed, Dec 22, 2021 at 02:27:25PM +0900, Tomohito Esaki wrote: The LINEAR modifier is advertised as default if a driver doesn't specify modifiers. However, there are legacy drivers such as radeon that do not support modifiers

Re: [RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout

2022-01-16 Thread Esaki Tomohito
Thank you for your reviews. On 2022/01/14 23:16, Andy Shevchenko wrote: On Fri, Jan 14, 2022 at 07:17:52PM +0900, Tomohito Esaki wrote: The LINEAR modifier is advertised as default if a driver doesn't specify modifiers. ... + const uint64_t default_modifiers[] = { + DRM_

[PATCH V2 1/7] drm/amd/pm: drop unneeded lock protection smu->mutex

2022-01-16 Thread Evan Quan
As all those APIs are already protected either by adev->pm.mutex or smu->message_lock. Signed-off-by: Evan Quan Change-Id: I1db751fba9caabc5ca1314992961d3674212f9b0 --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 315 ++ drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 1 -

[PATCH V2 2/7] drm/amd/pm: drop unneeded vcn/jpeg_gate_lock

2022-01-16 Thread Evan Quan
As those related APIs are already protected by adev->pm.mutex. Signed-off-by: Evan Quan Change-Id: I762fab96bb1c034c153b029f939ec6e498460007 -- v1->v2: - optimize the label for error exit(Guchun) --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 63 --- drivers/gpu/drm/amd/pm

[PATCH V2 3/7] drm/amd/pm: drop unneeded smu->metrics_lock

2022-01-16 Thread Evan Quan
As all those related APIs are already well protected by adev->pm.mutex and smu->message_lock. Signed-off-by: Evan Quan Change-Id: Ic75326ba7b4b67be8762d5407d02f6c514e1ad35 --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 1 - drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 1 - .../gpu/dr

[PATCH V2 4/7] drm/amd/pm: drop unneeded smu->sensor_lock

2022-01-16 Thread Evan Quan
As all those related APIs are already well protected by adev->pm.mutex and smu->message_lock. Signed-off-by: Evan Quan Change-Id: I20974b2ae68d63525bc7c7f406fede2971c5fecc --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 1 - drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h |

[PATCH V2 5/7] drm/amd/pm: drop unneeded smu_baco->mutex

2022-01-16 Thread Evan Quan
As those APIs related are already well protected by adev->pm.mutex. Signed-off-by: Evan Quan Change-Id: I8a7d8da5710698a98dd0f7e70c244be57474b573 --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 1 - drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 1 - .../gpu/drm/amd/pm/swsmu/smu11/smu_v11

[PATCH V2 6/7] drm/amd/pm: drop unneeded feature->mutex

2022-01-16 Thread Evan Quan
As all those related APIs are already well protected by adev->pm.mutex. Signed-off-by: Evan Quan Change-Id: Ia2c752ff22e8f23601484f48b66151cfda8c01b5 --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 1 - drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 1 - .../gpu/drm/amd/pm/swsmu/smu13/smu

[PATCH V2 7/7] drm/amd/pm: drop unneeded hwmgr->smu_lock

2022-01-16 Thread Evan Quan
As all those related APIs are already well protected by adev->pm.mutex. Signed-off-by: Evan Quan Change-Id: I36426791d3bbc9d84a6ae437da26a892682eb0cb --- .../gpu/drm/amd/pm/powerplay/amd_powerplay.c | 278 +++--- drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h | 1 - 2 files changed

[PATCH] drm/amdgpu: limit the number of dst address in trace

2022-01-16 Thread Somalapuram Amaranath
trace_amdgpu_vm_update_ptes trace unable to log when nptes too large Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.

[PATCH 1/2] drm/amdgpu: add reset register trace dump function for gfx_v10_0

2022-01-16 Thread Somalapuram Amaranath
Implementation of register trace dump function on the AMD GPU resets Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 8 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c| 53 ++- drivers/gpu/drm/amd/include/amd_shared.h | 1 + 3 files cha

[PATCH 2/2] drm/amdgpu: add AMDGPURESET uevent on AMD GPU reset

2022-01-16 Thread Somalapuram Amaranath
AMDGPURESET uevent added to notify userspace, collect dump_stack and trace Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/nv.c | 45 + 1 file changed, 45 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/

Re: [PATCH] drm/amdgpu: remove duplicate include

2022-01-16 Thread Christian König
Am 15.01.22 um 08:02 schrieb cgel@gmail.com: From: Changcheng Deng 'drm/drm_drv.h' included in 'amdgpu_ttm.c' is duplicated. It is also included on 53 line. Reported-by: Zeal Robot Signed-off-by: Changcheng Deng Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm

Re: RIP: 0010:radeon_vm_fini+0x15/0x220 [radeon]

2022-01-16 Thread Christian König
Hi Borislav, Am 15.01.22 um 17:11 schrieb Borislav Petkov: Hi folks, so this is a *very* old K8 laptop - yap, you read it right, family 0xf. [ 31.353032] powernow_k8: fid 0xa (1800 MHz), vid 0xa [ 31.353569] powernow_k8: fid 0x8 (1600 MHz), vid 0xc [ 31.354081] powernow_k8: fid 0x0 (800

Re: [PATCH] drm/amdgpu: limit the number of dst address in trace

2022-01-16 Thread Christian König
Am 17.01.22 um 07:32 schrieb Somalapuram Amaranath: trace_amdgpu_vm_update_ptes trace unable to log when nptes too large Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/

Re: [PATCH 2/2] drm/amdgpu: add AMDGPURESET uevent on AMD GPU reset

2022-01-16 Thread Christian König
Am 17.01.22 um 07:33 schrieb Somalapuram Amaranath: AMDGPURESET uevent added to notify userspace, collect dump_stack and trace Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/nv.c | 45 + 1 file changed, 45 insertions(+) diff --git a/drive

[PATCH] drm/amdgpu: limit the number of dst address in trace

2022-01-16 Thread Somalapuram Amaranath
trace_amdgpu_vm_update_ptes trace unable to log when nptes too large Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 5 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c| 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/

Re: [PATCH] drm/amdgpu: limit the number of dst address in trace

2022-01-16 Thread Christian König
Am 17.01.22 um 08:55 schrieb Somalapuram Amaranath: trace_amdgpu_vm_update_ptes trace unable to log when nptes too large Signed-off-by: Somalapuram Amaranath Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 5 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c|