On 1/11/2022 1:15 PM, Tao Zhou wrote:
PMFW only returns 0 on master die and sends NACK back on other dies for
the message.
v2: only send GmiPwrDnControl msg on master die instead of all
dies.
v3: remove the pointer check for get_socket_id and get_die_id as they
should be present on Aldebaran.
On 1/11/2022 1:17 PM, Evan Quan wrote:
On functionality unsupported, -EOPNOTSUPP will be returned. And we rely
on that to determine the fan attributes support.
Fixes: 801771de0331 ("drm/amd/pm: do not expose power implementation details to
amdgpu_pm.c")
Signed-off-by: Evan Quan
Change-Id: I
[Public]
Hi Christian,
Looks this patch still missed in 5.16 kernel. Is it intentional?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/ttm/ttm_bo.c?h=v5.16
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Pan, Xinhui
Sent: Tuesday,
[AMD Official Use Only]
> -Original Message-
> From: Lazar, Lijo
> Sent: Tuesday, January 11, 2022 4:14 PM
> To: Quan, Evan ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Chen, Guchun
>
> Subject: Re: [PATCH] drm/amd/pm: correct the checks for fan attributes
> support
>
>
On 1/11/2022 3:36 PM, Quan, Evan wrote:
[AMD Official Use Only]
-Original Message-
From: Lazar, Lijo
Sent: Tuesday, January 11, 2022 4:14 PM
To: Quan, Evan ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Chen, Guchun
Subject: Re: [PATCH] drm/amd/pm: correct the checks fo
On 2022-01-11 00:39, Rodrigo Siqueira wrote:
> We have one internal CI that builds our kernel with the -Werror flag; as
> a result, when we try to sync our branch with amd-staging-drm-next we
> get some failures due to warnings. This commit tries to alleviate this
> problem by forcing a warning to
[AMD Official Use Only]
> -Original Message-
> From: Lazar, Lijo
> Sent: Tuesday, January 11, 2022 6:15 PM
> To: Quan, Evan ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Chen, Guchun
>
> Subject: Re: [PATCH] drm/amd/pm: correct the checks for fan attributes
> support
>
>
Am 11.01.22 um 06:21 schrieb Guchun Chen:
This is observed in SRIOV case with virtual KMS as display.
_raw_spin_lock_irqsave+0x37/0x40
drm_handle_vblank+0x69/0x350 [drm]
? try_to_wake_up+0x432/0x5c0
? amdgpu_vkms_prepare_fb+0x1c0/0x1c0 [amdgpu]
drm_crtc_handle_vblank+0x17/0x20 [drm]
amdgpu_vk
On 1/11/2022 4:12 PM, Quan, Evan wrote:
[AMD Official Use Only]
-Original Message-
From: Lazar, Lijo
Sent: Tuesday, January 11, 2022 6:15 PM
To: Quan, Evan ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Chen, Guchun
Subject: Re: [PATCH] drm/amd/pm: correct the checks fo
On 2022-01-11 11:41, Michel Dänzer wrote:
> On 2022-01-11 00:39, Rodrigo Siqueira wrote:
>> We have one internal CI that builds our kernel with the -Werror flag; as
>> a result, when we try to sync our branch with amd-staging-drm-next we
>> get some failures due to warnings. This commit tries to al
Am 11.01.22 um 08:09 schrieb Somalapuram Amaranath:
trace_amdgpu_vm_update_ptes trace unable to log when nptes too large
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm
Am 11.01.22 um 08:11 schrieb Somalapuram Amaranath:
Implementation of register dump function when the AMD GPU resets
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 55 +++-
drivers/gpu/drm/amd/include/amd_shared.h | 2 +
2 files chan
Am 11.01.22 um 08:11 schrieb Somalapuram Amaranath:
Implementation of debug fs “amdgpu_reset_reg_dumps”
to capture reset register status
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 64 +
1 file changed, 64 insertions(+)
diff --g
Am 11.01.22 um 08:12 schrieb Somalapuram Amaranath:
AMDGPURESET uevent added to notify userspace,
collect dump_stack and amdgpu_reset_reg_dumps
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/nv.c | 31 +++
1 file changed, 31 insertions(+)
dif
IIRC we have completely dropped this patch in favor of a check at a
different place.
Regards,
Christian.
Am 11.01.22 um 09:47 schrieb Chen, Guchun:
[Public]
Hi Christian,
Looks this patch still missed in 5.16 kernel. Is it intentional?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds
On functionality unsupported, -EOPNOTSUPP will be returned. And we rely
on that to determine the fan attributes support.
Fixes: 801771de0331 ("drm/amd/pm: do not expose power implementation details to
amdgpu_pm.c")
Signed-off-by: Evan Quan
Change-Id: I95e7e0beebd678a446221a72234cd356e14f0fcd
--
[AMD Official Use Only]
> -Original Message-
> From: Lazar, Lijo
> Sent: Tuesday, January 11, 2022 6:53 PM
> To: Quan, Evan ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Chen, Guchun
>
> Subject: Re: [PATCH] drm/amd/pm: correct the checks for fan attributes
> support
>
>
[AMD Official Use Only]
> -Original Message-
> From: Lazar, Lijo
> Sent: Monday, January 10, 2022 3:03 PM
> To: Quan, Evan ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: Re: [PATCH 3/7] drm/amd/pm: drop unneeded smu->metrics_lock
>
>
>
> On 1/7/2022 7:49 AM, Qua
On 2022-01-11 6:00 a.m., Michel Dänzer wrote:
On 2022-01-11 11:41, Michel Dänzer wrote:
On 2022-01-11 00:39, Rodrigo Siqueira wrote:
We have one internal CI that builds our kernel with the -Werror flag; as
a result, when we try to sync our branch with amd-staging-drm-next we
get some failure
On 2022-01-10 3:19 p.m., Alex Deucher wrote:
warning: ISO C90 forbids mixed declarations and code
[-Wdeclaration-after-statement]
Fixes: 8c50db2f64ee ("drm/amdgpu: Adjust error inject function code style in
amdgpu_ras.c")
Cc: yipechai
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/
On Tue, Jan 11, 2022 at 2:11 AM Somalapuram Amaranath
wrote:
>
> Implementation of register dump function when the AMD GPU resets
>
> Signed-off-by: Somalapuram Amaranath
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 55 +++-
> drivers/gpu/drm/amd/include/amd_shared.h |
[AMD Official Use Only]
Reviewed-by: Kent Russell
> -Original Message-
> From: amd-gfx On Behalf Of Felix
> Kuehling
> Sent: Monday, January 10, 2022 7:13 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH 1/2] drm/amdkfd: Fix DQM asserts on Hawaii
>
> Ping.
>
> On 2021-12-0
On Mon, Jan 10, 2022 at 5:21 PM Linus Torvalds
wrote:
>
> I'll see if I can bisect it at least partially.
It seems to be very reliable. I can see the flickering even at early
boot before gdb has started - the graphical screen where you type the
encrypted disk password at boot already shows it as
On Mon, Jan 10, 2022 at 6:44 PM Linus Torvalds
wrote:
>
> I'll double-check to see if a revert fixes it at the top of my tree.
Yup. It reverts cleanly, and the end result builds and works fine, and
doesn't show the horrendous flickering.
I have done that revert, and will continue the merge windo
On Mon, Jan 10, 2022 at 6:22 PM Linus Torvalds
wrote:
>
> and I guess I'll do the few more bisections to pick out the exact one.
a896f870f8a5f23ec961d16baffd3fda1f8be57c is the first bad commit.
Attaching ther BISECT_LOG in case anybody cares.
I'll double-check to see if a revert fixes it at th
On Mon, Jan 10, 2022 at 9:53 PM Linus Torvalds
wrote:
>
> On Mon, Jan 10, 2022 at 6:44 PM Linus Torvalds
> wrote:
> >
> > I'll double-check to see if a revert fixes it at the top of my tree.
>
> Yup. It reverts cleanly, and the end result builds and works fine, and
> doesn't show the horrendous f
Add yellow carp to devices which support recovery
Signed-off-by: CHANDAN VURDIGERE NATARAJ
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index f0fc015bd11e..2f519cbe7af9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/
[Public]
Reviewed-by: Alex Deucher
From: VURDIGERENATARAJ, CHANDAN
Sent: Tuesday, January 11, 2022 10:25 AM
To: Deucher, Alexander
Cc: amd-gfx@lists.freedesktop.org ;
VURDIGERENATARAJ, CHANDAN
Subject: [PATCH] drm/amdgpu: Enable recovery on yellow carp
Add ye
On 2022-01-11 10:08, Alex Deucher wrote:
> On Mon, Jan 10, 2022 at 9:53 PM Linus Torvalds
> wrote:
>>
>> On Mon, Jan 10, 2022 at 6:44 PM Linus Torvalds
>> wrote:
>>>
>>> I'll double-check to see if a revert fixes it at the top of my tree.
>>
>> Yup. It reverts cleanly, and the end result builds
On 2022-01-10 7:10 p.m., Felix Kuehling
wrote:
On
2022-01-05 10:22 a.m., philip yang wrote:
On 2021-12-22 7:37 p.m., Rajneesh Bhardwaj wrote:
Recoverable page faults are represented
by the xnac
On 2022-01-10 6:58 p.m., Felix Kuehling
wrote:
On
2022-01-05 9:43 a.m., philip yang wrote:
On 2021-12-22 7:37 p.m., Rajneesh Bhardwaj wrote:
During CRIU restore phase, the VMAs for
the virtual
On 2022-01-11 02:52, Mahapatra, Rajib wrote:
> dpcd_set_source_specific_data is not specific to OLED panel. It is called
> from boot-up path also.
> Hersen Wu introduced it in resume-path while enabling OLED panel for Linux in
> below commit.
>
If we set it in the boot-up path we'll probabl
On some OEM setups users can configure the BIOS for S3 or S2idle.
When configured to S3 users can still choose 's2idle' in the kernel
by using `/sys/power/mem_sleep`. When configured this way, the system
will use more power but should still work for suspend and resume.
As such, remove the checks
Three misspelled ASICs in comments here, so fix the spelling
Signed-off-by: Kent Russell
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
index
Am 2022-01-11 um 12:31 p.m. schrieb Kent Russell:
> Three misspelled ASICs in comments here, so fix the spelling
>
> Signed-off-by: Kent Russell
Reviewed-by: Felix Kuehling
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_device.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff -
Am 2022-01-04 um 2:12 p.m. schrieb Jonathan Kim:
> For better performance during VRAM access for debugged processes, do
> read/write copies over SDMA.
>
> In order to fulfill post mortem debugging on a broken device, fallback to
> stable MMIO access when gpu recovery is disabled or when job submiss
On 1/11/2022 10:59 PM, Mario Limonciello wrote:
On some OEM setups users can configure the BIOS for S3 or S2idle.
When configured to S3 users can still choose 's2idle' in the kernel
by using `/sys/power/mem_sleep`. When configured this way, the system
will use more power but should still work
[AMD Official Use Only]
> -Original Message-
> From: Lazar, Lijo
> Sent: Tuesday, January 11, 2022 12:54
> To: Limonciello, Mario ; amd-
> g...@lists.freedesktop.org
> Cc: Bjoren Dasse
> Subject: Re: [PATCH] drm/amd: apply s0ix codepath to more cases
>
>
>
> On 1/11/2022 10:59 PM, M
On some OEM setups users can configure the BIOS for S3 or S2idle.
When configured to S3 users can still choose 's2idle' in the kernel by
using `/sys/power/mem_sleep`. Before commit 6dc8265f9803 ("drm/amdgpu:
always reset the asic in suspend (v2)"), the GPU would crash. Now when
configured this wa
yes, I will use Dual MIT/GPL
Regards,
Arun
On 10/01/22 1:33 pm, Christian König wrote:
> Am 09.01.22 um 15:19 schrieb Arunpravin:
>> +// SPDX-License-Identifier: MIT
>
>> +MODULE_DESCRIPTION("DRM Buddy Allocator");
>> +MODULE_LICENSE("GPL");
>
> I'm not an expert on this, but maybe we shoul
- Make drm_buddy_alloc a single function to handle
range allocation and non-range allocation demands
- Implemented a new function alloc_range() which allocates
the requested power-of-two block comply with range limitations
- Moved order computation and memory alignment logic from
i915 drive
Move the base i915 buddy allocator code into drm
- Move i915_buddy.h to include/drm
- Move i915_buddy.c to drm root folder
- Rename "i915" string with "drm" string wherever applicable
- Rename "I915" string with "DRM" string wherever applicable
- Fix header file dependencies
- Fix alignment issues
Implemented a function which walk through the order list,
compares the offset and returns the maximum offset block,
this method is unpredictable in obtaining the high range
address blocks which depends on allocation and deallocation.
for instance, if driver requests address at a low specific
range,
Move shared vram inline functions and structs
into a header file
Signed-off-by: Arunpravin
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h | 51
1 file changed, 51 insertions(+)
create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h
diff --git a/drivers/gpu/drm/a
On contiguous allocation, we round up the size
to the *next* power of 2, implement a function
to free the unused pages after the newly allocate block.
v2(Matthew Auld):
- replace function name 'drm_buddy_free_unused_pages' with
drm_buddy_block_trim
- replace input argument name 'actual_siz
- Remove drm_mm references and replace with drm buddy functionalities
- Add res cursor support for drm buddy
v2(Matthew Auld):
- replace spinlock with mutex as we call kmem_cache_zalloc
(..., GFP_KERNEL) in drm_buddy_alloc() function
- lock drm_buddy_block_trim() function as it calls
Cases should be same indentation as switch. Also fix string spanning
across multiple lines.
Signed-off-by: Graham Sider
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 55 -
1 file changed, 27 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_devic
[AMD Official Use Only]
Reviewed-by: Alex Deucher
From: amd-gfx on behalf of Graham Sider
Sent: Tuesday, January 11, 2022 3:19 PM
To: amd-gfx@lists.freedesktop.org
Cc: Sider, Graham
Subject: [PATCH] drm/amdkfd: Fix indentation on switch statement
Cases shoul
On Tue, Jan 11, 2022 at 7:38 AM Harry Wentland wrote:
>
> Attached is a v2 of the buggy patch that should get this right.
> If you have a chance to try it out let us know
I can confirm that I do not see the horribly flickering behavior with
this patch.
I didn't look at what the actual difference
Rather than opting into GPU recovery support, default to on, and
opt out if it's not working on a particular GPU. This avoids the
need to add new asics to this list since this is a core feature.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 44 +---
[AMD Official Use Only]
Reviewed-by: Evan Quan
> -Original Message-
> From: amd-gfx On Behalf Of Alex
> Deucher
> Sent: Wednesday, January 12, 2022 6:45 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: [PATCH] drm/amdgpu: invert the logic in
> amdgpu_device_sh
Signed-off-by: Stanley.Yang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 10 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +-
drivers/gpu/drm/amd/amdgpu/ta_ras_if.h | 3 ++-
3 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
b/dr
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Kent Russell
Sent: Wednesday, January 12, 2022 1:31 AM
To: amd-gfx@lists.freedesktop.org
Cc: Russell, Kent
Subject: [PATCH] drm/amdkfd: Fix ASIC name typos
Three misspelled ASICs in commen
[AMD Official Use Only]
> -Original Message-
> From: Bert Karwatzki
> Sent: Tuesday, January 11, 2022 19:12
> To: amd-gfx@lists.freedesktop.org
> Cc: Limonciello, Mario ; Kazlauskas, Nicholas
> ; Zhuo, Qingqing (Lillian)
> ; Scott Bruce ; Chris Hixon
>
> Subject: [PATCH v5] drm/amd/displ
Hi, Simon
On 2022/01/06 8:57, Simon Ser wrote:
Thanks for working on this! I've pushed a patch [1] to drm-misc-next which
touches the same function, can you rebase your patches on top of it?
[1]: https://patchwork.freedesktop.org/patch/467940/?series=98255&rev=3
I understand. I will rebase th
[Public]
Hi Christian,
My BAD, I checked that discussion history of this just now. So If I read it
correctly, the double check at a different place to skip evict is: " drm/ttm:
Double check mem_type of BO while eviction"? It is in 5.16 kernel.
Regards,
Guchun
-Original Message-
From:
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Wednesday, January 12, 2022 6:45 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH] drm/amdgpu: invert the logic in
amdgpu_device_should_recove
I just tested patch v5 applied to amd-staging-drm-next (with HEAD
26c981e27e698c251ef3241f73ac846e66ad7fc3) and suspend and resume work
fine. But as amd-staging-drm-next is still based on linux-5.13 I had to
replace the mediatek wlan driver by the version from linux-5.16.
Hi Andrey,
Please go ahead and push your change. I will prepare the RFC later.
On 2022/1/8 上午12:02, Andrey Grodzovsky wrote:
>
> On 2022-01-07 12:46 a.m., JingWen Chen wrote:
>> On 2022/1/7 上午11:57, JingWen Chen wrote:
>>> On 2022/1/7 上午3:13, Andrey Grodzovsky wrote:
On 2022-01-06 12:18 a.m.
On 1/11/2022 6:11 PM, Evan Quan wrote:
On functionality unsupported, -EOPNOTSUPP will be returned. And we rely
on that to determine the fan attributes support.
Fixes: 801771de0331 ("drm/amd/pm: do not expose power implementation details to
amdgpu_pm.c")
Signed-off-by: Evan Quan
Reviewed-b
Yeah, that should probably be the right one.
Christian.
Am 12.01.22 um 03:19 schrieb Chen, Guchun:
[Public]
Hi Christian,
My BAD, I checked that discussion history of this just now. So If I read it correctly,
the double check at a different place to skip evict is: " drm/ttm: Double check
me
On 1/11/2022 6:51 PM, Quan, Evan wrote:
[AMD Official Use Only]
-Original Message-
From: Lazar, Lijo
Sent: Monday, January 10, 2022 3:03 PM
To: Quan, Evan ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: Re: [PATCH 3/7] drm/amd/pm: drop unneeded smu->metrics_lock
Am 04.01.22 um 20:12 schrieb Jonathan Kim:
For better performance during VRAM access for debugged processes, do
read/write copies over SDMA.
In order to fulfill post mortem debugging on a broken device, fallback to
stable MMIO access when gpu recovery is disabled or when job submission
time outs
If nobody has any more objections/ideas I'm going to push this one here
to drm-misc-next in the afternoon.
Christian.
Am 11.01.22 um 21:14 schrieb Arunpravin:
Move the base i915 buddy allocator code into drm
- Move i915_buddy.h to include/drm
- Move i915_buddy.c to drm root folder
- Rename "i9
No longer insert ras blocks into ras_list if it already exists in ras_list.
Signed-off-by: yipechai
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index 62b
Add a filter condition to restrict the SW ras function to be registered only by
asics whose hardware supports the ras function.
Signed-off-by: yipechai
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdg
66 matches
Mail list logo
