Re: [RFC 4/6] drm/amdgpu: Serialize non TDR gpu recovery with TDRs

2021-12-21 Thread Christian König
Am 20.12.21 um 23:17 schrieb Andrey Grodzovsky: On 2021-12-20 2:20 a.m., Christian König wrote: Am 17.12.21 um 23:27 schrieb Andrey Grodzovsky: Use reset domain wq also for non TDR gpu recovery trigers such as sysfs and RAS. We must serialize all possible GPU recoveries to gurantee no concurre

Re: Expecting to revert commit 55285e21f045 "fbdev/efifb: Release PCI device ..."

2021-12-21 Thread Linus Torvalds
[ Adding back in more amd people and the amd list, the people Daniel added seem to have gotten lost again, but I think people at least saw my original report thanks to Daniel ] With "amdgpu.runpm=0", things are better, but not perfect. With that I can lock the screen, and it has to go through *two

Re: [PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read premission in ONEVF mode

2021-12-21 Thread Nikolic, Marina
[AMD Official Use Only] Hi Kent, Thank you for the review. Yes, I can confirm I am trying to set this for every single file for SRIOV mode. @Kitchen, Greg required this for ROCM-SMI 5.0 release. In case you need it, he can provide more details. I'm going to clarify

Re: [PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read premission in ONEVF mode

2021-12-21 Thread Nikolic, Marina
[AMD Official Use Only] >From 06359f3be0c0b889519d6dd954fb11f31e9a15e0 Mon Sep 17 00:00:00 2001 From: Marina Nikolic Date: Tue, 14 Dec 2021 20:57:53 +0800 Subject: [PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read permission in ONEVF mode == Description == Setting through sysfs shou

[PATCH] drm/amdgpu: fix runpm documentation

2021-12-21 Thread Alex Deucher
It's not only supported by HG/PX laptops. It's supported by all dGPUs which supports BOCO/BACO functionality (runtime D3). BOCO - Bus Off, Chip Off. The entire chip is powered off. This is controlled by ACPI. BACO - Bus Active, Chip Off. The chip still shows up on the PCI bus, but

Re: [RFC 3/6] drm/amdgpu: Fix crash on modprobe

2021-12-21 Thread Andrey Grodzovsky
On 2021-12-21 2:02 a.m., Christian König wrote: Am 20.12.21 um 20:22 schrieb Andrey Grodzovsky: On 2021-12-20 2:17 a.m., Christian König wrote: Am 17.12.21 um 23:27 schrieb Andrey Grodzovsky: Restrict jobs resubmission to suspend case only since schedulers not initialised yet on probe. S

Re: [RFC 4/6] drm/amdgpu: Serialize non TDR gpu recovery with TDRs

2021-12-21 Thread Andrey Grodzovsky
On 2021-12-21 2:59 a.m., Christian König wrote: Am 20.12.21 um 23:17 schrieb Andrey Grodzovsky: On 2021-12-20 2:20 a.m., Christian König wrote: Am 17.12.21 um 23:27 schrieb Andrey Grodzovsky: Use reset domain wq also for non TDR gpu recovery trigers such as sysfs and RAS. We must serialize

RE: Expecting to revert commit 55285e21f045 "fbdev/efifb: Release PCI device ..."

2021-12-21 Thread Deucher, Alexander
[Public] > -Original Message- > From: Linus Torvalds > Sent: Monday, December 20, 2021 5:05 PM > To: Imre Deak > Cc: Daniel Vetter ; Deucher, Alexander > ; Kai-Heng Feng > > Subject: Re: Expecting to revert commit 55285e21f045 "fbdev/efifb: Release > PCI device ..." > > On Mon, Dec 20,

RE: Expecting to revert commit 55285e21f045 "fbdev/efifb: Release PCI device ..."

2021-12-21 Thread Deucher, Alexander
[Public] > -Original Message- > From: Linus Torvalds > Sent: Monday, December 20, 2021 5:21 PM > To: Imre Deak ; Koenig, Christian > ; Pan, Xinhui ; > Wentland, Harry > Cc: Daniel Vetter ; Deucher, Alexander > ; Kai-Heng Feng > ; amd-gfx list g...@lists.freedesktop.org> > Subject: Re: E

RE: Expecting to revert commit 55285e21f045 "fbdev/efifb: Release PCI device ..."

2021-12-21 Thread Deucher, Alexander
[Public] > -Original Message- > From: Deucher, Alexander > Sent: Tuesday, December 21, 2021 12:01 PM > To: Linus Torvalds ; Imre Deak > ; amd-gfx@lists.freedesktop.org > Cc: Daniel Vetter ; Kai-Heng Feng > > Subject: RE: Expecting to revert commit 55285e21f045 "fbdev/efifb: Release > PCI

Re: Various problems trying to vga-passthrough a Renoir iGPU to a xen/qubes-os hvm

2021-12-21 Thread Alex Deucher
On Sun, Dec 19, 2021 at 11:41 AM Yann Dirson wrote: > > Christian wrote: > > Am 19.12.21 um 17:00 schrieb Yann Dirson: > > > Alex wrote: > > >> Thinking about this more, I think the problem might be related to > > >> CPU > > >> access to "VRAM". APUs don't have dedicated VRAM, they use a > > >> r

Re: Re: Re: Re: 回复: Re: [PATCH] drm/amdgpu: fixup bad vram size on gmc v8

2021-12-21 Thread Alex Deucher
Yes, you can either do that, or if amdgpu is loaded, just read the data from /sys/kernel/debug/dri/0/amdgpu_vbios Alex On Mon, Dec 20, 2021 at 3:06 AM 周宗敏 wrote: > > > Dear Alex: > > > I've never tried to get a VBIOS before, so can you tell me how to get a > vbios image copy for you? > > I t

Re: [PATCH 10/19] drm/amd/display: Changed pipe split policy to allow for multi-display pipe split

2021-12-21 Thread Alex Deucher
On Fri, Dec 17, 2021 at 4:51 PM Rodrigo Siqueira Jordao wrote: > > > > On 2021-12-17 4:36 p.m., Deucher, Alexander wrote: > > [AMD Official Use Only] > > > > > > Maybe add Bug links for: > > https://gitlab.freedesktop.org/drm/amd/-/issues/1522 > >

Re: Expecting to revert commit 55285e21f045 "fbdev/efifb: Release PCI device ..."

2021-12-21 Thread Alex Deucher
On Tue, Dec 21, 2021 at 1:47 PM Deucher, Alexander wrote: > > [Public] > > > -Original Message- > > From: Deucher, Alexander > > Sent: Tuesday, December 21, 2021 12:01 PM > > To: Linus Torvalds ; Imre Deak > > ; amd-gfx@lists.freedesktop.org > > Cc: Daniel Vetter ; Kai-Heng Feng > > > > S

Re: Expecting to revert commit 55285e21f045 "fbdev/efifb: Release PCI device ..."

2021-12-21 Thread Harry Wentland
On 2021-12-21 16:18, Alex Deucher wrote: > On Tue, Dec 21, 2021 at 1:47 PM Deucher, Alexander > wrote: >> >> [Public] >> >>> -Original Message- >>> From: Deucher, Alexander >>> Sent: Tuesday, December 21, 2021 12:01 PM >>> To: Linus Torvalds ; Imre Deak >>> ; amd-gfx@lists.freedesktop.o

Re: Various problems trying to vga-passthrough a Renoir iGPU to a xen/qubes-os hvm

2021-12-21 Thread Yann Dirson
Alex wrote: > > On Sun, Dec 19, 2021 at 11:41 AM Yann Dirson wrote: > > > > Christian wrote: > > > Am 19.12.21 um 17:00 schrieb Yann Dirson: > > > > Alex wrote: > > > >> Thinking about this more, I think the problem might be related > > > >> to > > > >> CPU > > > >> access to "VRAM". APUs don'

Re: Expecting to revert commit 55285e21f045 "fbdev/efifb: Release PCI device ..."

2021-12-21 Thread Alex Deucher
On Tue, Dec 21, 2021 at 5:09 PM Harry Wentland wrote: > > > > On 2021-12-21 16:18, Alex Deucher wrote: > > On Tue, Dec 21, 2021 at 1:47 PM Deucher, Alexander > > wrote: > >> > >> [Public] > >> > >>> -Original Message- > >>> From: Deucher, Alexander > >>> Sent: Tuesday, December 21, 2021 1

Re: Various problems trying to vga-passthrough a Renoir iGPU to a xen/qubes-os hvm

2021-12-21 Thread Alex Deucher
On Tue, Dec 21, 2021 at 5:12 PM Yann Dirson wrote: > > > Alex wrote: > > > > On Sun, Dec 19, 2021 at 11:41 AM Yann Dirson wrote: > > > > > > Christian wrote: > > > > Am 19.12.21 um 17:00 schrieb Yann Dirson: > > > > > Alex wrote: > > > > >> Thinking about this more, I think the problem might be r

Re: Various problems trying to vga-passthrough a Renoir iGPU to a xen/qubes-os hvm

2021-12-21 Thread Yann Dirson
- Mail original - > De: "Alex Deucher" > À: "Yann Dirson" > Cc: "Christian König" , "amd-gfx list" > > Envoyé: Mardi 21 Décembre 2021 23:31:01 > Objet: Re: Various problems trying to vga-passthrough a Renoir iGPU to a > xen/qubes-os hvm > > On Tue, Dec 21, 2021 at 5:12 PM Yann Dirs

RE: [PATCH] drm/amdgpu: fix runpm documentation

2021-12-21 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Tuesday, December 21, 2021 10:59 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH] drm/amdgpu: fix runpm documentation > > It's not only supported by HG/PX

RE: [PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read premission in ONEVF mode

2021-12-21 Thread Quan, Evan
[AMD Official Use Only] From: amd-gfx On Behalf Of Nikolic, Marina Sent: Tuesday, December 21, 2021 10:36 PM To: Russell, Kent ; amd-gfx@lists.freedesktop.org Cc: Mitrovic, Milan ; Kitchen, Greg Subject: Re: [PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read premission in ONEVF m

RE: [PATCH V5 05/16] drm/amd/pm: do not expose those APIs used internally only in si_dpm.c

2021-12-21 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Tuesday, December 21, 2021 2:17 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH V5 05/16] drm/amd/pm: do not expose those APIs used > internally only in si_dpm.c

RE: [PATCH V5 13/16] drm/amd/pm: relocate the power related headers

2021-12-21 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Tuesday, December 21, 2021 2:22 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH V5 13/16] drm/amd/pm: relocate the power related > headers > > > > On 12/13/202

[RFC PATCH 0/3] Add support modifiers for drivers whose planes only support linear layout

2021-12-21 Thread Tomohito Esaki
Some drivers whose planes only support linear layout fb do not support format modifiers. These drivers should support modifiers, however the DRM core should handle this rather than open-coding in every driver. In this patch series, these drivers expose format modifiers based on the following sugge

[RFC PATH 1/3] drm: add support modifiers for drivers whose planes only support linear layout

2021-12-21 Thread Tomohito Esaki
The LINEAR modifier is advertised as default if a driver doesn't specify modifiers. However, there are legacy drivers such as radeon that do not support modifiers but infer the actual layout of the underlying buffer. Therefore, a new flag not_support_fb_modifires is introduced for these legacy driv

[RFC PATH 2/3] drm: set fb_modifiers_not_supported flag in legacy drivers

2021-12-21 Thread Tomohito Esaki
Set fb_modifiers_not_supported flag in legacy drivers whose planes support non-linear layouts but does not support modifiers, and replace allow_fb_modifiers with fb_modifiers_not_supported. Signed-off-by: Tomohito Esaki --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 6 +++--- drivers/gpu/drm/

[RFC PATH 3/3] drm: replace allow_fb_modifiers with fb_modifiers_not_supported

2021-12-21 Thread Tomohito Esaki
Since almost drivers support fb modifiers, allow_fb_modifiers is replaced with fb_modifiers_not_supported and removed. Signed-off-by: Tomohito Esaki --- drivers/gpu/drm/drm_framebuffer.c| 6 +++--- drivers/gpu/drm/drm_ioctl.c | 2 +- drivers/gpu/drm/drm_pla

[PATCH] drm/ttm: add workaround for some arm hardware issue

2021-12-21 Thread Victor Zhao
Some Arm based platform has hardware issue which may generate incorrect addresses when receiving writes from the CPU with a discontiguous set of byte enables. This affects the writes with write combine property. Workaround by change PROT_NORMAL_NC to PROT_DEVICE_nGnRE on arm. As this is an issue w

Re: [RFC 3/6] drm/amdgpu: Fix crash on modprobe

2021-12-21 Thread Christian König
Am 21.12.21 um 17:03 schrieb Andrey Grodzovsky: On 2021-12-21 2:02 a.m., Christian König wrote: Am 20.12.21 um 20:22 schrieb Andrey Grodzovsky: On 2021-12-20 2:17 a.m., Christian König wrote: Am 17.12.21 um 23:27 schrieb Andrey Grodzovsky: Restrict jobs resubmission to suspend case only s