RE: [PATCH v2 11/23] drm/amd/display: Implement DPIA clock recovery phase

2021-10-08 Thread Lin, Wayne
[AMD Official Use Only] Thanks Mike. Will give a fix. Regards, Wayne > -Original Message- > From: Mike Lothian > Sent: Thursday, October 7, 2021 6:01 PM > To: Lin, Wayne > Cc: amd-gfx list ; Deucher, Alexander > ; Wentland, Harry > ; Kazlauskas, Nicholas ; > Siqueira, Rodrigo > ; Wa

Re: [PATCH v3] drm/dp: Add Additional DP2 Headers

2021-10-08 Thread Tvrtko Ursulin
Hi, Is it my checkout only or this causes a lot of build warnings for everyone? ./include/drm/drm_dp_helper.h:1120: warning: "DP_TEST_264BIT_CUSTOM_PATTERN_7_0" redefined 1120 | #define DP_TEST_264BIT_CUSTOM_PATTERN_7_0 0x2230 | In file included from ./drivers/gpu/drm/amd/amdgpu/../di

[PATCH] drm/amd/display: Fix Werror when building

2021-10-08 Thread Wayne Lin
[Why & How] Got Werror when building with Clang-13: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:195:2: error: variable 'ts' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized] default: ^~~ drivers/gpu/drm/amd/amdgpu/../

Re: [PATCH] drm/amd/display: Fix Werror when building

2021-10-08 Thread Alex Deucher
Acked-by: Alex Deucher On Fri, Oct 8, 2021 at 9:39 AM Wayne Lin wrote: > > [Why & How] > Got Werror when building with Clang-13: > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:195:2: > error: variable 'ts' is used uninitialized whenever switch default is > taken [-Werror,-Wsome

[PATCH] drm/amd/display: remove duplicate include in dcn201_clk_mgr.c

2021-10-08 Thread cgel . zte
From: Lv Ruyi Remove all but the first include of reg_helper.h and core_types.h from dcn201_clk_mgr.c. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- .../gpu/drm/amd/display/dc/clk_mgr/dcn201/dcn201_clk_mgr.c| 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/disp

Re: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend")

2021-10-08 Thread Borislav Petkov
On Fri, Oct 08, 2021 at 11:12:35AM -0400, Alex Deucher wrote: > Can you try swapping the order of > amdgpu_device_ip_set_powergating_state() and > amdgpu_device_ip_set_clockgating_state() in the patch? Nope, the diff below didn't change things. Should I comment them out one by one and see whether

[PATCH 2/2] drm/amdgpu/nbio2.3: don't use GPU_HDP_FLUSH bit 12

2021-10-08 Thread Alex Deucher
It's used internally by firmware. Using it in the driver could conflict with firmware. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c b/drive

[PATCH 1/2] drm/amdgpu/nbio7.4: don't use GPU_HDP_FLUSH bit 12

2021-10-08 Thread Alex Deucher
It's used internally by firmware. Using it in the driver could conflict with firmware. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c b/driv

[PATCH] drm/amd/display: Enable PSR by default on DCN3.1

2021-10-08 Thread Nicholas Kazlauskas
[Why] New idle optimizations for DCN3.1 require PSR for optimal power savings on panels that support it. This was previously left disabled by default because of issues with compositors that do not pageflip and scan out directly to the frontbuffer. For these compositors we now have detection metho

Re: [PATCH v2 1/7] drm/sysfs: introduce drm_sysfs_connector_hotplug_event

2021-10-08 Thread Simon Ser
Ping

Re: [PATCH 1/2] drm/amdgpu/nbio7.4: don't use GPU_HDP_FLUSH bit 12

2021-10-08 Thread Zhu, James
[AMD Official Use Only] Reviewed-by: James Zhu for the series. James Zhu From: amd-gfx on behalf of Alex Deucher Sent: Friday, October 8, 2021 12:10 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 1/2] drm/amdgpu/nbio7.4: don't

Re: [PATCH 1/4] drm/amdkfd: ratelimited svm debug messages

2021-10-08 Thread philip yang
On 2021-10-06 4:55 p.m., Felix Kuehling wrote: Am 2021-10-06 um 10:32 a.m. schrieb Philip Yang: No function change, use pr_debug_ratelimited to avoid per page debug message overflowing dmesg buf and console log. use dev_err to show error mess

[pull] amdgpu, amdkfd drm-next-5.16

2021-10-08 Thread Alex Deucher
Hi Dave, Daniel, More new stuff for 5.16. MCE change has an ack from Boris to merge through the amdgpu tree. The following changes since commit 1e3944578b749449bd7fa6bf0bae4c3d3f5f1733: Merge tag 'amd-drm-next-5.16-2021-09-27' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2021

Re: [PATCH v3 20/20] drm: cleanup: remove acquire_ctx from drm_mode_config

2021-10-08 Thread Fernando Ramos
On 21/10/07 09:37PM, Fernando Ramos wrote: > --- > include/drm/drm_mode_config.h | 10 -- > 1 file changed, 10 deletions(-) > > diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h > index 48b7de80daf5..b214b07157f2 100644 > This patch was missing the commit descrip

Re: [PATCH v3] drm/dp: Add Additional DP2 Headers

2021-10-08 Thread Harry Wentland
On 2021-10-08 04:36, Tvrtko Ursulin wrote: > > Hi, > > Is it my checkout only or this causes a lot of build warnings for everyone? > > ./include/drm/drm_dp_helper.h:1120: warning: > "DP_TEST_264BIT_CUSTOM_PATTERN_7_0" redefined >  1120 | #define DP_TEST_264BIT_CUSTOM_PATTERN_7_0  0x2230 >  

[PATCH] MAINTAINERS: Add Siqueira for AMD DC

2021-10-08 Thread Harry Wentland
He's been helping maintain it for quite a while now. Make it official. Signed-off-by: Harry Wentland --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 24d520c4b157..b107ddb306de 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -876,6 +876,7 @@ F: i

RE: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend")

2021-10-08 Thread Quan, Evan
[AMD Official Use Only] Maybe the change below can address your issue. https://lists.freedesktop.org/archives/amd-gfx/2021-September/069006.html BR Evan > -Original Message- > From: Borislav Petkov > Sent: Friday, October 8, 2021 11:36 PM > To: Alex Deucher > Cc: Quan, Evan ; amd-gfx li