Re: [PATCH v2 07/14] drm/msm: Convert to Linux IRQ interfaces

2021-08-07 Thread Rob Clark
On Tue, Aug 3, 2021 at 2:37 AM Dmitry Baryshkov wrote: > > On 03/08/2021 12:06, Thomas Zimmermann wrote: > > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > > don't benefit from using it. > > > > DRM IRQ call

Re: [PATCH v2 07/14] drm/msm: Convert to Linux IRQ interfaces

2021-08-07 Thread Thomas Zimmermann
Hi Am 07.08.21 um 19:08 schrieb Rob Clark: On Tue, Aug 3, 2021 at 2:37 AM Dmitry Baryshkov wrote: On 03/08/2021 12:06, Thomas Zimmermann wrote: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit fr

Re: [PATCH v2 07/14] drm/msm: Convert to Linux IRQ interfaces

2021-08-07 Thread Rob Clark
On Sat, Aug 7, 2021 at 11:40 AM Thomas Zimmermann wrote: > > Hi > > Am 07.08.21 um 19:08 schrieb Rob Clark: > > On Tue, Aug 3, 2021 at 2:37 AM Dmitry Baryshkov > > wrote: > >> > >> On 03/08/2021 12:06, Thomas Zimmermann wrote: > >>> Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM'

[PATCH 2/3] amdgpu/pm: Replace smu11 usage of sprintf with sysfs_emit

2021-08-07 Thread Darren Powell
modification of smu11 files arcturus_ppt.c sienna_cichlid_ppt.c vangogh_ppt.c === Test === AMDGPU_PCI_ADDR=`lspci -nn | grep "VGA\|Display" | cut -d " " -f 1` AMDGPU_HWMON=`ls -la /sys/class/hwmon | grep $AMDGPU_PCI_ADDR | awk '{print $9}'` HWMON_DIR=/sys/class/hwmon/${AMDGPU_HWMON} LOGFIL

[PATCH v2 0/3] Replace usage of sprintf with sysfs_emit in swsmu powerplay

2021-08-07 Thread Darren Powell
=== Description === Replace usage of sprintf with sysfs_emit in swsmu powerplay v2: rebased on 2f56b0d631eb === Test System === * DESKTOP(AMD FX-8350 + NAVI10(731F/ca), BIOS: F2) + ISO(Ubuntu 20.04.2 LTS) + Kernel(5.13.0-gb1d634be9673-fdoagd5f) === Patch Summary === linux: (g...@gitlab

[PATCH 1/3] amdgpu/pm: Replace navi10 usage of sprintf with sysfs_emit

2021-08-07 Thread Darren Powell
initial modification of files smu_cmn.c navi10_ppt.c === Test === AMDGPU_PCI_ADDR=`lspci -nn | grep "VGA\|Display" | cut -d " " -f 1` AMDGPU_HWMON=`ls -la /sys/class/hwmon | grep $AMDGPU_PCI_ADDR | awk '{print $9}'` HWMON_DIR=/sys/class/hwmon/${AMDGPU_HWMON} LOGFILE=pp_printf.test.log lspci

[PATCH 3/3] amdgpu/pm: Replace smu12/13 usage of sprintf with sysfs_emit

2021-08-07 Thread Darren Powell
initial modification of files renoir_ppt.c aldebaran_ppt.c yellow_carp_ppt.c === Test === AMDGPU_PCI_ADDR=`lspci -nn | grep "VGA\|Display" | cut -d " " -f 1` AMDGPU_HWMON=`ls -la /sys/class/hwmon | grep $AMDGPU_PCI_ADDR | awk '{print $9}'` HWMON_DIR=/sys/class/hwmon/${AMDGPU_HWMON} LOGFILE

[PATCH 3/4] amdgpu/pm: Replace hwmgr smu usage of sprintf with sysfs_emit

2021-08-07 Thread Darren Powell
replacing printfs with sysfs_emit minor smu7 change to remove compiler warning comparison of int and uint32_t minor smu8 change to remove compiler warning comparison of int and uint32_t === Test === AMDGPU_PCI_ADDR=`lspci -nn | grep "VGA\|Display" | cut -d " " -f 1` AMDGPU_HWMON=`ls -la /sys/cl

[PATCH 1/4] amdgpu/pm: Replace vega10 usage of sprintf with sysfs_emit

2021-08-07 Thread Darren Powell
initial modification of files vega10_hwmgr.c === Test === AMDGPU_PCI_ADDR=`lspci -nn | grep "VGA\|Display" | cut -d " " -f 1` AMDGPU_HWMON=`ls -la /sys/class/hwmon | grep $AMDGPU_PCI_ADDR | awk '{print $9}'` HWMON_DIR=/sys/class/hwmon/${AMDGPU_HWMON} LOGFILE=pp_printf.test.log lspci -nn | gre

[PATCH 4/4] amdgpu/pm: Replace amdgpu_pm usage of sprintf with sysfs_emit

2021-08-07 Thread Darren Powell
replacing printfs with sysfs_emit === Test === AMDGPU_PCI_ADDR=`lspci -nn | grep "VGA\|Display" | cut -d " " -f 1` AMDGPU_HWMON=`ls -la /sys/class/hwmon | grep $AMDGPU_PCI_ADDR | awk '{print $9}'` HWMON_DIR=/sys/class/hwmon/${AMDGPU_HWMON} LOGFILE=pp_printf.test.log lspci -nn | grep "VGA\|Displ

[PATCH 0/4] Replace usage of sprintf with sysfs_emit in hwmgr powerplay

2021-08-07 Thread Darren Powell
=== Description === Replace usage of sprintf with sysfs_emit in hwmgr powerplay === Test System === * DESKTOP(AMD FX-8350 + VEGA10(687F/c3), BIOS: F2) + ISO(Ubuntu 20.04.2 LTS) + Kernel(5.13.0-gb1d634be9673-fdoagd5f) === Patch Summary === linux: (g...@gitlab.freedesktop.org:agd5f) origin/