[PATCH] DRM: gpu: radeon: Fixed coding style issues

2021-08-05 Thread Sergio Miguéns Iglesias
Fixed braces, an unnecessary if statement and added a missing space. Signed-off-by: Sergio Miguéns Iglesias --- drivers/gpu/drm/radeon/radeon_fb.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c i

Re: Linux Mint 20.04 5.11 issue

2021-08-05 Thread Tim Cahill
When launching Chromium from a terminal window, I get the following output: 2606:2626:0804/084411.009101:ERROR:nss_util.cc(286)] After loading Root Certs, loaded==false: NSS error code: -8018mesa: for the --simplifycfg- sink-common option: may only occur zero or one times!mesa: for the -- global-is

[PATCHv2 1/2] drm/amd/amdgpu embed hw_fence into amdgpu_job

2021-08-05 Thread Jingwen Chen
From: Jack Zhang Why: Previously hw fence is alloced separately with job. It caused historical lifetime issues and corner cases. The ideal situation is to take fence to manage both job and fence's lifetime, and simplify the design of gpu-scheduler. How: We propose to embed hw_fence into amdgpu_j

[PATCHv2 2/2] drm/amd/amdgpu: add tdr support for embeded hw_fence

2021-08-05 Thread Jingwen Chen
[Why] After embeded hw_fence to amdgpu_job, we need to add tdr support for this feature. [How] 1. Add a resubmit_flag for resubmit jobs. 2. Clear job fence from RCU and force complete vm flush fences in pre_asic_reset 3. skip dma_fence_get for resubmit jobs and add a dma_fence_put for guilty

RE: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

2021-08-05 Thread Deng, Emily
Acked-by: Emily.Deng >-Original Message- >From: Gu, JiaWei (Will) >Sent: Thursday, August 5, 2021 2:32 PM >To: amd-gfx@lists.freedesktop.org >Cc: Nieto, David M ; Deng, Emily >; Deucher, Alexander > >Subject: RE: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF >mode > >[AMD Off

RE: [PATCH] drm/amdgpu: set default noretry=1 to fix kfd SVM issues for raven

2021-08-05 Thread Zhu, Changfeng
[AMD Official Use Only] Hi Felix, Can we set noretry=1 for dgpu path(ignore_crat=1) which doesn’t to through iommuv2 path on raven as below: > + case CHIP_RAVEN: > + /* > + * TODO: Raven currently can fix most SVM issues with > + * noretry =1. However it

Re: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

2021-08-05 Thread Lazar, Lijo
On 8/5/2021 12:01 PM, Gu, JiaWei (Will) wrote: [AMD Official Use Only] Ping. -Original Message- From: Gu, JiaWei (Will) Sent: Wednesday, August 4, 2021 4:08 PM To: Gu, JiaWei (Will) ; amd-gfx@lists.freedesktop.org Cc: Nieto, David M ; Deng, Emily ; Deucher, Alexander Subject: RE:

RE: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

2021-08-05 Thread Gu, JiaWei (Will)
[AMD Official Use Only] Hi Lijo, It's for Navi12 asic as far as I know. Best regards, Jiawei -Original Message- From: Lazar, Lijo Sent: Thursday, August 5, 2021 5:08 PM To: Gu, JiaWei (Will) ; amd-gfx@lists.freedesktop.org Cc: Nieto, David M ; Deng, Emily ; Deucher, Alexander Subjec

Re: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

2021-08-05 Thread Lazar, Lijo
Navi12 is swsmu based. Suggest you to check the implementation of below sys nodes and decide what you want to do. Not able to figure out how it worked for you, did you really try this on any 1VF system? + AMDGPU_DEVICE_ATTR_RO(pp_num_states, ATTR_FLAG_BASIC|ATT

Re: [PATCH] DRM: gpu: radeon: Fixed coding style issues

2021-08-05 Thread Christian König
Am 04.08.21 um 13:20 schrieb Sergio Miguéns Iglesias: Fixed braces, an unnecessary if statement and added a missing space. Signed-off-by: Sergio Miguéns Iglesias Normally we see patches which just fixes coding style as unnecessary churn, but the "if (rbo) {}" is really ugly here. So Review

Re: [PATCH] drm/amd/amdgpu: skip locking delayed work if not initialized.

2021-08-05 Thread Christian König
Am 05.08.21 um 04:37 schrieb YuBiao Wang: When init failed in early init stage, amdgpu_object has not been initialized, so hasn't the ttm delayed queue functions. Signed-off-by: YuBiao Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH] drm/amdgpu: set default noretry=1 to fix kfd SVM issues for raven

2021-08-05 Thread Felix Kuehling
Am 2021-08-05 um 4:51 a.m. schrieb Zhu, Changfeng: > [AMD Official Use Only] > > Hi Felix, > > Can we set noretry=1 for dgpu path(ignore_crat=1) which doesn’t to through > iommuv2 path on raven as below: There are other possible reasons than ignore_crat for Raven to work in dGPU mode (broken CR

Re: [PATCH] drm/amdkfd: Expose GFXIP engine version to sysfs

2021-08-05 Thread Felix Kuehling
Am 2021-08-04 um 2:17 p.m. schrieb Graham Sider: > Add u32 gfx_version field to kfd_node_properties and kfd_device_info. Update this description with the new property name. With that fixed, the patch is Reviewed-by: Felix Kuehling > Populate _device_info structs accordingly and expose to sysfs

[PATCH v3] drm/radeon: Update pitch for page flip

2021-08-05 Thread Zhenneng Li
When primary bo is updated, crtc's pitch may have not been updated, this will lead to show disorder content when user changes display mode, we update crtc's pitch in page flip to avoid this bug. This refers to amdgpu's pageflip. v1->v2: Update all of the pitch in all of the page_flip functions in

Re: [git pull] drm fixes for 5.14-rc4

2021-08-05 Thread Alex Deucher
On Thu, Aug 5, 2021 at 2:14 PM Linus Torvalds wrote: > > This might possibly have been fixed already by the previous drm pull, > but I wanted to report it anyway, just in case. > > It happened after an uptime of over a week, so it might not be trivial > to reproduce. > > It's a NULL pointer derefe

Re: [git pull] drm fixes for 5.14-rc4

2021-08-05 Thread Linus Torvalds
This might possibly have been fixed already by the previous drm pull, but I wanted to report it anyway, just in case. It happened after an uptime of over a week, so it might not be trivial to reproduce. It's a NULL pointer dereference in dc_stream_retain() with the code being lock xadd %

[PATCH] drm/amd/pm: Fix a memory leak in an error handling path in 'vangogh_tables_init()'

2021-08-05 Thread Christophe JAILLET
'watermarks_table' must be freed instead 'clocks_table', because 'clocks_table' is known to be NULL at this point and 'watermarks_table' is never freed if the last kzalloc fails. Fixes: c98ee89736b8 ("drm/amd/pm: add the fine grain tuning function for vangogh") Signed-off-by: Christophe JAILLET

Re: [PATCH v3] drm/radeon: Update pitch for page flip

2021-08-05 Thread Alex Deucher
On Thu, Aug 5, 2021 at 6:46 AM Zhenneng Li wrote: > > > When primary bo is updated, crtc's pitch may > have not been updated, this will lead to show > disorder content when user changes display mode, > we update crtc's pitch in page flip to avoid > this bug. > This refers to amdgpu's pageflip. > >

Re: [PATCH] DRM: gpu: radeon: Fixed coding style issues

2021-08-05 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Aug 5, 2021 at 8:33 AM Christian König wrote: > > Am 04.08.21 um 13:20 schrieb Sergio Miguéns Iglesias: > > Fixed braces, an unnecessary if statement and added a missing space. > > > > Signed-off-by: Sergio Miguéns Iglesias > > Normally we see patches which just f

Re: [PATCH] drm/amd/pm: Fix a memory leak in an error handling path in 'vangogh_tables_init()'

2021-08-05 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Aug 5, 2021 at 2:44 PM Christophe JAILLET wrote: > > 'watermarks_table' must be freed instead 'clocks_table', because > 'clocks_table' is known to be NULL at this point and 'watermarks_table' is > never freed if the last kzalloc fails. > > Fixes: c98ee89736b8 ("drm

Re: Help needed for EVoC/GSoC/Outreachy

2021-08-05 Thread Lyude Paul
Hi everyone! I got some questions from someone that made me realize that there's a couple of things that I forgot to mention here that might be useful for folks to know regarding being a mentor: * "Who decides what project and what student?" It's up to the student to come up with ideas for what

Re: [PATCHv2 1/2] drm/amd/amdgpu embed hw_fence into amdgpu_job

2021-08-05 Thread Andrey Grodzovsky
On 2021-08-05 4:31 a.m., Jingwen Chen wrote: From: Jack Zhang Why: Previously hw fence is alloced separately with job. It caused historical lifetime issues and corner cases. The ideal situation is to take fence to manage both job and fence's lifetime, and simplify the design of gpu-scheduler.

RE: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy

2021-08-05 Thread Chrisanthus, Anitha
Hi Thomas, > -Original Message- > From: Thomas Zimmermann > Sent: Wednesday, August 4, 2021 12:11 AM > To: Chrisanthus, Anitha ; Sam Ravnborg > > Cc: dan...@ffwll.ch; airl...@linux.ie; alexander.deuc...@amd.com; > christian.koe...@amd.com; liviu.du...@arm.com; brian.star...@arm.com; > bb

[pull] amdgpu drm-fixes-5.14

2021-08-05 Thread Alex Deucher
Hi Dave, Daniel, Same pull, more S-o-b. The following changes since commit d28e2568ac26fff351c846bf74ba6ca5dded733e: Merge tag 'amd-drm-fixes-5.14-2021-07-28' of https://gitlab.freedesktop.org/agd5f/linux into drm-fixes (2021-07-29 17:20:29 +1000) are available in the Git repository at:

[PATCH] drm/amd/pm: bug fix for the runtime pm BACO

2021-08-05 Thread Kenneth Feng
In some systems only MACO is supported. This is to fix the prolbem that runtime pm is enabled but BACO is not supported. MACO will be handled seperately. Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-

RE: [PATCH] drm/amd/pm: bug fix for the runtime pm BACO

2021-08-05 Thread Gui, Jack
[AMD Official Use Only] Tested and Reviewed-by: Jack Gui -Original Message- From: Kenneth Feng Sent: Friday, August 6, 2021 10:35 AM To: amd-gfx@lists.freedesktop.org Cc: Gui, Jack ; Feng, Kenneth Subject: [PATCH] drm/amd/pm: bug fix for the runtime pm BACO In some systems only MACO

RE: [PATCH] drm/amd/amdgpu: skip locking delayed work if not initialized.

2021-08-05 Thread Wang, YuBiao
[AMD Official Use Only] Hi Christian, This part is added by a commit which stated that: When unloading driver after killing some applications, it will hit sdma flush tlb job timeout which is called by ttm_bo_delay_delete. So to avoid the job submit after fence driver fini, call ttm_bo_lock_dela