[PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-22 Thread Evan Quan
The customized OD settings can be divided into two parts: those committed ones and non-committed ones. - For those changes which had been fed to SMU before S3/S4/Runpm suspend kicked, they are committed changes. They should be properly restored and fed to SMU on S3/S4/Runpm resume. - Fo

[PATCH 2/2] drm/amd/pm: restore user customized OD settings properly for Sienna Cichlid

2021-07-22 Thread Evan Quan
Properly restore those committed and non-committed user customized OD settings. Change-Id: I25396df0b3ecdd7a0d9fc77ed220b0abf1fde020 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/inc/smu_v11_0.h | 2 ++ drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 15 +-- .../d

[PATCH] drm/amdgpu: Check pmops for desired suspend state

2021-07-22 Thread Pratik Vishwakarma
[Why] User might set mem_sleep as deep and it will result in amdgpu resume errors. [How] Check with pm for default suspend state Signed-off-by: Pratik Vishwakarma --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/am

[PATCH] drm/amdgpu: Add msix restore for pass-through mode

2021-07-22 Thread Chengzhe Liu
In pass-through mode, after mode 1 reset, msix enablement status would lost and never receives interrupt again. So, we should restore msix status after mode 1 reset. Signed-off-by: Chengzhe Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH] drm/amdgpu: Change the imprecise output

2021-07-22 Thread Roy Sun
The fail reason is that the vfgate is disabled Signed-off-by: Roy Sun --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c index 9f3d82dfb79c..f94ef15b

Re: [PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-22 Thread Lazar, Lijo
On 7/22/2021 8:50 AM, Evan Quan wrote: The customized OD settings can be divided into two parts: those committed ones and non-committed ones. - For those changes which had been fed to SMU before S3/S4/Runpm suspend kicked, they are committed changes. They should be properly restor

RE: [PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-22 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, July 22, 2021 4:10 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH 1/2] drm/amd/pm: restore user customized OD settings > properly for NV1x > > > > O

RE: [PATCH] drm/amdgpu: Change the imprecise output

2021-07-22 Thread Zhou, Peng Ju
[AMD Official Use Only] Reviewed-by: Peng Ju Zhou > -Original Message- > From: amd-gfx On Behalf Of Roy Sun > Sent: Thursday, July 22, 2021 3:14 PM > To: amd-gfx@lists.freedesktop.org > Cc: Sun, Roy > Subject: [PATCH] drm/amdgpu: Change the imprecise output > > The fail reason is that

Re: [PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-22 Thread Lazar, Lijo
On 7/22/2021 2:03 PM, Quan, Evan wrote: [AMD Official Use Only] -Original Message- From: Lazar, Lijo Sent: Thursday, July 22, 2021 4:10 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH 1/2] drm/amd/pm: restore user customized OD setting

[PATCH] drm/amdgpu: fix build error

2021-07-22 Thread Guchun Chen
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c: In function 'smu_cmn_send_msg_without_waiting': drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:259:15: error: 'struct amdgpu_device' has no member named 'in_pci_err_recovery' if (smu->adev->in_pci_err_recovery) ^~ CC [M] dri

ThinkPad T14 Gen 1 AMD switching to lowest brightness during boot process with 5.14-rc2

2021-07-22 Thread Martin Steigerwald
Not subscribed, so please Cc on answer. Hi! Just compiled 5.14-rc2 for my T14 Gen 1 AMD with "AMD Ryzen 7 PRO 4750U with Radeon Graphics" with Low Power Display (400 Nits). Using that kernel, the display starts with the usual high brightness. However, during boot the brightness goes down to wh

Re: drm/amdgpu: Check pmops for desired suspend state

2021-07-22 Thread Raul E Rangel
On Thu, Jul 22, 2021 at 10:57:14AM +0530, Pratik Vishwakarma wrote: > [Why] > User might set mem_sleep as deep and it will result > in amdgpu resume errors. > > [How] > Check with pm for default suspend state > > Signed-off-by: Pratik Vishwakarma > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Jingwen Chen
On Wed Jul 21, 2021 at 12:53:51PM -0400, Andrey Grodzovsky wrote: > > On 2021-07-20 11:13 p.m., Jingwen Chen wrote: > > [Why] > > After embeded hw_fence to amdgpu_job, we need to add tdr support > > for this feature. > > > > [How] > > 1. Add a resubmit_flag for resubmit jobs. > > 2. Clear job fen

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Christian König
Am 22.07.21 um 16:45 schrieb Andrey Grodzovsky: On 2021-07-22 6:45 a.m., Jingwen Chen wrote: On Wed Jul 21, 2021 at 12:53:51PM -0400, Andrey Grodzovsky wrote: On 2021-07-20 11:13 p.m., Jingwen Chen wrote: [Why] After embeded hw_fence to amdgpu_job, we need to add tdr support for this feature.

Re: ThinkPad T14 Gen 1 AMD switching to lowest brightness during boot process with 5.14-rc2

2021-07-22 Thread Alex Deucher
On Thu, Jul 22, 2021 at 10:04 AM Martin Steigerwald wrote: > > Not subscribed, so please Cc on answer. > > Hi! > > Just compiled 5.14-rc2 for my T14 Gen 1 AMD with "AMD Ryzen 7 PRO 4750U > with Radeon Graphics" with Low Power Display (400 Nits). > > Using that kernel, the display starts with the u

Re: [PATCH v4 10/13] lib: test_hmm add module param for zone device type

2021-07-22 Thread Jason Gunthorpe
On Sat, Jul 17, 2021 at 02:21:32PM -0500, Alex Sierra wrote: > In order to configure device generic in test_hmm, two > module parameters should be passed, which correspon to the > SP start address of each device (2) spm_addr_dev0 & > spm_addr_dev1. If no parameters are passed, private device > type

Re: [PATCH] drm/amdgpu: fix build error

2021-07-22 Thread Luben Tuikov
On 2021-07-22 5:25 a.m., Guchun Chen wrote: > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c: In function > 'smu_cmn_send_msg_without_waiting': > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:259:15: error: 'struct > amdgpu_device' has no member named 'in_pci_err_recovery' >if (smu->adev

RE: [PATCH] drm/amdgpu: fix build error

2021-07-22 Thread Chen, Guchun
[Public] I guess your branch does not have below patch: 7afefb81b72c drm/amdgpu: Rename flag which prevents HW access Regards, Guchun -Original Message- From: Tuikov, Luben Sent: Thursday, July 22, 2021 10:14 PM To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Deuch

Re: [PATCH] drm/amdgpu: fix build error

2021-07-22 Thread Luben Tuikov
Please push your patch now that it's been reviewed. Regards, Luben On 2021-07-22 10:22 a.m., Chen, Guchun wrote: > [Public] > > I guess your branch does not have below patch: > > 7afefb81b72c drm/amdgpu: Rename flag which prevents HW access > > Regards, > Guchun > > -Original Message- > F

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Andrey Grodzovsky
On 2021-07-22 6:45 a.m., Jingwen Chen wrote: On Wed Jul 21, 2021 at 12:53:51PM -0400, Andrey Grodzovsky wrote: On 2021-07-20 11:13 p.m., Jingwen Chen wrote: [Why] After embeded hw_fence to amdgpu_job, we need to add tdr support for this feature. [How] 1. Add a resubmit_flag for resubmit jobs

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Jingwen Chen
On Thu Jul 22, 2021 at 10:45:40AM -0400, Andrey Grodzovsky wrote: > > On 2021-07-22 6:45 a.m., Jingwen Chen wrote: > > On Wed Jul 21, 2021 at 12:53:51PM -0400, Andrey Grodzovsky wrote: > > > On 2021-07-20 11:13 p.m., Jingwen Chen wrote: > > > > [Why] > > > > After embeded hw_fence to amdgpu_job, w

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Jingwen Chen
On Thu Jul 22, 2021 at 06:24:28PM +0200, Christian König wrote: > Am 22.07.21 um 16:45 schrieb Andrey Grodzovsky: > > > > On 2021-07-22 6:45 a.m., Jingwen Chen wrote: > > > On Wed Jul 21, 2021 at 12:53:51PM -0400, Andrey Grodzovsky wrote: > > > > On 2021-07-20 11:13 p.m., Jingwen Chen wrote: > > >

Re: [PATCH v4 10/13] lib: test_hmm add module param for zone device type

2021-07-22 Thread Sierra Guiza, Alejandro (Alex)
On 7/22/2021 7:23 AM, Jason Gunthorpe wrote: On Sat, Jul 17, 2021 at 02:21:32PM -0500, Alex Sierra wrote: In order to configure device generic in test_hmm, two module parameters should be passed, which correspon to the SP start address of each device (2) spm_addr_dev0 & spm_addr_dev1. If no pa

Re: [PATCH] drm/amdgpu: Check pmops for desired suspend state

2021-07-22 Thread Deucher, Alexander
[AMD Official Use Only] I sent a similar patch out a while ago, but never had a chance to follow up on it. The problem is users might change the default. https://www.spinics.net/lists/amd-gfx/msg60578.html Alex From: Vishwakarma, Pratik Sent: Thursday, July 2

Re: [PATCH] drm/amdgpu: Add msix restore for pass-through mode

2021-07-22 Thread Deucher, Alexander
[Public] Acked-by: Alex Deucher From: Chengzhe Liu Sent: Thursday, July 22, 2021 1:49 AM To: amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Koenig, Christian ; Deucher, Alexander ; Xiao, Jack ; Zhang, Hawking ; Xu, Feifei ; Wang, Kevin(Yang) ; Liu, Cheng

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Andrey Grodzovsky
On 2021-07-22 12:47 p.m., Jingwen Chen wrote: On Thu Jul 22, 2021 at 06:24:28PM +0200, Christian König wrote: Am 22.07.21 um 16:45 schrieb Andrey Grodzovsky: On 2021-07-22 6:45 a.m., Jingwen Chen wrote: On Wed Jul 21, 2021 at 12:53:51PM -0400, Andrey Grodzovsky wrote: On 2021-07-20 11:13 p.m

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Jingwen Chen
On Thu Jul 22, 2021 at 01:17:13PM -0400, Andrey Grodzovsky wrote: > > On 2021-07-22 12:47 p.m., Jingwen Chen wrote: > > On Thu Jul 22, 2021 at 06:24:28PM +0200, Christian König wrote: > > > Am 22.07.21 um 16:45 schrieb Andrey Grodzovsky: > > > > On 2021-07-22 6:45 a.m., Jingwen Chen wrote: > > > >

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Andrey Grodzovsky
On 2021-07-22 1:27 p.m., Jingwen Chen wrote: On Thu Jul 22, 2021 at 01:17:13PM -0400, Andrey Grodzovsky wrote: On 2021-07-22 12:47 p.m., Jingwen Chen wrote: On Thu Jul 22, 2021 at 06:24:28PM +0200, Christian König wrote: Am 22.07.21 um 16:45 schrieb Andrey Grodzovsky: On 2021-07-22 6:45 a.m.

Re: [PATCH v4 10/13] lib: test_hmm add module param for zone device type

2021-07-22 Thread Jason Gunthorpe
On Thu, Jul 22, 2021 at 11:59:17AM -0500, Sierra Guiza, Alejandro (Alex) wrote: > > On 7/22/2021 7:23 AM, Jason Gunthorpe wrote: > > On Sat, Jul 17, 2021 at 02:21:32PM -0500, Alex Sierra wrote: > > > In order to configure device generic in test_hmm, two > > > module parameters should be passed, wh

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Jingwen Chen
On Thu Jul 22, 2021 at 01:50:09PM -0400, Andrey Grodzovsky wrote: > > On 2021-07-22 1:27 p.m., Jingwen Chen wrote: > > On Thu Jul 22, 2021 at 01:17:13PM -0400, Andrey Grodzovsky wrote: > > > On 2021-07-22 12:47 p.m., Jingwen Chen wrote: > > > > On Thu Jul 22, 2021 at 06:24:28PM +0200, Christian Kö

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Christian König
Am 22.07.21 um 18:47 schrieb Jingwen Chen: On Thu Jul 22, 2021 at 06:24:28PM +0200, Christian König wrote: Am 22.07.21 um 16:45 schrieb Andrey Grodzovsky: On 2021-07-22 6:45 a.m., Jingwen Chen wrote: On Wed Jul 21, 2021 at 12:53:51PM -0400, Andrey Grodzovsky wrote: On 2021-07-20 11:13 p.m., J