[PATCH] drm/amdgpu: Clear doorbell interrupt status for Sienna Cichlid

On Sienna Cichlid, in pass-through mode, if we unload the driver in BACO mode(RTPM), then the kernel would receive thousands of interrupts. That's because there is doorbell monitor interrupt on BIF, so KVM keeps injecting interrupts to the guest VM. So we should clear the doorbell interrupt status

RE: [PATCH 1/2] drm/amd/pm: Add information about SMU11 firmware version

[Public] In the SMU issue troubleshooting process we also can check the SMU version by reading MP1 scratch register and from long term we may need put the SMC version collection in the debug sysfs amdgpu_firmware_info. In this patch fashion, we better use dev_dbg instead of dev_info for only d

[PATCH 2/2] drm: add tdr support for embeded hw_fence

[Why] After embeded hw_fence to amdgpu_job, we need to add tdr support for this feature. [How] 1. Add a resubmit_flag for resubmit jobs. 2. Clear job fence from RCU and force complete vm flush fences in pre_asic_reset 3. skip dma_fence_get for resubmit jobs and add a dma_fence_put for guilty

[PATCH] drm/amdgpu/gfx10: fix mixed declaration and code warning

Move the declaration up to the top of the function. Fixes: 631d55e089eaa8 ("drm/amdgpu: Add error message when programing registers fails") Cc: Roy Sun Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

Re: [PATCH 1/2] drm/amd/pm: Add information about SMU11 firmware version

On 7/20/2021 22:07, Liang, Prike wrote: [Public] In the SMU issue troubleshooting process we also can check the SMU version by reading MP1 scratch register and from long term we may need put the SMC version collection in the debug sysfs amdgpu_firmware_info In this patch fashion, we better u

[PATCH 1/2] drm/amd/amdgpu embed hw_fence into amdgpu_job

From: Jack Zhang Why: Previously hw fence is alloced separately with job. It caused historical lifetime issues and corner cases. The ideal situation is to take fence to manage both job and fence's lifetime, and simplify the design of gpu-scheduler. How: We propose to embed hw_fence into amdgpu_j

Re: [RFC v2 1/2] ppc/fpu: Add generic FPU api similar to x86

> + > +/* > + * Use kernel_fpu_begin/end() if you intend to use FPU in kernel context. It > + * disables preemption so be careful if you intend to use it for long periods > + * of time. > + * TODO: If you intend to use the FPU in irq/softirq you need to check first > with > + * irq_fpu_usable() if

Re: [RFC v2 2/2] drm/amd/display: Use PPC FPU functions

On Wed, Jul 21, 2021 at 08:29:43AM +0200, Christian K??nig wrote: > Looks good in general, but question is what about other architectures like > ARM? DRM_AMD_DC_DCN currently requires X86 || PPC64. Maybe a good think would be to add a new KERNEL_FPU_API Kconfig symbol, selected by x86 and powerpc

RE: [PATCH 1/2] drm/amd/pm: Add information about SMU11 firmware version

[Public] > -Original Message- > From: Limonciello, Mario > Sent: Wednesday, July 21, 2021 11:15 AM > To: Liang, Prike ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 1/2] drm/amd/pm: Add information about SMU11 > firmware version > > On 7/20/2021 22:07, Liang, Prike wrote: > > [Publ

RE: [PATCH] drm/amd/amdgpu: consider paging job always not guilty

[AMD Official Use Only] Hi Christian, I have uploaded the latest patch according to your suggestion. Best Regards, JingWen Chen -Original Message- From: Christian König Sent: Tuesday, July 20, 2021 8:13 PM To: Chen, JingWen ; amd-gfx@lists.freedesktop.org Cc: Chen, Horace ; Liu, Monk

[PATCH v2 1/2] drm/amd/display: Revert "Re-enable 'Guard ASSR with internal display flag'"

[Why] A new change that simplifies the ASSR enabling and guarding is found that also fixes regression on some embedded panels. [How] Revert the ASSR changes in preparation for upcoming patch. Reviewed-by: Alex Deucher Signed-off-by: Stylon Wang --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c

[PATCH v2 2/2] drm/amd/display: Fix ASSR regression on embedded panels

[Why] Regression found in some embedded panels traces back to the earliest upstreamed ASSR patch. The changed code flow are causing problems with some panels. [How] - Change ASSR enabling code while preserving original code flow as much as possible - Simplify the code on guarding with internal d

[PATCH v2 0/2] Fix regression on embedded panels caused by enabling ASSR

Previous ASSR-enabling patches cause blank screen on some embedded panels. This patch set minimize the changes made to code logic prior to the ASSR change and also improve on code readability. Changes from prior rev1 to now: v2: - Update reviewed-by and bug links Stylon Wang (2): drm/amd/dis

Re: [PATCH 1/7] vgaarb: remove VGA_DEFAULT_DEVICE

Am 20.07.21 um 15:50 schrieb Daniel Vetter: On Fri, Jul 16, 2021 at 09:14:02AM +0200, Christian König wrote: Am 16.07.21 um 08:16 schrieb Christoph Hellwig: The define is entirely unused. Signed-off-by: Christoph Hellwig I'm not an expert for this particular code, but at least of hand ever

[RFC v2 0/2] PPC: Add generic FPU api similar to x86

This is an attempt to have generic FPU enable/disable calls similar to x86. So that we can simplify gpu/drm/amd/display/dc/os_types.h Also adds FPU correctness logic seen in x86. v2: - Added asm/fpu/api.h powerpc variant with kernel_fpu_begin/end() and kernel_fpu_enabled() declarations - Updat

[RFC v2 2/2] drm/amd/display: Use PPC FPU functions

Use kernel_fpu_begin & kernel_fpu_end for PPC Depends on "ppc/fpu: Add generic FPU api similar to x86" v2: - Got rid of macro switch for PPC as header file with same name as x86 is added by previous patch in the series Signed-off-by: Anson Jacob CC: Christoph Hellwig CC: Rodrigo Siqueira CC

[RFC v2 1/2] ppc/fpu: Add generic FPU api similar to x86

- Add kernel_fpu_begin & kernel_fpu_end API as x86 - Add logic similar to x86 to ensure fpu begin/end call correctness - Add kernel_fpu_enabled to know if FPU is enabled v2: - Added asm/fpu/api.h powerpc variant with kernel_fpu_begin/end() and kernel_fpu_enabled() declarations - Updated kernel

Re: [RFC v2 2/2] drm/amd/display: Use PPC FPU functions

Am 21.07.21 um 06:48 schrieb Anson Jacob: Use kernel_fpu_begin & kernel_fpu_end for PPC Depends on "ppc/fpu: Add generic FPU api similar to x86" v2: - Got rid of macro switch for PPC as header file with same name as x86 is added by previous patch in the series Signed-off-by: Anson Jacob CC

Re: [RFC v2 2/2] drm/amd/display: Use PPC FPU functions

Am 21.07.21 um 08:51 schrieb Christoph Hellwig: On Wed, Jul 21, 2021 at 08:29:43AM +0200, Christian K??nig wrote: Looks good in general, but question is what about other architectures like ARM? DRM_AMD_DC_DCN currently requires X86 || PPC64. And exactly that's the problem I'm noting here. At

Re: [PATCH] drm/amdgpu/acp: Make PM domain really work

Applied. Thanks! I've removed the unused variables when I applied. Alex On Tue, Jul 20, 2021 at 1:31 PM Kai-Heng Feng wrote: > > Devices created by mfd_add_hotplug_devices() don't really increase the > index of its name, so get_mfd_cell_dev() cannot find any device, hence a > NULL dev is passe

Re: [PATCH v3 2/4] drm/amd/display: Add FPU event trace

On 07/20, Christian König wrote: > > > Am 20.07.21 um 02:49 schrieb Rodrigo Siqueira: > > We don't have any mechanism for tracing FPU operations inside the > > display core, making the debug work a little bit tricky. This commit > > introduces a trace mechanism inside our DC_FP_START/END macros f

Re: [PATCH v3 2/4] drm/amd/display: Add FPU event trace

Am 21.07.21 um 13:44 schrieb Rodrigo Siqueira: On 07/20, Christian König wrote: Am 20.07.21 um 02:49 schrieb Rodrigo Siqueira: We don't have any mechanism for tracing FPU operations inside the display core, making the debug work a little bit tricky. This commit introduces a trace mechanism ins

Re: [PATCH v5 0/2] Add p2p via dmabuf to habanalabs

On Sun, Jul 11, 2021 at 05:05:59PM +0300, Oded Gabbay wrote: > Hi, > This is v5 of this patch-set following again a long email thread. > > It contains fixes to the implementation according to the review that Jason > did on v4. Jason, I appreciate your feedback. If you can take another look > to se

[PATCH] drm/amd/amdgpu: add consistent PSP FW loading size checking

[Public] Signed-off-by: Candice Li candice...@amd.com --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 108 -- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 32 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_u

[RESEND PATCH v6 06/14] drm/amd: Gate i2c transaction logs on drm_debug_syslog

From: Sean Paul Since the logs protected by these checks specifically target syslog, use the new drm_debug_syslog_enabled() call to avoid triggering these prints when only trace is enabled. Acked-by: Christian König Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/

Re: [PATCH v2 0/2] Fix regression on embedded panels caused by enabling ASSR

[Public] Series looks good to me. Thanks! Alex From: amd-gfx on behalf of Stylon Wang Sent: Wednesday, July 21, 2021 12:25 AM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing ; Siqueira, R

[PATCH 2/2] drm/amdgpu: add yellow carp pci id (v2)

From: Aaron Liu Add Yellow Carp PCI id support. v2: add another DID Signed-off-by: Aaron Liu Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/driv

[PATCH 1/2] drm/amdgpu: update yellow carp external rev_id handling

From: Aaron Liu 0x1681 has a different external revision id. Signed-off-by: Aaron Liu Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/d

Re: [PATCH] drm/amdgpu: Clear doorbell interrupt status for Sienna Cichlid

Yeah, looks good. Acked-by: Luben Tuikov On 2021-07-20 11:02 p.m., Chengzhe Liu wrote: > On Sienna Cichlid, in pass-through mode, if we unload the driver in BACO > mode(RTPM), then the kernel would receive thousands of interrupts. > That's because there is doorbell monitor interrupt on BIF, so K

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

On 2021-07-20 11:13 p.m., Jingwen Chen wrote: [Why] After embeded hw_fence to amdgpu_job, we need to add tdr support for this feature. [How] 1. Add a resubmit_flag for resubmit jobs. 2. Clear job fence from RCU and force complete vm flush fences in pre_asic_reset 3. skip dma_fence_get for

[PATCH 0/3] drm/amdgpu: modernize virtual display feature

The amdgpu vkms interface provides a virtual KMS interface for several use cases: devices without display hardware, platforms where the actual display hardware is not useful (e.g., servers), SR-IOV virtual functions, device emulation/simulation, and device bring up prior to display hardware being u

[PATCH 1/3] drm/amdgpu: create amdgpu_vkms (v2)

Modify the VKMS driver into an api that dce_virtual can use to create virtual displays that obey drm's atomic modesetting api. v2: Made local functions static. Reported-by: kernel test robot Signed-off-by: Ryan Taylor --- drivers/gpu/drm/amd/amdgpu/Makefile | 1 + drivers/gpu/drm/amd/am

[PATCH 2/3] drm/amdgpu: cleanup dce_virtual

Remove obsolete functions and variables from dce_virtual. Signed-off-by: Ryan Taylor --- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 568 +-- 1 file changed, 3 insertions(+), 565 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/

[PATCH 3/3] drm/amdgpu: replace dce_virtual with amdgpu_vkms (v3)

Move dce_virtual into amdgpu_vkms and update all references to dce_virtual with amdgpu_vkms. v2: Removed more references to dce_virtual. v3: Restored display modes from previous implementation. Reported-by: kernel test robot Suggested-by: Alex Deucher Signed-off-by: Ryan Taylor --- drivers/g

Re: [PATCH] drm/amd/pm: Fix a bug communicating with the SMU (v5)

On Mon, Jul 19, 2021 at 7:18 PM Luben Tuikov wrote: > > This fixes a bug which if we probe a non-existing > I2C device, and the SMU returns 0xFF, from then on > we can never communicate with the SMU, because the > code before this patch reads and interprets 0xFF > as a terminal error, and thus we

[pull] amdgpu drm-fixes-5.14

Hi Dave, Daniel, Updates for 5.14. Mostly fixes for new asics added in 5.14. The following changes since commit 876d98e5511d8cfd12fc617a6717e7a8ea07be17: Merge tag 'drm-intel-fixes-2021-07-15' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes (2021-07-16 10:53:02 +1000) are ava

[PATCH] drm/amdgpu/display: only enable aux backlight control for OLED panels

We've gotten a number of reports about backlight control not working on panels which indicate that they use aux backlight control. A recent patch: commit 2d73eabe2984a435737498ab39bb1500a9ffe9a9 Author: Camille Cho Date: Thu Jul 8 18:28:37 2021 +0800 drm/amd/display: Only set default brig