[PATCH -next] drm/amdgpu: Fix missing unlock on error in amdgpu_ras_debugfs_table_read()

2021-07-05 Thread Yang Yingliang
Add the missing unlock before return from function amdgpu_ras_debugfs_table_read() in the error handling case. Fixes: 9b790694a031 ("drm/amdgpu: RAS EEPROM table is now in debugfs") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 6

Xorg doesn't work anymore after the latest DRM updates

2021-07-05 Thread Christian Zigotzky
Hi All, Xorg doesn't work anymore after the latest DRM updates. [1] Error messages: Jul 03 08:54:51 Fienix systemd[1]: Starting Light Display Manager... Jul 03 08:54:51 Fienix systemd[1]: Started Light Display Manager. Jul 03 08:54:51 Fienix kernel: BUG: Kernel NULL pointer dereference on read

[PATCH] drm/amdgpu: initialize amdgpu_ras_query_error_count() error count parameters

2021-07-05 Thread trix
From: Tom Rix Static analysis reports this problem amdgpu_ras.c:2324:2: warning: 2nd function call argument is an uninitialized value atomic_set(&con->ras_ce_count, ce_count); ^~~~ ce_count is normally set by the earlier call to amdgpu_ras_qu

Re: Xorg doesn't work anymore after the latest DRM updates

2021-07-05 Thread Christian Zigotzky
Oh dear, there is another issue after the latest PowerPC updates. The X5000 doesn't boot anymore. Error messages: Oops: Exeption in kernel node, sig: 4 [#1] ... Kernel panic - not syncing: Attempted to kill init! exitcode=0x0004 --- Unfortunately we have two issues at the same time. We ar

Re: [PATCH v4] drm/amdgpu: Restore msix after FLR

2021-07-05 Thread Lazar, Lijo
On 7/2/2021 8:53 AM, Peng Ju Zhou wrote: From: "Emily.Deng" After FLR, the msix will be cleared, so need to re-enable it. Signed-off-by: Emily.Deng Signed-off-by: Peng Ju Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

Re: Xorg doesn't work anymore after the latest DRM updates

2021-07-05 Thread Das, Nirmoy
Hi Christian, This issue looks similar to the one Mikel Rychliski fixed recently  : https://patchwork.freedesktop.org/patch/440791. Let us know if this helps. Regards, Nirmoy On 7/3/2021 9:30 AM, Christian Zigotzky wrote: Hi All, Xorg doesn't work anymore after the latest DRM updates. [1

[PATCH v4 0/2] Add p2p via dmabuf to habanalabs

2021-07-05 Thread Oded Gabbay
Hi, I'm sending v4 of this patch-set following the long email thread. I want to thank Jason for reviewing v3 and pointing out the errors, saving us time later to debug it :) I consulted with Christian on how to fix patch 2 (the implementation) and at the end of the day I shamelessly copied the rel

[PATCH v4 1/2] habanalabs: define uAPI to export FD for DMA-BUF

2021-07-05 Thread Oded Gabbay
User process might want to share the device memory with another driver/device, and to allow it to access it over PCIe (P2P). To enable this, we utilize the dma-buf mechanism and add a dma-buf exporter support, so the other driver can import the device memory and access it. The device memory is al

[PATCH v4 2/2] habanalabs: add support for dma-buf exporter

2021-07-05 Thread Oded Gabbay
From: Tomer Tayar Implement the calls to the dma-buf kernel api to create a dma-buf object backed by FD. We block the option to mmap the DMA-BUF object because we don't support DIRECT_IO and implicit P2P. We only implement support for explicit P2P through importing the FD of the DMA-BUF. In the

[PATCH] SWDEV-291099 - Use a percise function name

2021-07-05 Thread Roy Sun
The callback functions are used for SRIOV read/write instead of just for rlcg read/write Signed-off-by: Roy Sun --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.h| 4 ++-- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 4 ++-- drivers/gpu/drm/amd/amd

RE: [PATCH 1/2] drm/amd/pm: Add I2C quirk table to Aldebaran

2021-07-05 Thread Lazar, Lijo
[Public] Series is Reviewed-by: Lijo Lazar -Original Message- From: Tuikov, Luben Sent: Saturday, July 3, 2021 5:55 AM To: amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Deucher, Alexander ; Grodzovsky, Andrey ; Lazar, Lijo ; Clements, John ; Zhang, Hawking Subject: [PA

Re: [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-07-05 Thread Werner Sembach
Am 01.07.21 um 15:24 schrieb Pekka Paalanen: > On Thu, 1 Jul 2021 14:50:13 +0200 > Werner Sembach wrote: > >> Am 01.07.21 um 10:07 schrieb Pekka Paalanen: >> >>> On Wed, 30 Jun 2021 11:20:18 +0200 >>> Werner Sembach wrote: >>> Am 30.06.21 um 10:41 schrieb Pekka Paalanen: > On

Re: [PATCH 1/4] drm/amdgpu: fix a signedness bug in __verify_ras_table_checksum()

2021-07-05 Thread Luben Tuikov
Alex, I think we should pull these through amd-staging-drm-next. Regards, Luben On 2021-07-04 11:18 a.m., Luben Tuikov wrote: > Series is, > Reviewed-by: Luben Tuikov > > Regards, > Luben > > On 2021-07-03 5:44 a.m., Dan Carpenter wrote: >> If amdgpu_eeprom_read() returns a negative error code

RE: [PATCH -next] drm/amdgpu: Fix missing unlock on error in amdgpu_ras_debugfs_table_read()

2021-07-05 Thread Chen, Guchun
[Public] Thank you for the patch, Yingliang. There is a similar patch sent out last Saturday and under review. Please check it. [PATCH 3/4] drm/amdgpu: unlock on error in amdgpu_ras_debugfs Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Yang Yingliang Sent: Monday, Ju