RE: [PATCH 2/2] drm/amdgpu/acpi: make ATPX/ATCS structures global

[Public] -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, May 26, 2021 8:53 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 2/2] drm/amdgpu/acpi: make ATPX/ATCS structures global They are global ACPI methods, so maybe the structur

RE: [PATCH] drm/amd/amdgpu:save psp ring wptr in SRIOV to avoid attack

[AMD Official Use Only] Reviewed-by: Emily Deng >-Original Message- >From: amd-gfx On Behalf Of Jingwen >Chen >Sent: Wednesday, May 26, 2021 2:55 PM >To: amd-gfx@lists.freedesktop.org >Cc: Chen, JingWen ; Zhao, Victor >; Liu, Monk >Subject: [PATCH] drm/amd/amdgpu:save psp ring wptr in

RE: [PATCH] drm/amd/amdgpu:save psp ring wptr in SRIOV to avoid attack

[AMD Official Use Only] >>+ ring->ring_wptr = psp_write_ptr_reg; Put the cache mechanism into the callbacks please >>+ ring->ring_wptr = 0; It is not needed At last, try to put more details in the comment to let people know why we need this PSP WPTR cache mechanism Thanks

[PATCHv2] drm/amd/amdgpu:save psp ring wptr to avoid attack

From: Victor Zhao [Why] When some tools performing psp mailbox attack, the readback value of register can be a random value which may break psp. [How] Use a psp wptr cache machanism to aovid the change made by attack. v2: unify change and add detailed reason Change-Id: Idee78e8c1c781463048f2f6

RE: [PATCH] drm/amd/amdgpu:save psp ring wptr in SRIOV to avoid attack

Hi Monk, New patch submitted according to your suggestion Best Regards, JingWen Chen -Original Message- From: Liu, Monk Sent: Wednesday, May 26, 2021 3:24 PM To: Chen, JingWen ; amd-gfx@lists.freedesktop.org Cc: Zhao, Victor ; Chen, JingWen Subject: RE: [PATCH] drm/amd/amdgpu:save psp

[PATCH] drm/amd/pm: retain the fine grain tuning parameters after resume

This patch is to retain the fine grain tuning parameters after resume for legacy APU, it will cover Raven/Raven2/Picasso. Signed-off-by: Xiaojian Du --- .../amd/pm/powerplay/hwmgr/hardwaremanager.c | 3 ++- .../drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c | 21 +++ 2 files changed

RE: [PATCH v2] drm/amdgpu: fix metadata_size for ubo ioctl queries

[AMD Official Use Only] Reviewed-by: Nirmoy Das -Original Message- From: Zhang, Morris Sent: Wednesday, May 26, 2021 5:11 AM To: amd-gfx@lists.freedesktop.org; Das, Nirmoy Subject: [PATCH v2] drm/amdgpu: fix metadata_size for ubo ioctl queries Although the kfd_ioctl_get_dmabuf_info()

Re: radeon ring 0 test failed on arm64

Hi Robin, Am 25.05.21 um 22:09 schrieb Robin Murphy: On 2021-05-25 14:05, Alex Deucher wrote: On Tue, May 25, 2021 at 8:56 AM Peter Geis wrote: On Tue, May 25, 2021 at 8:47 AM Alex Deucher wrote: On Tue, May 25, 2021 at 8:42 AM Peter Geis wrote: Good Evening, I am stress testing the

Re: [PATCH] drm/amd/amdgpu: Disable page fault retry for beige_goby

[AMD Official Use Only] Reviewed-by: Tao Zhou mailto:tao.zh...@amd.com>> From: Chengming Gui Sent: Wednesday, May 26, 2021 3:48 PM To: amd-gfx@lists.freedesktop.org Cc: Gui, Jack ; Zhou1, Tao ; Chen, Jiansong (Simon) ; Zhang, Hawking Subject: [PATCH] drm/amd/am

RE: [PATCH] drm/amdgpu: Correctly clear GCEA error status

[AMD Official Use Only - Internal Distribution Only] Reviewed-by: John Clements -Original Message- From: Joshi, Mukul Sent: Wednesday, May 26, 2021 4:20 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Clements, John ; Li, Dennis ; Joshi, Mukul Subject: [PATCH] drm/amdgpu:

[PATCH 2/7] drm/amdgpu: move shadow bo validation to VM code

Do the shadow bo validation in the VM code as VM code knows/owns shadow BOs. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 23 --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 + 2 files changed, 9 insertions(+), 19 deletions(-) diff --git a/drive

[PATCH 3/7] drm/amdgpu: use amdgpu_bo_vm for vm code

Use amdgpu_bo_vm subclass for creating BOs related to PD/PT. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 43 ++ 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/

[PATCH v2 7/7] drm/amdgpu: do not allocate entries separately

Allocate PD/PT entries while allocating VM BOs and use that instead of allocating those entries separately. v2: create a new var for num entries. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 34 +++--- 1 file changed, 20 insertions(+), 14 deletions(

[PATCH 1/7] drm/amdgpu: add amdgpu_bo_vm bo type

Add new BO subclass that will be used by amdgpu vm code. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 32 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 10 +++ 2 files changed, 42 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgp

[PATCH 4/7] drm/amdgpu: create shadow bo directly

Shadow BOs are only needed by VM code so create it directly within the vm code. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/d

[PATCH 5/7] drm/amdgpu: switch to amdgpu_bo_vm for shadow pointer

The subclass, amdgpu_bo_vm is intended for PT/PD BOs which are shadowed, so switch to shadow pointer of amdgpu_bo_vm. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 27 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 16 ++-- 2 files chang

[PATCH 6/7] drm/amdgpu: remove unused code

Remove unused code related to shadow BO. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 29 -- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 3 --- 2 files changed, 32 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers

[PATCH] drm/amdgpu: Fix Gstreamer api vaapih264enc missing

since vcn decoding ring is not required, so just disable it. Cc: Alex.Deucher Cc: Christian.Konig Signed-off-by: Li.Xin.Justin Signed-off-by: Frank.Min --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 25 ++--- 2 files chan

Re: [PATCH 3/3] drm/amdgpu: Use delayed work to collect RAS error counters

Am 26.05.21 um 02:40 schrieb Luben Tuikov: On Context Query2 IOCTL return the correctable and uncorrectable errors in O(1) fashion, from cached values, and schedule a delayed work function to calculate and cache them for the next such IOCTL. v2: Cancel pending delayed work at ras_fini(). Cc: Al

RE: [PATCH 1/2] drm/amdgpu/acpi: fix typo in ATCS handling

[AMD Official Use Only - Internal Distribution Only] Tested-by: Sathishkumar S Reviewed-by: Sathishkumar S -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, May 26, 2021 8:53 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 1/2] drm

Re: [PATCH] drm/amdgpu: Fix Gstreamer api vaapih264enc missing

Am 26.05.21 um 12:13 schrieb Li, Xin (Justin): since vcn decoding ring is not required, so just disable it. Cc: Alex.Deucher Cc: Christian.Konig Signed-off-by: Li.Xin.Justin Signed-off-by: Frank.Min --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/vcn_v2

RE: [PATCH 3/3] drm/amdgpu: Use delayed work to collect RAS error counters

[AMD Official Use Only] Scheduling an error status query just based on IOCTL doesn't sound like a sound approach. What if driver needs to handle errors based on that - for ex: if the number of correctable errors exceed a certain threshold? IMO, I'm more aligned to Luben's original approach of h

Re: radeon ring 0 test failed on arm64

Hi Robin, Am 26.05.21 um 12:59 schrieb Robin Murphy: On 2021-05-26 10:42, Christian König wrote: Hi Robin, Am 25.05.21 um 22:09 schrieb Robin Murphy: On 2021-05-25 14:05, Alex Deucher wrote: On Tue, May 25, 2021 at 8:56 AM Peter Geis wrote: On Tue, May 25, 2021 at 8:47 AM Alex Deucher w

RE: [PATCH] free the metadata buffer for sg type BOs as well

[AMD Official Use Only] Please add a commit message as well. With that, this is Acked-by: Nirmoy Das but Christian should review it as well. Nirmoy -Original Message- From: Zhang, Morris Sent: Wednesday, May 26, 2021 5:46 AM To: amd-gfx@lists.freedesktop.org; Das, Nirmoy Subject: [P

Re: [PATCH 6/7] drm/amdgpu: remove unused code

[AMD Official Use Only] I just realized that I didn't remove the shadow pointer from the amdgpu_bo. I will update that in the next version. Regards, Nirmoy From: Das, Nirmoy Sent: Wednesday, May 26, 2021 12:10 PM To: amd-gfx@lists.freedesktop.org Cc: Koenig, Ch

RE: [PATCH] drm/amdgpu: Correctly clear GCEA error status

[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Joshi, Mukul Sent: Wednesday, May 26, 2021 04:20 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Clements, John ; Li, Dennis ; Joshi, Mukul Subject: [PATCH] drm/amdgpu: Correctly clea

Re: [PATCH v4 0/7] drm: Clean up mmap for TTM-based GEM drivers

Patches #1-#4 are Reviewed-by: Christian König Patches #5 and #6 are Acked-by: Christian König Patch #7 already has my rb. I would say push that to drm-misc-next ASAP. Regards, Christian. Am 25.05.21 um 17:10 schrieb Thomas Zimmermann: Implement mmap via struct drm_gem_object_functions.mma

Re: [PATCH 1/7] drm/amdgpu: add amdgpu_bo_vm bo type

Am 26.05.21 um 12:10 schrieb Nirmoy Das: Add new BO subclass that will be used by amdgpu vm code. Signed-off-by: Nirmoy Das Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 32 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 10 +++

Re: [PATCH 2/7] drm/amdgpu: move shadow bo validation to VM code

Am 26.05.21 um 12:10 schrieb Nirmoy Das: Do the shadow bo validation in the VM code as VM code knows/owns shadow BOs. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 23 --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 + 2 files changed, 9 inse

RE: [PATCH 2/7] drm/amdgpu: move shadow bo validation to VM code

[AMD Official Use Only] Thanks Christian, I found some more issues as well, I will update and resend again. -Original Message- From: Koenig, Christian Sent: Wednesday, May 26, 2021 2:03 PM To: Das, Nirmoy ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH 2/7]

Re: [PATCH 3/7] drm/amdgpu: use amdgpu_bo_vm for vm code

Am 26.05.21 um 12:10 schrieb Nirmoy Das: Use amdgpu_bo_vm subclass for creating BOs related to PD/PT. I think it would be better if you just squash patch #3, #4 and #5 together. Apart from that looks good to me, but still need to double check patch #7. Christian. Signed-off-by: Nirmoy Das

Re: [PATCH] free the metadata buffer for sg type BOs as well

You need a commit message. Am 26.05.21 um 05:46 schrieb Shiwu Zhang: Signed-off-by: Shiwu Zhang With that fixed the patch is Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/

[PATCH 12/34] drm/amd/display/amdgpu_dm/amdgpu_dm: Functions must directly follow their headers

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:608: warning: Function parameter or member 'interrupt_params' not described in 'dm_dcn_vertical_interrupt0_high_irq' Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian Kön

[PATCH 03/34] drm/amd/pm/powerplay/hwmgr/smu7_thermal: Provide function name for 'smu7_fan_ctrl_set_default_mode()'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_thermal.c:132: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Evan Quan Cc: Alex Deucher Cc: "Christian König" Cc

[PATCH 10/34] drm/amd/display/dc/bios/bios_parser: Fix formatting and misnaming issues

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:997: warning: expecting prototype for get_ss_info_from_table(). Prototype was for get_ss_info_from_tbl() instead drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1562: warnin

[PATCH 22/34] drm/amd/display/dc/core/dc: Convert function headers to kernel-doc

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3324: warning: Cannot understand * drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3344: warning: Cannot understa

[PATCH 24/34] drm/amd/display/modules/hdcp/hdcp_psp: Remove unused function 'mod_hdcp_hdcp1_get_link_encryption_status()'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:374:22: warning: no previous prototype for ‘mod_hdcp_hdcp1_get_link_encryption_status’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König"

[PATCH 05/34] drm/amd/pm/powerplay/hwmgr/vega12_hwmgr: Provide 'vega12_init_smc_table()' function name

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega12_hwmgr.c:812: warning: expecting prototype for Initializes the SMC table and uploads it(). Prototype was for vega12_init_smc_table() instead Cc: Evan Quan Cc: Alex Deucher Cc: "Christian K

[PATCH -next] drm/amdgpu: Fix Wunused-label warning

If CONFIG_64BIT is n, build warns: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:333:1: warning: label ‘exit’ defined but not used [-Wunused-label] Fixes: f89f8c6bafd0 ("drm/amdgpu: Guard against write accesses after device removal") Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/amdgpu/amdgp

[PATCH 06/34] drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Kernel-doc headers must contain function names

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:547: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hw

[PATCH 14/34] drm/amd/display/dc/gpio/gpio_service: Pass around correct dce_{version, environment} types

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/gpio_service.c: In function ‘dal_gpio_service_create’: drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/gpio_service.c:71:4: warning: implicit conversion from ‘enum dce_version’ to ‘enum dce_environment

[PATCH 17/34] drm/amd/display/dc/dce/dce_mem_input: Remove duplicate initialisation of GRPH_CONTROL__GRPH_NUM_BANKS_{SHIFT, MASK}

Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:29: drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_sh_mask.h:7270:45: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd

[PATCH 04/34] drm/amd/pm/powerplay/hwmgr/vega12_thermal: Provide function name

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega12_thermal.c:171: warning: expecting prototype for Set the requested temperature range for high and low alert signals(). Prototype was for vega12_thermal_set_temperature_range() instead Cc: E

[PATCH 02/34] drm/amd/pm/swsmu/smu13/aldebaran_ppt: Remove unused variable 'ret'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/aldebaran_ppt.c: In function ‘aldebaran_is_dpm_running’: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/aldebaran_ppt.c:1260:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc:

[PATCH 18/34] drm/amd/display/dc/dce/dce_mem_input: Remove duplicate initialisation of GRPH_CONTROL__GRPH_NUM_BANKS_{SHIFT, MASK

Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:29: drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_sh_mask.h:7270:45: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/amd

[PATCH 20/34] drm/amd/display/amdgpu_dm/amdgpu_dm: Fix kernel-doc formatting issue

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:608: warning: Function parameter or member 'interrupt_params' not described in 'dm_dcn_vertical_interrupt0_high_irq' Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian Kön

[PATCH 07/34] drm/amd/pm/powerplay/hwmgr/vega20_hwmgr: Provide function name 'vega20_init_smc_table()'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_hwmgr.c:781: warning: expecting prototype for Initializes the SMC table and uploads it(). Prototype was for vega20_init_smc_table() instead Cc: Evan Quan Cc: Alex Deucher Cc: "Christian K

[PATCH 19/34] drm/amd/amdgpu/amdgpu_device: Make local function static

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4624:6: warning: no previous prototype for ‘amdgpu_device_recheck_guilty_jobs’ [-Wmissing-prototypes] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: a

[PATCH 23/34] drm/amd/display/dmub/src/dmub_srv_stat: Convert function header to kernel-doc

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_srv_stat.c:38: warning: Cannot understand * Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König"

[PATCH 01/34] drm/amd/pm/inc/smu_v13_0: Move table into the only source file that uses it

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/inc/smu_v13_0.h:54:43: warning: ‘smu13_thermal_policy’ defined but not used [-Wunused-const-variable=] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Kevin Wang Cc: amd-gfx@list

[PATCH 00/34] Rid W=1 warnings from GPU

This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (34): drm/amd/pm/inc/smu_v13_0: Move table into the only source file that uses it drm/amd/pm/swsmu/smu13/aldebaran_ppt: Remove unu

[PATCH 16/34] drm/amd/display/dc/dce/dce_transform: Remove superfluous re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL,

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:374:22: warning: no previous prototype for ‘mod_hdcp_hdcp1_get_link_encryption_status’ In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:28: drive

[PATCH 09/34] drm/amd/display/dc/bios/command_table_helper2: Fix function name 'dal_cmd_table_helper_transmitter_bp_to_atom2()'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table_helper2.c:141: warning: expecting prototype for translate_transmitter_bp_to_atom2(). Prototype was for dal_cmd_table_helper_transmitter_bp_to_atom2() instead Cc: Harry Wentland Cc: Leo

[PATCH 13/34] drm/amd/display/dc/dce/dmub_outbox: Convert over to kernel-doc

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_outbox.c:30: warning: Cannot understand * Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc:

[PATCH 21/34] drm/amd/display/dc/dce110/dce110_hw_sequencer: Include header containing our prototypes

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:929:6: warning: no previous prototype for ‘dce110_edp_wait_for_T12’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David A

[PATCH 08/34] drm/amd/display/dc/bios/command_table_helper: Fix function name for 'dal_cmd_table_helper_transmitter_bp_to_atom()'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table_helper.c:127: warning: expecting prototype for translate_transmitter_bp_to_atom(). Prototype was for dal_cmd_table_helper_transmitter_bp_to_atom() instead Cc: Harry Wentland Cc: Leo Li

Re: radeon ring 0 test failed on arm64

On 2021-05-26 10:42, Christian König wrote: Hi Robin, Am 25.05.21 um 22:09 schrieb Robin Murphy: On 2021-05-25 14:05, Alex Deucher wrote: On Tue, May 25, 2021 at 8:56 AM Peter Geis wrote: On Tue, May 25, 2021 at 8:47 AM Alex Deucher wrote: On Tue, May 25, 2021 at 8:42 AM Peter Geis wr

[PATCH 15/34] drm/amd/display/dc/dce110/dce110_hw_sequencer: Include our own header

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:927:6: warning: no previous prototype for ‘dce110_edp_wait_for_T12’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David A

Re: [PATCH] drm/amd/pm: retain the fine grain tuning parameters after resume

On Wed, May 26, 2021 at 4:06 AM Xiaojian Du wrote: > > This patch is to retain the fine grain tuning parameters after resume for > legacy APU, it will cover Raven/Raven2/Picasso. > > Signed-off-by: Xiaojian Du > --- > .../amd/pm/powerplay/hwmgr/hardwaremanager.c | 3 ++- > .../drm/amd/pm/power

[PATCH v2 3/5] drm/amdgpu: switch to amdgpu_bo_vm for vm code

The subclass, amdgpu_bo_vm is intended for PT/PD BOs which are also shadowed, so switch to amdgpu_bo_vm BO for PT/PD BOs. v2: squash three related patches. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 90 + drivers/gpu/drm/amd/amdgpu/amdgpu_vm_

[PATCH 1/5] drm/amdgpu: add amdgpu_bo_vm bo type

Add new BO subclass that will be used by amdgpu vm code. Signed-off-by: Nirmoy Das Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 32 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 10 +++ 2 files changed, 42 insertions(+) diff --git a/dr

[PATCH v2 2/5] drm/amdgpu: move shadow bo validation to VM code

Do the shadow bo validation in the VM code as VM code knows/owns shadow BOs. v2: Fix a typo. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 23 --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 + 2 files changed, 9 insertions(+), 19 deletions(-) d

[PATCH v2 4/5] drm/amdgpu: remove unused code

Remove unused code related to shadow BO. v2: removing shadow bo ptr from base class. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 29 -- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 6 - 2 files changed, 35 deletions(-) diff --git a/driver

[PATCH 5/5] drm/amdgpu: do not allocate entries separately

Allocate PD/PT entries while allocating VM BOs and use that instead of allocating those entries separately. v2: create a new var for num entries. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 34 +++--- 1 file changed, 20 insertions(+), 14 deletions(

Re: [PATCH] drm/amdgpu: Don't flush HDP on A+A

Am 2021-05-25 um 1:56 p.m. schrieb Eric Huang: > With XGMI connection flushing HDP on PCIe is unnecessary, > it is also to optimize memory allocation latency. > > Signed-off-by: Eric Huang > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c >

[PATCH RESEND] amd/display: convert DRM_DEBUG_ATOMIC to drm_dbg_atomic

This allows to tie the log message to a specific DRM device. Signed-off-by: Simon Ser Cc: Alex Deucher Cc: Harry Wentland Cc: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/displ

Re: [PATCH] drm/amdgpu: Don't flush HDP on A+A

Am 25.05.21 um 19:56 schrieb Eric Huang: With XGMI connection flushing HDP on PCIe is unnecessary, it is also to optimize memory allocation latency. Signed-off-by: Eric Huang diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c index ac45d9c7a4

Re: [PATCH] drm/amdgpu: Fix clang warning: unused label 'exit'

Am 25.05.21 um 20:44 schrieb Andrey Grodzovsky: Problem: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:332:1: warning: unused label 'exit' [-Wunused-label] exit: ^ Fix: Put #ifdef CONFIG_64BIT around exit Reported-by: kernel test robot Signed-off-by: Andrey Grodzovsky Reviewed-by: Chris

Re: [PATCH RESEND] amd/display: convert DRM_DEBUG_ATOMIC to drm_dbg_atomic

Reviewed-by: Bas Nieuwenhuizen I think there are plenty more occurrences too or did I miss the cleanup of those? On Wed, May 26, 2021 at 3:56 PM Simon Ser wrote: > > This allows to tie the log message to a specific DRM device. > > Signed-off-by: Simon Ser > Cc: Alex Deucher > Cc: Harry Wentla

[PATCH 1/2] drm/amdgpu/acpi: fix typo in ATCS handling

Path should be NULL when we already have the handle to the object. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c ind

[PATCH 2/2] drm/amdgpu/acpi: make ATPX/ATCS structures global (v2)

They are global ACPI methods, so maybe the structures global in the driver. This simplified a number of things in the handling of these methods. v2: reset the handle if verify interface fails (Lijo) Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 9 +- drivers/

[amdgpu] question about HWS pipe multiplexing mechanism

Hi! I learned that each pipe can manage multiple hardware queues from the previous discussion: https://lists.freedesktop.org/archives/amd-gfx/2018-February/019034.html . And I had a few questions about the details. I was wondering that how a pipe switches between the hardware queues belong to it: 1

RE: [PATCH 00/15] DC Patches May 24th, 2021

[AMD Official Use Only] Done. Hi all,   This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, on the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP

Re: [PATCH v2 2/5] drm/amdgpu: move shadow bo validation to VM code

Am 26.05.21 um 15:06 schrieb Nirmoy Das: Do the shadow bo validation in the VM code as VM code knows/owns shadow BOs. v2: Fix a typo. Signed-off-by: Nirmoy Das Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 23 --- drivers/gpu/drm/amd/am

Re: [PATCH 3/3] drm/amdgpu: Use delayed work to collect RAS error counters

On 2021-05-26 6:15 a.m., Christian König wrote: > Am 26.05.21 um 02:40 schrieb Luben Tuikov: >> On Context Query2 IOCTL return the correctable and >> uncorrectable errors in O(1) fashion, from cached >> values, and schedule a delayed work function to >> calculate and cache them for the next such IO

Re: [PATCH v2 3/5] drm/amdgpu: switch to amdgpu_bo_vm for vm code

Am 26.05.21 um 15:06 schrieb Nirmoy Das: The subclass, amdgpu_bo_vm is intended for PT/PD BOs which are also shadowed, so switch to amdgpu_bo_vm BO for PT/PD BOs. v2: squash three related patches. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 90 +---

Re: [PATCH 3/3] drm/amdgpu: Use delayed work to collect RAS error counters

On 2021-05-26 7:00 a.m., Lazar, Lijo wrote: > [AMD Official Use Only] > > Scheduling an error status query just based on IOCTL doesn't sound like a > sound approach. What if driver needs to handle errors based on that - for ex: > if the number of correctable errors exceed a certain threshold? Tha

Re: [PATCH 3/3] drm/amdgpu: Use delayed work to collect RAS error counters

[AMD Official Use Only] Hi Luben, What I meant by event based is a thread waiting on wait queue for events, not a periodic polling as you had in the original patch. It still fetches the cached data on IOCTL but also triggers an event to poll for new errors. Similarly, a periodic error handler

Re: [PATCH 3/3] drm/amdgpu: Use delayed work to collect RAS error counters

Isn't that kind what this patch does? When the app is running, these IOCTL calls are happening at regular intervals, so if we schedule work, the cache should be updated by the next time we get the IOCTL call. I'm not sure how we would trigger the events. I don't think interrupts on correctable e

[PATCH 1/3] drm/amdgpu: Don't query CE and UE errors

On QUERY2 IOCTL don't query counts of correctable and uncorrectable errors, since when RAS is enabled and supported on Vega20 server boards, this takes insurmountably long time, in O(n^3), which slows the system down to the point of it being unusable when we have GUI up. Fixes: ae363a212b14 ("drm/

[PATCH 2/3] drm/amdgpu: Fix RAS function interface

The correctable and uncorrectable errors are calculated at each invocation of this function. Therefore, it is highly inefficient to return just one of them based on a Boolean input. If the caller wants both, twice the work would be done. (And this work is O(n^3) on Vega20.) Fix this "interface" to

[PATCH 3/3] drm/amdgpu: Use delayed work to collect RAS error counters

On Context Query2 IOCTL return the correctable and uncorrectable errors in O(1) fashion, from cached values, and schedule a delayed work function to calculate and cache them for the next such IOCTL. v2: Cancel pending delayed work at ras_fini(). v3: Remove conditionals when dealing with delayed

Re: [PATCH v2 3/5] drm/amdgpu: switch to amdgpu_bo_vm for vm code

Hi Christian, On 5/26/21 4:58 PM, Christian König wrote: Am 26.05.21 um 15:06 schrieb Nirmoy Das: The subclass, amdgpu_bo_vm is intended for PT/PD BOs which are also shadowed, so switch to amdgpu_bo_vm BO for PT/PD BOs. v2: squash three related patches. Signed-off-by: Nirmoy Das ---   driver

FW:we produce competitive 4G 2G GPS trackers for vehicle management-China’s leading GPS and solutions provider

Dear Customer, Hope you are well at the special moment. Here Joy Cheu of Duomi Technology , a reliable China’s GPS TRACKER and solutions provider. Application of persons, motocycle, fleet manegement, car rental etc. Are you interested in getting more of our high cost performance 2G&4G

Re: [PATCH] drm/amdgpu: Fix Gstreamer api vaapih264enc missing

On Wed, May 26, 2021 at 6:13 AM Li, Xin (Justin) wrote: > > since vcn decoding ring is not required, so just disable it. > > Cc: Alex.Deucher > Cc: Christian.Konig > Signed-off-by: Li.Xin.Justin > Signed-off-by: Frank.Min > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 6 +++--- > drivers/

Re: [PATCH] drm/amdkfd: move flushing TLBs from map to unmap

On 2021-05-25 3:16 p.m., Felix Kuehling wrote: Similar to a recent fix by Philip Yang 76e08b37d0aa ("drm/amdgpu: flush TLB if valid PDE turns into PTE"), there needs to be a conditional TLB flush after map, if any PDEs were unmapped and turned into PTEs in the process. This is currently returned

Re: [PATCH 0/4] drm: Finally retire struct drm_format_name_buf

ping for further a-bs / r-bs Am 16.05.21 um 14:13 schrieb Thomas Zimmermann: This is a cleanup patchset to remove drm_format_name_buf et al. There are two instances in drivers that need to be replaced with the %4cc printk format modifier. Patch 3 was left over back from an earlier patchset. [1]

Re: [PATCH 0/4] drm: Finally retire struct drm_format_name_buf

On Wed, May 26, 2021 at 09:21:10PM +0200, Thomas Zimmermann wrote: > ping for further a-bs / r-bs Thanks for the ping. For the series: Reviewed-by: Sakari Ailus > > Am 16.05.21 um 14:13 schrieb Thomas Zimmermann: > > This is a cleanup patchset to remove drm_format_name_buf et al. There > > ar

Re: [PATCH 3/3] drm/amdgpu: Use delayed work to collect RAS error counters

[Public] Reviewed-by: Alex Deucher From: Tuikov, Luben Sent: Wednesday, May 26, 2021 12:43 PM To: amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Deucher, Alexander ; Koenig, Christian ; Clements, John ; Zhang, Hawking Subject: [PATCH 3/3] drm/amdgpu: Use d

Re: [PATCH] drm/amdkfd: move flushing TLBs from map to unmap

Am 2021-05-26 um 3:21 p.m. schrieb Eric Huang: > > On 2021-05-25 3:16 p.m., Felix Kuehling wrote: >> Similar to a recent fix by Philip Yang 76e08b37d0aa ("drm/amdgpu: flush >> TLB if valid PDE turns into PTE"), there needs to be a conditional TLB >> flush after map, if any PDEs were unmapped and tu

RE: [PATCH] drm/amdgpu: Fix Gstreamer api vaapih264enc missing

[AMD Official Use Only] Looks it lack enough background for people to review: - if (adev->vcn.inst[i].ring_dec.sched.ready) + if (adev->vcn.inst[i].ring_dec.sched.ready || + (adev->asic_type == CHIP_NAVI12 && +

[PATCH 1/2] drm/ttm: cleanup and add TTM_PL_FLAG_TEMPORARY

Make TTM_PL_FLAG_* start from zero and add TTM_PL_FLAG_TEMPORARY flag for temporary GTT allocation use. Signed-off-by: Lang Yu --- include/drm/ttm/ttm_placement.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/drm/ttm/ttm_placement.h b/include/drm/ttm/ttm_placem

[PATCH 2/2] drm/amdgpu: stop bookkeeping of temporary GTT allocation

To improve buffer migration performace, stop bookkeeping of temporary GTT allocation, including allocation for BO evicted from VRAM and bounce buffer. Signed-off-by: Lang Yu --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 16 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++

Re: [PATCH 0/4] drm: Finally retire struct drm_format_name_buf

Acked-by: Alex Deucher for the amdgpu changes. On Wed, May 26, 2021 at 3:21 PM Thomas Zimmermann wrote: > > ping for further a-bs / r-bs > > Am 16.05.21 um 14:13 schrieb Thomas Zimmermann: > > This is a cleanup patchset to remove drm_format_name_buf et al. There > > are two instances in drivers

[pull] amdgpu, amdkfd drm-fixes-5.13

Hi Dave, Daniel, Fixes for 5.13. The following changes since commit a2b4785f01280a4291edb9fda69032fc2e4bfd3f: drm/amdgpu: stop touching sched.ready in the backend (2021-05-19 18:07:43 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-d

Re: [PATCH 01/34] drm/amd/pm/inc/smu_v13_0: Move table into the only source file that uses it

Applied. Thanks! On Wed, May 26, 2021 at 4:47 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/inc/smu_v13_0.h:54:43: warning: > ‘smu13_thermal_policy’ defined but not used [-Wunused-const-variable=] > > Cc: Alex Deucher > Cc: "Chri

Re: [PATCH 02/34] drm/amd/pm/swsmu/smu13/aldebaran_ppt: Remove unused variable 'ret'

This should be checked. Will send out a patch momentarily. Thanks, Alex On Wed, May 26, 2021 at 4:47 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/aldebaran_ppt.c: In function > ‘aldebaran_is_dpm_running’: > drivers

[PATCH] drm/amdgpu/swsmu/aldebaran: fix check in is_dpm_running

If smu_cmn_get_enabled_mask() fails, return false to be consistent with other asics. Signed-off-by: Alex Deucher Cc: Lee Jones --- drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldeba

Re: [PATCH 03/34] drm/amd/pm/powerplay/hwmgr/smu7_thermal: Provide function name for 'smu7_fan_ctrl_set_default_mode()'

Applied. Thanks! On Wed, May 26, 2021 at 4:47 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_thermal.c:132: > warning: This comment starts with '/**', but isn't a kernel-doc comment. > Refer Documentation/doc-

Re: [PATCH 04/34] drm/amd/pm/powerplay/hwmgr/vega12_thermal: Provide function name

Applied. Thanks! On Wed, May 26, 2021 at 4:47 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega12_thermal.c:171: > warning: expecting prototype for Set the requested temperature range for high > and low alert sig

  1   2   >