Re: 回复: 回复: [RFC PATCH 1/2] drm/amdgpu: Fix memory corruption due to swapout and swapin

2021-05-20 Thread Pan, Xinhui
I just sent out patch below yesterday. swapping unpopulated bo is useless indeed. [RFC PATCH 2/2] drm/ttm: skip swapout when ttm has no backend page. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/

回复: 回复: 回复: [RFC PATCH 1/2] drm/amdgpu: Fix memory corruption due to swapout and swapin

2021-05-20 Thread Pan, Xinhui
[AMD Official Use Only] I just sent out patch below yesterday. swapping unpopulated bo is useless indeed. [RFC PATCH 2/2] drm/ttm: skip swapout when ttm has no backend page. 发件人: Christian König 发送时间: 2021年5月20日 14:39 收件人: Pan, Xinhui; Kuehling, Felix;

Re: New uAPI for color management proposal and feedback request

2021-05-20 Thread Pekka Paalanen
On Wed, 19 May 2021 16:49:35 +0300 Ville Syrjälä wrote: > On Wed, May 19, 2021 at 12:34:05PM +0300, Pekka Paalanen wrote: > > On Wed, 12 May 2021 16:04:16 +0300 > > Ville Syrjälä wrote: > > > > > On Wed, May 12, 2021 at 02:06:56PM +0200, Werner Sembach wrote: > > > > Hello, > > > > > > > >

Re: [PATCH] drm/amdgpu/acpi: unify ATCS handling

2021-05-20 Thread Lijo Lazar
On 5/20/2021 2:07 AM, Alex Deucher wrote: Treat it like ATIF and check both the dGPU and APU for the method. This is required because ATCS may be hung off of the APU in ACPI on A+A systems. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 17 +-- drivers/gpu/dr

[PATCH] drm/amd/pm: Update PPTable struct for beige_goby

2021-05-20 Thread Chengming Gui
Update PPTable structure since SMC#73.9/IFWI-XXX.013 Signed-off-by: Chengming Gui Reviewed-by: Tao Zhou Change-Id: I7f6a2dd85b367eb4ecbcfcd5141b1960a395ec24 --- drivers/gpu/drm/amd/pm/inc/smu11_driver_if_sienna_cichlid.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

RE: [PATCH] drm/amd/pm: Update PPTable struct for beige_goby

2021-05-20 Thread Chen, Jiansong (Simon)
[AMD Official Use Only] Reviewed-by: Jiansong Chen -Original Message- From: Chengming Gui Sent: Thursday, May 20, 2021 3:55 PM To: amd-gfx@lists.freedesktop.org Cc: Gui, Jack ; Zhou1, Tao ; Chen, Jiansong (Simon) ; Zhang, Hawking ; Feng, Kenneth Subject: [PATCH] drm/amd/pm: Update PP

Re: [PATCH 2/5] amdgpu/pm: simplify logic of smu_get_power_level

2021-05-20 Thread Lijo Lazar
On 5/20/2021 9:27 AM, Darren Powell wrote: new powerplay enumeration pp_power_limit_level modify hwmon show_power functions to use pp_power_limit_level remove insertion of byte field into smu_get_power_level output arg "limit" modify smu_get_power_level to use pp_power_limit_level si

[PATCH] drm/amd/pm: fix return value in aldebaran_set_mp1_state()

2021-05-20 Thread Feifei Xu
We should just return error in invalid case. For valid but not implemented one, do nothing and return 0. Otherwise resume will abort because of the wrong return value. Signed-off-by: Feifei Xu --- drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 6 -- 1 file changed, 4 insertions(+), 2 d

Re: [PATCH 1/3] drm/amdgpu: Add new domain for preemptible SG BOs

2021-05-20 Thread Christian König
Am 19.05.21 um 17:22 schrieb Felix Kuehling: Am 2021-05-19 um 6:04 a.m. schrieb Christian König: Am 19.05.21 um 07:45 schrieb Felix Kuehling: SG BOs such as dmabuf imports and userptr BOs do not consume system resources directly. Instead they point to resources owned elsewhere. They typically

Re: [PATCH 1/7] drm/amdgpu/vcn1: add cancel_delayed_work_sync before power gate

2021-05-20 Thread Christian König
Am 19.05.21 um 18:22 schrieb James Zhu: Add cancel_delayed_work_sync before set power gating state to avoid race condition issue when power gating. Signed-off-by: James Zhu Acked-by: Christian König for the series. --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 6 +- 1 file changed, 5

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-20 Thread Christian König
Kudos should go to Nirmoy who mentioned that tool in one of our discussions. But, yeah it is rather useful :) Regards, Christian. Am 20.05.21 um 03:30 schrieb Gu, JiaWei (Will): [AMD Official Use Only - Internal Distribution Only] Thanks Christian! Happy to learn new tricks. Best regards,

Re: [RFC PATCH 2/2] drm/ttm: skip swapout when ttm has no backend page.

2021-05-20 Thread Christian König
Am 19.05.21 um 04:28 schrieb xinhui pan: Signed-off-by: xinhui pan --- drivers/gpu/drm/ttm/ttm_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c index 510e3e001dab..a9772fcc8f9c 100644 --- a/drivers/gpu/drm/ttm/ttm

Re: [PATCH] drm/amd/pm: fix return value in aldebaran_set_mp1_state()

2021-05-20 Thread Lijo Lazar
This now handles all of the states. Those states are not valid (and therefore not handled) for Aldebaran. If the intent is to skip handling of any other state, may be just return 0 for default or skip default altogether so that it falls through to return 0 for any other state. In any case, Re

Re: [PATCH 03/38] drm/radeon/radeon_cs: Fix incorrectly documented function 'radeon_cs_parser_fini'

2021-05-20 Thread Christian König
Am 20.05.21 um 14:02 schrieb Lee Jones: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_cs.c:417: warning: expecting prototype for cs_parser_fini(). Prototype was for radeon_cs_parser_fini() instead Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc:

Re: [PATCH 10/38] drm/amd/amdgpu/amdgpu_ids: Correct some function name disparity

2021-05-20 Thread Christian König
Am 20.05.21 um 14:02 schrieb Lee Jones: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:200: warning: expecting prototype for amdgpu_vm_grab_idle(). Prototype was for amdgpu_vmid_grab_idle() instead drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:272: warnin

Re: [PATCH 20/38] drm/radeon/radeon_vm: Fix function naming disparities

2021-05-20 Thread Christian König
Am 20.05.21 um 14:02 schrieb Lee Jones: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_vm.c:61: warning: expecting prototype for radeon_vm_num_pde(). Prototype was for radeon_vm_num_pdes() instead drivers/gpu/drm/radeon/radeon_vm.c:642: warning: expecting pro

[PATCH 24/38] drm/amd/amdgpu/mmhub_v9_4: Fix naming disparity with 'mmhub_v9_4_set_fault_enable_default()'

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c:446: warning: expecting prototype for mmhub_v1_0_set_fault_enable_default(). Prototype was for mmhub_v9_4_set_fault_enable_default() instead Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: D

[PATCH 33/38] drm/amd/amdgpu/sdma_v5_0: Fix typo in function name

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:563: warning: expecting prototype for sdma_v_0_ctx_switch_enable(). Prototype was for sdma_v5_0_ctx_switch_enable() instead Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc:

[PATCH 20/38] drm/radeon/radeon_vm: Fix function naming disparities

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_vm.c:61: warning: expecting prototype for radeon_vm_num_pde(). Prototype was for radeon_vm_num_pdes() instead drivers/gpu/drm/radeon/radeon_vm.c:642: warning: expecting prototype for radeon_vm_update_pdes(). Prototy

[PATCH 36/38] drm/amd/amdgpu/vcn_v1_0: Fix some function naming disparity

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:775: warning: expecting prototype for vcn_v1_0_start(). Prototype was for vcn_v1_0_start_spg_mode() instead drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:: warning: expecting prototype for vcn_v1_0_stop(). Proto

[PATCH 32/38] drm/amd/amdgpu/sdma_v4_0: Realign functions with their headers

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:764: warning: expecting prototype for sdma_v4_0_page_ring_set_wptr(). Prototype was for sdma_v4_0_ring_set_wptr() instead drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:830: warning: expecting prototype for sdma_v

re: drm/amdgpu/acpi: unify ATCS handling (v2) [uninitialized variable error]

2021-05-20 Thread Colin Ian King
Hi, Static analysis on linux-next with Coverity has detected an issue in drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c with the following commit: commit c1c4d8efdddec8a0ccc8525b29740640bd652ce8 Author: Alex Deucher Date: Wed May 19 15:47:42 2021 -0400 drm/amdgpu/acpi: unify ATCS handling (v2)

[PATCH 11/38] drm/amd/amdgpu/amdgpu_debugfs: Fix a couple of misnamed functions

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1004: warning: expecting prototype for amdgpu_debugfs_regs_gfxoff_write(). Prototype was for amdgpu_debugfs_gfxoff_write() instead drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1053: warning: expecting p

[PATCH 31/38] drm/amd/amdgpu/sdma_v2_4: Correct misnamed function 'sdma_v2_4_ring_emit_hdp_flush()'

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c:281: warning: expecting prototype for sdma_v2_4_hdp_flush_ring_emit(). Prototype was for sdma_v2_4_ring_emit_hdp_flush() instead Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter

XDC 2021: Registration & Call for Proposals now open!

2021-05-20 Thread Szwichtenberg, Radoslaw
Hello! Registration & Call for Proposals are now open for XDC 2021, which will take place on September 15-17, 2021. This year we will repeat as virtual event. https://indico.freedesktop.org/event/1/ As usual, the conference is free of charge and open to the general public. If you plan on attendi

[PATCH][next] drm/amdgpu/acpi: Fix null check on memory allocation

2021-05-20 Thread Colin King
From: Colin Ian King The current null check is checking the wrong pointer atif. Fix this to check the correct pointer atcs. Addresses-Coverity: ("Uninitialized pointer read") Fixes: c1c4d8efddde ("drm/amdgpu/acpi: unify ATCS handling (v2)") Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd

[PATCH 34/38] drm/amd/amdgpu/amdgpu_vce: Fix a few incorrectly named functions

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:98: warning: expecting prototype for amdgpu_vce_init(). Prototype was for amdgpu_vce_sw_init() instead drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:214: warning: expecting prototype for amdgpu_vce_fini(). Proto

[PATCH 21/38] drm/amd/include/aldebaran_ip_offset: Mark top-level IP_BASE as __maybe_unused

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../include/aldebaran_ip_offset.h:259:29: warning: ‘XGMI2_BASE’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/amd/amdgpu/../include/aldebaran_ip_offset.h:252:29: warning: ‘XGMI1_BASE’ defined but not u

[PATCH 10/38] drm/amd/amdgpu/amdgpu_ids: Correct some function name disparity

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:200: warning: expecting prototype for amdgpu_vm_grab_idle(). Prototype was for amdgpu_vmid_grab_idle() instead drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:272: warning: expecting prototype for amdgpu_vm_grab_r

[PATCH 16/38] drm/amd/amdgpu/si_dma: Fix some function name disparity

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/si_dma.c:320: warning: expecting prototype for cik_dma_vm_copy_pte(). Prototype was for si_dma_vm_copy_pte() instead drivers/gpu/drm/amd/amdgpu/si_dma.c:412: warning: expecting prototype for si_dma_pad_ib(). Prototype

[PATCH 03/38] drm/radeon/radeon_cs: Fix incorrectly documented function 'radeon_cs_parser_fini'

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_cs.c:417: warning: expecting prototype for cs_parser_fini(). Prototype was for radeon_cs_parser_fini() instead Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: Jerom

[PATCH 29/38] drm/radeon/r100: Realign doc header with function 'r100_cs_packet_parse_vline()'

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/r100.c:1423: warning: expecting prototype for r100_cs_packet_next_vline(). Prototype was for r100_cs_packet_parse_vline() instead Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semw

Requests For Proposals for hosting XDC 2022 are now open

2021-05-20 Thread Samuel Iglesias Gonsálvez
Hello everyone! The X.org board is soliciting proposals to host XDC in 2022. Since XDC 2021 is being held in Europe this year (although virtually), we've decided to host in North America. However, the board is open to other locations, especially if there's an interesting co-location with another c

[PATCH 13/38] drm/amd/amdgpu/cik_sdma: Fix a few incorrectly named functions

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/cik_sdma.c:735: warning: expecting prototype for cik_sdma_vm_copy_pages(). Prototype was for cik_sdma_vm_copy_pte() instead drivers/gpu/drm/amd/amdgpu/cik_sdma.c:762: warning: expecting prototype for cik_sdma_vm_write_

[PATCH 14/38] drm/amd/amdgpu/gfx_v7_0: Repair function names in the documentation

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2126: warning: expecting prototype for gfx_v7_0_ring_emit_hdp(). Prototype was for gfx_v7_0_ring_emit_hdp_flush() instead drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2262: warning: expecting prototype for gfx_v7_

[PATCH 23/38] drm/amd/amdgpu/gmc_v7_0: Fix potential copy/paste issue

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c:526: warning: expecting prototype for gmc_v8_0_set_fault_enable_default(). Prototype was for gmc_v7_0_set_fault_enable_default() instead Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel

[PATCH 35/38] drm/amd/amdgpu/sdma_v5_2: Repair typo in function name

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:501: warning: expecting prototype for sdma_v_0_ctx_switch_enable(). Prototype was for sdma_v5_2_ctx_switch_enable() instead Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc:

[PATCH 17/38] drm/amd/amdgpu/dce_v6_0: Repair function name of 'si_get_number_of_dram_channels()'

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/dce_v6_0.c:468: warning: expecting prototype for cik_get_number_of_dram_channels(). Prototype was for si_get_number_of_dram_channels() instead Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vette

[PATCH 38/38] drm/amd/amdgpu/smuio_v13_0: Realign 'smuio_v13_0_is_host_gpu_xgmi_supported()' header

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/smuio_v13_0.c:99: warning: expecting prototype for smuio_v13_0_supports_host_gpu_xgmi(). Prototype was for smuio_v13_0_is_host_gpu_xgmi_supported() instead Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc:

[PATCH 12/38] drm/amd/amdgpu/amdgpu_gmc: Fix a little naming related doc-rot

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:487: warning: expecting prototype for amdgpu_tmz_set(). Prototype was for amdgpu_gmc_tmz_set() instead drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:533: warning: expecting prototype for amdgpu_noretry_set(). Pr

[PATCH 30/38] drm/amd/amdgpu/gfx_v9_4_2: Mark functions called by reference as static

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c:1008:5: warning: no previous prototype for ‘gfx_v9_4_2_query_ras_error_count’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c:1054:6: warning: no previous prototype for ‘gfx_v9_4_2_reset_ras

[PATCH 19/38] drm/radeon/cik: Fix incorrectly named function 'cik_irq_suspend()'

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/cik.c:7450: warning: expecting prototype for cik_irq_disable(). Prototype was for cik_irq_suspend() instead Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-gfx@lists.f

[PATCH 00/38] Rid W=1 warnings from GPU

2021-05-20 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (38): drm/mediatek/mtk_disp_color: Strip incorrect doc and demote header drm/mediatek/mtk_disp_gamma: Strip and demote non-conformant

[PATCH 26/38] drm/amd/amdgpu/gmc_v10_0: Fix potential copy/paste issue

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c:955: warning: expecting prototype for gmc_v8_0_gart_fini(). Prototype was for gmc_v10_0_gart_fini() instead Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc:

[PATCH 37/38] drm/amd/amdgpu/gfx_v10_0: Demote kernel-doc abuse

2021-05-20 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:51: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Su

Re: [PATCH 1/7] drm/amdgpu/vcn1: add cancel_delayed_work_sync before power gate

2021-05-20 Thread Leo Liu
The series are: Reviewed-by: Leo Liu On 2021-05-19 12:22 p.m., James Zhu wrote: Add cancel_delayed_work_sync before set power gating state to avoid race condition issue when power gating. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 6 +- 1 file changed, 5 ins

[PATCH 1/6] drm/amd/pm: Add ASIC independent throttle bits

2021-05-20 Thread Graham Sider
Add new defines for thermal throttle status bits which are ASIC independent. This bit field will be visible to userspace via gpu_metrics, replacing the previous ASIC dependent bit fields. --- drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h | 32 + 1 file changed, 32 insertions(+)

[PATCH 5/6] drm/amd/pm: Add vangogh throttler translation

2021-05-20 Thread Graham Sider
Perform dependent to independent throttle status translation for vangogh. --- .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 41 +-- 1 file changed, 37 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu1

[PATCH 2/6] drm/amd/pm: Add arcturus throttler translation

2021-05-20 Thread Graham Sider
Perform dependent to independent throttle status translation for arcturus. --- .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 62 --- 1 file changed, 53 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/sm

[PATCH 6/6] drm/amd/pm: Add aldebaran throttler translation

2021-05-20 Thread Graham Sider
Perform dependent to independent throttle status translation for aldebaran. --- .../drm/amd/pm/swsmu/smu13/aldebaran_ppt.c| 44 --- 1 file changed, 38 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/

[PATCH 3/6] drm/amd/pm: Add navi1x throttler translation

2021-05-20 Thread Graham Sider
Perform dependent to independent throttle status translation for navi1x (navi10, navi12). --- .../gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 63 --- 1 file changed, 55 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c b/drivers/gpu/drm/am

[PATCH 4/6] drm/amd/pm: Add sienna cichlid throttler translation

2021-05-20 Thread Graham Sider
Perform dependent to independent throttle status translation for sienna cichlid. --- .../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 48 ++- 1 file changed, 46 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c b/drivers/gpu/drm/amd

[PATCH 1/2] drm/amdgpu/acpi: unify ATCS handling (v3)

2021-05-20 Thread Alex Deucher
Treat it like ATIF and check both the dGPU and APU for the method. This is required because ATCS may be hung off of the APU in ACPI on A+A systems. v2: add back accidently removed ACPI handle check. v3: Fix incorrect atif check (Colin) Fix uninitialized variable (Colin) Signed-off-by: Alex D

[PATCH 2/2] drm/amdgpu/apci: switch ATIF/ATCS probe order

2021-05-20 Thread Alex Deucher
Try the handle from ATPX first since this is the most common case. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c b/drivers/gpu/drm/amd/amdgpu/am

[PATCH -next] drm/amdgpu: fix unused-but-set-variable warnings

2021-05-20 Thread Wei Yongjun
GCC reports the following warnings with W=1: drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c:190:22: warning: variable 'ring' set but not used [-Wunused-but-set-variable] 190 | struct amdgpu_ring *ring; | ^~~~ drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c:162:22: warning: variable

Re: [PATCH 03/38] drm/radeon/radeon_cs: Fix incorrectly documented function 'radeon_cs_parser_fini'

2021-05-20 Thread Alex Deucher
Applied. Thanks! Alex On Thu, May 20, 2021 at 8:04 AM Christian König wrote: > > Am 20.05.21 um 14:02 schrieb Lee Jones: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/radeon/radeon_cs.c:417: warning: expecting prototype for > > cs_parser_fini(). Prototype was f

Re: [PATCH 10/38] drm/amd/amdgpu/amdgpu_ids: Correct some function name disparity

2021-05-20 Thread Alex Deucher
Applied. Thanks! Alex On Thu, May 20, 2021 at 8:04 AM Christian König wrote: > > Am 20.05.21 um 14:02 schrieb Lee Jones: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:200: warning: expecting prototype > > for amdgpu_vm_grab_idle(). Proto

Re: [PATCH 11/38] drm/amd/amdgpu/amdgpu_debugfs: Fix a couple of misnamed functions

2021-05-20 Thread Alex Deucher
Applied. Thanks! Alex On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1004: warning: expecting > prototype for amdgpu_debugfs_regs_gfxoff_write(). Prototype was for > amdgpu_debugfs_gfxoff_w

Re: [PATCH 12/38] drm/amd/amdgpu/amdgpu_gmc: Fix a little naming related doc-rot

2021-05-20 Thread Alex Deucher
Applied. Thanks! Alex On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:487: warning: expecting prototype > for amdgpu_tmz_set(). Prototype was for amdgpu_gmc_tmz_set() instead > drivers/gpu/drm/a

Re: [PATCH 13/38] drm/amd/amdgpu/cik_sdma: Fix a few incorrectly named functions

2021-05-20 Thread Alex Deucher
Applied. Thanks! Alex On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:735: warning: expecting prototype for > cik_sdma_vm_copy_pages(). Prototype was for cik_sdma_vm_copy_pte() instead > drivers/g

Re: [PATCH 14/38] drm/amd/amdgpu/gfx_v7_0: Repair function names in the documentation

2021-05-20 Thread Alex Deucher
Applied. Thanks! Alex On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2126: warning: expecting prototype for > gfx_v7_0_ring_emit_hdp(). Prototype was for gfx_v7_0_ring_emit_hdp_flush() > instead

Re: [PATCH 16/38] drm/amd/amdgpu/si_dma: Fix some function name disparity

2021-05-20 Thread Alex Deucher
Applied. Thanks! Alex On Thu, May 20, 2021 at 8:04 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/si_dma.c:320: warning: expecting prototype for > cik_dma_vm_copy_pte(). Prototype was for si_dma_vm_copy_pte() instead > drivers/gpu/drm/

Re: [PATCH 17/38] drm/amd/amdgpu/dce_v6_0: Repair function name of 'si_get_number_of_dram_channels()'

2021-05-20 Thread Alex Deucher
Applied. Thanks! Alex On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c:468: warning: expecting prototype for > cik_get_number_of_dram_channels(). Prototype was for > si_get_number_of_dram_channels(

Re: [PATCH 19/38] drm/radeon/cik: Fix incorrectly named function 'cik_irq_suspend()'

2021-05-20 Thread Alex Deucher
Applied. Thanks! On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/cik.c:7450: warning: expecting prototype for > cik_irq_disable(). Prototype was for cik_irq_suspend() instead > > Cc: Alex Deucher > Cc: "Christian

Re: [PATCH 20/38] drm/radeon/radeon_vm: Fix function naming disparities

2021-05-20 Thread Alex Deucher
Applied. Thanks! On Thu, May 20, 2021 at 8:05 AM Christian König wrote: > > Am 20.05.21 um 14:02 schrieb Lee Jones: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/radeon/radeon_vm.c:61: warning: expecting prototype for > > radeon_vm_num_pde(). Prototype was for

Re: [PATCH 21/38] drm/amd/include/aldebaran_ip_offset: Mark top-level IP_BASE as __maybe_unused

2021-05-20 Thread Alex Deucher
Applied. Thanks! Alex On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../include/aldebaran_ip_offset.h:259:29: warning: > ‘XGMI2_BASE’ defined but not used [-Wunused-const-variable=] > drivers/gpu/drm/amd/am

Re: [PATCH 23/38] drm/amd/amdgpu/gmc_v7_0: Fix potential copy/paste issue

2021-05-20 Thread Alex Deucher
Applied. Thanks! On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c:526: warning: expecting prototype for > gmc_v8_0_set_fault_enable_default(). Prototype was for > gmc_v7_0_set_fault_enable_default()

Re: [PATCH 24/38] drm/amd/amdgpu/mmhub_v9_4: Fix naming disparity with 'mmhub_v9_4_set_fault_enable_default()'

2021-05-20 Thread Alex Deucher
Applied. Thanks! On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c:446: warning: expecting prototype > for mmhub_v1_0_set_fault_enable_default(). Prototype was for > mmhub_v9_4_set_fault_enable_def

Re: [PATCH 26/38] drm/amd/amdgpu/gmc_v10_0: Fix potential copy/paste issue

2021-05-20 Thread Alex Deucher
Applied. Thanks! Alex On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c:955: warning: expecting prototype for > gmc_v8_0_gart_fini(). Prototype was for gmc_v10_0_gart_fini() instead > > Cc: Alex Deu

Re: [PATCH 29/38] drm/radeon/r100: Realign doc header with function 'r100_cs_packet_parse_vline()'

2021-05-20 Thread Alex Deucher
Applied. Thanks! On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/r100.c:1423: warning: expecting prototype for > r100_cs_packet_next_vline(). Prototype was for r100_cs_packet_parse_vline() > instead > > Cc: Alex

Re: [PATCH 30/38] drm/amd/amdgpu/gfx_v9_4_2: Mark functions called by reference as static

2021-05-20 Thread Alex Deucher
Applied. Thanks! On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c:1008:5: warning: no previous > prototype for ‘gfx_v9_4_2_query_ras_error_count’ [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgp

Re: [PATCH 31/38] drm/amd/amdgpu/sdma_v2_4: Correct misnamed function 'sdma_v2_4_ring_emit_hdp_flush()'

2021-05-20 Thread Alex Deucher
Applied. Thanks! On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c:281: warning: expecting prototype for > sdma_v2_4_hdp_flush_ring_emit(). Prototype was for > sdma_v2_4_ring_emit_hdp_flush() instea

Re: [PATCH 32/38] drm/amd/amdgpu/sdma_v4_0: Realign functions with their headers

2021-05-20 Thread Alex Deucher
Applied. Thanks! On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:764: warning: expecting prototype for > sdma_v4_0_page_ring_set_wptr(). Prototype was for sdma_v4_0_ring_set_wptr() > instead > dr

Re: [PATCH 33/38] drm/amd/amdgpu/sdma_v5_0: Fix typo in function name

2021-05-20 Thread Alex Deucher
Applied. Thanks! On Thu, May 20, 2021 at 8:04 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:563: warning: expecting prototype for > sdma_v_0_ctx_switch_enable(). Prototype was for sdma_v5_0_ctx_switch_enable() > instead > >

Re: [PATCH 35/38] drm/amd/amdgpu/sdma_v5_2: Repair typo in function name

2021-05-20 Thread Alex Deucher
Applied. Thanks! On Thu, May 20, 2021 at 8:04 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:501: warning: expecting prototype for > sdma_v_0_ctx_switch_enable(). Prototype was for sdma_v5_2_ctx_switch_enable() > instead > >

Re: [PATCH 36/38] drm/amd/amdgpu/vcn_v1_0: Fix some function naming disparity

2021-05-20 Thread Alex Deucher
Applied. Thanks! On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:775: warning: expecting prototype for > vcn_v1_0_start(). Prototype was for vcn_v1_0_start_spg_mode() instead > drivers/gpu/drm/amd/

Re: [PATCH 37/38] drm/amd/amdgpu/gfx_v10_0: Demote kernel-doc abuse

2021-05-20 Thread Alex Deucher
Applied. Thanks! On Thu, May 20, 2021 at 8:04 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:51: warning: This comment starts with > '/**', but isn't a kernel-doc comment. Refer > Documentation/doc-guide/kernel-doc.rst > > C

Re: [PATCH 38/38] drm/amd/amdgpu/smuio_v13_0: Realign 'smuio_v13_0_is_host_gpu_xgmi_supported()' header

2021-05-20 Thread Alex Deucher
Applied. Thanks! On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/smuio_v13_0.c:99: warning: expecting prototype > for smuio_v13_0_supports_host_gpu_xgmi(). Prototype was for > smuio_v13_0_is_host_gpu_xgmi_sup

Re: [PATCH 34/38] drm/amd/amdgpu/amdgpu_vce: Fix a few incorrectly named functions

2021-05-20 Thread Alex Deucher
Applied. Thanks! On Thu, May 20, 2021 at 8:04 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:98: warning: expecting prototype for > amdgpu_vce_init(). Prototype was for amdgpu_vce_sw_init() instead > drivers/gpu/drm/amd/amd

Re: [PATCH -next] drm/amdgpu: fix unused-but-set-variable warnings

2021-05-20 Thread Alex Deucher
Applied. Thanks! On Thu, May 20, 2021 at 9:32 AM Wei Yongjun wrote: > > GCC reports the following warnings with W=1: > > drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c:190:22: warning: > variable 'ring' set but not used [-Wunused-but-set-variable] > 190 | struct amdgpu_ring *ring; > |

[PATCH] drm/amd/display: Allow bandwidth validation for 0 streams.

2021-05-20 Thread Bindu Ramamurthy
[Why] Bandwidth calculations are triggered for non zero streams, and in case of 0 streams these calculations were skipped with pstate status not being updated. [How] As the pstate status is applicable for non zero streams, check added for allowing 0 streams inline with

Re: (subset) [PATCH 1/3] gpu: drm: replace occurrences of invalid character

2021-05-20 Thread Mark Brown
On Wed, 19 May 2021 10:15:35 +0200, Mauro Carvalho Chehab wrote: > There are some places at drm that ended receiving a > REPLACEMENT CHARACTER U+fffd ('�'), probably because of > some bad charset conversion. > > Fix them by using what it seems to be the proper > character. Applied to ht

RE: [PATCH] drm/amd/display: Allow bandwidth validation for 0 streams.

2021-05-20 Thread Li, Roman
[Public] Reviewed-by: Roman Li -Original Message- From: Bindu Ramamurthy Sent: Thursday, May 20, 2021 5:04 PM To: amd-gfx@lists.freedesktop.org Cc: Li, Roman ; R, Bindu Subject: [PATCH] drm/amd/display: Allow bandwidth validation for 0 streams. [Why] Bandwidth calculations are

[PATCH v2 2/3] drm/amdgpu: Use preemptible placement for KFD

2021-05-20 Thread Felix Kuehling
KFD userptr BOs and SG BOs used for DMA mappings can be preempted with CWSR. Therefore we can use preemptible placement and avoid unwanted evictions due to GTT accounting. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 7 --- 1 file changed, 4 insertions

[PATCH v2 1/3] drm/amdgpu: Add new placement for preemptible SG BOs

2021-05-20 Thread Felix Kuehling
SG BOs such as dmabuf imports and userptr BOs do not consume system resources directly. Instead they point to resources owned elsewhere. They typically get evicted by DMABuf move notifiers of MMU notifiers. If those notifiers don't need to wait for hardware fences (i.e. the SG BOs are used in a pre

[PATCH v2 3/3] drm/amdgpu: Workaround IOMMU driver bug

2021-05-20 Thread Felix Kuehling
The intel IOMMU driver causes kernel oopses or internal errors flooding kernel log when mapping larger SG tables. Limiting the size of userptr BOs to 6GB seems to avoid this. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 3 +++ 1 file changed, 3 insertions(

[PATCH] drm/amd/pm: Correct reserved uint32_t number in beige_goby_PPTable

2021-05-20 Thread Chengming Gui
Correct reserved number according to the latest struct in drm-next Signed-off-by: Chengming Gui Change-Id: I5991a8ef53134c00348a96f776a539bad6da4fa1 --- drivers/gpu/drm/amd/pm/inc/smu11_driver_if_sienna_cichlid.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

RE: [PATCH] drm/amd/pm: Correct reserved uint32_t number in beige_goby_PPTable

2021-05-20 Thread Chen, Guchun
[AMD Public Use] Reviewed-by: Guchun Chen I wonder shall we pay further attention to the alignment of the strucuture PPTable_beige_goby_t? Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Chengming Gui Sent: Friday, May 21, 2021 10:59 AM To: amd-gfx@lists.freedesktop.org

[PATCH] drm/amdgpu/display: make backlight setting failure messages debug

2021-05-20 Thread Alex Deucher
Avoid spamming the log. The backlight controller on DCN chips gets powered down when the display is off, so if you attempt to set the backlight level when the display is off, you'll get this message. This isn't a problem as we cache the requested backlight level if it's adjusted when the display

[pull] amdgpu, amdkfd drm-next-5.14

2021-05-20 Thread Alex Deucher
Hi Dave, Daniel, More updates for 5.14. On top of the stuff from last week's PR. The following changes since commit 2bb5b5f688cbbd5030629905d3ed8032ab46e79f: drm/radeon/dpm: Disable sclk switching on Oland when two 4K 60Hz monitors are connected (2021-05-19 22:29:40 -0400) are available in t

[PATCH] drm/amdgpu: Use dma_resv_lock instead in BO release_notify

2021-05-20 Thread xinhui pan
The reservation object might be locked again by evict/swap after individualized. The race is like below. cpu 0 cpu 1 BO release BO evict or swap ttm_bo_individualize_resv {resv = &_resv} ttm_bo_ev

RE: [PATCH] drm/amd/pm: fix return value in aldebaran_set_mp1_state()

2021-05-20 Thread Xu, Feifei
[AMD Official Use Only] PP_MP1_STATE_NONE should be valid while other 2 are not for Aldebaran for now. It depends on whether driver want to throw out error if the msg fall out of the 4 cases. Benefit of handling all the cases will be catching potential bugs easily. But the handling of these 4 a