RE: [PATCH] drm/amdgpu: Use DRM_INFO if VFCT table not valid

2021-03-15 Thread Xu, Feifei
[AMD Official Use Only - Internal Distribution Only] Sorry, please ignore this one. I will draft a V2 to remove this one: if (!adev->bios) { -DRM_ERROR("Unable to allocate bios\n"); +DRM_INFO("Unable to allocate bios,skipping\n"); return false; Thanks, Feifei -Original Message- From: Fe

RE: [PATCH] drm/amdgpu: Use DRM_INFO if VFCT table not valid

2021-03-15 Thread Zhang, Hawking
[AMD Public Use] Might be better switch to dev_err so in mGPU setup there is bdf along with the warning/ Regards, Hawking -Original Message- From: Xu, Feifei Sent: Monday, March 15, 2021 15:11 To: Xu, Feifei ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Lazar, Lijo ; Zhang

[PATCH] gpu: drm: amd: pm: Mundane typo fix in the file amdgpu_pm.c

2021-03-15 Thread Bhaskar Chowdhury
s/maxmum/maximum/ Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c index 7b6ef05a1d35..7af74d236600 100644 --- a/drivers/gpu/drm/a

Re: [PATCH] powerpc: Fix missing declaration of [en/dis]able_kernel_vsx()

2021-03-15 Thread Michael Ellerman
On Tue, 9 Mar 2021 08:39:39 + (UTC), Christophe Leroy wrote: > Add stub instances of enable_kernel_vsx() and disable_kernel_vsx() > when CONFIG_VSX is not set, to avoid following build failure. > > CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.o > In file included from >

[PATCH 0/1] Init atombios timeout when amdgpu is Thunderbolt / USB4 when IO BAR is assigned

2021-03-15 Thread Nicholas Johnson
Hi all, I am not certain why this happens, but when IO bar is assigned on Thunderbolt, the amdgpu init fails: [drm:atom_op_jump [amdgpu]] *ERROR* atombios stuck in loop for more than 20secs aborting [drm:amdgpu_atom_execute_table_locked [amdgpu]] *ERROR* atombios stuck executing B456 (len 304,

[PATCH V2] drm: amd: pm: Mundane typo fixes in the file amdgpu_pm.c

2021-03-15 Thread Bhaskar Chowdhury
s/"an minimum"/"a minimum"/ s/"an maxmum"/"a maximum"/ Signed-off-by: Bhaskar Chowdhury --- Changes from V1: Randy's suggestion to adjust the subject line text And missed out a spell too,which now included drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 de

[PATCH 1/1] amdgpu: use MMIO to init atombios if device is Thunderbolt / USB4 attached

2021-03-15 Thread Nicholas Johnson
When using some Thunderbolt hosts using BIOS-assisted PCI enumeration with IO BAR assigned, we get an atombios timeout, such as: [drm:atom_op_jump [amdgpu]] *ERROR* atombios stuck in loop for more than 20secs aborting [drm:amdgpu_atom_execute_table_locked [amdgpu]] *ERROR* atombios stuck executi

Re: slow boot with 7fef431be9c9 ("mm/page_alloc: place pages to tail in __free_pages_core()")

2021-03-15 Thread Mike Rapoport
Hi, On Sat, Mar 13, 2021 at 10:05:23AM +0100, David Hildenbrand wrote: > > Am 13.03.2021 um 05:04 schrieb Liang, Liang (Leo) : > > > > Hi David, > > > > Which benchmark tool you prefer? Memtest86+ or else? > > Hi Leo, > > I think you want something that runs under Linux natively. > > I‘m plan

Re: [PATCH V2] drm: amd: pm: Mundane typo fixes in the file amdgpu_pm.c

2021-03-15 Thread Randy Dunlap
On 3/14/21 8:21 PM, Bhaskar Chowdhury wrote: > > s/"an minimum"/"a minimum"/ > s/"an maxmum"/"a maximum"/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > Changes from V1: > Randy's suggestion to adjust the subject line text > And missed out a spell too,which now inclu

Re: [PATCH] gpu: drm: amd: pm: Mundane typo fix in the file amdgpu_pm.c

2021-03-15 Thread Randy Dunlap
On 3/14/21 6:57 PM, Bhaskar Chowdhury wrote: > > s/maxmum/maximum/ > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c > b/drivers/gpu/drm/amd/pm/amdgpu_pm.c

RE: [PATCH] drm/amdgpu: Use DRM_INFO if VFCT table not valid

2021-03-15 Thread Xu, Feifei
OK. Will add in V2 Thanks, Feifei -Original Message- From: Zhang, Hawking Sent: Monday, March 15, 2021 3:28 PM To: Xu, Feifei ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Lazar, Lijo Subject: RE: [PATCH] drm/amdgpu: Use DRM_INFO if VFCT table not valid [AMD Public Use] M

[PATCH v2] drm/amdgpu: Use dev_info if VFCT table not valid

2021-03-15 Thread Feifei Xu
Some ASICs do not have GOP driver to copy vbios image into VFCT table. And it will go to next check. Signed-off-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c b/

RE: [PATCH v2] drm/amdgpu: Use dev_info if VFCT table not valid

2021-03-15 Thread Zhang, Hawking
[AMD Public Use] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Feifei Xu Sent: Monday, March 15, 2021 17:11 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Lazar, Lijo ; Zhang, Hawking ; Xu, Feifei Subject: [PATCH v2] drm/amdgpu: Use dev_info if VFC

Re: [PATCH 1/1] drm/amdgpu: wrap kiq ring ops with kiq spinlock

2021-03-15 Thread Christian König
Am 12.03.21 um 18:08 schrieb Nirmoy Das: KIQ ring is being operated by kfd as well as amdgpu. KFD is using kiq lock, we should the same from amdgpu side as well. Signed-off-by: Nirmoy Das Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 15 +++ 1 file

Re: [PATCH 1/2] drm/amdkfd: Fix recursive lock warnings

2021-03-15 Thread Christian König
Am 13.03.21 um 03:43 schrieb Felix Kuehling: memalloc_nofs_save/restore are no longer sufficient to prevent recursive lock warnings when holding locks that can be taken in MMU notifiers. Use memalloc_noreclaim_save/restore instead. Fixes: f920e413ff9c ("mm: track mmu notifiers in fs_reclaim_acqu

Re: [PATCH 2/2] drm/amdkfd: Fix resource cursor initialization

2021-03-15 Thread Christian König
Am 13.03.21 um 03:43 schrieb Felix Kuehling: Make sure the cur->size doesn't exceed cur->remaining. Otherwise the first call to amdgpu_res_next will trigger the BUG_ON in that function. Mhm the BUG_ON is correct since the function complains that we want to move the cursor forward by more than

Re: [PATCH 1/1] drm/amdgpu: wrap kiq ring ops with kiq spinlock

2021-03-15 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Hi Das, It seems more reasonable to put spin lock in ring structure, so that KIQ ring can be treated like other normal ring. and do we have other paths to call kiq ring except for kernel initialization? it seems the kfd and kgd will use kiq i

Re: [PATCH 1/1] drm/amdgpu: wrap kiq ring ops with kiq spinlock

2021-03-15 Thread Nirmoy
On 3/15/21 11:32 AM, Wang, Kevin(Yang) wrote: [AMD Official Use Only - Internal Distribution Only] Hi Das, It seems more reasonable to put spin lock in ring structure, so that KIQ ring can be treated like other normal ring. We don't use locks for other rings though. and do we have oth

[PATCH 00/23] DC Patches March 15, 2021

2021-03-15 Thread Solomon Chiu
This DC patchset brings improvements in multiple areas. In summary, we highlight: * Add debug out when viewport too small * use max lb for latency hiding * System black screen hangs on driver load * Fix UBSAN warning for not a valid value for type '_Bool' * Fix for outbox1 ring buffer typecasting

[PATCH 01/23] drm/amd/display: 3.2.126.1

2021-03-15 Thread Solomon Chiu
From: Aric Cyr Bumping DC version for DMU FW fix Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display

[PATCH 02/23] drm/amd/display: Add debug out when viewport too small

2021-03-15 Thread Solomon Chiu
From: Nikola Cornij [why] It helps debugging display setup issues Signed-off-by: Nikola Cornij Reviewed-by: Nicholas Kazlauskas Acked-by: Solomon Chiu --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c| 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/dr

[PATCH 03/23] drm/amd/display: use max lb for latency hiding

2021-03-15 Thread Solomon Chiu
From: Dmytro Laktyushkin Enable max memory lb config to improve stutter efficiency and latency hiding. Also increase max number of lb lines to be used by dml since experiments have shown that there isnt a hard max beyond what fits in lb. Signed-off-by: Dmytro Laktyushkin Reviewed-by: Eric Berns

[PATCH 04/23] drm/amd/display: System black screen hangs on driver load

2021-03-15 Thread Solomon Chiu
From: Aric Cyr This reverts commit bea6beb76a9f19a9a86d24d304f27b3cff5f1791 as it causes crash on driver load in some scenarios. Signed-off-by: Aric Cyr Reviewed-by: Martin Leung Acked-by: Solomon Chiu --- .../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 48 +-- drivers/gpu/dr

[PATCH 05/23] drm/amd/display: Fix UBSAN warning for not a valid value for type '_Bool'

2021-03-15 Thread Solomon Chiu
From: Anson Jacob [Why] dc_cursor_position do not initialise position.translate_by_source when crtc or plane->state->fb is NULL. UBSAN caught this error in dce110_set_cursor_position, as the value was garbage. [How] Initialise dc_cursor_position structure elements to 0 in handle_cursor_update be

[PATCH 06/23] drm/amd/display: Fix for outbox1 ring buffer typecasting issue

2021-03-15 Thread Solomon Chiu
From: Meenakshikumar Somasundaram [WHY] Compiler warning "pointer to integer of different size" reported on outbox1 ring buffer address typecasting. Reported-by: kernel test robot [HOW] Fixed the issue by typecasting with character pointer. Signed-off-by: Meenakshikumar Somasundaram Reviewed

[PATCH 07/23] drm/amd/display: Bypass sink detect when there are no eDPs connected

2021-03-15 Thread Solomon Chiu
From: Jake Wang [How & Why] Check DC config to determine if there are any eDPs connected. If there are no eDPs connected, bypass sink detect when querying eDP presence. Signed-off-by: Jake Wang Reviewed-by: Nicholas Kazlauskas Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dc/core/dc

[PATCH 08/23] drm/amd/display: Increase precision for bpp in DSC calculations

2021-03-15 Thread Solomon Chiu
From: Jun Lei [Why?] Many DSC variables and related functions use whole bits for bpp. [How?] Change variables and related functions to use 16ths of a bit for bpp. Signed-off-by: Dillon Varone Reviewed-by: Wenjing Liu Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dc/dc_hw_types.h |

[PATCH 09/23] drm/amd/display: Add changes for dsc bpp in 16ths and unify bw calculations

2021-03-15 Thread Solomon Chiu
From: Dillon Varone [Why?] Some code still expected bpp to be used in whole bits, not 16ths. dsc.c uses redundant function now found in dc to calculate stream bandwidth from timing. [How?] Fix code to work with 16ths instead of whole bits for dsc bpp. Refactor get_dsc_bandwidth to accept inputs

[PATCH 10/23] drm/amd/display: Correct algorithm for reversed gamma

2021-03-15 Thread Solomon Chiu
From: Calvin Hou [Why] DCN30 needs to correctly program reversed gamma curve, which DCN20 already has. Also needs to fix a bug that 252-255 values are clipped. [How] Apply two fixes into DCN30. Signed-off-by: Calvin Hou Reviewed-by: Jun Lei Reviewed-by: Krunoslav Kovac Acked-by: Solomon Chiu

[PATCH 11/23] drm/amd/display: Remove MPC gamut remap logic for DCN30

2021-03-15 Thread Solomon Chiu
From: Dillon Varone [Why?] Should only reroute gamut remap to mpc unless 3D LUT is not used and all planes are using the same src->dest. [How?] Remove DCN30 specific logic for rerouting gamut remap to mpc. Signed-off-by: Dillon Varone Reviewed-by: Krunoslav Kovac Acked-by: Aric Cyr Acked-by:

[PATCH 12/23] drm/amd/display: Fix typo for helpers function name

2021-03-15 Thread Solomon Chiu
From: "Leo (Hanghong) Ma" [why] Word "helper" was misspelled as "helpes" in dm_helpes_dmub_outbox0_interrupt_control function. [how] Fix the spelling. Signed-off-by: Leo (Hanghong) Ma Reviewed-by: Yongqiang Sun Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpe

[PATCH 13/23] drm/amd/display: Fix secure display lock problems

2021-03-15 Thread Solomon Chiu
From: Wayne Lin [Why] Find out few locks problems while doing secure display. They are following few parts: 1. crc_rd_work_lock in amdgpu_dm_crtc_handle_crc_window_irq() should also use spin_lock_irqsave instead of spin_lock_irq. 2. In crc_win_update_set(), crc_rd_work_lock should be grabbed af

[PATCH 14/23] drm/amd/display: Fix no previous prototype warning

2021-03-15 Thread Solomon Chiu
From: Wayne Lin [Why] Received compiling warning: All warnings (new ones prefixed by >>): >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5574:5: warning: no previous prototype for 'amdgpu_dm_crtc_late_register' [-Wmissing-prototypes] 5574 | int amdgpu_dm_crtc_late_register(s

[PATCH 15/23] drm/amd/display: Separate caps for maximum RGB and YUV plane counts

2021-03-15 Thread Solomon Chiu
From: Atufa Khan Not all ASICs have same plane capabilities so need to split them out for proper support handling. Signed-off-by: Atufa Khan Reviewed-by: Aric Cyr Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dc/dc.h | 2 ++ drivers/gpu/drm/amd/display/dc/dce110/

[PATCH 16/23] drm/amd/display: Add debugfs to control DMUB trace buffer events

2021-03-15 Thread Solomon Chiu
From: "Leo (Hanghong) Ma" [Why] We want to have a debugfs interface to enable or disable DMCUB trace buffer events. [How] Add debugfs interface to enable or disable trace buffer events. Signed-off-by: Leo (Hanghong) Ma Reviewed-by: Harry Wentland Acked-by: Solomon Chiu --- .../gpu/drm/amd/d

[PATCH 17/23] drm/amd/display: [FW Promotion] Release 0.0.56

2021-03-15 Thread Solomon Chiu
From: Anthony Koo More updates to the comments to better describe the function of different cmds and parameters in the dmub interface. Signed-off-by: Anthony Koo Reviewed-by: Aric Cyr Acked-by: Solomon Chiu --- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 668 ++ 1 file ch

[PATCH 18/23] drm/amd/display: DCHUB underflow counter increasing in some scenarios

2021-03-15 Thread Solomon Chiu
From: Aric Cyr [Why] When unplugging a display, the underflow counter can be seen to increase because PSTATE switch is allowed even when some planes are not blanked. [How] Check that all planes are not active instead of all streams before allowing PSTATE change. Signed-off-by: Aric Cyr Reviewe

[PATCH 19/23] drm/amd/display: 3.2.127

2021-03-15 Thread Solomon Chiu
From: Aric Cyr Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index d26472ef1572..352651

[PATCH 20/23] drm/amd/display: fix dml prefetch validation

2021-03-15 Thread Solomon Chiu
From: Dmytro Laktyushkin Incorrect variable used, missing initialization during validation. Signed-off-by: Dmytro Laktyushkin Reviewed-by: Eric Bernstein Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20.c | 1 + drivers/gpu/drm/amd/display/dc/dml/dcn2

[PATCH 21/23] drm/amd/display: fix dcn3+ bw validation soc param update sequence

2021-03-15 Thread Solomon Chiu
From: Dmytro Laktyushkin SOC needs to be updated to the WM set A values before validation happens. Signed-off-by: Dmytro Laktyushkin Reviewed-by: Eric Bernstein Acked-by: Solomon Chiu --- .../drm/amd/display/dc/dcn30/dcn30_resource.c | 17 - .../drm/amd/display/dc/dcn30/dcn

[PATCH 22/23] drm/amd/display: add a func to disable accelerated mode

2021-03-15 Thread Solomon Chiu
From: Yao Wang1 [Why] When driver disabled, we driver force the YCbCr420 to RGB, which means some register will be changed, such as RDPCS_PHY_DP_MPLLB_TX_CLK_DIV changed from 1 to 0 When driver re-enabled, OS will Set Mode YCbCr420 again, which means the register RDPCS_PHY_DP_MPLLB_TX_CLK_DIV sho

[PATCH 23/23] drm/amd/display: Fix potential memory leak

2021-03-15 Thread Solomon Chiu
From: Qingqing Zhuo [Why] vblank_workqueue is never released. [How] Free it upon dm finish. Signed-off-by: Qingqing Zhuo Reviewed-by: Nicholas Kazlauskas Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 + 1 file changed, 9 insertions(+) diff --git a

[PATCH] drm/amdgpu: make sure to only process the remaining VM range

2021-03-15 Thread Christian König
We should only map the remaining size here and not the whole segment. Signed-off-by: Christian König Fixes: 3af0a018a728 ("drm/amdgpu: new resource cursor") --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu

Re: slow boot with 7fef431be9c9 ("mm/page_alloc: place pages to tail in __free_pages_core()")

2021-03-15 Thread David Hildenbrand
On 13.03.21 14:48, Mike Rapoport wrote: Hi, On Sat, Mar 13, 2021 at 10:05:23AM +0100, David Hildenbrand wrote: Am 13.03.2021 um 05:04 schrieb Liang, Liang (Leo) : Hi David, Which benchmark tool you prefer? Memtest86+ or else? Hi Leo, I think you want something that runs under Linux nativel

[PATCH] drm/amd/display: Remove unnecessary conversion to bool

2021-03-15 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_mpc.c:358:69-74: WARNING: conversion to bool not needed here. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_mpc.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 2/2] drm/amdkfd: Fix resource cursor initialization

2021-03-15 Thread Felix Kuehling
Am 2021-03-15 um 6:22 a.m. schrieb Christian König: > Am 13.03.21 um 03:43 schrieb Felix Kuehling: >> Make sure the cur->size doesn't exceed cur->remaining. Otherwise the >> first call to amdgpu_res_next will trigger the BUG_ON in that function. > > Mhm the BUG_ON is correct since the function com

Re: [PATCH 2/2] drm/amdkfd: Fix resource cursor initialization

2021-03-15 Thread Christian König
Am 15.03.21 um 14:08 schrieb Felix Kuehling: Am 2021-03-15 um 6:22 a.m. schrieb Christian König: Am 13.03.21 um 03:43 schrieb Felix Kuehling: Make sure the cur->size doesn't exceed cur->remaining. Otherwise the first call to amdgpu_res_next will trigger the BUG_ON in that function. Mhm the B

RE: [PATCH 00/23] DC Patches March 15, 2021

2021-03-15 Thread Wheeler, Daniel
[AMD Public Use] Hi all, This week this patchset was tested on a HP Envy 360, with Ryzen 5 4500U, on the following display types (via usb-c to dp/dvi/hdmi/vga): 4k 60z, 1440p 144hz, 1680*1050 60hz, internal eDP 1080p 60hz Tested on a Sapphire Pulse RX5700XT on the following display types (via D

RE: [PATCH 2/2] drm/amdgpu: Enable lightSBR for SMU on passthrough and XGMI configuration

2021-03-15 Thread Zhang, Hawking
[AMD Public Use] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of shaoyunl Sent: Thursday, March 11, 2021 01:56 To: amd-gfx@lists.freedesktop.org Cc: Liu, Shaoyun Subject: [PATCH 2/2] drm/amdgpu: Enable lightSBR for SMU on passthrough and XGMI

Re: [PATCH 1/1] amdgpu: use MMIO to init atombios if device is Thunderbolt / USB4 attached

2021-03-15 Thread Alex Deucher
On Mon, Mar 15, 2021 at 4:04 AM Nicholas Johnson wrote: > > When using some Thunderbolt hosts using BIOS-assisted PCI enumeration > with IO BAR assigned, we get an atombios timeout, such as: > > [drm:atom_op_jump [amdgpu]] *ERROR* atombios stuck in loop for more than > 20secs aborting > [drm:amdg

[PATCH 1/1] drm/amdgpu: make BO type check less restrictive

2021-03-15 Thread Nirmoy Das
BO with ttm_bo_type_sg type can also have tiling_flag and metadata. So so BO type check for only ttm_bo_type_kernel. Signed-off-by: Nirmoy Das Reported-by: Tom StDenis --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/driv

[PATCH] drm/amdgpu: drop legacy IO bar support

2021-03-15 Thread Alex Deucher
It was leftover from radeon where it was required for some specific old hardware. It hasn't been required for ages and the driver already falls back to MMIO when legacy IO is not available. Legacy IO also seems to be problematic on on some thunderbolt devices. Drop it. Signed-off-by: Alex Deuch

Re: [PATCH 1/1] drm/amdgpu: make BO type check less restrictive

2021-03-15 Thread Christian König
Am 15.03.21 um 16:14 schrieb Nirmoy Das: BO with ttm_bo_type_sg type can also have tiling_flag and metadata. So so BO type check for only ttm_bo_type_kernel. Signed-off-by: Nirmoy Das Reported-by: Tom StDenis At some point we should probably add a amdgpu_bo_is_user() helper function, but fo

Re: [PATCH] drm/amdgpu: drop legacy IO bar support

2021-03-15 Thread Christian König
Am 15.03.21 um 16:17 schrieb Alex Deucher: It was leftover from radeon where it was required for some specific old hardware. It hasn't been required for ages and the driver already falls back to MMIO when legacy IO is not available. Legacy IO also seems to be problematic on on some thunderbolt

Re: [PATCH] drm/amd/display: Free local data after use

2021-03-15 Thread Rodrigo Siqueira
Nice catch! Reviewed-by: Rodrigo Siqueira On 03/11, Victor Lu wrote: > Fixes the following memory leak in dc_link_construct(): > > unreferenced object 0xa03e81471400 (size 1024): > comm "amd_module_load", pid 2486, jiffies 4294946026 (age 10.544s) > hex dump (first 32 bytes): > 00 00 00 00

Re: [PATCH] drm/amd/display: Free local data after use

2021-03-15 Thread Rodrigo Siqueira
Applied to amd-staging-drm-next. Thanks On 03/11, Victor Lu wrote: > Fixes the following memory leak in dc_link_construct(): > > unreferenced object 0xa03e81471400 (size 1024): > comm "amd_module_load", pid 2486, jiffies 4294946026 (age 10.544s) > hex dump (first 32 bytes): > 00 00 00 00 00

[PATCH 1/2] drm/amdgpu: Keep pending_reset valid during smu reset the ASIC

2021-03-15 Thread shaoyunl
SMU internal might need to check this pending_reset setting to decide the reset method Signed-off-by: shaoyunl Change-Id: I8d88abf56d481e7443ac31baa2929826aec9e576 --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd

[PATCH 2/2] drm/amd/pm: Use BACO reset arg 0 on XGMI configuration

2021-03-15 Thread shaoyunl
With arg 1 BACO reset, it will try to reload the SMU FW after reset. This might failed if driver already in a pending reset status during probe period. Arg 0 reset will bring asic back to a clean state and driver will re-init everythign including SMU FW Signed-off-by: shaoyunl Change-Id: I6df90

Re: [PATCH 1/1] drm/amdgpu: make BO type check less restrictive

2021-03-15 Thread StDenis, Tom
[AMD Official Use Only - Internal Distribution Only] FWIW the patch seems to fix the issue I was seeing :-) Tom From: Koenig, Christian Sent: Monday, March 15, 2021 11:22 To: Das, Nirmoy Cc: amd-gfx@lists.freedesktop.org; StDenis, Tom Subject: Re: [PATCH

Re: [PATCH][next] drm/amd/pm: Fix spelling mistake "disble" -> "disable"

2021-03-15 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Mar 12, 2021 at 5:08 AM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in an assert message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 2 +- > 1 file changed, 1 insertion(+

Re: [PATCH] drm/amd/display: remove redundant initialization of variable result

2021-03-15 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Mar 11, 2021 at 11:34 AM Colin King wrote: > > From: Colin Ian King > > The variable result is being initialized with a value that is > never read and it is being updated later with a new value. The > initialization is redundant and can be removed. > > Addresses-

Re: [PATCH V2] drm: amd: pm: Mundane typo fixes in the file amdgpu_pm.c

2021-03-15 Thread Alex Deucher
On Sun, Mar 14, 2021 at 11:22 PM Bhaskar Chowdhury wrote: > > > s/"an minimum"/"a minimum"/ > s/"an maxmum"/"a maximum"/ > > Signed-off-by: Bhaskar Chowdhury Applied. Thanks! Alex > --- > Changes from V1: > Randy's suggestion to adjust the subject line text > And missed out a spell too,w

Re: [PATCH] drm/amd/display: Remove unnecessary conversion to bool

2021-03-15 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Mar 15, 2021 at 4:22 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_mpc.c:358:69-74: WARNING: > conversion to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong >

Re: [PATCH 1/2] drm/amdgpu: fix compile error on architecture s390

2021-03-15 Thread Nirmoy
Wouldn't this restrict amdgpu for only x86 platform? On 3/11/21 4:29 AM, Oak Zeng wrote: ioremap_cache is not supported on some architecture such as s390. Put the codes into a #ifdef to fix some compile error reported by test robot. Signed-off-by: Oak Zeng Reported-by: Kernel test robot ---

RE: [PATCH 1/2] drm/amdgpu: fix compile error on architecture s390

2021-03-15 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: amd-gfx On Behalf Of > Nirmoy > Sent: Monday, March 15, 2021 2:43 PM > To: Zeng, Oak ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 1/2] drm/amdgpu: fix compile error on architecture s390 > > Wouldn't this restrict amdgpu for only x86

2021 X.Org Foundation Election Candidates

2021-03-15 Thread Harry Wentland
To all X.Org Foundation Members: The election for the X.Org Foundation Board of Directors will begin on 22 March 2021. We have 6 candidates who are running for 4 seats. They are (in alphabetical order): Samuel Iglesias Gonsálvez Manasi Navare Lyude Paul Rodrigo Siqueira Lu

[PATCH] drm/amdgpu/display: drop unused DCN3.01 functions

2021-03-15 Thread Alex Deucher
No longer used. Drop to avoid warnings. Fixes: e0e33d4006aa ("[why] the dcn301_calculate_wm_and_dl() calculation exposed a issue - switch to dcn30 version for now. still need to follow up with dcn301 watermark updates version.") Signed-off-by: Alex Deucher Cc: Charles Sun Cc: Nikola Cornij

Re: [PATCH] drm/amdgpu/display: drop unused DCN3.01 functions

2021-03-15 Thread Nirmoy
Reviewed-by: Nirmoy Das On 3/15/21 8:12 PM, Alex Deucher wrote: No longer used. Drop to avoid warnings. Fixes: e0e33d4006aa ("[why] the dcn301_calculate_wm_and_dl() calculation exposed a issue - switch to dcn30 version for now. still need to follow up with dcn301 watermark updates versio

Re: [PATCH 1/2] drm/amdgpu: fix compile error on architecture s390

2021-03-15 Thread Nirmoy
Hi Alex, On 3/15/21 7:46 PM, Deucher, Alexander wrote: [AMD Public Use] -Original Message- From: amd-gfx On Behalf Of Nirmoy Sent: Monday, March 15, 2021 2:43 PM To: Zeng, Oak ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amdgpu: fix compile error on architecture s390

RE: [PATCH 1/2] drm/amdgpu: fix compile error on architecture s390

2021-03-15 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: Das, Nirmoy > Sent: Monday, March 15, 2021 3:17 PM > To: Deucher, Alexander ; Das, Nirmoy > ; Zeng, Oak ; amd- > g...@lists.freedesktop.org > Subject: Re: [PATCH 1/2] drm/amdgpu: fix compile error on architecture s390 > > Hi Alex, > > On 3/1

[PATCH] drm/amdgpu/ttm: fix ifdefs for non-x86

2021-03-15 Thread Alex Deucher
The else clause needs to be CONFIG_64BIT not CONFIG_X86. Fixes: e98f250bddb5 ("drm/amdgpu: fix compile error on architecture s390") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.

RE: [PATCH 1/2] drm/amdgpu: fix compile error on architecture s390

2021-03-15 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: amd-gfx On Behalf Of > Deucher, Alexander > Sent: Monday, March 15, 2021 3:24 PM > To: Das, Nirmoy ; Zeng, Oak > ; amd-gfx@lists.freedesktop.org > Subject: RE: [PATCH 1/2] drm/amdgpu: fix compile error on architecture s390 > > [AMD Public Use

Re: [PATCH] drm/amdgpu/ttm: fix ifdefs for non-x86

2021-03-15 Thread Nirmoy
Reviewed-by: Nirmoy Das On 3/15/21 8:38 PM, Alex Deucher wrote: The else clause needs to be CONFIG_64BIT not CONFIG_X86. Fixes: e98f250bddb5 ("drm/amdgpu: fix compile error on architecture s390") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 ++ 1 file changed

Re: [PATCH] drm/amdgpu/ttm: fix ifdefs for non-x86

2021-03-15 Thread Zeng, Oak
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Oak Zeng Regards, Oak On 2021-03-15, 3:39 PM, "amd-gfx on behalf of Alex Deucher" wrote: The else clause needs to be CONFIG_64BIT not CONFIG_X86. Fixes: e98f250bddb5 ("drm/amdgpu: fix compile error on architecture

Re: [PATCH] drm/amdkfd: Fix UBSAN shift-out-of-bounds warning

2021-03-15 Thread Lyude Paul
On Sat, 2021-03-06 at 03:55 +, Jacob, Anson wrote: > [AMD Public Use] > > Thanks Lyude for testing the patch. > > Are you referring to this issue [1] ? > > Is it reproducible after applying this patch as well ? Yes I am - and yeah, if you're talking about the patch you originally asked me t

[PATCH] drm/amd/pm: fix workload mismatch on vega10

2021-03-15 Thread Kenneth Feng
Workload number mapped to the correct one. This issue is only on vega10. Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/

Re: [PATCH] drm/amd/pm: fix workload mismatch on vega10

2021-03-15 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kevin Wang Best Regards. Kevin From: amd-gfx on behalf of Kenneth Feng Sent: Tuesday, March 16, 2021 10:29 AM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH] drm/amd/pm: f

RE: [PATCH 2/2] drm/amd/pm: Use BACO reset arg 0 on XGMI configuration

2021-03-15 Thread Zhang, Hawking
[AMD Public Use] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of shaoyunl Sent: Tuesday, March 16, 2021 00:01 To: amd-gfx@lists.freedesktop.org Cc: Liu, Shaoyun Subject: [PATCH 2/2] drm/amd/pm: Use BACO reset arg 0 on XGMI configurat