Re: [PATCH 1/2] drm/amdgpu: Add otg vertical IRQ Source

2021-02-04 Thread Alex Deucher
Series is: Acked-by: Alex Deucher On Tue, Feb 2, 2021 at 1:17 AM Wayne Lin wrote: > > [Why & How] > In order to get appropriate timing for registers which > read/write is vertical line sensitive, add new IRQ source variable. > This interrupt is triggered by specific vertical line, > > Signed-off

Re: [PATCH 2/2] drm/amdgpu: enable DPM_FLAG_MAY_SKIP_RESUME and DPM_FLAG_SMART_SUSPEND flags

2021-02-04 Thread Michal Rostecki
On Tue, Feb 02, 2021 at 12:17:48PM -0500, Alex Deucher wrote: > Once the device has runtime suspended, we don't need to power it > back up again for system suspend. Likewise for resume, we don't > to power up the device again on resume only to power it back off > again via runtime pm because it's

Re: [PATCH 2/2] drm/amdgpu: enable DPM_FLAG_MAY_SKIP_RESUME and DPM_FLAG_SMART_SUSPEND flags

2021-02-04 Thread Alex Deucher
On Wed, Feb 3, 2021 at 2:56 AM Lazar, Lijo wrote: > > [AMD Public Use] > > > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Tuesday, February 2, 2021 10:48 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 2/2] drm/amdgpu: enable D

[PATCH 01/14] drm/amdkfd: Get unique_id dynamically v2

2021-02-04 Thread Christian König
From: Kent Russell Instead of caching the value during amdgpu_device_init, just call the function directly. This avoids issues where the unique_id hasn't been saved by the time that KFD's topology snapshot is done (e.g. Arcturus). KFD's topology information from the amdgpu_device was initially c

[PATCH 1/3] drm/amdgpu: drop extra drm_kms_helper_poll_enable/disable calls

2021-02-04 Thread Alex Deucher
These are already called in amdgpu_device_suspend/resume which are already called in the same functions. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 -- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/gpu

[PATCH 3/3] drm/amdgpu: reset runpm flag if device suspend fails

2021-02-04 Thread Alex Deucher
If device suspend fails when we attempt to runtime suspend, reset the runpm flag. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/a

[PATCH 2/3] drm/amdgpu: use runpm flag rather than fbcon for kfd runtime suspend

2021-02-04 Thread Alex Deucher
the flag used by kfd is not actually related to fbcon, it just happens to align. Use the runpm flag instead so that we can decouple it from the fbcon flag. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH 1/3] drm/scheduler: provide scheduler score externally

2021-02-04 Thread Christian König
Allow multiple schedulers to share the load balancing score. This is useful when one engine has different hw rings. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +- drivers/gpu/drm/etnaviv/etnaviv_sched.c | 2 +- drivers/gpu/drm/lima/lima_sched.c

[PATCH 3/3] drm/amdgpu: share scheduler score on VCN3 instances

2021-02-04 Thread Christian König
The VCN3 instances can do both decode as well as encode. Share the scheduler load balancing score and remove fixing encode to only the second instance. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 1 + drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 11 +++ 2

[PATCH 2/3] drm/amdgpu: add the sched_score to amdgpu_ring_init

2021-02-04 Thread Christian König
Allow separate ring to share the same scheduler score. No functional change. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 50 --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 5 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 6 ++- drivers

Re: [PATCH 2/2] drm/amdgpu: enable DPM_FLAG_MAY_SKIP_RESUME and DPM_FLAG_SMART_SUSPEND flags

2021-02-04 Thread Felix Kuehling
Am 2021-02-04 um 9:37 a.m. schrieb Alex Deucher: > On Wed, Feb 3, 2021 at 2:56 AM Lazar, Lijo wrote: >> [AMD Public Use] >> >> >> -Original Message- >> From: amd-gfx On Behalf Of Alex >> Deucher >> Sent: Tuesday, February 2, 2021 10:48 PM >> To: amd-gfx@lists.freedesktop.org >> Cc: Deuc

Re: [PATCH 2/3] drm/amdgpu: use runpm flag rather than fbcon for kfd runtime suspend

2021-02-04 Thread Felix Kuehling
Am 2021-02-04 um 9:43 a.m. schrieb Alex Deucher: > the flag used by kfd is not actually related to fbcon, it just happens > to align. Use the runpm flag instead so that we can decouple it from > the fbcon flag. > > Signed-off-by: Alex Deucher Acked-by: Felix Kuehling > --- > drivers/gpu/drm/

Re: [PATCH v2 1/1] drm/amdgpu: enable wave limit on non high prio cs pipes

2021-02-04 Thread Nirmoy
ping. On 2/3/21 6:11 PM, Nirmoy Das wrote: To achieve the best QoS for high priority compute jobs it is required to limit waves on other compute pipes as well. This patch will set min value in non high priority mmSPI_WCL_PIPE_PERCENT_CS[0-3] registers to minimize the impact of normal/low priorit

Re: [PATCH v2 1/1] drm/amdgpu: enable wave limit on non high prio cs pipes

2021-02-04 Thread Alex Deucher
Reviewed-by: Alex Deucher On Thu, Feb 4, 2021 at 11:17 AM Nirmoy wrote: > > ping. > > On 2/3/21 6:11 PM, Nirmoy Das wrote: > > To achieve the best QoS for high priority compute jobs it is > > required to limit waves on other compute pipes as well. > > This patch will set min value in non high pr

Re: [PATCH 3/3] drm/amdgpu: share scheduler score on VCN3 instances

2021-02-04 Thread Leo Liu
The series are: Reviewed-and-Tested-by: Leo Liu On 2021-02-04 9:44 a.m., Christian König wrote: The VCN3 instances can do both decode as well as encode. Share the scheduler load balancing score and remove fixing encode to only the second instance. Signed-off-by: Christian König --- drive

[PATCH 1/7] drm/amdgpu/si: minor clean up of reset code

2021-02-04 Thread Alex Deucher
Drop duplicate reset method logging, whitespace changes. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/si.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c index 7817e5156cb5..668dd6dfe6a3 1

[PATCH 3/7] drm/amdgpu/vi: minor clean up of reset code

2021-02-04 Thread Alex Deucher
Drop duplicate reset method logging, whitespace changes. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vi.c | 36 + 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c index

[PATCH 4/7] drm/amdgpu: add generic pci reset as an option

2021-02-04 Thread Alex Deucher
This allows us to use generic PCI reset mechanisms (FLR, SBR) as a reset mechanism to verify that the generic PCI reset mechanisms are working properly. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 4 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12 +

[PATCH 2/7] drm/amdgpu/cik: minor clean up of reset code

2021-02-04 Thread Alex Deucher
Drop duplicate reset method logging, whitespace changes. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/cik.c | 33 +++- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/cik.c b/drivers/gpu/drm/amd/amdgpu/cik.c ind

[PATCH 5/7] drm/amdgpu/si: add PCI reset support

2021-02-04 Thread Alex Deucher
Use generic PCI reset for GPU reset if the user specifies PCI reset as the reset mechanism. This should in general only be used for validation. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/si.c | 37 - 1 file changed, 23 insertions(+), 14 deletions(

[PATCH 7/7] drm/amdgpu/nv: add PCI reset support

2021-02-04 Thread Alex Deucher
Use generic PCI reset for GPU reset if the user specifies PCI reset as the reset mechanism. This should in general only be used for validation. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nv.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/d

[PATCH 6/7] drm/amdgpu/soc15: add PCI reset support

2021-02-04 Thread Alex Deucher
Use generic PCI reset for GPU reset if the user specifies PCI reset as the reset mechanism. This should in general only be used for validation. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc15.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) di

[PATCH 2/3] drm/amdgpu: use runpm flag rather than fbcon for kfd runtime suspend (v2)

2021-02-04 Thread Alex Deucher
the flag used by kfd is not actually related to fbcon, it just happens to align. Use the runpm flag instead so that we can decouple it from the fbcon flag. v2: fix resume as well Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+

Re: [pull] amdgpu, amdkfd drm-next-5.12

2021-02-04 Thread Dave Airlie
On Thu, 4 Feb 2021 at 14:57, Alex Deucher wrote: > > Hi Dave, Daniel, > > More fixes for 5.12. Same PR from last week with the issue Felix reported > fixed and a few more additional fixes on top. > > The following changes since commit a6b8720c2f85143561c3453e1cf928a2f8586ac0: > > Merge tag 'amd

RE: [PATCH 3/3] drm/amdgpu: reset runpm flag if device suspend fails

2021-02-04 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Series is acked-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, February 4, 2021 10:43 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 3/3] drm/amdgpu: reset runpm

RE: [PATCH 7/7] drm/amdgpu/nv: add PCI reset support

2021-02-04 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Series is acked-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Friday, February 5, 2021 2:47 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 7/7] drm/amdgpu/nv: add PCI rese

Re: [PATCH 2/3] drm/amdgpu: use runpm flag rather than fbcon for kfd runtime suspend (v2)

2021-02-04 Thread Lazar, Lijo
[AMD Official Use Only - Internal Distribution Only] If it's part of adev, does it need an arg? Can't kfd check it directly? Thanks, Lijo From: amd-gfx on behalf of Alex Deucher Sent: Friday, February 5, 2021 1:34:50 AM To: amd-gfx@lists.freedesktop.org Cc: De

Re: [PATCH 2/3] drm/amdgpu: use runpm flag rather than fbcon for kfd runtime suspend (v2)

2021-02-04 Thread Felix Kuehling
Am 2021-02-04 um 9:20 p.m. schrieb Lazar, Lijo: > > [AMD Official Use Only - Internal Distribution Only] > > > [AMD Official Use Only - Internal Distribution Only] > > > If it's part of adev, does it need an arg? Can't kfd check it directly? We could. Actually amdgpu_amdkfd_suspend/resume are just

Re: [pull] amdgpu, amdkfd drm-next-5.12

2021-02-04 Thread Alex Deucher
On Thu, Feb 4, 2021 at 6:52 PM Dave Airlie wrote: > > On Thu, 4 Feb 2021 at 14:57, Alex Deucher wrote: > > > > Hi Dave, Daniel, > > > > More fixes for 5.12. Same PR from last week with the issue Felix reported > > fixed and a few more additional fixes on top. > > > > The following changes since

Re: [PATCH 2/2] drm/amdgpu: enable DPM_FLAG_MAY_SKIP_RESUME and DPM_FLAG_SMART_SUSPEND flags

2021-02-04 Thread Bhardwaj, Rajneesh
On 2/4/2021 10:14 AM, Felix Kuehling wrote: Am 2021-02-04 um 9:37 a.m. schrieb Alex Deucher: On Wed, Feb 3, 2021 at 2:56 AM Lazar, Lijo wrote: [AMD Public Use] -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Tuesday, February 2, 2021 10:48 PM To: amd-gfx@lists.free

RE: [PATCH 2/3] drm/amdgpu: use runpm flag rather than fbcon for kfd runtime suspend (v2)

2021-02-04 Thread Bhardwaj, Rajneesh
[AMD Public Use] Reviewed-by: Rajneesh Bhardwaj -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, February 4, 2021 3:05 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 2/3] drm/amdgpu: use runpm flag rather than fbcon for kfd runtim