[PATCH] drm: Check actual format for legacy pageflip.

2021-01-02 Thread Bas Nieuwenhuizen
With modifiers one can actually have different format_info structs for the same format, which now matters for AMDGPU since we convert implicit modifiers to explicit modifiers with multiple planes. I checked other drivers and it doesn't look like they end up triggering this case so I think this is

Re: [PATCH] drm/amdgpu: Do not change amdgpu framebuffer format during page flip

2021-01-02 Thread Bas Nieuwenhuizen
https://lists.freedesktop.org/archives/dri-devel/2021-January/292761.html is my alternative patch. On Tue, Dec 22, 2020 at 4:18 AM Zhan Liu wrote: > > [Why] > Driver cannot change amdgpu framebuffer (afb) format while doing > page flip. Force system doing so will cause ioctl error, and result in

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Bas Nieuwenhuizen
I think the problem here is that application A can set the FB and then application B can use getfb2 (say ffmpeg). https://lists.freedesktop.org/archives/dri-devel/2021-January/292761.html would be my alternative patch. (I'm not good at detecting the effects of tearing apparently but tested this

[PATCH] drm: Allow format change during legacy page-flip if driver is atomic.

2021-01-02 Thread Mario Kleiner
This is a slight improvement for legacy flipping, but also an attempted fix for a bug/regression introduced into Linux 4.11-rc. Commit 816853f9dc4057b6c7ee3c45ca9bd5905 ("drm/amd/display: Set new format info for converted metadata.") fixes the getfb2 ioctl, but in exchange it completely breaks all

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Mario Kleiner
On Sat, Jan 2, 2021 at 3:05 PM Bas Nieuwenhuizen wrote: > > I think the problem here is that application A can set the FB and then > application B can use getfb2 (say ffmpeg). Yes. That, and also the check for 'X' won't get us far, because if i use my own software Psychtoolbox under Vulkan in di

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-02 Thread Mario Kleiner
On Sat, Jan 2, 2021 at 3:02 PM Bas Nieuwenhuizen wrote: > > With modifiers one can actually have different format_info structs > for the same format, which now matters for AMDGPU since we convert > implicit modifiers to explicit modifiers with multiple planes. > > I checked other drivers and it do

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Bas Nieuwenhuizen
On Sat, Jan 2, 2021 at 4:05 PM Mario Kleiner wrote: > > On Sat, Jan 2, 2021 at 3:05 PM Bas Nieuwenhuizen > wrote: > > > > I think the problem here is that application A can set the FB and then > > application B can use getfb2 (say ffmpeg). > > > Yes. That, and also the check for 'X' won't get us

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Mario Kleiner
On Sat, Jan 2, 2021 at 4:49 PM Bas Nieuwenhuizen wrote: > > On Sat, Jan 2, 2021 at 4:05 PM Mario Kleiner > wrote: > > > > On Sat, Jan 2, 2021 at 3:05 PM Bas Nieuwenhuizen > > wrote: > > > > > > I think the problem here is that application A can set the FB and then > > > application B can use ge

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Ilia Mirkin
On Sat, Jan 2, 2021 at 1:35 PM Mario Kleiner wrote: > I'm less sure about nouveau. It uses modifiers, but has atomic support > only on nv50+ and that atomic support is off by default -- needs a > nouveau.nouveau_atomic=1 boot parameter to switch it on. It seems to > enable modifier support uncondi

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Mario Kleiner
On Sat, Jan 2, 2021 at 7:51 PM Ilia Mirkin wrote: > On Sat, Jan 2, 2021 at 1:35 PM Mario Kleiner > wrote: > > I'm less sure about nouveau. It uses modifiers, but has atomic support > > only on nv50+ and that atomic support is off by default -- needs a > > nouveau.nouveau_atomic=1 boot parameter

amdgpu does not support 3840x2160@30Hz on kaveri apu

2021-01-02 Thread Davide Corrado
hello, I'd like to report this issue that I am having since I updated my display (samsung U28E590). The amdgpu does not support the native resolution of my new monitor, which is 3840x2160*.* Using a HDMI or DVI connection (I tried both, same results), the maximum supported refresh is 30Hz, so I'm s