Am 27.11.20 um 17:26 schrieb t...@redhat.com:
From: Tom Rix
The macro use will already have a semicolon.
Signed-off-by: Tom Rix
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/
From: Tom Rix
The macro use will already have a semicolon.
Signed-off-by: Tom Rix
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index f9c81bc21ba4..301e93c9e
On Fri, Nov 27, 2020 at 11:04:55AM -0500, Andrey Grodzovsky wrote:
>
> On 11/27/20 9:59 AM, Daniel Vetter wrote:
> > On Wed, Nov 25, 2020 at 02:34:44PM -0500, Andrey Grodzovsky wrote:
> > > On 11/25/20 11:36 AM, Daniel Vetter wrote:
> > > > On Wed, Nov 25, 2020 at 01:57:40PM +0100, Christian König
Reviewed-by: Rodrigo Siqueira
On 11/30, Wayne Lin wrote:
> Fixes below compiler warnings:
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5374:5:
> warning: no previous prototype for function
> 'amdgpu_dm_crtc_atomic_set_property' [
Just a small optimization for accessing system pages directly.
Was missed for gmc v10 since the feature landed for older gmcs
while we were still on the emulator or gmc10 and we use the AGP
aperture for zfb on the emulator.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c
Am 30.11.20 um 16:47 schrieb Alex Deucher:
Just a small optimization for accessing system pages directly.
Was missed for gmc v10 since the feature landed for older gmcs
while we were still on the emulator or gmc10 and we use the AGP
aperture for zfb on the emulator.
Signed-off-by: Alex Deucher
[AMD Public Use]
We need to figure out what the root cause is then. If we can't figure it out
soon, we should revert the change for navi1x and continue to debug it until we
can find the root cause and we can safely re-enable it.
Alex
From: Chen, Guchun
Sent: S
Like I stated elsewhere, I would recommend noretry=0 for Navi and later
GPUs because there is no performance advantage from disabling retry on
those GPUs.
Regards,
Felix
Am 2020-11-30 um 12:22 p.m. schrieb Deucher, Alexander:
>
> [AMD Public Use]
>
>
> We need to figure out what the root caus
There are no performance advantages to setting it to 1 and
it causes stability issues in some cases.
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1374
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Am 2020-11-30 um 1:58 p.m. schrieb Alex Deucher:
> There are no performance advantages to setting it to 1 and
> it causes stability issues in some cases.
>
> Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1374
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 1
There are no performance advantages to setting it to 1 and
it causes stability issues in some cases.
v2: simplify the code
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1374
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 5 -
1 file changed, 5 deletions(-)
Another related thought: I think the reason some chips had failing VM
fault tests with noretry=0 was due to a dependency on IH rerouting of
retry faults. This dependency has been fixed by Christian recently:
commit 849c62248ee84c1e304a9ce2f673c79e23f29bf9
Author: Christian K?nig
Date: Sat Oct 3
On Mon, Nov 30, 2020 at 2:25 PM Felix Kuehling wrote:
>
> Am 2020-11-30 um 1:58 p.m. schrieb Alex Deucher:
> > There are no performance advantages to setting it to 1 and
> > it causes stability issues in some cases.
> >
> > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1374
> > Signed-off-b
Am 2020-11-30 um 2:25 p.m. schrieb Alex Deucher:
> There are no performance advantages to setting it to 1 and
> it causes stability issues in some cases.
See my later email on the other thread. There was another consideration
besides performance. It had to do with retry fault handling, which
depen
Am 30.11.20 um 20:52 schrieb Felix Kuehling:
Am 2020-11-30 um 2:25 p.m. schrieb Alex Deucher:
There are no performance advantages to setting it to 1 and
it causes stability issues in some cases.
See my later email on the other thread. There was another consideration
besides performance. It had
> On Nov 24, 2020, at 06:38, Thomas Zimmermann wrote:
>
> Using struct drm_device.pdev is deprecated. Convert vmwgfx to struct
> drm_device.dev. No functional changes.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Roland Scheidegger
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 8
If vram is used up, display allocate vram evict the KFD BOs to system
memory. KFD schedule restore work to restore BOs back to vram to resume
queues. If restore BOs failed, KFD will reschedule the restore work to
try again. If display BOs are pinned in vram, KFD restore work will keep
retry, and ma
Just a small optimization for accessing system pages directly.
Was missed for gmc v10 since the feature landed for older gmcs
while we were still on the emulator or gmc10 and we use the AGP
aperture for zfb on the emulator.
v2: fix up the system aperture as well
Signed-off-by: Alex Deucher
---
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c:278: warning: Function parameter or
> member 'vmhub' not described in 'gmc_v10_0_flush_gpu_tlb'
> drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c:278: warning:
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/iceland_ih.c:191: warning: Function parameter or
> member 'ih' not described in 'iceland_ih_get_wptr'
> drivers/gpu/drm/amd/amdgpu/iceland_ih.c:223: warning: Func
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/tonga_ih.c:193: warning: Function parameter or
> member 'ih' not described in 'tonga_ih_get_wptr'
> drivers/gpu/drm/amd/amdgpu/tonga_ih.c:225: warning: Function p
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:2576:5: warning: no previous
> prototype for ‘parse_ta_bin_descriptor’ [-Wmissing-prototypes]
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: Dav
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/cz_ih.c:191: warning: Function parameter or
> member 'ih' not described in 'cz_ih_get_wptr'
> drivers/gpu/drm/amd/amdgpu/cz_ih.c:223: warning: Function parameter
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/vega10_ih.c:377: warning: Function parameter or
> member 'ih' not described in 'vega10_ih_get_wptr'
> drivers/gpu/drm/amd/amdgpu/vega10_ih.c:440: warning: Functio
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/navi10_ih.c:453: warning: Function parameter or
> member 'ih' not described in 'navi10_ih_get_wptr'
> drivers/gpu/drm/amd/amdgpu/navi10_ih.c:512: warning: Functio
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/psp_v11_0.c:223:5: warning: no previous prototype
> for ‘psp_v11_0_wait_for_bootloader’ [-Wmissing-prototypes]
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc:
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/dce_v10_0.c:237: warning: Function parameter or
> member 'async' not described in 'dce_v10_0_page_flip'
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: David
Fix a typo: "TZM" --> "TMZ"
Signed-off-by: Luben Tuikov
---
tests/amdgpu/security_tests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/amdgpu/security_tests.c b/tests/amdgpu/security_tests.c
index 9b39e167..351eac82 100644
--- a/tests/amdgpu/security_tests.c
+++ b/te
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/dce_v11_0.c:255: warning: Function parameter or
> member 'async' not described in 'dce_v11_0_page_flip'
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: David
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:2998:6: warning: no previous prototype
> for ‘gfx_v9_0_rlc_stop’ [-Wmissing-prototypes]
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: David Airli
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:3698: warning: Excess function
> parameter 'adev' description in 'DEFAULT_SH_MEM_BASES'
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: David Airli
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c: In function ‘gfx_v10_rlcg_wreg’:
> drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:1416:18: warning: variable ‘grbm_idx’
> set but not used [-Wunused-but-set-
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c:254: warning: Function parameter or
> member 'job' not described in 'sdma_v2_4_ring_emit_ib'
> drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c:254: warning: Fu
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:428: warning: Function parameter or
> member 'job' not described in 'sdma_v3_0_ring_emit_ib'
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:428: warning: Fu
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:1651: warning: Function parameter or
> member 'ib' not described in 'sdma_v3_0_emit_copy_buffer'
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:1651: warnin
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c:153: warning: Function parameter or
> member 'handle' not described in 'uvd_v5_0_hw_init'
> drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c:153: warning: Excess
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:848: warning: Function parameter or
> member 'job' not described in 'sdma_v4_0_ring_emit_ib'
> drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:848: warning: Fu
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:95: warning: cannot understand
> function prototype: 'struct amdgpu_uvd_cs_ctx '
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:555: warning: Function par
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:367: warning: Function parameter or
> member 'job' not described in 'sdma_v5_2_ring_emit_ib'
> drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:367: warning: Fu
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:97: warning: Function parameter or
> member 'size' not described in 'amdgpu_vce_sw_init'
> drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:441: warning: Func
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c:211: warning: Function parameter or
> member 'bo' not described in 'uvd_v6_0_enc_get_create_msg'
> drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c:211: warning:
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c:219: warning: Function parameter or
> member 'bo' not described in 'uvd_v7_0_enc_get_create_msg'
> drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c:219: warning:
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:5008:6: warning: no previous
> prototype for ‘gfx_v10_0_rlc_stop’ [-Wmissing-prototypes]
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: David Air
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:439: warning: Excess function
> parameter 'sw' description in 'vcn_v1_0_disable_clock_gating'
> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:566: warning: Exc
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c:219: warning: Function parameter or
> member 'addr' not described in 'jpeg_v1_0_decode_ring_emit_fence'
> drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c:219:
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c:498: warning: Function parameter or
> member 'addr' not described in 'jpeg_v2_0_dec_ring_emit_fence'
> drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c:498: war
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:483: warning: Excess function
> parameter 'sw' description in 'vcn_v2_0_disable_clock_gating'
> drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:644: warning: Exc
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:403: warning: Function parameter or
> member 'job' not described in 'sdma_v5_0_ring_emit_ib'
> drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:403: warning: Fu
If vram is used up, display allocate vram evict the KFD BOs to system
memory. KFD schedule restore work to restore BOs back to vram. If
display BOs are pinned in vram, KFD restore work will keep retry, and
may never success.
If restore BO back to vram failed, keep the BO in system memory to
preven
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c: In function ‘vcn_v3_0_start_sriov’:
> drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c:1242:3: warning: variable
> ‘direct_poll’ set but not used [-Wunused-but-s
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:183: warning: Function parameter or
> member 'handle' not described in 'acp_hw_init'
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:183: warning: Excess f
Am 2020-11-30 um 5:48 p.m. schrieb Philip Yang:
> If vram is used up, display allocate vram evict the KFD BOs to system
> memory. KFD schedule restore work to restore BOs back to vram. If
> display BOs are pinned in vram, KFD restore work will keep retry, and
> may never success.
>
> If restore BO
rather than just dropping the error. Also fixes a set but not
used variable warning.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
b/drivers/gpu/drm/amd/pm/
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c: At top level:
> drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:764:5: warning:
> no previous prototype for ‘vangogh_s
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> It's used in some, but not all source files which include 'smu_v11_0.h'.
>
> Fixes the following W=1 kernel build warning(s):
>
> In file included from
> drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/smu_v11_0.c:36:
> drivers/gpu/drm/amd/amdgp
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-de...@lists.freedesktop.org
> Signed-off-by: Lee Jones
Appli
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Evan Quan
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-de...@lists.freedesktop.org
> Signed-off-by:
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/fiji_smumgr.c: In function
> ‘fiji_populate_smc_boot_level’:
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/fiji_smumgr.c:1603:6:
> w
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:555: warning: Function parameter or
> member 'buf_sizes' not described in 'amdgpu_uvd_cs_msg_decode'
>
> Cc: Alex Deucher
> Cc: "Christian König"
>
Rather than just silently dropping it. Also fixes a set but
unused variable warning.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/pm/powerplay/smumgr/tonga_smumgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/tonga_smumgr.c
On Thu, Nov 26, 2020 at 8:42 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/tonga_smumgr.c: In
> function ‘tonga_thermal_setup_fan_table’:
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/tonga_smumgr.c:2469:6:
On Thu, Nov 26, 2020 at 8:42 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/polaris10_smumgr.c:2145:5:
> warning: no previous prototype for ‘polaris10_thermal_avfs_enable’
> [-Wmissing-prototypes]
>
> Cc: Evan Quan
Rather than just silently dropping it. Also fixes a set but
unused variable warning.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c
b/dri
On Thu, Nov 26, 2020 at 8:42 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/ci_smumgr.c: In function
> ‘ci_thermal_setup_fan_table’:
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/ci_smumgr.c:2132:6:
> warning
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/iceland_smumgr.c:2085:5:
> warning: no previous prototype for ‘iceland_thermal_setup_fan_table’
> [-Wmissing-prototypes]
> drivers/gpu/drm
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/vegam_smumgr.c:2249:5:
> warning: no previous prototype for ‘vegam_thermal_avfs_enable’
> [-Wmissing-prototypes]
>
> Cc: Evan Quan
> Cc: A
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/smu9_smumgr.c:38:6:
> warning: no previous prototype for ‘smu9_is_smc_ram_running’
> [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/.
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/fiji_smumgr.c:1107:
> warning: Function parameter or member 'mem_clock' not described in
> 'fiji_get_mclk_frequency_ratio'
>
> Cc: Evan Qua
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/hardwaremanager.c:518:5:
> warning: no previous prototype for ‘phm_set_min_deep_sleep_dcefclk’
> [-Wmissing-prototypes]
> drivers/gpu/drm/a
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> Cc: Evan Quan
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-de...@lists.freedesktop.org
> Signed-off-by:
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> They are used by some source files which include pp_thermal.h, but not all.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/inc/pp_thermal.h:28:41: warning:
> ‘SMU7ThermalWithDelayPolicy’ defined but n
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppevvmath.h: In function
> ‘fMultiply’:
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppevvmath.h:336:22:
> warning: variable ‘Y_LessT
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> In file included from
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomctrl.c:31:
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomctrl.c: In function
> ‘atomctrl_calculate
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_hwmgr.c:5696:5:
> warning: no previous prototype for ‘smu7_init_function_pointers’
> [-Wmissing-prototypes]
> 5696 | int smu7_init_fun
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomfwctrl.c:78: warning:
> Function parameter or member 'hwmgr' not described in
> 'pp_atomfwctrl_is_voltage_controlled_by_gpio_v4'
> dr
Rather than just silently dropping it. Also fixes a set but
unused variable warning.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumg
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/iceland_smumgr.c: In
> function ‘iceland_thermal_setup_fan_table’:
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/iceland_smumgr.c:209
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/hardwaremanager.c:232:
> warning: Function parameter or member 'hwmgr' not described in
> 'phm_start_thermal_controller'
> drivers/gpu/drm/
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/process_pptables_v1_0.c:41:
> warning: Function parameter or member 'hwmgr' not described in 'set_hw_cap'
> drivers/gpu/drm/amd/amdgpu/../pm
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomctrl.c:104: warning:
> Function parameter or member 'reg_block' not described in
> 'atomctrl_set_mc_reg_address_table'
> drivers/gpu/
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_processpptables.c:1148:5:
> warning: no previous prototype for ‘vega10_pp_tables_initialize’
> [-Wmissing-prototypes]
>
> Cc: Evan
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_hwmgr.c:202: warning:
> Function parameter or member 'hwmgr' not described in
> 'smu7_get_mc_microcode_version'
> drivers/gpu/drm/amd/
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_thermal.c:112:
> warning: Function parameter or member 'hwmgr' not described in
> 'smu7_fan_ctrl_set_static_mode'
> drivers/gpu/drm/am
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_thermal.c:128:
> warning: Function parameter or member 'hwmgr' not described in
> 'vega10_fan_ctrl_set_static_mode'
> drivers/gpu/dr
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega12_hwmgr.c:2862:5:
> warning: no previous prototype for ‘vega12_hwmgr_init’ [-Wmissing-prototypes]
> 2862 | int vega12_hwmgr_init(struct
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_hwmgr.c:4403:5:
> warning: no previous prototype for ‘vega20_hwmgr_init’ [-Wmissing-prototypes]
> 4403 | int vega20_hwmgr_init(struct
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu_helper.c:112: warning:
> Function parameter or member 'hwmgr' not described in 'phm_wait_on_register'
> drivers/gpu/drm/amd/amdgpu/../pm
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_thermal.c:217:
> warning: Function parameter or member 'hwmgr' not described in
> 'vega20_thermal_get_temperature'
> drivers/gpu/drm
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega12_thermal.c:63:
> warning: Cannot understand * @fn vega12_enable_fan_control_feature
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmg
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> 'link_bandwidth_kbps' is always obtained, but only used if
> CONFIG_DRM_AMD_DC_DCN is defined.
Probably better to just move this under CONFIG_DRM_AMD_DC_DCN. I'll
send a patch.
Thanks,
Alex
>
> Fixes the following W=1 kernel build warning(
It's only used when CONFIG_DRM_AMD_DC_DCN is set. Fixes and set but
not used warning.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/dr
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote:
>
> 'dpp_input_csc_matrix' is used by some, but not all source files which
> include dpp.h.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/inc/hw/dpp.h:50:42: warning:
> ‘dpp_input_csc_matrix’ def
On Thu, Nov 26, 2020 at 8:44 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_color.c:128:
> warning: Function parameter or member 'lut' not described in
> '__drm_lut_to_dc_gamma'
> drivers/gpu/drm/amd/amdgpu
On Thu, Nov 26, 2020 at 8:44 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_pp_smu.c:538:6:
> warning: no previous prototype for ‘pp_rv_set_wm_ranges’
> [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/.
On Thu, Nov 26, 2020 at 8:44 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_pp_smu.c:664:20:
> warning: no previous prototype for ‘pp_nv_set_pme_wa_enable’
> [-Wmissing-prototypes]
>
> Cc: Harry Wentland
>
On Thu, Nov 26, 2020 at 8:44 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/basics/conversion.c:34:10: warning:
> no previous prototype for ‘fixed_point_to_int_frac’ [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../dis
On Thu, Nov 26, 2020 at 8:44 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/basics/fixpt31_32.c:29:32: warning:
> ‘dc_fixpt_pi’ defined but not used [-Wunused-const-variable=]
>
> Cc: Harry Wentland
> Cc: Leo Li
> Cc: Alex
On Thu, Nov 26, 2020 at 8:44 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/basics/vector.c:55:6: warning: no
> previous prototype for ‘dal_vector_presized_costruct’ [-Wmissing-prototypes]
>
> Cc: Harry Wentland
> Cc: Leo Li
[AMD Official Use Only - Internal Distribution Only]
Hi Alex,
The followings seem missing in programming
mmMMMC_VM_SYSTEM_APERTURE_LOW/HIGH_ADDR.
min(adev->gmc.fb_start, adev->gmc.agp_start)
max(adev->gmc.fb_end, adev->gmc.agp_end)
BR
Evan
-Original Message-
From: amd-gfx On Behalf Of
[AMD Official Use Only - Internal Distribution Only]
Reviewed-and-tested-by: Evan Quan
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Tuesday, December 1, 2020 5:49 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH] drm/amdgpu: enable AGP ape
1 - 100 of 107 matches
Mail list logo
