Hi Christian
Am 12.11.20 um 18:16 schrieb Christian König:
> Am 12.11.20 um 14:21 schrieb Thomas Zimmermann:
>> In order to avoid eviction of vmap'ed buffers, pin them in their GEM
>> object's vmap implementation. Unpin them in the vunmap implementation.
>> This is needed to make generic fbdev sup
Am 12.11.20 um 15:20 schrieb Ruhl, Michael J:
-Original Message-
From: Ben Skeggs
Sent: Wednesday, November 11, 2020 9:39 PM
To: Ruhl, Michael J
Cc: Thomas Zimmermann ; bske...@redhat.com;
airl...@linux.ie; dan...@ffwll.ch; christian.koe...@amd.com; amd-
g...@lists.freedesktop.org; nouv
On Fri, Nov 13, 2020 at 02:53:17PM +0800, Liang, Prike wrote:
> The gfx_state_change_set() funtion can support set GFX power
> change status to D0/D3.
>
> Signed-off-by: Prike Liang
Reviewed-by: Huang Rui
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 18 +-
> drive
Per PMFW 59.13.0.
Signed-off-by: Tao Zhou
---
drivers/gpu/drm/amd/pm/inc/smu_v11_0.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/inc/smu_v11_0.h
b/drivers/gpu/drm/amd/pm/inc/smu_v11_0.h
index 5ad693312187..41bc919dc9f4 100644
--- a/drivers/gpu/drm/
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Jiansong Chen
-Original Message-
From: Zhou1, Tao
Sent: Friday, November 13, 2020 4:51 PM
To: Chen, Jiansong (Simon) ; Gui, Jack
; Zhang, Hawking ;
amd-gfx@lists.freedesktop.org
Cc: Zhou1, Tao
Subject: [PATCH] drm/amd/
fix -Wmissing-protoypes warning
Signed-off-by: Hawking Zhang
---
drivers/gpu/drm/amd/amdgpu/smuio_v11_0.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/smuio_v9_0.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/smuio_v11_0.c
b/drivers/gpu/drm/amd/am
[AMD Official Use Only - Internal Distribution Only]
This patch is Reviewed-by: Likun Gao
Regards,
Likun
-Original Message-
From: amd-gfx On Behalf Of Hawking Zhang
Sent: Friday, November 13, 2020 5:28 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking
Subject: [PATCH] drm/amdgpu
[AMD Public Use]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Hawking Zhang
Sent: Friday, November 13, 2020 5:28 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking
Subject: [PATCH] drm/amdgpu: declare smuio callback function as static
fi
Hmm. I've written new patches to check the remaining plane state [1],
but I'm confused. On my RX 580 machine, it turns out the pitch used by
my cursor is not 128 or 256, it's 512. Here's a drm_info excerpt:
├───DRM_CAP_CURSOR_WIDTH = 128
├───DRM_CAP_CURSOR_HEIGHT = 128
[…]
├───Plan
This patch fixes >200 warnings.
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:123:22:
warning: ‘DP_VGA_LVDS_CONVERTER_ID_3’ defined but not used
[-Wunused-const-variable=]
123 | static const uint8_t DP_VGA_LVDS_CONVERTER_ID_
This patch fixes nearly 400 warnings!
These structures are too widely used in too many varying
configurations to be split-up into different headers or moved into
source files.
Instead, we'll mark them as __maybe_unused which tells the compiler
that we're aware they're being included into source f
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c:225: warning: Function parameter or
member 'control' not described in 'smu_v11_0_i2c_transmit'
drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c:325: warning: Function parameter or
member 'control' not describ
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c:86: warning: Function parameter or
member 'f' not described in 'amdgpu_sync_get_owner'
drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c:86: warning: Excess function
parameter 'fence' description in 'amdgpu_sync_g
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c:130:6: warning: no previous
prototype for ‘amdgpu_fw_attestation_debugfs_init’ [-Wmissing-prototypes]
Cc: Alex Deucher
Cc: "Christian König"
Cc: David Airlie
Cc: Daniel Vetter
Cc: Hawking Zha
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:271: warning: Function parameter or
member 'id' not described in 'amdgpu_vmid_grab_reserved'
drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:523: warning: Function parameter or
member 'vmhub' not described in 'amd
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c:63: warning: Function parameter or
member 'resv' not described in 'amdgpu_vm_sdma_prepare'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c:63: warning: Function parameter or
member 'sync_mode' not describe
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:308: warning: Function parameter
or member 'f' not described in 'amdgpu_debugfs_regs_read'
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:308: warning: Function parameter
or member 'buf' not described in
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c: In function
‘amdgpu_allocate_static_csa’:
drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c:40:6: warning: variable ‘r’ set but
not used [-Wunused-but-set-variable]
Cc: Alex Deucher
Cc: "Christian König"
Cc: Dav
On Fri, 13 Nov 2020, Alex Deucher wrote:
> On Fri, Nov 13, 2020 at 2:19 AM Lee Jones wrote:
> >
> > On Fri, 06 Nov 2020, Lee Jones wrote:
> >
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly litt
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
This brings the running total from 5000 (in v5.9) down to 1400!
Hopefully not too much more to go now.
Lee Jones (40):
drm/amd/include/vega10_ip
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Function parameter or
member 'freq' not described in 'amdgpu_pll_compute'
drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Function parameter or
member 'fb_div_p' not described in 'amdgp
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c:35:5: warning: no previous prototype
for ‘amdgpu_to_sched_priority’ [-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c:122:5: warning: no previous
prototype for ‘amdgpu_sched_ioctl’ [-Wmiss
This patch fixes >200 warnings.
Fixes the following W=1 kernel build warning(s):
from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:31:
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:126:22:
warning: ‘DP_DVI_CONVERTER_ID_5’ defined but not used [-Wunused-const-
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c:66: warning: Function parameter or
member 'adev' not described in 'amdgpu_ib_get'
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c:66: warning: Function parameter or
member 'vm' not described in 'amdgpu_ib_get'
driv
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:560:6: warning: no previous prototype
for ‘amdgpu_virt_update_vf2pf_work_item’ [-Wmissing-prototypes]
Cc: Alex Deucher
Cc: "Christian König"
Cc: David Airlie
Cc: Daniel Vetter
Cc: amd-gfx@lists.freedes
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:908:5: warning: no previous prototype
for ‘amdgpu_ras_error_cure’ [-Wmissing-prototypes]
Cc: Alex Deucher
Cc: "Christian König"
Cc: David Airlie
Cc: Daniel Vetter
Cc: amd-gfx@lists.freedesktop.org
Cc: d
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c:168: warning: Function parameter or
member 'max_dw' not described in 'amdgpu_ring_init'
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c:168: warning: Excess function
parameter 'max_ndw' description in 'amdgpu_ri
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:69: warning: Function parameter or
member 'bo' not described in 'amdgpu_gmc_pd_addr'
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:121: warning: Function parameter or
member 'bo' not described in 'amdgpu_gmc_agp
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1482:6: warning: no previous prototype
for ‘amdgpu_ras_error_status_query’ [-Wmissing-prototypes]
Cc: Alex Deucher
Cc: "Christian König"
Cc: David Airlie
Cc: Daniel Vetter
Cc: amd-gfx@lists.freedesktop.
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:648: warning: Function parameter
or member 'dev' not described in 'amdgpu_vram_mgr_free_sgt'
drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:648: warning: Function parameter
or member 'dir' not described
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c:486:5: warning: no previous prototype
for ‘amdgpu_info_ioctl’ [-Wmissing-prototypes]
486 | int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct
drm_file *filp)
| ^
Cc: Alex De
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:5211:45: warning: ‘gfx_v7_0_ip_block’
defined but not used [-Wunused-const-variable=]
Cc: Alex Deucher
Cc: "Christian König"
Cc: David Airlie
Cc: Daniel Vetter
Cc: Sumit Semwal
Cc: amd-gfx@lists.freedesk
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c:50: warning: Function parameter or
member 'resv' not described in 'amdgpu_vm_cpu_prepare'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c:50: warning: Function parameter or
member 'sync_mode' not described i
On Thu, Nov 12, 2020 at 5:06 PM Bhawanpreet Lakha
wrote:
>
> From: Alex Deucher
>
> Adjust the FP handling to avoid nested calls.
>
> The nested calls cause the warning below
> WARNING: CPU: 3 PID: 384 at arch/x86/kernel/fpu/core.c:129 kernel_fpu_begin
>
> Fixes: 26803606c5d6 ("drm/amdgpu/display
On Fri, Nov 13, 2020 at 8:49 AM Lee Jones wrote:
>
> This patch fixes nearly 400 warnings!
>
> These structures are too widely used in too many varying
> configurations to be split-up into different headers or moved into
> source files.
>
> Instead, we'll mark them as __maybe_unused which tells th
On Fri, Nov 13, 2020 at 8:49 AM Lee Jones wrote:
>
> This patch fixes >200 warnings.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:123:22:
> warning: ‘DP_VGA_LVDS_CONVERTER_ID_3’ defined but not used
> [-Wunused-const-
On Fri, Nov 13, 2020 at 10:23 AM Alex Deucher wrote:
>
> On Fri, Nov 13, 2020 at 8:49 AM Lee Jones wrote:
> >
> > This patch fixes >200 warnings.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:123:22:
> > warnin
On Fri, Nov 13, 2020 at 8:49 AM Lee Jones wrote:
>
> This patch fixes >200 warnings.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:123:22:
> warning: ‘DP_VGA_LVDS_CONVERTER_ID_3’ defined but not used
> [-Wunused-const-
Am 13.11.20 um 08:59 schrieb Thomas Zimmermann:
Hi Christian
Am 12.11.20 um 18:16 schrieb Christian König:
Am 12.11.20 um 14:21 schrieb Thomas Zimmermann:
In order to avoid eviction of vmap'ed buffers, pin them in their GEM
object's vmap implementation. Unpin them in the vunmap implementation.
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote:
>
> This patch fixes >200 warnings.
>
> Fixes the following W=1 kernel build warning(s):
>
> from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:31:
> drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:126:22:
> warnin
Feel free to keep my rb for this, but is 455 days enough in general or
should we add wrap around handling?
Christian.
Am 10.11.20 um 18:57 schrieb Sierra Guiza, Alejandro (Alex):
[AMD Public Use]
I just added support for vega10_ih too.
Regards,
Alex
-Original Message-
From: Sierra
Am 11.11.20 um 23:27 schrieb James Zhu:
This allows us to enable dec software ring feature on VCN.
The default is 0 for all asics, and it is only valid for
asics with vcn3.0 and above.
Is that only supposed to be used for testing or do you really want to
upstream this?
A module parameter is
Am 11.11.20 um 23:27 schrieb James Zhu:
Add vcn software ring decode ring test and decode ib test.
Signed-off-by: James Zhu
Reviewed-by: Leo Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 138 ++--
1 file changed, 132 insertions(+), 6 deletions(-)
diff --git
On Fri, Nov 13, 2020 at 8:49 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c:486:5: warning: no previous
> prototype for ‘amdgpu_info_ioctl’ [-Wmissing-prototypes]
> 486 | int amdgpu_info_ioctl(struct drm_device *dev, void *da
On Thu, Nov 12, 2020 at 9:07 PM Simon Ser wrote:
>
> CC Daniel Vetter and Bas, see below…
>
> On Thursday, November 12, 2020 8:56 PM, Kazlauskas, Nicholas
> wrote:
>
> > Reviewed-by: Nicholas kazlauskasnicholas.kazlaus...@amd.com
>
> Thanks for the review!
>
> > > Couple questions:
> > >
> > > -
On Fri, 13 Nov 2020, Alex Deucher wrote:
> On Fri, Nov 13, 2020 at 8:49 AM Lee Jones wrote:
> >
> > This patch fixes >200 warnings.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:123:22:
> > warning: ‘DP_VGA_LVD
On 2020-11-13 2:23 a.m., Alex Deucher wrote:
If we have more than 4 displays we will run
into dummy irq calls or flip timout issues.
Signed-off-by: Alex Deucher
Reviewed-by: Nicholas Kazlauskas
Regards,
Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c
amdgpu_do_test_moves() is failing because of wrong
usable gart size calculation and throwing:
[drm:amdgpu_do_test_moves [amdgpu]] *ERROR* 20bdc9f3 bind failed
Signed-off-by: Nirmoy Das
---
This still doesn't work. As per my calculation 1st 4MB of GART is not
accounted for in adev->gmc.g
Am 13.11.20 um 17:17 schrieb Nirmoy Das:
amdgpu_do_test_moves() is failing because of wrong
usable gart size calculation and throwing:
[drm:amdgpu_do_test_moves [amdgpu]] *ERROR* 20bdc9f3 bind failed
Signed-off-by: Nirmoy Das
---
This still doesn't work. As per my calculation 1st 4MB
The DCC_MAX_COMPRESSED_BLOCK has to contain one of
AMD_FMT_MOD_DCC_BLOCK_* and with 3 values this doesn't
fit in 1 bit.
Fix this cleanly while it is only in drm-next.
Fixes: 8ba16d5993749c3f31fd2b49e16f0dc1e1770b9c
---
Found while reviewing Simon's drm_info PR:
https://github.com/ascent12/drm_i
Hi
Am 16.11.20 um 12:28 schrieb Christian König:
> Am 13.11.20 um 08:59 schrieb Thomas Zimmermann:
>> Hi Christian
>>
>> Am 12.11.20 um 18:16 schrieb Christian König:
>>> Am 12.11.20 um 14:21 schrieb Thomas Zimmermann:
In order to avoid eviction of vmap'ed buffers, pin them in their GEM
On 11/13/20 5:21 PM, Christian König wrote:
Am 13.11.20 um 17:17 schrieb Nirmoy Das:
amdgpu_do_test_moves() is failing because of wrong
usable gart size calculation and throwing:
[drm:amdgpu_do_test_moves [amdgpu]] *ERROR* 20bdc9f3 bind failed
Signed-off-by: Nirmoy Das
---
This stil
[AMD Public Use]
This give us time for the rest of the enablement we're doing. However, we
should fix the fundamental problem in the near future.
Regards,
Alejandro S.
> -Original Message-
> From: amd-gfx On Behalf Of
> Christian König
> Sent: Monday, November 16, 2020 5:31 AM
> To: S
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c:168: warning: Function parameter or
> member 'max_dw' not described in 'amdgpu_ring_init'
> drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c:168: warning: E
I'd feel better with wrap-around handling. I think having a system up
for that long is not likely but not impossible. Having a known hard
limit on uptime is probably a bad thing. Imagine someone trying to
reproduce the problem ...
Regards,
Felix
Am 2020-11-16 um 6:31 a.m. schrieb Christian Köni
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c:66: warning: Function parameter or
> member 'adev' not described in 'amdgpu_ib_get'
> drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c:66: warning: Function par
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Function parameter or
> member 'freq' not described in 'amdgpu_pll_compute'
> drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Fun
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c:86: warning: Function parameter or
> member 'f' not described in 'amdgpu_sync_get_owner'
> drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c:86: warning: Exc
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:648: warning: Function
> parameter or member 'dev' not described in 'amdgpu_vram_mgr_free_sgt'
> drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:64
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:560:6: warning: no previous
> prototype for ‘amdgpu_virt_update_vf2pf_work_item’ [-Wmissing-prototypes]
>
> Cc: Alex Deucher
> Cc: "Christian König"
The table describes how each bit in the u64 value is used. Explicitly
state which values a field can take if we have defines for them. Also
add a note when a field isn't always populated.
Forcing people to update the table when changing the bit layout should
make it more obvious when there's a mis
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c: In function
> ‘amdgpu_allocate_static_csa’:
> drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c:40:6: warning: variable ‘r’ set but
> not used [-Wunused-but-
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c:35:5: warning: no previous
> prototype for ‘amdgpu_to_sched_priority’ [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c:122:5: war
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:271: warning: Function parameter or
> member 'id' not described in 'amdgpu_vmid_grab_reserved'
> drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:523: warning
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:308: warning: Function parameter
> or member 'f' not described in 'amdgpu_debugfs_regs_read'
> drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:308: w
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:69: warning: Function parameter or
> member 'bo' not described in 'amdgpu_gmc_pd_addr'
> drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:121: warning: Functi
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:908:5: warning: no previous
> prototype for ‘amdgpu_ras_error_cure’ [-Wmissing-prototypes]
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: David
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c:50: warning: Function parameter
> or member 'resv' not described in 'amdgpu_vm_cpu_prepare'
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c:50: warni
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c:63: warning: Function parameter
> or member 'resv' not described in 'amdgpu_vm_sdma_prepare'
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c:63: wa
On Fri, Nov 13, 2020 at 8:51 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c:130:6: warning: no
> previous prototype for ‘amdgpu_fw_attestation_debugfs_init’
> [-Wmissing-prototypes]
>
> Cc: Alex Deucher
> Cc: "Chr
amdgpu_do_test_moves() is failing because of wrong
usable gart size calculation and throwing:
[drm:amdgpu_do_test_moves [amdgpu]] *ERROR* 20bdc9f3 bind failed
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_test.c | 13 -
1 file changed, 4 insertions(+), 9 de
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c:225: warning: Function parameter
> or member 'control' not described in 'smu_v11_0_i2c_transmit'
> drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c:325:
On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:5211:45: warning: ‘gfx_v7_0_ip_block’
> defined but not used [-Wunused-const-variable=]
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: David Airli
On Fri, Nov 13, 2020 at 11:25 AM Bas Nieuwenhuizen
wrote:
>
> The DCC_MAX_COMPRESSED_BLOCK has to contain one of
> AMD_FMT_MOD_DCC_BLOCK_* and with 3 values this doesn't
> fit in 1 bit.
>
> Fix this cleanly while it is only in drm-next.
>
> Fixes: 8ba16d5993749c3f31fd2b49e16f0dc1e1770b9c
Fixes: 8
On Fri, Nov 13, 2020 at 12:34 PM Nirmoy Das wrote:
>
> amdgpu_do_test_moves() is failing because of wrong
> usable gart size calculation and throwing:
>
> [drm:amdgpu_do_test_moves [amdgpu]] *ERROR* 20bdc9f3 bind failed
>
> Signed-off-by: Nirmoy Das
Reviewed-by: Alex Deucher
> ---
> d
On Tue, Nov 10, 2020 at 9:48 PM Bas Nieuwenhuizen
wrote:
>
> This has some more improvements for the addfb2 code in amdgpu.
>
> These patches make ffmpeg work with DCC compressed and YUV surfaces
> with kmsgrab, both in the modifier and non-modifier case.
Looks good to me. Series is:
Reviewed-by
The DCC_MAX_COMPRESSED_BLOCK has to contain one of
AMD_FMT_MOD_DCC_BLOCK_* and with 3 values this doesn't
fit in 1 bit.
Fix this cleanly while it is only in drm-next.
Fixes: 8ba16d599374 ("drm/fourcc: Add AMD DRM modifiers.")
Reviewed-by: Alex Deucher
Signed-off-by: Bas Nieuwenhuizen
---
inclu
On Fri, Nov 13, 2020 at 6:53 PM Alex Deucher wrote:
>
> On Tue, Nov 10, 2020 at 9:48 PM Bas Nieuwenhuizen
> wrote:
> >
> > This has some more improvements for the addfb2 code in amdgpu.
> >
> > These patches make ffmpeg work with DCC compressed and YUV surfaces
> > with kmsgrab, both in the modif
On Fri, Nov 13, 2020 at 12:56 PM Bas Nieuwenhuizen
wrote:
>
> On Fri, Nov 13, 2020 at 6:53 PM Alex Deucher wrote:
> >
> > On Tue, Nov 10, 2020 at 9:48 PM Bas Nieuwenhuizen
> > wrote:
> > >
> > > This has some more improvements for the addfb2 code in amdgpu.
> > >
> > > These patches make ffmpeg
On Fri, Nov 13, 2020 at 12:55 PM Bas Nieuwenhuizen
wrote:
>
> The DCC_MAX_COMPRESSED_BLOCK has to contain one of
> AMD_FMT_MOD_DCC_BLOCK_* and with 3 values this doesn't
> fit in 1 bit.
>
> Fix this cleanly while it is only in drm-next.
>
> Fixes: 8ba16d599374 ("drm/fourcc: Add AMD DRM modifiers."
On Fri, Nov 13, 2020 at 12:21 PM Simon Ser wrote:
>
> The table describes how each bit in the u64 value is used. Explicitly
> state which values a field can take if we have defines for them. Also
> add a note when a field isn't always populated.
>
> Forcing people to update the table when changing
On 2020-11-12 5:06 p.m., Bhawanpreet Lakha wrote:
From: Alex Deucher
Adjust the FP handling to avoid nested calls.
The nested calls cause the warning below
WARNING: CPU: 3 PID: 384 at arch/x86/kernel/fpu/core.c:129 kernel_fpu_begin
Fixes: 26803606c5d6 ("drm/amdgpu/display: FP fixes for DCN3.x
On Thu, Nov 12, 2020 at 5:23 PM Ryan Taylor wrote:
>
> Allocate smu_power->power_context to size of smu_11_0_power_context instead of
> smu_11_0_dpm_context.
>
> Signed-off-by: Ryan Taylor
> Reviewed-by: Alex Deucher
> Reviewed-by: Evan Quan
Looks good to me.
Thanks!
Alex
> ---
> drivers/g
There is a delta in the dmub code
- add boot options
- add boot status
- remove unused auto_load_is_done func pointer
Signed-off-by: Bhawanpreet Lakha
---
drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 20 +-
.../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 3 ++-
.../gpu/drm/amd/di
Never used so drop it.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c
b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c
index 50308a5573e4..04226b
The function was added, but the callback was not registered,
possibly lost in a rebase.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c
b/drivers/gpu/drm/amd/pm/sw
On 6/22/20 1:50 PM, Daniel Vetter wrote:
On Mon, Jun 22, 2020 at 7:45 PM Christian König
wrote:
Am 22.06.20 um 16:32 schrieb Andrey Grodzovsky:
On 6/22/20 9:18 AM, Christian König wrote:
Am 21.06.20 um 08:03 schrieb Andrey Grodzovsky:
Will be used to reroute CPU mapped BO's page faults once
From: Jacky Liao
[Why]
The I2C memory blocks should be powered down when they are not in use.
This will reduce power consumption.
[How]
1. Write to I2C_LIGHT_SLEEP_FORCE to put memory in light sleep when
released
2. Added a debug option to allow this behaviour to be turned off
Signed-off-by:
From: Wyatt Wood
[Why]
Use GPINT command to get PSR residency from FW.
[How]
Hook up PSR residency command to DSAT.
Since PSR Count Request is deprecated, we will use this.
Signed-off-by: Wyatt Wood
Acked-by: Bindu Ramamurthy
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 12 +++
From: Yongqiang Sun
[Why & How]
Add a dual edp power optimization flag, so driver will
notify this flag to dmub FW to determine if apply the
power optimization.
Signed-off-by: Yongqiang Sun
Acked-by: Bindu Ramamurthy
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 1 +
drivers/gpu/drm/a
From: Sung Lee
[WHY & HOW]
Currently if VBIOSSMC_Result_UnknownCmd is returned as result of smu msg
there is no way to know. Put 1 in param so if 1 is returned, this unknown case
is handled.
Signed-off-by: Sung Lee
Acked-by: Bindu Ramamurthy
---
.../drm/amd/display/dc/clk_mgr/dcn21/rn_clk_m
From: Wayne Lin
[Why]
Instead of calculating CRC on whole frame, add flexibility to calculate
CRC on specific frame region.
[How]
Add few crc window coordinate properties. By default, CRC is calculated
on whole frame unless user space specifies the CRC calculation window.
Signed-off-by: Wayne L
From: Wenjing Liu
Signed-off-by: Wenjing Liu
Acked-by: Bindu Ramamurthy
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
b/drivers/gpu/drm/amd/display/dc/core/dc_
This DC patchset brings improvements in multiple areas. In summary, we have:
Anthony Koo (1):
drm/amd/display: [FW Promotion] Release 0.0.42
Aric Cyr (1):
drm/amd/display: 3.2.112
Dmytro Laktyushkin (1):
drm/amd/display: remove unused dml variables
Jacky Liao (1):
drm/amd/display: Add
From: Roy Chan
[Why]
Check if the eDP sink supports the dynamic backlight control
[How]
Query the dynamic backlight capability in DPCD (eDP case only)
Signed-off-by: Roy Chan
Acked-by: Bindu Ramamurthy
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 7 +++
drivers/gpu/drm/amd/disp
From: Samson Tam
[Why]
Cursor is missing on displays 2 and up when doing rotated
display groups in 1xnY setup. Calculation puts cursor
out of bounds so it is not enabled.
[How]
In dcn10_set_cursor_position(), add in viewport.y into cursor
calculations for 1xnY rotated display groups.
For pip
From: Anthony Koo
Signed-off-by: Anthony Koo
Acked-by: Bindu Ramamurthy
---
drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
From: Yongqiang Sun
[Why]
dpp dto phase and modulo are programmed with actual dpp global clk
and pipe clk. Need to use actual dpp clk to prgoram dpp dto modulo
to get more accuracy ratio.
[How]
assign actual dpp clk to dccg for dpp modulo programming.
Signed-off-by: Yongqiang Sun
Acked-by: Bin
From: Yongqiang Sun
[Why & How]
Update bounding box as per spread sheet.
Signed-off-by: Yongqiang Sun
Acked-by: Roman Li
---
.../amd/display/dc/dcn301/dcn301_resource.c | 60 +++
1 file changed, 47 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/d
From: Aric Cyr
Signed-off-by: Aric Cyr
Acked-by: Bindu Ramamurthy
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h
b/drivers/gpu/drm/amd/display/dc/dc.h
index 96ff556e2567..443b1f1ad546 100644
--- a
1 - 100 of 108 matches
Mail list logo
