Re: [PATCH RFC PKS/PMEM 05/58] kmap: Introduce k[un]map_thread

Ira, On Fri, Oct 09 2020 at 12:49, ira weiny wrote: > From: Ira Weiny > > To correctly support the semantics of kmap() with Kernel protection keys > (PKS), kmap() may be required to set the protections on multiple > processors (globally). Enabling PKS globally can be very expensive > depending o

[PATCH] amd/display/amdgpu_dm: delete same check in if condition

In function amdgpu_dm_connector_get_modes, drm_edid_is_valid will check weather (!edid), no need to check again in the if branch. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/

Re: Subject: [RFC] clang tooling cleanups

On Tue, 2020-10-27 at 09:42 -0700, t...@redhat.com wrote: > This rfc will describe > An upcoming treewide cleanup. > How clang tooling was used to programatically do the clean up. > Solicit opinions on how to generally use clang tooling. > > The clang warning -Wextra-semi-stmt produces about 10k w

Re: [PATCH 00/20] [Set 3] Rid W=1 warnings from GPU

On Mon, 09 Nov 2020, Alex Deucher wrote: > On Mon, Nov 9, 2020 at 4:19 PM Lee Jones wrote: > > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > This set takes the running (decr

Re: [PATCH RFC PKS/PMEM 05/58] kmap: Introduce k[un]map_thread

On Tue, Nov 10, 2020 at 02:13:56AM +0100, Thomas Gleixner wrote: > Ira, > > On Fri, Oct 09 2020 at 12:49, ira weiny wrote: > > From: Ira Weiny > > > > To correctly support the semantics of kmap() with Kernel protection keys > > (PKS), kmap() may be required to set the protections on multiple > >

Re: [PATCH 15/20] drm/radeon/r600d: Move 'rc600_*' prototypes into shared header

On Mon, 09 Nov 2020, Alex Deucher wrote: > On Mon, Nov 9, 2020 at 4:19 PM Lee Jones wrote: > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/radeon/r600_hdmi.c:177:6: warning: no previous prototype > > for ‘r600_hdmi_update_acr’ [-Wmissing-prototypes] > > 177 | v

Re: [PATCH 15/20] drm/radeon/r600d: Move 'rc600_*' prototypes into shared header

Hi Lee, > > the *d.h headers are supposed to just be hardware definitions. I'd > > prefer to keep driver stuff out of them. > > That's fine (I did wonder if that were the case). > > I need an answer from you and Sam whether I can create new headers. > > For me, it is the right thing to do. Pl

RE: [PATCH] drm/amd/pm: correct table_clk_vlt memory size due to replacing one-element array with flexible-array in struct phm_clock_voltage_dependency_table

[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Mengbing Wang Sent: Tuesday, November 10, 2020 3:27 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Mengbing (Martin) Subject: [PATCH] drm/amd/pm: correct table_clk_

RE: [PATCH] drm/amd/pm: correct table_clk_vlt memory size due to replacing one-element array with flexible-array in struct phm_clock_voltage_dependency_table

[AMD Public Use] The signed-off spelling is one typo caused by mis-editing? Signee-off-by: Mengbing Wang Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Mengbing Wang Sent: Tuesday, November 10, 2020 3:27 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Mengbing (Martin)

Re: [PATCH] drm/amdgpu: enable 48-bit IH timestamp counter

Am 10.11.20 um 04:20 schrieb Alex Sierra: By default this timestamp is based on a 32 bit counter. This is used by the amdgpu_gmc_filter_faults, to avoid process the same interrupt in retry configuration. Apparently there's a problem when the timestamp coming from IH overflows and compares against

Re: [PATCH] drivers: amdgpu: amdgpu_display: Fixed the spelling of falg to flag

Am 09.11.20 um 22:07 schrieb Bhaskar Chowdhury: s/falg/flag/p Signed-off-by: Bhaskar Chowdhury Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/

[PATCH] drm/nouveau: Fix out-of-bounds access when deferencing MMU type

The value of struct drm_device.ttm.type_vram can become -1 for unknown types of memory (see nouveau_ttm_init()). This leads to an out-of-bounds error when accessing struct nvif_mmu.type[]: [ 18.304116] == [ 18.311649] BUG: KA

Re: [PATCH] amd/display/amdgpu_dm: delete same check in if condition

On 2020-11-10 3:03 a.m., Bernard Zhao wrote: In function amdgpu_dm_connector_get_modes, drm_edid_is_valid will check weather (!edid), no need to check again in the if branch. Signed-off-by: Bernard Zhao Reviewed-by: Harry Wentland Harry --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_d

Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume

On 2020-11-10 2:49 a.m., Stylon Wang wrote: EDID parsing in S3 resume pushes new display modes to probed_modes list but doesn't consolidate to actual mode list. This creates a race condition when amdgpu_dm_connector_ddc_get_modes() re-initializes the list head without walking the list and results

RE: [PATCH] drm/amd/display: Tune fclk for 4K OLED display

[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Hersen Wu -Original Message- From: Vishwakarma, Pratik Sent: Monday, November 9, 2020 12:39 AM To: Wu, Hersen ; amd-gfx@lists.freedesktop.org Cc: Vishwakarma, Pratik Subject: [PATCH] drm/amd/display: Tune fclk for 4K O

Re: [PATCH 3/3] drm/amdgpu: enable only one compute queue for raven

On 11/9/20 7:57 PM, Alex Deucher wrote: On Mon, Nov 9, 2020 at 1:12 PM Nirmoy Das wrote: Because of firmware bug, Raven asics can't handle jobs scheduled to multiple compute queues. So enable only one compute queue till we have a firmware fix. Signed-off-by: Nirmoy Das --- drivers/gpu/drm

Re: [PATCH] drm/nouveau: Fix out-of-bounds access when deferencing MMU type

Am 10.11.20 um 14:36 schrieb Thomas Zimmermann: The value of struct drm_device.ttm.type_vram can become -1 for unknown types of memory (see nouveau_ttm_init()). This leads to an out-of-bounds error when accessing struct nvif_mmu.type[]: [ 18.304116]

RE: [PATCH] drm/nouveau: Fix out-of-bounds access when deferencing MMU type

>-Original Message- >From: Thomas Zimmermann >Sent: Tuesday, November 10, 2020 8:37 AM >To: bske...@redhat.com; airl...@linux.ie; dan...@ffwll.ch; Ruhl, Michael J >; christian.koe...@amd.com >Cc: nouv...@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Thomas >Zimmermann ; Maarten

Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume

[AMD Official Use Only - Internal Distribution Only] Lee Starnes just sent the exact same patch yesterday. Please review that one: https://patchwork.freedesktop.org/patch/399497/ Alex From: Wentland, Harry Sent: Tuesday, November 10, 2020 9:27 AM To: Wang, Chao

Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume

It's missing the "drm_connector_list_update" call which I assume is important. Stylon, can you review Lee Starnes's patch? Is the drm_connector_list_update call maybe not needed? Thanks, Harry On 2020-11-10 11:26 a.m., Deucher, Alexander wrote: [AMD Official Use Only - Internal Distributio

Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume

[AMD Official Use Only - Internal Distribution Only] Ah, sorry, I missed that part of the patch. Alex From: Wentland, Harry Sent: Tuesday, November 10, 2020 11:42 AM To: Deucher, Alexander ; Wang, Chao-kai (Stylon) ; amd-gfx@lists.freedesktop.org Cc: Kazlausk

Re: [PATCH 15/20] drm/radeon/r600d: Move 'rc600_*' prototypes into shared header

On Tue, 10 Nov 2020, Sam Ravnborg wrote: > Hi Lee, > > > > the *d.h headers are supposed to just be hardware definitions. I'd > > > prefer to keep driver stuff out of them. > > > > That's fine (I did wonder if that were the case). > > > > I need an answer from you and Sam whether I can create

[PATCH] drm/amd/pm: Use kmemdup instead of kmalloc and memcpy

Fixes coccicheck warning: drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c:255: 36-43: WARNING opportunity for kmemdup Signed-off-by: Tian Tao --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

Re: [PATCH RFC PKS/PMEM 05/58] kmap: Introduce k[un]map_thread

On Mon, Nov 09 2020 at 20:59, Ira Weiny wrote: > On Tue, Nov 10, 2020 at 02:13:56AM +0100, Thomas Gleixner wrote: > Also, we can convert the new memcpy_*_page() calls to kmap_local() as well. > [For now my patch just uses kmap_atomic().] > > I've not looked at all of the patches in your latest vers

Re: Subject: [RFC] clang tooling cleanups

On 11/9/20 6:52 PM, Joe Perches wrote: > On Tue, 2020-10-27 at 09:42 -0700, t...@redhat.com wrote: >> This rfc will describe >> An upcoming treewide cleanup. >> How clang tooling was used to programatically do the clean up. >> Solicit opinions on how to generally use clang tooling. >> >> The clang

Re: [PATCH] drm/amd/pm: Use kmemdup instead of kmalloc and memcpy

On Tue, Nov 10, 2020 at 11:57 AM Tian Tao wrote: > > Fixes coccicheck warning: > drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c:255: > 36-43: WARNING opportunity for kmemdup > > Signed-off-by: Tian Tao Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega

Re: [PATCH v2 2/8] drm/ttm: Remap all page faults to per process dummy page.

On 6/22/20 5:41 AM, Daniel Vetter wrote: On Sun, Jun 21, 2020 at 02:03:02AM -0400, Andrey Grodzovsky wrote: On device removal reroute all CPU mappings to dummy page per drm_file instance or imported GEM object. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 65 +

Re: [PATCH v2 5/8] drm/amdgpu: Refactor sysfs removal

Hi, back to this after a long context switch for some higher priority stuff. So here I was able eventually to drop all this code and this change here https://cgit.freedesktop.org/~agrodzov/linux/commit/?h=amd-staging-drm-next-device-unplug&id=61852c8a59b4dd89d637693552c73175b9f2ccd6 was enough f

[PATCH] drm/amdgpu: enable 48-bit IH timestamp counter

By default this timestamp is based on a 32 bit counter. This is used by the amdgpu_gmc_filter_faults, to avoid process the same interrupt in retry configuration. Apparently there's a problem when the timestamp coming from IH overflows and compares against timestamp coming from the the hash table. T

RE: [PATCH] drm/amdgpu: enable 48-bit IH timestamp counter

[AMD Public Use] I just added support for vega10_ih too. Regards, Alex > -Original Message- > From: Sierra Guiza, Alejandro (Alex) > Sent: Tuesday, November 10, 2020 11:55 AM > To: amd-gfx@lists.freedesktop.org > Cc: Koenig, Christian ; Kuehling, Felix > ; Sierra Guiza, Alejandro (Alex)

Re: [PATCH] drm/amdgpu: enable 48-bit IH timestamp counter

Hi Alex, Please update vega10_ih.c as well. Thanks, Philip On 2020-11-09 10:20 p.m., Alex Sierra wrote: By default this timestamp is based on a 32 bit counter. This is used by the amdgpu_gmc_filter_faults, to avoid process the same interrupt i

Re: [PATCH v2 5/8] drm/amdgpu: Refactor sysfs removal

On Tue, Nov 10, 2020 at 12:54:21PM -0500, Andrey Grodzovsky wrote: > Hi, back to this after a long context switch for some higher priority stuff. > > So here I was able eventually to drop all this code and this change here > https://cgit.freedesktop.org/~agrodzov/linux/commit/?h=amd-staging-drm-n

Re: [PATCH] amd/display/amdgpu_dm: delete same check in if condition

Applied. Thanks! Alex On Tue, Nov 10, 2020 at 9:13 AM Harry Wentland wrote: > > On 2020-11-10 3:03 a.m., Bernard Zhao wrote: > > In function amdgpu_dm_connector_get_modes, drm_edid_is_valid > > will check weather (!edid), no need to check again in the if > > branch. > > > > Signed-off-by: Berna

[PATCH 10/30] drm/radeon/radeon_sync: Add description for function param 'rdev'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_sync.c:92: warning: Function parameter or member 'rdev' not described in 'radeon_sync_resv' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-gfx@lists.freedeskto

[PATCH 08/30] drm/radeon/ci_dpm: Remove set but unused variable 'dpm_event_src'

And the piece of code that has never been executed. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/ci_dpm.c: In function ‘ci_set_dpm_event_sources’: drivers/gpu/drm/radeon/ci_dpm.c:1369:28: warning: variable ‘dpm_event_src’ set but not used [-Wunused-but-set-variable]

[PATCH 26/30] drm/radeon/ni_dpm: Move 'ni_get_{pi, ps}()'s into shared header

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/ni_dpm.c:727:23: warning: no previous prototype for ‘ni_get_pi’ [-Wmissing-prototypes] 727 | struct ni_power_info *ni_get_pi(struct radeon_device *rdev) | ^ drivers/gpu/drm/radeon/ni_dpm.c:734:15: warning: no prev

[PATCH 06/30] drm/radeon/trinity_dpm: Remove some defined but never used arrays

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/trinity_dpm.c:146:18: warning: ‘trinity_sysls_default’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/radeon/trinity_dpm.c:131:18: warning: ‘trinity_mgcg_shls_disable’ defined but not used [-Wunused-const-

[PATCH 01/30] drm/radeon/evergreen: Add comment for 'evergreen_page_flip()'s 'async' param

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/evergreen.c: In function ‘evergreen_gpu_init’: drivers/gpu/drm/radeon/evergreen.c:1419: warning: Function parameter or member 'async' not described in 'evergreen_page_flip' Cc: Alex Deucher Cc: "Christian König" Cc: Davi

[PATCH 02/30] drm/radeon/evergreen: Remove set but unused variable 'mc_shared_chmap'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/evergreen.c: In function ‘evergreen_gpu_init’: drivers/gpu/drm/radeon/evergreen.c:3135:6: warning: variable ‘mc_shared_chmap’ set but not used [-Wunused-but-set-variable] Cc: Alex Deucher Cc: "Christian König" Cc: David

[PATCH 13/30] drm/radeon/radeon_mn: Supply description for 'cur_seq' even if it is unused

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_mn.c:51: warning: Function parameter or member 'cur_seq' not described in 'radeon_mn_invalidate' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri

[PATCH 29/30] drm/radeon/r600_dma: Move 'r600_gpu_check_soft_reset()'s prototype to shared location

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/r600.c:1615:5: warning: no previous prototype for ‘r600_gpu_check_soft_reset’ [-Wmissing-prototypes] 1615 | u32 r600_gpu_check_soft_reset(struct radeon_device *rdev) | ^ Cc: Alex Deucher Cc: "Chri

[PATCH 14/30] drm/radeon/evergreen_dma: Fix doc-rot of function parameter 'resv'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/evergreen_dma.c:112: warning: Function parameter or member 'resv' not described in 'evergreen_copy_dma' drivers/gpu/drm/radeon/evergreen_dma.c:112: warning: Excess function parameter 'fence' description in 'evergreen_copy_

[PATCH 30/30] drm/radeon/cik: Move 'r600_ih_ring_{alloc, fini}()'s prototypes to shared header

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/r600.c:3480:5: warning: no previous prototype for ‘r600_ih_ring_alloc’ [-Wmissing-prototypes] 3480 | int r600_ih_ring_alloc(struct radeon_device *rdev) | ^~ drivers/gpu/drm/radeon/r600.c:3516:6: warning: n

[PATCH 19/30] drm/radeon/radeon_drv: Move 'radeon_mmap()'s prototype to shared header

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_ttm.c:931:5: warning: no previous prototype for ‘radeon_mmap’ [-Wmissing-prototypes] 931 | int radeon_mmap(struct file *filp, struct vm_area_struct *vma) | ^~~ Cc: Alex Deucher Cc: "Christian König" Cc: D

[PATCH 18/30] drm/radeon/evergreen_cs: Fix misnaming issues surrounding 'p' param

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/evergreen_cs.c:1026: warning: Function parameter or member 'p' not described in 'evergreen_cs_packet_parse_vline' drivers/gpu/drm/radeon/evergreen_cs.c:1026: warning: Excess function parameter 'parser' description in 'ever

[PATCH 03/30] drm/radeon/ni: Demote vague attempt at function header doc

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/ni.c: In function ‘cayman_gpu_init’: drivers/gpu/drm/radeon/ni.c:2679: warning: Function parameter or member 'ring' not described in 'cayman_vm_flush' drivers/gpu/drm/radeon/ni.c:2679: warning: Function parameter or member

[PATCH 05/30] drm/radeon/cik: Remove set but unused variable 'mc_shared_chmap'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/cik.c: In function ‘cik_gpu_init’: drivers/gpu/drm/radeon/cik.c:3180:6: warning: variable ‘mc_shared_chmap’ set but not used [-Wunused-but-set-variable] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel

[PATCH 24/30] drm/radeon/rv770: Move 'rv770_get_*()'s prototypes to shared header

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/rv770_dpm.c:47:18: warning: no previous prototype for ‘rv770_get_ps’ [-Wmissing-prototypes] 47 | struct rv7xx_ps *rv770_get_ps(struct radeon_ps *rps) | ^~~~ drivers/gpu/drm/radeon/rv770_dpm.c:54:26: warning: no pr

[PATCH 11/30] drm/radeon/radeon_ib: Supply description for 'radeon_ib_get's get param

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_ib.c:61: warning: Function parameter or member 'vm' not described in 'radeon_ib_get' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-de...@lists

[PATCH 07/30] drm/radeon/kv_dpm: Strip out unused functions and their tables

These haven't been used since the driver was upstreamed in 2013. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/kv_dpm.c:161:40: warning: ‘cpl_cac_config_reg’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/radeon/kv_dpm.c:156:40: warning: ‘mc3_cac_conf

[PATCH 21/30] drm/radeon/atom: Move 'radeon_atom_hw_i2c_*()'s prototypes into shared header

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/atombios_i2c.c:100:5: warning: no previous prototype for ‘radeon_atom_hw_i2c_xfer’ [-Wmissing-prototypes] 100 | int radeon_atom_hw_i2c_xfer(struct i2c_adapter *i2c_adap, | ^~~ drivers/gpu/drm/radeon/at

[PATCH 17/30] drm/radeon/r600_cs: Fix some doc-rot and supply missing function param docs

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/r600_cs.c:793: warning: Function parameter or member 'p' not described in 'r600_cs_packet_parse_vline' drivers/gpu/drm/radeon/r600_cs.c:793: warning: Excess function parameter 'parser' description in 'r600_cs_packet_parse_

[PATCH 16/30] drm/radeon/r100: Fix some kernel-doc formatting, misnaming and missing issues

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/r100.c:163: warning: Function parameter or member 'async' not described in 'r100_page_flip' drivers/gpu/drm/radeon/r100.c:848: warning: Function parameter or member 'rdev' not described in 'r100_ring_hdp_flush' drivers/gp

[PATCH 25/30] drm/radeon/sumo_dpm: Move 'sumo_get_pi()'s prototype into shared header

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/sumo_dpm.c:81:25: warning: no previous prototype for ‘sumo_get_pi’ [-Wmissing-prototypes] 81 | struct sumo_power_info *sumo_get_pi(struct radeon_device *rdev) | ^~~ Cc: Alex Deucher Cc: "Christian König" Cc: Dav

[PATCH 20/30] drm/radeon/radeon_drv: Move 'radeon_driver_irq_handler_kms's prototype into shared header

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_irq_kms.c:53:13: warning: no previous prototype for ‘radeon_driver_irq_handler_kms’ [-Wmissing-prototypes] 53 | irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg) | ^ drivers/

[PATCH 15/30] drm/radeon/cik_sdma: Demote vague attempt at kernel-doc

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/cik_sdma.c:949: warning: Function parameter or member 'ring' not described in 'cik_dma_vm_flush' drivers/gpu/drm/radeon/cik_sdma.c:949: warning: Function parameter or member 'vm_id' not described in 'cik_dma_vm_flush' dri

[PATCH 00/30] [Set 4] Rid W=1 warnings from GPU

This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Exciting times (using Arm as the benchmark): Before these sets: 5031 drivers/gpu/ 3923 drivers/gpu/drm/amd/ 258 drivers/gpu/drm/radeon/

[PATCH 28/30] drm/radeon/evergreen: Move 'cayman_*()'s prototypes to shared header

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/ni.c:1378:6: warning: no previous prototype for ‘cayman_cp_int_cntl_setup’ [-Wmissing-prototypes] 1378 | void cayman_cp_int_cntl_setup(struct radeon_device *rdev, | ^~~~ drivers/gpu/drm/radeon/ni.c:173

[PATCH 27/30] drm/radeon/ni: Remove set but unused variable 'mc_shared_chmap'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/ni.c: In function ‘cayman_gpu_init’: drivers/gpu/drm/radeon/ni.c:880:6: warning: variable ‘mc_shared_chmap’ set but not used [-Wunused-but-set-variable] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel

[PATCH 04/30] drm/radeon/si: Remove set but unused variable 'mc_shared_chmap'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/si.c: In function ‘si_gpu_init’: drivers/gpu/drm/radeon/si.c:3090:6: warning: variable ‘mc_shared_chmap’ set but not used [-Wunused-but-set-variable] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Ve

[PATCH 12/30] drm/radeon/radeon_dp_mst: Remove unused variable 'ret' from radeon_mst_encoder_dpms()

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_dp_mst.c: In function ‘radeon_mst_encoder_dpms’: drivers/gpu/drm/radeon/radeon_dp_mst.c:366:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Alex Deucher Cc: "Christian König" Cc: David

[PATCH 09/30] drm/radeon/radeon_vm: Fix some function parameter documentation

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_vm.c:131: warning: Function parameter or member 'rdev' not described in 'radeon_vm_get_bos' drivers/gpu/drm/radeon/radeon_vm.c:643: warning: Excess function parameter 'start' description in 'radeon_vm_update_page_di

[PATCH 23/30] drm/radeon/evergreen_hdmi: Move 'evergreen_*()' and 'dce4_*()' HDMI prototypes to shared header

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/evergreen_hdmi.c:37:6: warning: no previous prototype for ‘dce4_audio_enable’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/evergreen_hdmi.c:67:6: warning: no previous prototype for ‘evergreen_hdmi_update_acr’ [-Wmissing-p

[PATCH 22/30] drm/radeon/radeon_gem: Move 'radeon_gem_prime_*()'s prototypes to shared header

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_prime.c:34:18: warning: no previous prototype for ‘radeon_gem_prime_get_sg_table’ [-Wmissing-prototypes] 34 | struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj) | ^~~~

Re: [PATCH 15/20] drm/radeon/r600d: Move 'rc600_*' prototypes into shared header

On Tue, Nov 10, 2020 at 4:41 AM Lee Jones wrote: > > On Tue, 10 Nov 2020, Sam Ravnborg wrote: > > > Hi Lee, > > > > > > the *d.h headers are supposed to just be hardware definitions. I'd > > > > prefer to keep driver stuff out of them. > > > > > > That's fine (I did wonder if that were the case).

[PATCH] drm/amd/amdgpu: Update VCN initizalization behvaior

- Issue: In the original vcn3.0 code, it assumes that the VCN's init_status is always 1, even after the MMSCH updates the header. This is incorrect since by default, it should be set to 0, and MMSCH will update it to 1 if VCN is ready. - Fix: We need to read back the table header afte

Re: [PATCH 15/20] drm/radeon/r600d: Move 'rc600_*' prototypes into shared header

On Tue, 10 Nov 2020, Alex Deucher wrote: > On Tue, Nov 10, 2020 at 4:41 AM Lee Jones wrote: > > > > On Tue, 10 Nov 2020, Sam Ravnborg wrote: > > > > > Hi Lee, > > > > > > > > the *d.h headers are supposed to just be hardware definitions. I'd > > > > > prefer to keep driver stuff out of them. > >

Re: [PATCH 15/19] gpu: drm: radeon: radeon_drv: Remove unused variable 'ret'

On Thu, Nov 5, 2020 at 9:52 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_drv.c: In function > ‘radeon_pmops_runtime_suspend’: > drivers/gpu/drm/radeon/radeon_drv.c:455:6: warning: variable ‘ret’ set but > not used [-Wunused-but-set-

Re: [PATCH 18/19] gpu: drm: amd: amdgpu: amdgpu: Mark global variables as __maybe_unused

On Thu, Nov 5, 2020 at 9:52 AM Lee Jones wrote: > > These 3 variables are used in *some* sourcefiles which include > amdgpu.h, but not *all*. This leads to a flurry of build warnings. > > Fixes the following W=1 kernel build warning(s): > > from drivers/gpu/drm/amd/amdgpu/amdgpu.h:67, > drivers

Re: [PATCH 17/19] gpu: drm: radeon: radeon_device: Fix a bunch of kernel-doc misdemeanours

On Thu, Nov 5, 2020 at 9:52 AM Lee Jones wrote: > > - Demote non-conformant headers > - Fix misnaming issues > - Rename labels with identical names > - Remove incorrect descriptions > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_device.c:637:6: warning:

Re: [PATCH 06/19] drm/radeon/atom: Move prototype into shared location

On Fri, Nov 6, 2020 at 4:50 PM Lee Jones wrote: > > Both source files include atom.h, which seems like a reasonable > location to place an atom based function into. > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_atombios.c:1791:6: warning: no previous > pr

Re: [PATCH 07/19] drm/radeon/radeon_kms: Include header containing our own prototypes

On Fri, Nov 6, 2020 at 4:50 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_kms.c:61:6: warning: no previous prototype for > ‘radeon_driver_unload_kms’ [-Wmissing-prototypes] > drivers/gpu/drm/radeon/radeon_kms.c:104:5: warning: no prev

Re: [PATCH 11/19] drm/radeon/radeon_drv: Source file headers are not good candidates for kernel-doc

On Fri, Nov 6, 2020 at 4:50 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_drv.c:2: warning: Cannot understand * file > radeon_drv.c > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Gareth H

Re: [PATCH 13/19] drm/radeon/radeon_drv: Move prototypes to a shared headerfile

On Fri, Nov 6, 2020 at 4:50 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > 62 | void radeon_driver_unload_kms(struct drm_device *dev) > | ^~~~ > drivers/gpu/drm/radeon/radeon_kms.c:105:5: warning: no previous prototype > for ‘radeon_driver_load

Re: [PATCH 15/19] drm/radeon: Move prototypes to shared header

On Fri, Nov 6, 2020 at 4:50 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_kms.c:756:5: warning: no previous prototype > for ‘radeon_get_vblank_counter_kms’ [-Wmissing-prototypes] > 756 | u32 radeon_get_vblank_counter_kms(struct drm_cr

Re: [PATCH 18/19] drm/radeon/atombios_crtc: Remove description of non-existent function param 'encoder'

On Fri, Nov 6, 2020 at 4:50 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/atombios_crtc.c:1796: warning: Excess function > parameter 'encoder' description in 'radeon_get_shared_nondp_ppll' > > Cc: Alex Deucher > Cc: "Christian König" > Cc:

Re: [PATCH 01/20] drm/radeon/radeon_ttm: Place declaration of 'rdev' in same clause as its use

On Mon, Nov 9, 2020 at 4:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_ttm.c: In function ‘radeon_ttm_tt_create’: > drivers/gpu/drm/radeon/radeon_ttm.c:611:24: warning: variable ‘rdev’ set but > not used [-Wunused-but-set-variable]

Re: [PATCH 03/20] drm/radeon/radeon_fence: Demote some non-conformant kernel-doc headers and fix another

On Mon, Nov 9, 2020 at 4:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_fence.c:168: warning: Function parameter or > member 'wait' not described in 'radeon_fence_check_signaled' > drivers/gpu/drm/radeon/radeon_fence.c:168: warning:

Re: [PATCH 06/20] drm/radeon/radeon_connectors: Strip out set but unused variable 'ret'

On Mon, Nov 9, 2020 at 4:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_connectors.c: In function > ‘radeon_setup_mst_connector’: > drivers/gpu/drm/radeon/radeon_connectors.c:2574:7: warning: variable ‘ret’ > set but not used [-Wun

Re: [PATCH 07/20] drm/radeon/radeon_display: Remove unused variable 'mod'

On Mon, Nov 9, 2020 at 4:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_display.c: In function ‘radeon_div’: > drivers/gpu/drm/radeon/radeon_display.c:1094:11: warning: variable ‘mod’ set > but not used [-Wunused-but-set-variable] >

Re: [PATCH 08/20] drm/radeon/radeon_i2c: Remove pointless function header

On Mon, Nov 9, 2020 at 4:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_i2c.c:46: warning: Function parameter or > member 'radeon_connector' not described in 'radeon_ddc_probe' > drivers/gpu/drm/radeon/radeon_i2c.c:46: warning: Func

Re: [PATCH 09/20] drm/radeon/radeon_irq_kms: Demote non-conformant kernel-doc fix another

On Mon, Nov 9, 2020 at 4:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_irq_kms.c:56: warning: Function parameter or > member 'irq' not described in 'radeon_driver_irq_handler_kms' > drivers/gpu/drm/radeon/radeon_irq_kms.c:56: warni

Re: [PATCH 10/20] drm/radeon/radeon_ring: Add missing function parameters 'rdev' and 'data'

On Mon, Nov 9, 2020 at 4:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_ring.c:226: warning: Function parameter or > member 'rdev' not described in 'radeon_ring_unlock_undo' > drivers/gpu/drm/radeon/radeon_ring.c:240: warning: Funct

Re: [PATCH 11/20] drm/radeon/r600: Strip out set but unused 'tmp' variables

On Mon, Nov 9, 2020 at 4:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/r600.c: In function ‘r600_pcie_gart_tlb_flush’: > drivers/gpu/drm/radeon/r600.c:1083:7: warning: variable ‘tmp’ set but not > used [-Wunused-but-set-variable] > drive

Re: [PATCH 12/20] drm/radeon/radeon_cs: Fix a bunch of doc-rot issues

On Mon, Nov 9, 2020 at 4:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_cs.c:416: warning: Function parameter or > member 'backoff' not described in 'radeon_cs_parser_fini' > drivers/gpu/drm/radeon/radeon_cs.c:735: warning: Function

Re: [PATCH 18/20] drm/radeon/radeon_display: Fix function doc formatting and missing param issues

On Mon, Nov 9, 2020 at 4:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_display.c:264: warning: Function parameter or > member '__work' not described in 'radeon_unpin_work_func' > drivers/gpu/drm/radeon/radeon_display.c:406: warning

Re: [PATCH 19/20] drm/radeon/r600: Fix a misnamed parameter description and a formatting issue

On Mon, Nov 9, 2020 at 4:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/r600.c:2965: warning: Function parameter or member > 'resv' not described in 'r600_copy_cpdma' > drivers/gpu/drm/radeon/r600.c:2965: warning: Excess function parameter

Re: [PATCH 20/20] drm/radeon/cik: Fix a bunch of function parameter descriptions

On Mon, Nov 9, 2020 at 4:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/cik.c:1869:5: warning: no previous prototype for > ‘ci_mc_load_microcode’ [-Wmissing-prototypes] > drivers/gpu/drm/radeon/cik.c: In function ‘cik_gpu_init’: > drivers

Re: [PATCH 02/30] drm/radeon/evergreen: Remove set but unused variable 'mc_shared_chmap'

On Tue, Nov 10, 2020 at 2:31 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/evergreen.c: In function ‘evergreen_gpu_init’: > drivers/gpu/drm/radeon/evergreen.c:3135:6: warning: variable > ‘mc_shared_chmap’ set but not used [-Wunused-but-set-v

Re: [PATCH 01/30] drm/radeon/evergreen: Add comment for 'evergreen_page_flip()'s 'async' param

On Tue, Nov 10, 2020 at 2:31 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/evergreen.c: In function ‘evergreen_gpu_init’: > drivers/gpu/drm/radeon/evergreen.c:1419: warning: Function parameter or > member 'async' not described in 'evergreen_

Re: [PATCH 04/30] drm/radeon/si: Remove set but unused variable 'mc_shared_chmap'

On Tue, Nov 10, 2020 at 2:31 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/si.c: In function ‘si_gpu_init’: > drivers/gpu/drm/radeon/si.c:3090:6: warning: variable ‘mc_shared_chmap’ set > but not used [-Wunused-but-set-variable] > > Cc: Alex

Re: [PATCH 03/30] drm/radeon/ni: Demote vague attempt at function header doc

On Tue, Nov 10, 2020 at 2:31 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/ni.c: In function ‘cayman_gpu_init’: > drivers/gpu/drm/radeon/ni.c:2679: warning: Function parameter or member > 'ring' not described in 'cayman_vm_flush' > drivers/

Re: [PATCH 05/30] drm/radeon/cik: Remove set but unused variable 'mc_shared_chmap'

On Tue, Nov 10, 2020 at 2:31 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/cik.c: In function ‘cik_gpu_init’: > drivers/gpu/drm/radeon/cik.c:3180:6: warning: variable ‘mc_shared_chmap’ set > but not used [-Wunused-but-set-variable] > > Cc: A

Re: [PATCH 09/30] drm/radeon/radeon_vm: Fix some function parameter documentation

On Tue, Nov 10, 2020 at 2:31 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_vm.c:131: warning: Function parameter or > member 'rdev' not described in 'radeon_vm_get_bos' > drivers/gpu/drm/radeon/radeon_vm.c:643: warning: Excess functio

Re: [PATCH 07/30] drm/radeon/kv_dpm: Strip out unused functions and their tables

On Tue, Nov 10, 2020 at 2:31 PM Lee Jones wrote: > > These haven't been used since the driver was upstreamed in 2013. > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/kv_dpm.c:161:40: warning: ‘cpl_cac_config_reg’ > defined but not used [-Wunused-const-variable=] >

Re: [PATCH 06/30] drm/radeon/trinity_dpm: Remove some defined but never used arrays

On Tue, Nov 10, 2020 at 2:31 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/trinity_dpm.c:146:18: warning: > ‘trinity_sysls_default’ defined but not used [-Wunused-const-variable=] > drivers/gpu/drm/radeon/trinity_dpm.c:131:18: warning: > ‘t

Re: [PATCH 12/30] drm/radeon/radeon_dp_mst: Remove unused variable 'ret' from radeon_mst_encoder_dpms()

On Tue, Nov 10, 2020 at 2:31 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_dp_mst.c: In function > ‘radeon_mst_encoder_dpms’: > drivers/gpu/drm/radeon/radeon_dp_mst.c:366:6: warning: variable ‘ret’ set > but not used [-Wunused-but-se

Re: [PATCH 10/30] drm/radeon/radeon_sync: Add description for function param 'rdev'

On Tue, Nov 10, 2020 at 2:31 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_sync.c:92: warning: Function parameter or > member 'rdev' not described in 'radeon_sync_resv' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie

Re: [PATCH 11/30] drm/radeon/radeon_ib: Supply description for 'radeon_ib_get's get param

On Tue, Nov 10, 2020 at 2:31 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_ib.c:61: warning: Function parameter or member > 'vm' not described in 'radeon_ib_get' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc:

Re: [PATCH 08/30] drm/radeon/ci_dpm: Remove set but unused variable 'dpm_event_src'

On Tue, Nov 10, 2020 at 2:31 PM Lee Jones wrote: > > And the piece of code that has never been executed. > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/ci_dpm.c: In function ‘ci_set_dpm_event_sources’: > drivers/gpu/drm/radeon/ci_dpm.c:1369:28: warning: variable

  1   2   >