Am 30.10.20 um 08:57 schrieb Deepak R Varma:
On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote:
On Fri, Oct 30, 2020 at 08:52:45AM +0530, Deepak R Varma wrote:
Using DEFINE_DEBUGFS_ATTRIBUTE macro with debugfs_create_file_unsafe()
function in place of the debugfs_create_file() function wi
On Fri, Oct 30, 2020 at 08:52:45AM +0530, Deepak R Varma wrote:
> Using DEFINE_DEBUGFS_ATTRIBUTE macro with debugfs_create_file_unsafe()
> function in place of the debugfs_create_file() function will make the
> file operation struct "reset" aware of the file's lifetime. Additional
> details here: h
On Fri, 30 Oct, 2020, 1:32 PM Greg KH, wrote:
> On Fri, Oct 30, 2020 at 01:27:16PM +0530, Deepak R Varma wrote:
> > On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote:
> > > On Fri, Oct 30, 2020 at 08:52:45AM +0530, Deepak R Varma wrote:
> > > > Using DEFINE_DEBUGFS_ATTRIBUTE macro with
> de
On Fri, Oct 30, 2020 at 01:27:16PM +0530, Deepak R Varma wrote:
> On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote:
> > On Fri, Oct 30, 2020 at 08:52:45AM +0530, Deepak R Varma wrote:
> > > Using DEFINE_DEBUGFS_ATTRIBUTE macro with debugfs_create_file_unsafe()
> > > function in place of the
On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote:
> On Fri, Oct 30, 2020 at 08:52:45AM +0530, Deepak R Varma wrote:
> > Using DEFINE_DEBUGFS_ATTRIBUTE macro with debugfs_create_file_unsafe()
> > function in place of the debugfs_create_file() function will make the
> > file operation struct "
On Fri, Oct 30, 2020 at 09:25:18AM +0100, Greg KH wrote:
> On Fri, Oct 30, 2020 at 09:00:04AM +0100, Christian König wrote:
> > Am 30.10.20 um 08:57 schrieb Deepak R Varma:
> > > On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote:
> > > > On Fri, Oct 30, 2020 at 08:52:45AM +0530, Deepak R Varm
On Fri, Oct 30, 2020 at 10:15:21AM +0100, Daniel Vetter wrote:
> On Fri, Oct 30, 2020 at 09:25:18AM +0100, Greg KH wrote:
> > On Fri, Oct 30, 2020 at 09:00:04AM +0100, Christian König wrote:
> > > Am 30.10.20 um 08:57 schrieb Deepak R Varma:
> > > > On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH
Am 30.10.20 um 09:25 schrieb Greg KH:
On Fri, Oct 30, 2020 at 09:00:04AM +0100, Christian König wrote:
Am 30.10.20 um 08:57 schrieb Deepak R Varma:
On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote:
On Fri, Oct 30, 2020 at 08:52:45AM +0530, Deepak R Varma wrote:
Using DEFINE_DEBUGFS_ATT
With only the kms driver left, we can fold this in. This means
we need to move the ioctl table, which means one additional ioctl
must be defined in headers.
Also there's a conflict between the radeon_init macro and the module
init function, so rename the module functions to avoid that.
Signed-off
Will expand it to other ASICs after verified.
Change-Id: I03e074ea0e921a984eb819b222e434e8e375
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm
Am 30.10.20 um 12:04 schrieb Evan Quan:
Will expand it to other ASICs after verified.
Change-Id: I03e074ea0e921a984eb819b222e434e8e375
Signed-off-by: Evan Quan
Acked-by: Christian König
I assume this fixes my issue on Vega20?
Thanks,
Christian.
---
drivers/gpu/drm/amd/display/amdgp
[AMD Official Use Only - Internal Distribution Only]
Hi Christian,
Just sent out a patch which should be able to address this issue you saw.
https://lists.freedesktop.org/archives/amd-gfx/2020-October/055431.html
BR
Evan
-Original Message-
From: Christian König
Sent: Thursday, October 2
[AMD Official Use Only - Internal Distribution Only]
Yes, it is intended for that.
BR
Evan
-Original Message-
From: Koenig, Christian
Sent: Friday, October 30, 2020 7:06 PM
To: Quan, Evan ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: Re: [PATCH] drm/amdgpu: apply dm_pp
Thanks, going to test it later today.
Christian.
Am 30.10.20 um 12:07 schrieb Quan, Evan:
[AMD Official Use Only - Internal Distribution Only]
Yes, it is intended for that.
BR
Evan
-Original Message-
From: Koenig, Christian
Sent: Friday, October 30, 2020 7:06 PM
To: Quan, Evan ; amd-
From: "Tianci.Yin"
The crash caused by the NULL pointer of
adev->ddev.mode_config.funcs in drm_kms_helper_hotplug_event(),
but this function should not be called on headless SKU.
Fix the mismatch between the return value of
amdgpu_device_has_dc_support() and the real DCN supporting
state to avoi
Toggle on/off gfxoff during video playback to fix
gpu hang.
Signed-off-by: Jiansong Chen
Change-Id: I5b938c446884268c2cda0801121a53da980e603a
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdg
[AMD Public Use]
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Jiansong Chen
Sent: Friday, October 30, 2020 19:37
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Zhu, James ;
Liu, Leo ; Zhou1, Tao ; Chen, Jiansong
(Simon)
Subject: [PATCH] drm/amdgpu: di
[AMD Public Use]
I'm not sure I get your point on changing amdgpu_device_has_dc_support()
interface by adding new parameter. but it seems to me change input parameter
from pdev to adev for nv_is_headless_sku is more straightforward.
Regards,
Hawking
-Original Message-
From: Tianci Yin
[AMD Public Use]
Hi Hawking,
amdgpu_device_asic_has_dc_support() is referrenced by amdgpu_pci_probe(),
at that point, adev has not been allocated yet.
My change can make it to right code path.
int amdgpu_device_resume(struct drm_device *dev, bool fbcon)
{
...
if (!amdgpu_device_has_dc_support(ad
[AMD Public Use]
[AMD Public Use]
I see. Thanks for the clarifying, Tianci.
In such case, how about we add a new flag AMD_IS_HEADLESS to amd_chip_flags, so
we can identify headless asic at the beginning when we add a new item to
pciidlist.
Regards,
Hawking
From: Yin, Tianci (Rico)
Sent: Fri
Zhang, Hawking would like to recall the message, "[PATCH] drm/amdgpu: fix NULL
pointer crash on navi10 headless SKU".
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by: Huang Rui
-Original Message-
From: Su, Jinzhou (Joe)
Sent: Friday, October 30, 2020 2:55 PM
To: amd-gfx@lists.freedesktop.org
Cc: Huang, Ray ; Su, Jinzhou (Joe)
Subject: [PATCH] amdgpu: Add mmhub MGCG and MGLS for vangogh
Add AMD_CG_SUPPORT_MC_MGCG and AMD_CG_SUPPORT_MC_L
[AMD Public Use]
[AMD Public Use]
I see, thanks for the clarifying. The patch is
Reviewed-by: Hawking Zhang
I was thinking to have a new flag like AMD_IS_HEADLESS in amd_chip_flag, but
after think it a bit more, that's just complicated the case, I agree with your
current approach.
Regards,
Hi Jiansong
Pls check inline.
thanks!
James
On 2020-10-30 7:37 a.m., Jiansong Chen wrote:
Toggle on/off gfxoff during video playback to fix
gpu hang.
[JZ] It is a workaround, not a fix. Also Arcturus needn't this WA.
Signed-off-by: Jiansong Chen
Change-Id: I5b938c446884268c2cda0801121a53da
[AMD Public Use]
Maybe it would be easier to check if the DCE IP exists? E.g.,
if (!amdgpu_device_ip_get_ip_block(adev, AMD_IP_BLOCK_TYPE_DCE) ||
(!amdgpu_device_has_dc_support(adev))
...
Also do we even need to skip DCN init for these cards, or will the display code
handle it automatically sinc
On Fri, 30 Oct 2020, Greg KH wrote:
> On Fri, Oct 30, 2020 at 01:47:05PM +0530, Sumera Priyadarsini wrote:
> > On Fri, 30 Oct, 2020, 1:32 PM Greg KH, wrote:
> >
> > > On Fri, Oct 30, 2020 at 01:27:16PM +0530, Deepak R Varma wrote:
> > > > On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote
On Fri, Oct 30, 2020 at 01:47:05PM +0530, Sumera Priyadarsini wrote:
> On Fri, 30 Oct, 2020, 1:32 PM Greg KH, wrote:
>
> > On Fri, Oct 30, 2020 at 01:27:16PM +0530, Deepak R Varma wrote:
> > > On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote:
> > > > On Fri, Oct 30, 2020 at 08:52:45AM +053
On Fri, Oct 30, 2020 at 10:24:57AM +0100, Daniel Vetter wrote:
> On Fri, Oct 30, 2020 at 10:15:21AM +0100, Daniel Vetter wrote:
> > On Fri, Oct 30, 2020 at 09:25:18AM +0100, Greg KH wrote:
> > > On Fri, Oct 30, 2020 at 09:00:04AM +0100, Christian König wrote:
> > > > Am 30.10.20 um 08:57 schrieb De
On Fri, Oct 30, 2020 at 09:00:04AM +0100, Christian König wrote:
> Am 30.10.20 um 08:57 schrieb Deepak R Varma:
> > On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote:
> > > On Fri, Oct 30, 2020 at 08:52:45AM +0530, Deepak R Varma wrote:
> > > > Using DEFINE_DEBUGFS_ATTRIBUTE macro with debugf
Toggle on/off gfxoff during video playback to fix gpu hang.
v2: change sequence to be more compatible with original code.
Signed-off-by: Jiansong Chen
Change-Id: I5b938c446884268c2cda0801121a53da980e603a
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 5 -
1 file changed, 4 insertions(+), 1 d
[AMD Official Use Only - Internal Distribution Only]
Hi James,
Thanks for your input, v2 patch is sent out.
Regards,
Jiansong
-Original Message-
From: Zhu, James
Sent: Friday, October 30, 2020 9:06 PM
To: Chen, Jiansong (Simon) ;
amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Zhu, J
[AMD Official Use Only - Internal Distribution Only]
Please ignore the change.
-Original Message-
From: Jiansong Chen
Sent: Friday, October 30, 2020 10:57 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Zhu, James ;
Liu, Leo ; Zhou1, Tao ; Chen, Jiansong
(Simon)
Subject: [PA
Toggle on/off gfxoff during video playback to fix gpu hang.
v2: change sequence to be more compatible with original code.
Signed-off-by: Jiansong Chen
Change-Id: I5b938c446884268c2cda0801121a53da980e603a
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 5 -
1 file changed, 4 insertions(+), 1 d
[AMD Official Use Only - Internal Distribution Only]
This patch is Reviewed-by: James Zhu
From: Jiansong Chen
Sent: Friday, October 30, 2020 11:05 AM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Zhu, James ;
Liu, Leo ; Zhou1, Tao ; Chen, Jiansong
(Si
Thanks, Bryan, for your report. It was indeed an issue with the merge.
The fix will be in next week's set of DC patches.
Harry
On 2020-10-28 1:39 p.m., Bryan Angelo wrote:
While looking at the following commit, I noticed what might be an
arithmetic issue potentially stemming from some merge/
Tested-by: Christian König
That indeed fixes the issue.
Thanks,
Christian.
Am 30.10.20 um 12:11 schrieb Christian König:
Thanks, going to test it later today.
Christian.
Am 30.10.20 um 12:07 schrieb Quan, Evan:
[AMD Official Use Only - Internal Distribution Only]
Yes, it is intended for t
Applied. Thanks for all of your hard work on this!
Alex
On Wed, Oct 28, 2020 at 7:52 PM Bas Nieuwenhuizen
wrote:
>
> This adds modifier support to the amdgpu kernel drivers for GFX9 and
> later GPUs. It has been tested on
>
> - VEGA10, RAVEN, NAVI14
> - weston, sway, X with xf86-video-amdgpu (i
On 2020-10-29 11:53 p.m., Alex Deucher wrote:
On Mon, Oct 26, 2020 at 5:01 PM Arnd Bergmann wrote:
From: Arnd Bergmann
gcc -Wextra warns about a function taking an enum argument
being called with a bool:
drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c: In function
'app
From: Veerabadhran Gopalakrishnan
Concurrent operation of VCN and JPEG decoder in DPG mode is
causing ring timeout due to power state.
Signed-off-by: Veerabadhran Gopalakrishnan
---
drivers/gpu/drm/amd/amdgpu/soc15.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers
Reviewed-by: Leo Liu
On 2020-10-30 1:10 p.m., veerabadhran.gopalakrish...@amd.com wrote:
From: Veerabadhran Gopalakrishnan
Concurrent operation of VCN and JPEG decoder in DPG mode is
causing ring timeout due to power state.
Signed-off-by: Veerabadhran Gopalakrishnan
---
drivers/gpu/drm/am
Applied. Thanks!
Alex
On Fri, Oct 30, 2020 at 1:04 PM Harry Wentland wrote:
>
>
>
> On 2020-10-29 11:53 p.m., Alex Deucher wrote:
> > On Mon, Oct 26, 2020 at 5:01 PM Arnd Bergmann wrote:
> >>
> >> From: Arnd Bergmann
> >>
> >> gcc -Wextra warns about a function taking an enum argument
> >> be
On Fri, Oct 30, 2020 at 6:11 AM Daniel Vetter wrote:
>
> With only the kms driver left, we can fold this in. This means
> we need to move the ioctl table, which means one additional ioctl
> must be defined in headers.
>
> Also there's a conflict between the radeon_init macro and the module
> init
On 2020-10-30 2:55 a.m., Pratik Vishwakarma wrote:
[Why]
Incorrect values were resulting in flash lines
when MPO was enabled and system was left idle.
[How]
Increase min clk values only when MPO is enabled
and display is active to not affect S3 power.
Signed-off-by: Pratik Vishwakarma
Reviewed
[Why]
Vega20 and Arcturus asics use oss 5.0 version.
[How]
Replace ih ip block by navi10 for vega20 and arcturus.
Signed-off-by: Alex Sierra
---
drivers/gpu/drm/amd/amdgpu/soc15.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc
44 matches
Mail list logo
