[PATCH] drm/amdgpu: disable gfxoff temporarily for navy_flounder

2020-09-30 Thread Jiansong Chen
gfxoff is temporarily disabled for navy_flounder, since at present the feature caused some tdr when performing display operation. Signed-off-by: Jiansong Chen Change-Id: Ib2be4041f82a3f5e12c657541c516815c8eb3670 --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 3 +++ 1 file changed, 3 insertions(+)

RE: [PATCH] drm/amdgpu: disable gfxoff temporarily for navy_flounder

2020-09-30 Thread Zhou1, Tao
[AMD Public Use] Reviewed-by: Tao Zhou > -Original Message- > From: Jiansong Chen > Sent: Wednesday, September 30, 2020 3:37 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhou1, Tao ; Zhang, Hawking > ; Chen, Jiansong (Simon) > > Subject: [PATCH] drm/amdgpu: disable gfxoff temporarily f

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-09-30 Thread Christian König
Am 29.09.20 um 19:49 schrieb Thomas Zimmermann: Hi Christian Am 29.09.20 um 17:35 schrieb Christian König: Am 29.09.20 um 17:14 schrieb Thomas Zimmermann: The new helper ttm_kmap_obj_to_dma_buf() extracts address and location from and instance of TTM's kmap_obj and initializes struct dma_buf_m

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-09-30 Thread Thomas Zimmermann
Hi Am 30.09.20 um 10:05 schrieb Christian König: > Am 29.09.20 um 19:49 schrieb Thomas Zimmermann: >> Hi Christian >> >> Am 29.09.20 um 17:35 schrieb Christian König: >>> Am 29.09.20 um 17:14 schrieb Thomas Zimmermann: The new helper ttm_kmap_obj_to_dma_buf() extracts address and location >>>

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-09-30 Thread Christian König
Am 30.09.20 um 10:19 schrieb Thomas Zimmermann: Hi Am 30.09.20 um 10:05 schrieb Christian König: Am 29.09.20 um 19:49 schrieb Thomas Zimmermann: Hi Christian Am 29.09.20 um 17:35 schrieb Christian König: Am 29.09.20 um 17:14 schrieb Thomas Zimmermann: The new helper ttm_kmap_obj_to_dma_buf(

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-09-30 Thread Daniel Vetter
On Wed, Sep 30, 2020 at 10:34:31AM +0200, Christian König wrote: > Am 30.09.20 um 10:19 schrieb Thomas Zimmermann: > > Hi > > > > Am 30.09.20 um 10:05 schrieb Christian König: > > > Am 29.09.20 um 19:49 schrieb Thomas Zimmermann: > > > > Hi Christian > > > > > > > > Am 29.09.20 um 17:35 schrieb C

Re: [PATCH] drm/amd/pm: setup APU dpm clock table in SMU HW initialization

2020-09-30 Thread Nirmoy
Acked-by: Nirmoy Das On 9/30/20 6:07 AM, Evan Quan wrote: As the dpm clock table is needed during DC HW initialization. And that (DC HW initialization) comes before smu_late_init() where current APU dpm clock table setup is performed. So, NULL pointer dereference will be triggered. By moving AP

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-09-30 Thread Christian König
Am 30.09.20 um 11:47 schrieb Daniel Vetter: On Wed, Sep 30, 2020 at 10:34:31AM +0200, Christian König wrote: Am 30.09.20 um 10:19 schrieb Thomas Zimmermann: Hi Am 30.09.20 um 10:05 schrieb Christian König: Am 29.09.20 um 19:49 schrieb Thomas Zimmermann: Hi Christian Am 29.09.20 um 17:35 sch

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-09-30 Thread Daniel Vetter
On Wed, Sep 30, 2020 at 2:34 PM Christian König wrote: > > Am 30.09.20 um 11:47 schrieb Daniel Vetter: > > On Wed, Sep 30, 2020 at 10:34:31AM +0200, Christian König wrote: > >> Am 30.09.20 um 10:19 schrieb Thomas Zimmermann: > >>> Hi > >>> > >>> Am 30.09.20 um 10:05 schrieb Christian König: >

Re: [PATCH] drm/amd/pm: setup APU dpm clock table in SMU HW initialization

2020-09-30 Thread Dirk Gouders
Evan Quan writes: > As the dpm clock table is needed during DC HW initialization. > And that (DC HW initialization) comes before smu_late_init() > where current APU dpm clock table setup is performed. So, NULL > pointer dereference will be triggered. By moving APU dpm clock > table setup to smu_h

Re: [PATCH] drm/amd/pm: setup APU dpm clock table in SMU HW initialization

2020-09-30 Thread Alex Deucher
On Wed, Sep 30, 2020 at 12:08 AM Evan Quan wrote: > > As the dpm clock table is needed during DC HW initialization. > And that (DC HW initialization) comes before smu_late_init() > where current APU dpm clock table setup is performed. So, NULL > pointer dereference will be triggered. By moving APU

[PATCH] drm/amdgpu: fix build error

2020-09-30 Thread Guchun Chen
Regression by patch: fd583c4f01a7 drm/amdgpu: drop duplicated ecc check for vega10 (v4) CC [M] drivers/gpu/drm/amd/amdgpu/gfxhub_v2_1.o drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c: In function ‘gmc_v9_0_late_init’: drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:1216:59: error: expected ‘)’ before ‘{’ token 12

RE: [PATCH] drm/amdgpu: fix build error

2020-09-30 Thread Zhang, Hawking
[AMD Public Use] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Guchun Chen Sent: Wednesday, September 30, 2020 21:59 To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; StDenis, Tom Cc: Chen, Guchun Subject: [PATCH] drm/amdgpu: fix buil

RE: [PATCH 3/4] drm/amd/amdgpu: Define and implement a function that collects number of waves that are in flight.

2020-09-30 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Minor typo. See below. With that fixed this patch is Reviewed-By: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Ramesh Errabolu Sent: Tuesday, September 29, 2020 1:26 PM To: amd-gfx@lists.freedesktop.org Cc: Er

[pull] amdgpu drm-fixes-5.9

2020-09-30 Thread Alex Deucher
Hi Dave, Daniel, A bit bigger than usual since I missed last week. Mostly updates for new asics and a few of misc bug fixes. The following changes since commit 1f08fde70075784d28d1687d0e75871e81cc1173: Merge tag 'mediatek-drm-fixes-5.9' of https://git.kernel.org/pub/scm/linux/kernel/git/chun

RE: [PATCH 4/4] drm/amd/amdkfd: Surface files in Sysfs to allow users to get number of compute units that are in use.

2020-09-30 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Reviewed-By: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Ramesh Errabolu Sent: Tuesday, September 29, 2020 1:27 PM To: amd-gfx@lists.freedesktop.org Cc: Errabolu, Ramesh Subject: [PATCH 4/4] drm/amd/amdkfd:

Re: [PATCH] drm/amdgpu: fix perms of gfx_v10_0.c

2020-09-30 Thread Alex Deucher
Reviewed-by: Alex Deucher On Mon, Sep 28, 2020 at 4:18 PM Luben Tuikov wrote: > > Fix perms: a+x --> a-x. > > Signed-off-by: Luben Tuikov > --- > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > mode change 100755 => 100644 drivers/gpu/drm/amd/am

[pull] amdgpu, amdkfd, radeon drm-next-5.10

2020-09-30 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.10. The following changes since commit 911d5bd5e7b8531b39301c2c27e5b90d7bd71b88: drm/amd/pm: Skip smu_post_init in SRIOV (2020-09-18 16:14:56 -0400) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux tags/amd-drm-next-5.10-2020-09

BUG: amdgpu: NULL pointer dereference introduced in 5.9-rc1

2020-09-30 Thread Dirk Gouders
Commit c1cf79ca5ced46 (drm/amdgpu: use IP discovery table for renoir) introduced a NULL pointer dereference when booting with amdgpu.discovery=0. For amdgpu.discovery=0 that commit effectively removed the call of vega10_reg_base_init(adev), so I tested the correctness of the bisect session by rest

[PATCH RFC 0/1] drm/ttm: Allocate transparent huge pages without clearing __GFP_COMP

2020-09-30 Thread Alex Goins
Hi Christian, I've been looking into the DMA-BUFs exported from AMDGPU / TTM. Would you mind giving some input on this? I noticed that your changes implementing transparent huge page support in TTM are allocating them as non-compound. I understand that using multiorder non-compound pages is commo

[PATCH RFC 1/1] drm-ttm: Allocate transparent huge pages without clearing __GFP_COMP

2020-09-30 Thread Alex Goins
TTM currently supports allocating pages with GFP_TRANSHUGE_LIGHT, but with the __GFP_COMP flag cleared. Instead of being normal transparent huge pages, these are multiorder non-compound pages that have the same order as THPs. This interferes with drivers that import DMA-BUFs / SGTs backed by pages

[PATCH] drm/amdgpu/swsmu: clean up a bunch of stale interfaces

2020-09-30 Thread Alex Deucher
These were leftover from the initial implementation, but never used. Drop them. Noticed-by: Ryan Taylor Signed-off-by: Alex Deucher --- .../amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 23 -- drivers/gpu/drm/amd/pm/amdgpu_pm.c| 8 +- drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h