[PATCH] drm/amd/pm: set VCN pg per instances

2020-08-21 Thread Jiansong Chen
When deciding whether to set pg for vcn1, instances number is more generic than chip name. Signed-off-by: Jiansong Chen Change-Id: I5bf3f024ac499c347e3ea72563ae75e4a540f321 --- drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

RE: [PATCH] drm/amd/pm: set VCN pg per instances

2020-08-21 Thread Zhou1, Tao
[AMD Public Use] Reviewed-by: Tao Zhou > -Original Message- > From: Jiansong Chen > Sent: Friday, August 21, 2020 4:36 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhou1, Tao ; Lazar, Lijo ; > Chen, Jiansong (Simon) > Subject: [PATCH] drm/amd/pm: set VCN pg per instances > > When deci

[PATCH] drm/amdgpu: skip scheduling IBs when GPU recovery

2020-08-21 Thread Dennis Li
If GPU begin to do recovery, skip scheduling IBs. Otherwise GPU recovery randomly fail. Signed-off-by: Dennis Li diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c index dcfe8a3b03ff..054d7b0357fd 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c +

Re: [PATCH] drm/amdgpu: skip scheduling IBs when GPU recovery

2020-08-21 Thread Christian König
Am 21.08.20 um 10:57 schrieb Dennis Li: If GPU begin to do recovery, skip scheduling IBs. Otherwise GPU recovery randomly fail. NAK, this is prevented by stopping the scheduler during GPU recovery. If you see jobs submitted to the hardware while we recover the GPU then the scheduler is re-sta

[PATCH v5] drm/amdkfd: implement the dGPU fallback path for apu (v5)

2020-08-21 Thread Huang Rui
We still have a few iommu issues which need to address, so force raven as "dgpu" path for the moment. This is to add the fallback path to bypass IOMMU if IOMMU v2 is disabled or ACPI CRAT table not correct. v2: Use ignore_crat parameter to decide whether it will go with IOMMUv2. v3: Align with ex

Re: [PATCH 1/3] drm/amd/pm: correct Vega10 swctf limit setting

2020-08-21 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Might want to add: Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1267 with that, the series is: Reviewed-by: Alex Deucher From: Quan, Evan Sent: Friday, August 21, 2020 12:42 AM To: amd-gfx@lists.freedes

Re: Fix a memory leak bug for umr tool.

2020-08-21 Thread Tom St Denis
Sorry I missed this. I've applied it (with whitespace fixes) and pushed it out to main yesterday. Cheers, Tom On Thu, Aug 13, 2020 at 10:57 PM 张二东 wrote: > Hi: >The function umr_pm4_decode_ring_is_halted call umr_read_ring_data > > to get ringdata, umr_read_ring_data will alloc mem

[PATCH] drm/amd/powerplay: Fix hardmins not being sent to SMU for RV

2020-08-21 Thread Nicholas Kazlauskas
[Why] DC uses these to raise the voltage as needed for higher dispclk/dppclk and to ensure that we have enough bandwidth to drive the displays. There's a bug preventing these from actuially sending messages since it's checking the actual clock (which is 0) instead of the incoming clock (which shou

Re: [PATCH] drm/amd/powerplay: Fix hardmins not being sent to SMU for RV

2020-08-21 Thread Alex Deucher
On Fri, Aug 21, 2020 at 11:31 AM Nicholas Kazlauskas wrote: > > [Why] > DC uses these to raise the voltage as needed for higher dispclk/dppclk > and to ensure that we have enough bandwidth to drive the displays. > > There's a bug preventing these from actuially sending messages since > it's checki

[PATCH AUTOSEL 5.8 05/62] drm/amdgpu: fix RAS memory leak in error case

2020-08-21 Thread Sasha Levin
From: Guchun Chen [ Upstream commit 5e91160ac0b5cfbbaeb62cbff8b069262095f744 ] RAS context memory needs to freed in failure case. Signed-off-by: Guchun Chen Reviewed-by: Tao Zhou Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 19 +++

[PATCH AUTOSEL 5.8 21/62] drm/amdkfd: Fix reference count leaks.

2020-08-21 Thread Sasha Levin
From: Qiushi Wu [ Upstream commit 20eca0123a35305e38b344d571cf32768854168c ] kobject_init_and_add() takes reference even when it fails. If this function returns an error, kobject_put() must be called to properly clean up the memory associated with the object. Signed-off-by: Qiushi Wu Reviewed-

[PATCH AUTOSEL 5.8 22/62] drm/radeon: fix multiple reference count leak

2020-08-21 Thread Sasha Levin
From: Aditya Pakki [ Upstream commit 6f2e8acdb48ed166b65d47837c31b177460491ec ] On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki Signed-off-by: Alex Deuch

[PATCH AUTOSEL 5.8 24/62] drm/amd/display: fix ref count leak in amdgpu_drm_ioctl

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit 5509ac65f2fe5aa3c0003237ec629ca55024307c ] in amdgpu_drm_ioctl the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Nav

[PATCH AUTOSEL 5.8 23/62] drm/amdgpu: fix ref count leak in amdgpu_driver_open_kms

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit 9ba8923cbbe11564dd1bf9f3602add9a9cfbb5c6 ] in amdgpu_driver_open_kms the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-b

[PATCH AUTOSEL 5.8 25/62] drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit e008fa6fb41544b63973a529b704ef342f47cc65 ] in amdgpu_display_crtc_set_config, the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Sig

[PATCH AUTOSEL 5.8 28/62] drm/amdkfd: fix ref count leak when pm_runtime_get_sync fails

2020-08-21 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 1c1ada37af6ee6fb9cfc8da6a56cc83208cd8d6f ] The call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Reviewed-by: Rajneesh Bhardwaj Signed-of

[PATCH AUTOSEL 5.8 27/62] drm/amdgpu/fence: fix ref count leak when pm_runtime_get_sync fails

2020-08-21 Thread Sasha Levin
From: Alex Deucher [ Upstream commit e520d3e0d2818aafcdf9d8b60916754d8fedc366 ] The call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Reviewed-by: Felix Kuehling Acked-by: Ra

[PATCH AUTOSEL 5.8 26/62] drm/amdgpu/display: fix ref count leak when pm_runtime_get_sync fails

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit f79f94765f8c39db0b7dec1d335ab046aac03f20 ] The call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost Signed

[PATCH AUTOSEL 5.8 29/62] drm/amdgpu/pm: fix ref count leak when pm_runtime_get_sync fails

2020-08-21 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 66429300e1bd9cdfbe96cfc475e4964db2a36921 ] The call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Reviewed-by: Evan Quan Signed-off-by: Al

[PATCH AUTOSEL 5.7 05/61] drm/amdgpu: fix RAS memory leak in error case

2020-08-21 Thread Sasha Levin
From: Guchun Chen [ Upstream commit 5e91160ac0b5cfbbaeb62cbff8b069262095f744 ] RAS context memory needs to freed in failure case. Signed-off-by: Guchun Chen Reviewed-by: Tao Zhou Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 19 +++

[PATCH AUTOSEL 5.7 27/61] drm/amdgpu/fence: fix ref count leak when pm_runtime_get_sync fails

2020-08-21 Thread Sasha Levin
From: Alex Deucher [ Upstream commit e520d3e0d2818aafcdf9d8b60916754d8fedc366 ] The call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Reviewed-by: Felix Kuehling Acked-by: Ra

[PATCH AUTOSEL 5.7 22/61] drm/radeon: fix multiple reference count leak

2020-08-21 Thread Sasha Levin
From: Aditya Pakki [ Upstream commit 6f2e8acdb48ed166b65d47837c31b177460491ec ] On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki Signed-off-by: Alex Deuch

[PATCH AUTOSEL 5.7 21/61] drm/amdkfd: Fix reference count leaks.

2020-08-21 Thread Sasha Levin
From: Qiushi Wu [ Upstream commit 20eca0123a35305e38b344d571cf32768854168c ] kobject_init_and_add() takes reference even when it fails. If this function returns an error, kobject_put() must be called to properly clean up the memory associated with the object. Signed-off-by: Qiushi Wu Reviewed-

[PATCH AUTOSEL 5.7 23/61] drm/amdgpu: fix ref count leak in amdgpu_driver_open_kms

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit 9ba8923cbbe11564dd1bf9f3602add9a9cfbb5c6 ] in amdgpu_driver_open_kms the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-b

[PATCH AUTOSEL 5.7 24/61] drm/amd/display: fix ref count leak in amdgpu_drm_ioctl

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit 5509ac65f2fe5aa3c0003237ec629ca55024307c ] in amdgpu_drm_ioctl the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Nav

[PATCH AUTOSEL 5.7 25/61] drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit e008fa6fb41544b63973a529b704ef342f47cc65 ] in amdgpu_display_crtc_set_config, the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Sig

[PATCH AUTOSEL 5.7 29/61] drm/amdgpu/pm: fix ref count leak when pm_runtime_get_sync fails

2020-08-21 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 66429300e1bd9cdfbe96cfc475e4964db2a36921 ] The call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Reviewed-by: Evan Quan Signed-off-by: Al

[PATCH AUTOSEL 5.7 28/61] drm/amdkfd: fix ref count leak when pm_runtime_get_sync fails

2020-08-21 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 1c1ada37af6ee6fb9cfc8da6a56cc83208cd8d6f ] The call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Reviewed-by: Rajneesh Bhardwaj Signed-of

[PATCH AUTOSEL 5.7 26/61] drm/amdgpu/display: fix ref count leak when pm_runtime_get_sync fails

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit f79f94765f8c39db0b7dec1d335ab046aac03f20 ] The call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost Signed

[PATCH AUTOSEL 5.4 19/48] drm/amd/display: fix ref count leak in amdgpu_drm_ioctl

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit 5509ac65f2fe5aa3c0003237ec629ca55024307c ] in amdgpu_drm_ioctl the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Nav

[PATCH AUTOSEL 5.4 21/48] drm/amdgpu/display: fix ref count leak when pm_runtime_get_sync fails

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit f79f94765f8c39db0b7dec1d335ab046aac03f20 ] The call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost Signed

[PATCH AUTOSEL 5.4 18/48] drm/amdgpu: fix ref count leak in amdgpu_driver_open_kms

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit 9ba8923cbbe11564dd1bf9f3602add9a9cfbb5c6 ] in amdgpu_driver_open_kms the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-b

[PATCH AUTOSEL 5.4 16/48] drm/amdkfd: Fix reference count leaks.

2020-08-21 Thread Sasha Levin
From: Qiushi Wu [ Upstream commit 20eca0123a35305e38b344d571cf32768854168c ] kobject_init_and_add() takes reference even when it fails. If this function returns an error, kobject_put() must be called to properly clean up the memory associated with the object. Signed-off-by: Qiushi Wu Reviewed-

[PATCH AUTOSEL 5.4 17/48] drm/radeon: fix multiple reference count leak

2020-08-21 Thread Sasha Levin
From: Aditya Pakki [ Upstream commit 6f2e8acdb48ed166b65d47837c31b177460491ec ] On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki Signed-off-by: Alex Deuch

[PATCH AUTOSEL 5.4 20/48] drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit e008fa6fb41544b63973a529b704ef342f47cc65 ] in amdgpu_display_crtc_set_config, the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Sig

[PATCH AUTOSEL 4.19 15/38] drm/amd/display: fix ref count leak in amdgpu_drm_ioctl

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit 5509ac65f2fe5aa3c0003237ec629ca55024307c ] in amdgpu_drm_ioctl the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Nav

[PATCH AUTOSEL 4.19 14/38] drm/amdgpu: fix ref count leak in amdgpu_driver_open_kms

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit 9ba8923cbbe11564dd1bf9f3602add9a9cfbb5c6 ] in amdgpu_driver_open_kms the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-b

[PATCH AUTOSEL 4.19 12/38] drm/amdkfd: Fix reference count leaks.

2020-08-21 Thread Sasha Levin
From: Qiushi Wu [ Upstream commit 20eca0123a35305e38b344d571cf32768854168c ] kobject_init_and_add() takes reference even when it fails. If this function returns an error, kobject_put() must be called to properly clean up the memory associated with the object. Signed-off-by: Qiushi Wu Reviewed-

[PATCH AUTOSEL 4.19 13/38] drm/radeon: fix multiple reference count leak

2020-08-21 Thread Sasha Levin
From: Aditya Pakki [ Upstream commit 6f2e8acdb48ed166b65d47837c31b177460491ec ] On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki Signed-off-by: Alex Deuch

[PATCH AUTOSEL 4.19 17/38] drm/amdgpu/display: fix ref count leak when pm_runtime_get_sync fails

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit f79f94765f8c39db0b7dec1d335ab046aac03f20 ] The call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost Signed

[PATCH AUTOSEL 4.19 16/38] drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit e008fa6fb41544b63973a529b704ef342f47cc65 ] in amdgpu_display_crtc_set_config, the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Sig

[PATCH AUTOSEL 4.14 13/30] drm/amd/display: fix ref count leak in amdgpu_drm_ioctl

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit 5509ac65f2fe5aa3c0003237ec629ca55024307c ] in amdgpu_drm_ioctl the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Nav

[PATCH AUTOSEL 4.14 11/30] drm/radeon: fix multiple reference count leak

2020-08-21 Thread Sasha Levin
From: Aditya Pakki [ Upstream commit 6f2e8acdb48ed166b65d47837c31b177460491ec ] On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki Signed-off-by: Alex Deuch

[PATCH AUTOSEL 4.14 15/30] drm/amdgpu/display: fix ref count leak when pm_runtime_get_sync fails

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit f79f94765f8c39db0b7dec1d335ab046aac03f20 ] The call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost Signed

[PATCH AUTOSEL 4.14 10/30] drm/amdkfd: Fix reference count leaks.

2020-08-21 Thread Sasha Levin
From: Qiushi Wu [ Upstream commit 20eca0123a35305e38b344d571cf32768854168c ] kobject_init_and_add() takes reference even when it fails. If this function returns an error, kobject_put() must be called to properly clean up the memory associated with the object. Signed-off-by: Qiushi Wu Reviewed-

[PATCH AUTOSEL 4.14 12/30] drm/amdgpu: fix ref count leak in amdgpu_driver_open_kms

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit 9ba8923cbbe11564dd1bf9f3602add9a9cfbb5c6 ] in amdgpu_driver_open_kms the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-b

[PATCH AUTOSEL 4.9 09/26] drm/amdgpu: fix ref count leak in amdgpu_driver_open_kms

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit 9ba8923cbbe11564dd1bf9f3602add9a9cfbb5c6 ] in amdgpu_driver_open_kms the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-b

[PATCH AUTOSEL 4.14 14/30] drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit e008fa6fb41544b63973a529b704ef342f47cc65 ] in amdgpu_display_crtc_set_config, the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Sig

[PATCH AUTOSEL 4.4 09/22] drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit e008fa6fb41544b63973a529b704ef342f47cc65 ] in amdgpu_display_crtc_set_config, the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Sig

[PATCH AUTOSEL 4.4 10/22] drm/amdgpu/display: fix ref count leak when pm_runtime_get_sync fails

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit f79f94765f8c39db0b7dec1d335ab046aac03f20 ] The call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost Signed

[PATCH AUTOSEL 4.9 10/26] drm/amd/display: fix ref count leak in amdgpu_drm_ioctl

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit 5509ac65f2fe5aa3c0003237ec629ca55024307c ] in amdgpu_drm_ioctl the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Nav

[PATCH AUTOSEL 4.9 07/26] drm/amdkfd: Fix reference count leaks.

2020-08-21 Thread Sasha Levin
From: Qiushi Wu [ Upstream commit 20eca0123a35305e38b344d571cf32768854168c ] kobject_init_and_add() takes reference even when it fails. If this function returns an error, kobject_put() must be called to properly clean up the memory associated with the object. Signed-off-by: Qiushi Wu Reviewed-

[PATCH AUTOSEL 4.4 05/22] drm/amdkfd: Fix reference count leaks.

2020-08-21 Thread Sasha Levin
From: Qiushi Wu [ Upstream commit 20eca0123a35305e38b344d571cf32768854168c ] kobject_init_and_add() takes reference even when it fails. If this function returns an error, kobject_put() must be called to properly clean up the memory associated with the object. Signed-off-by: Qiushi Wu Reviewed-

[PATCH AUTOSEL 4.9 08/26] drm/radeon: fix multiple reference count leak

2020-08-21 Thread Sasha Levin
From: Aditya Pakki [ Upstream commit 6f2e8acdb48ed166b65d47837c31b177460491ec ] On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki Signed-off-by: Alex Deuch

[PATCH AUTOSEL 4.9 12/26] drm/amdgpu/display: fix ref count leak when pm_runtime_get_sync fails

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit f79f94765f8c39db0b7dec1d335ab046aac03f20 ] The call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost Signed

[PATCH AUTOSEL 4.4 08/22] drm/amd/display: fix ref count leak in amdgpu_drm_ioctl

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit 5509ac65f2fe5aa3c0003237ec629ca55024307c ] in amdgpu_drm_ioctl the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Nav

[PATCH AUTOSEL 4.4 07/22] drm/amdgpu: fix ref count leak in amdgpu_driver_open_kms

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit 9ba8923cbbe11564dd1bf9f3602add9a9cfbb5c6 ] in amdgpu_driver_open_kms the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-b

[PATCH AUTOSEL 4.4 06/22] drm/radeon: fix multiple reference count leak

2020-08-21 Thread Sasha Levin
From: Aditya Pakki [ Upstream commit 6f2e8acdb48ed166b65d47837c31b177460491ec ] On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki Signed-off-by: Alex Deuch

[PATCH AUTOSEL 4.9 11/26] drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config

2020-08-21 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit e008fa6fb41544b63973a529b704ef342f47cc65 ] in amdgpu_display_crtc_set_config, the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Sig

Re: [PATCH v5] drm/amdkfd: implement the dGPU fallback path for apu (v5)

2020-08-21 Thread Felix Kuehling
Am 2020-08-21 um 8:50 a.m. schrieb Huang Rui: > We still have a few iommu issues which need to address, so force raven > as "dgpu" path for the moment. > > This is to add the fallback path to bypass IOMMU if IOMMU v2 is disabled > or ACPI CRAT table not correct. > > v2: Use ignore_crat parameter t

[PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-08-21 Thread Michel Dänzer
From: Michel Dänzer Don't check drm_crtc_state::active for this either, per its documentation in include/drm/drm_crtc.h: * Hence drivers must not consult @active in their various * &drm_mode_config_funcs.atomic_check callback to reject an atomic * commit. The atomic helpers disable the CRTC

Re: [PATCH 3/3] drm/amdgpu: Embed drm_device into amdgpu_device (v2)

2020-08-21 Thread Alex Deucher
On Wed, Aug 19, 2020 at 1:01 AM Luben Tuikov wrote: > > a) Embed struct drm_device into struct amdgpu_device. > b) Modify the inline-f drm_to_adev() accordingly. > c) Modify the inline-f adev_to_drm() accordingly. > d) Eliminate the use of drm_device.dev_private, >in amdgpu. > e) Switch from u

Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-08-21 Thread Kazlauskas, Nicholas
On 2020-08-21 12:57 p.m., Michel Dänzer wrote: From: Michel Dänzer Don't check drm_crtc_state::active for this either, per its documentation in include/drm/drm_crtc.h: * Hence drivers must not consult @active in their various * &drm_mode_config_funcs.atomic_check callback to reject an atom

[PATCH 0/9] DC Patches August 24, 2020

2020-08-21 Thread Eryk Brol
This DC patchset brings improvements in multiple areas. In summary, we highlight: * Fixes on HDMI, HDCP, and EDID Emulation; * Enhancements in DMUB; * Improvements on ABM, DSC and others. Aric Cyr (1): drm/amd/display: 3.2.99 Brandon Syu (1): drm/amd/display: Keep current gain when ABM disa

[PATCH 9/9] drm/amd/display: Keep current gain when ABM disable immediately

2020-08-21 Thread Eryk Brol
From: Brandon Syu [Why] When system enters s3/s0i3, backlight PWM would set user level. [How] ABM disable function add keep current gain to avoid it. Signed-off-by: Brandon Syu Reviewed-by: Josip Pavic Acked-by: Eryk Brol --- drivers/gpu/drm/amd/display/dc/dc_stream.h | 2 +- 1 file changed

[PATCH 6/9] drm/amd/display: Add debugfs for connector's FEC & DSC capabilities

2020-08-21 Thread Eryk Brol
[why & how] Useful entry to understand if link has DSC or FEC capabilities, implemented to read DPCD caps stored on the link. Better than manually reading the registers with aux dpcd helper. Signed-off-by: Eryk Brol Signed-off-by: Mikita Lipski Reviewed-by: Mikita Lipski Acked-by: Eryk Brol --

[PATCH 3/9] drm/amd/display: Send H14b-VSIF specified in HDMI

2020-08-21 Thread Eryk Brol
From: Wayne Lin [Why] Current function excludes the logic to generate H14b-VSIF. Now it constructs HF-VSIF only and causes HDMI compliace test fail. [How] According to HDMI spec, source devices shall utilize the H14b-VSIF whenever the signaling capabilities of the H14b-VSIF allow this. Here kee

[PATCH 8/9] drm/amd/display: Fix passive dongle mistaken as active dongle in EDID emulation

2020-08-21 Thread Eryk Brol
From: Samson Tam [Why] dongle_type is set during dongle connection but for passive dongles, dongle_type is not set. If user starts with an active dongle and then switches to a passive dongle, it will still report as an active dongle. Trying to emulate the wrong connecter type results in display n

[PATCH 5/9] drm/amd/display: Send DISPLAY_OFF after power down on boot

2020-08-21 Thread Eryk Brol
From: Sung Lee [WHY] update_clocks might not be called on headless adapters. This means DISPLAY_OFF may not be sent in headless cases. [HOW] If hardware is powered down on boot because it is headless (mode set does not happen on that adapter) also send DISPLAY_OFF notification. Signed-off-by: S

[PATCH 7/9] drm/amd/display: Add connector HPD trigger debugfs entry

2020-08-21 Thread Eryk Brol
[why] Need a tool to retrigger a virtual hotplug for testing purposes with force redetection in both DC and DM. [how] Emulate handle_hpd_irq for connector as if usermode would trigger a hotplug. Perform DC link discovery, DM connector update, and DM force atomic commit. In order to trigger HPD on

[PATCH 4/9] drm/amd/display: Revert HDCP disable sequence change

2020-08-21 Thread Eryk Brol
From: Jaehyun Chung [Why] Revert HDCP disable sequence change that blanks stream before disabling HDCP. PSP and HW teams are currently investigating the root cause of why HDCP cannot be disabled before stream blank, which is expected to work without issues. Signed-off-by: Jaehyun Chung Reviewed

[PATCH 1/9] drm/amd/display: 3.2.99

2020-08-21 Thread Eryk Brol
From: Aric Cyr Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Eryk Brol --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index f3ac9e3df760..1d9c8e09c

[PATCH 2/9] drm/amd/display: Call DMUB for eDP power control

2020-08-21 Thread Eryk Brol
From: Chris Park [Why] If DMUB is used, LVTMA VBIOS call can be used to control eDP instead of tranditional transmitter control. Interface is agreed with VBIOS for eDP to use this new path to program LVTMA registers. [How] Expose DAL interface to send DMUB command for LVTMA control that VBIOS cu

Re: [PATCH v5] drm/amdkfd: implement the dGPU fallback path for apu (v5)

2020-08-21 Thread Huang Rui
On Sat, Aug 22, 2020 at 12:48:00AM +0800, Kuehling, Felix wrote: > > Am 2020-08-21 um 8:50 a.m. schrieb Huang Rui: > > We still have a few iommu issues which need to address, so force raven > > as "dgpu" path for the moment. > > > > This is to add the fallback path to bypass IOMMU if IOMMU v2 is d