[PATCH -next] drm/amdgpu: remove set but not used variable 'adev'

2020-07-02 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c: In function 'amdgpu_init_mem_type': drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:81:24: warning: variable 'adev' set but not used [-Wunused-but-set-variable] struct amdgpu_device *adev; ^

[PATCH v2] gpu/drm: Remove debug info about CPU address

2020-07-02 Thread Tiezhu Yang
When I update the latest kernel, I see the following "ptrval" boot messages. [1.872600] radeon :01:05.0: fence driver on ring 0 use gpu addr 0x48000c00 and cpu addr 0x(ptrval) [1.879095] radeon :01:05.0: fence driver on ring 5 use gpu addr 0x400560

Re: [PATCH v2] gpu/drm: Remove debug info about CPU address

2020-07-02 Thread Christian König
Am 02.07.20 um 04:27 schrieb Tiezhu Yang: When I update the latest kernel, I see the following "ptrval" boot messages. [1.872600] radeon :01:05.0: fence driver on ring 0 use gpu addr 0x48000c00 and cpu addr 0x(ptrval) [1.879095] radeon :01:05.0: fence dri

Re: [PATCH v2] gpu/drm: Remove debug info about CPU address

2020-07-02 Thread Christian König
Am 02.07.20 um 10:35 schrieb Tiezhu Yang: On 07/02/2020 04:27 PM, Christian König wrote: Am 02.07.20 um 04:27 schrieb Tiezhu Yang: When I update the latest kernel, I see the following "ptrval" boot messages. [    1.872600] radeon :01:05.0: fence driver on ring 0 use gpu addr 0x00

[PATCH 1/4] drm/amd/powerplay: drop unnecessary wrappers around clock retrieving

2020-07-02 Thread Evan Quan
By calling the target APIs directly. Change-Id: Ic1c92f26f7aeab334632a26bf75c3e232d1db0e1 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 9 - drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 1 - drivers/gpu/drm/amd/powerplay/navi10_ppt.c |

[PATCH 2/4] drm/amd/powerplay: bypass wrapper on retrieving current clock frequency

2020-07-02 Thread Evan Quan
By calling the target API(asic specific) directly. Change-Id: I711a57f46cd471928b7700b3a651ebfee9bf8206 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 363 +- drivers/gpu/drm/amd/powerplay/navi10_ppt.c| 5 +- .../drm/amd/powerplay/sienna_cichli

[PATCH 3/4] drm/amd/powerplay: unshare the code for retrieving current clock frequency

2020-07-02 Thread Evan Quan
By moving them into asic specific file. Since they are really ASIC specific. Change-Id: I932369d5c2033ab8567d26bebcac053a500227f0 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 11 +++ drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 10 ++

[PATCH 4/4] drm/amd/powerplay: drop unused code and wrapper around clock retrieving

2020-07-02 Thread Evan Quan
Clean code by dropping unnecessary ones. Change-Id: Idf89ef6fa787b61cd8baf8ded7e3f323bdcef189 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 8 +++- .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 3 -- drivers/gpu/drm/amd/powerplay/inc/smu_v11_0.h | 8 +--- driv

[PATCH 2/4] drm/amd/powerplay: revise calling chain on setting soft limit

2020-07-02 Thread Evan Quan
This helps to maintain clear code layers and drop unnecessary parameter. Change-Id: I2d27547414d964552d0515e76e165d34c8ce0132 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 +- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 20 + .../gpu/drm/amd/powerpla

[PATCH 1/4] drm/amd/powerplay: put setting hard limit common code in smu_v11_0.c

2020-07-02 Thread Evan Quan
As designed the common code shared among all smu v11 ASCIs go to smu_v11_0.c. This helps to maintain clear code layers. Change-Id: Ib5bd4b40702f1442a4b094d927aa5fc101b960c5 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 36 - .../gpu/drm/amd/powerpla

[PATCH 4/4] drm/amd/powerplay: put dpm frequency setting common code in smu_v11_0.c

2020-07-02 Thread Evan Quan
As designed the common code shared among all smu v11 ASCIs go to smu_v11_0.c. This helps to maintain clear code layers. Change-Id: I1f848eba0b6b56f8b5ef6f0888ee6955ba1d2070 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 65 -- .../gpu/drm/amd/powerplay/i

[PATCH 3/4] drm/amd/powerplay: revise calling chain on retrieving frequency range

2020-07-02 Thread Evan Quan
This helps to maintain clear code layers and drop unnecessary parameter. Change-Id: I2250a014759a0c855e476bbfa9642c1efc47ae26 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c | 6 +-- drivers/gpu/drm/amd/powerplay/

RE: [PATCH 1/1] drm/amdkfd: Remove redundand kfd2kgd interface lookup

2020-07-02 Thread Russell, Kent
[AMD Public Use] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Felix > Kuehling > Sent: Tuesday, June 30, 2020 10:34 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 1/1] drm/amdkfd: Remove redundand kfd2kgd interface > lookup > > kfd_pasid.c isn't

Re: [PATCH 1/2] moduleparams: Add hex type parameter

2020-07-02 Thread Christian König
Am 02.07.20 um 16:01 schrieb Paul Menzel: For bitmasks printing values in hex is more convenient. Prefix with 0x (#) to make it clear, that it’s a hex value. Using the helper for `amdgpu.ppfeaturemask`, it will look like below. Before: $ more /sys/module/amdgpu/parameters/ppfeaturemask

[PATCH 2/2] drm/amdgpu: Change type of module param `ppfeaturemask` to hex

2020-07-02 Thread Paul Menzel
The newly added hex helper is more convenient for bitmasks. Before: $ more /sys/module/amdgpu/parameters/ppfeaturemask 4294950911 After: $ more /sys/module/amdgpu/parameters/ppfeaturemask 0xbfff Cc: amd-gfx@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Signed-off-b

Re: [PATCH v2] gpu/drm: Remove debug info about CPU address

2020-07-02 Thread Tiezhu Yang
On 07/02/2020 04:27 PM, Christian König wrote: Am 02.07.20 um 04:27 schrieb Tiezhu Yang: When I update the latest kernel, I see the following "ptrval" boot messages. [1.872600] radeon :01:05.0: fence driver on ring 0 use gpu addr 0x48000c00 and cpu addr 0x(ptrval__

Re: [PATCH v2] gpu/drm: Remove debug info about CPU address

2020-07-02 Thread Tiezhu Yang
On 07/02/2020 04:39 PM, Christian König wrote: Am 02.07.20 um 10:35 schrieb Tiezhu Yang: On 07/02/2020 04:27 PM, Christian König wrote: Am 02.07.20 um 04:27 schrieb Tiezhu Yang: When I update the latest kernel, I see the following "ptrval" boot messages. [1.872600] radeon :01

[PATCH 1/2] moduleparams: Add hex type parameter

2020-07-02 Thread Paul Menzel
For bitmasks printing values in hex is more convenient. Prefix with 0x (#) to make it clear, that it’s a hex value. Using the helper for `amdgpu.ppfeaturemask`, it will look like below. Before: $ more /sys/module/amdgpu/parameters/ppfeaturemask 4294950911 After: $ more /sys/module

[PATCH 1/1] drm/amd/display: Add missing reg mask for dcn3

2020-07-02 Thread Bhawanpreet Lakha
This mask is missing for dcn3 so add it from dcn20. enc2_set_dynamic_metadata() trys to sets this and we get a generic_reg warning since the mask is not defined. Signed-off-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dio_stream_encoder.h | 1 + 1 file changed, 1 inserti

Re: [PATCH v5 01/12] iommu: Change type of pasid to u32

2020-07-02 Thread Felix Kuehling
Am 2020-07-02 um 3:10 p.m. schrieb Fenghua Yu: > Hi, Felix, Thomas, Joerg and maintainers, > > On Tue, Jun 30, 2020 at 10:12:38PM -0400, Felix Kuehling wrote: >> Am 2020-06-30 um 7:44 p.m. schrieb Fenghua Yu: >> You didn't change the return types of amdgpu_pasid_alloc and >> kfd_pasid_alloc. amdgpu

Re: [PATCH] drm/amdgpu: return an error for hw access in INFO ioctl when in reset

2020-07-02 Thread Felix Kuehling
Am 2020-07-01 um 10:34 a.m. schrieb Li, Dennis: > [AMD Official Use Only - Internal Distribution Only] > > Hi, Christian and Alex > Not only amdgpu ioctls, but amdkfd ioctls also have the same issue. Most KFD ioctls don't access HW directly. The only place that interacts with HW in KFD is