[bug report] drm/amd/display: Use dmub fw to lock pipe, cursor, dig

2020-06-26 Thread Dan Carpenter
Hello Wyatt Wood, This is a semi-automatic email about new static checker warnings. The patch 4dc079787b23: "drm/amd/display: Use dmub fw to lock pipe, cursor, dig" from May 27, 2020, leads to the following Smatch complaint: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:4091 dc

[PATCH] drm/amdgpu: return an error for hw access in INFO ioctl when in reset

2020-06-26 Thread Alex Deucher
When the GPU is in reset, accessing the hw is unreliable and could interfere with the reset. Return an error in those cases. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

[PATCH] drm/amdgpu: Adding wait time before reading upll control register

2020-06-26 Thread Alex Jivin
Adding a delay between writing to UVD control register and reading from it. This is to allow the HW to process the write command. Signed-off-by: Alex Jivin Suggested-By: Luben Tukov --- drivers/gpu/drm/amd/amdgpu/si.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd

[PATCH 01/11] drm/amd/display: Initialize psr debug flags to 0

2020-06-26 Thread Eryk Brol
From: Wyatt Wood [Why] Debug flags are not set by default. [How] Set debug flags to 0 Signed-off-by: Wyatt Wood Reviewed-by: Anthony Koo Acked-by: Eryk Brol --- drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/d

[PATCH 00/11] DC Patches June 29, 2020

2020-06-26 Thread Eryk Brol
This DC patchset brings improvements in multiple areas. In summary, we highlight: * Fixes in Freesync, DCN20, and others; * Enhancements in DC; * Improvements in PSR, link processing, and others. - Anthony Koo (3): drm/amd/display: [FW Promotion] Release 1.0.20 drm/amd/displa

[PATCH 09/11] drm/amd/display: Add register key and status for edid

2020-06-26 Thread Eryk Brol
From: Jing Zhou [Why] Register key for AE or QA do regression test. New edid status for check. [How] Add register key edid_read_retry_times. Add new edid status EDID_FALL_BACK. Signed-off-by: Jing Zhou Reviewed-by: Charlene Liu Acked-by: Eryk Brol --- drivers/gpu/drm/amd/display/dc/dc.h

[PATCH 07/11] drm/amd/display: Fix incorrect rounding for 10Hz refresh range

2020-06-26 Thread Eryk Brol
From: Jaehyun Chung [Why] In cases where refresh range is slightly below 10, FreeSync is not active or supported. Need to round values before checking refresh range in order to have FreeSync supported in these cases. [How] Remove redundant values and round values before checking valid refresh ra

[PATCH 11/11] drm/amd/display: Enable 4 to 1 mpc combine for max detile use

2020-06-26 Thread Eryk Brol
From: Dmytro Laktyushkin In case of certain display configurations we want to allow max detile buffer utilization by using 4 to 1 mpc combine Signed-off-by: Dmytro Laktyushkin Reviewed-by: Eric Bernstein Acked-by: Eryk Brol --- .../drm/amd/display/dc/dcn20/dcn20_resource.c | 24 -

[PATCH 03/11] drm/amd/display: [FW Promotion] Release 1.0.20

2020-06-26 Thread Eryk Brol
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Acked-by: Eryk Brol --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/

[PATCH 06/11] drm/amd/display: [FW Promotion] Release 1.0.21

2020-06-26 Thread Eryk Brol
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Acked-by: Eryk Brol --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/

[PATCH 05/11] drm/amd/display: check dpcd read status of DP_DOWNSTREAM_PORT_0

2020-06-26 Thread Eryk Brol
From: jinlong zhang [Why] For special DP convert VGA dongle, core_link_read_dpcd for DP_DOWNSTREAM_PORT_0 always return fail, then dongle_type will be set to DISPLAY_DONGLE_NONE, which will cause desktop resolution abnormal. [How] If dpcd for DP_DOWNSTREAM_PORT_0 read fail, skip set dongle_type

[PATCH 04/11] drm/amd/display: Handle SMU msg response

2020-06-26 Thread Eryk Brol
From: Yongqiang Sun [Why] SMU may return error code to driver, but driver only check if response is OK. [How] Check SMU response instead of reg_wait, assert in case of reponse isn't OK. Signed-off-by: Yongqiang Sun Reviewed-by: Tony Cheng Acked-by: Eryk Brol --- .../dc/clk_mgr/dcn10/rv1_clk

[PATCH 08/11] drm/amd/display: [FW Promotion] Release 1.0.22

2020-06-26 Thread Eryk Brol
From: Anthony Koo [Header Changes] - Add command for notification of active streams to DMUB Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Acked-by: Eryk Brol --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a

[PATCH 10/11] drm/amd/display: 3.2.92

2020-06-26 Thread Eryk Brol
From: Aric Cyr Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Eryk Brol --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 01ef2a3c1f3c..90cc3abe2

[PATCH 02/11] drm/amd/display: Preserve gpu memory allocation for life of dc

2020-06-26 Thread Eryk Brol
From: Joshua Aberback [Why] We want to keep the same buffer allocated for use during multiple hardware initializations. [How] - allocate gpu memory buffer on clock manager construct - free gpu memory buffer on clock manager destruct Signed-off-by: Joshua Aberback Reviewed-by: Jun Lei Acked-

Re: [PATCH 04/11] drm/amd/display: Handle SMU msg response

2020-06-26 Thread Alex Deucher
On Fri, Jun 26, 2020 at 12:19 PM Eryk Brol wrote: > > From: Yongqiang Sun > > [Why] > SMU may return error code to driver, but driver only check if response > is OK. > > [How] > Check SMU response instead of reg_wait, assert in case of reponse isn't > OK. Will you ever get concurrent calls to th

Re: [PATCH] drm/amdgpu: Adding wait time before reading upll control register

2020-06-26 Thread Christian König
Am 26.06.20 um 18:12 schrieb Alex Jivin: Adding a delay between writing to UVD control register and reading from it. This is to allow the HW to process the write command. Signed-off-by: Alex Jivin Suggested-By: Luben Tukov --- drivers/gpu/drm/amd/amdgpu/si.c | 6 ++ 1 file changed, 6 in

Re: [PATCH 04/11] drm/amd/display: Handle SMU msg response

2020-06-26 Thread Kazlauskas, Nicholas
On 2020-06-26 12:48 p.m., Alex Deucher wrote: On Fri, Jun 26, 2020 at 12:19 PM Eryk Brol wrote: From: Yongqiang Sun [Why] SMU may return error code to driver, but driver only check if response is OK. [How] Check SMU response instead of reg_wait, assert in case of reponse isn't OK. Will yo

[pull] amdgpu, amdkfd, radeon drm-next-5.9

2020-06-26 Thread Alex Deucher
Hi Dave, Daniel, First pull for 5.9. Big feature here is initial support for a new GPU, sienna cichlid. The following changes since commit 9ca1f474cea0edc14a1d7ec933e5472c0ff115d3: Merge tag 'amd-drm-next-5.8-2020-05-27' of git://people.freedesktop.org/~agd5f/linux into drm-next (2020-05-28

[PATCH v4] Revert "drm/amd/display: Expose connector VRR range via debugfs"

2020-06-26 Thread Manasi Navare
From: Bhanuprakash Modem v3: * Rebase (Manasi) v2: * Rebase (Manasi) As both VRR min and max are already part of drm_display_info, drm can expose this VRR range for each connector. Hence this logic should move to core DRM. This reverts commit 727962f030c23422a01e8b22d0f463815fb15ec4. Signed-o

[PATCH 1/1] drm/amdkfd: sparse: fix incorrect type in assignment

2020-06-26 Thread Felix Kuehling
The correct way to implement the fops->poll callback uses EPOLL* macros. For reference see also: commit a9a08845e9ac ("vfs: do bulk POLL* -> EPOLL* replacement") commit 7a163b2195cd ("unify {de,}mangle_poll(), get rid of kernel-side POLL...") Reported-by: kernel test robot Fixes: 73b753a11ae9 ("