RE: [PATCH] drm/amd/powerplay: correct the way for checking SMU_FEATURE_BACO_BIT support

2020-02-12 Thread Feng, Kenneth
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kenneth Feng -Original Message- From: amd-gfx On Behalf Of Evan Quan Sent: Wednesday, February 12, 2020 3:25 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: correct the way for c

Re: [PATCH] drm/ttm: replace dma_resv object on deleted BOs v3

2020-02-12 Thread Christian König
Am 12.02.20 um 07:23 schrieb Pan, Xinhui: 2020年2月11日 23:43,Christian König 写道: When non-imported BOs are resurrected for delayed delete we replace the dma_resv object to allow for easy reclaiming of the resources. v2: move that to ttm_bo_individualize_resv v3: add a comment to explain what's

[PATCH] drm/amdgpu: return -EFAULT if copy_to_user() fails

2020-02-12 Thread Dan Carpenter
The copy_to_user() function returns the number of bytes remaining to be copied, but we want to return a negative error code to the user. Fixes: 030d5b97a54b ("drm/amdgpu: use amdgpu_device_vram_access in amdgpu_ttm_vram_read") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/amdgpu/amdgpu_t

Re: [PATCH] drm/amdgpu: return -EFAULT if copy_to_user() fails

2020-02-12 Thread Christian König
Am 12.02.20 um 13:07 schrieb Dan Carpenter: The copy_to_user() function returns the number of bytes remaining to be copied, but we want to return a negative error code to the user. Fixes: 030d5b97a54b ("drm/amdgpu: use amdgpu_device_vram_access in amdgpu_ttm_vram_read") Signed-off-by: Dan Carpe

[PATCH 2/2] drm/amdgpu/gfx10: disable gfxoff when reading rlc clock

2020-02-12 Thread Alex Deucher
Otherwise we readback all ones. Fixes rlc counter readback while gfxoff is active. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c index

[PATCH 1/2] drm/amdgpu/gfx9: disable gfxoff when reading rlc clock

2020-02-12 Thread Alex Deucher
Otherwise we readback all ones. Fixes rlc counter readback while gfxoff is active. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index 824

Re: [PATCH 1/2] drm/amdgpu/vcn: fix race condition issue for vcn start

2020-02-12 Thread Zhu, James
[AMD Official Use Only - Internal Distribution Only] ping From: Zhu, James Sent: Monday, February 10, 2020 1:06 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, James Subject: [PATCH 1/2] drm/amdgpu/vcn: fix race condition issue for vcn start Fix race condition i

[PATCH] drm/powerplay: Ratelimit PP_ASSERT warnings

2020-02-12 Thread Kent Russell
In certain situations the message could be reported dozens-to-hundreds of times, based on how often the function is called. E.g. If MCLK DPM, any calls to get/set MCLK will result in a failure message, potentially flooding dmesg. Ratelimit the warnings to avoid this flood. Change-Id: Ib817fd9227e9

RE: [PATCH 1/2] drm/amdgpu/vcn: fix race condition issue for vcn start

2020-02-12 Thread Liu, Leo
With your patches, still seeing the hung with multiple processes of decode, encode, and transcode. I think we need find the root cause of that and give a comprehensive fix either from driver side or firmware side or both. Regards, Leo From: amd-gfx On Behalf Of Zhu, James Sent: Wednesday, Febr

[PATCH] drm/amdgpu: stop allocating PDs/PTs with the eviction lock held

2020-02-12 Thread Christian König
We need to make sure to not allocate PDs/PTs while holding the eviction lock or otherwise we will run into lock inversion in the MM as soon as we enable the MMU notifier. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 31 +- 1 file changed, 25

RE: [PATCH 1/3] drm/amdgpu/display: extend DCN guard in dal_bios_parser_init_cmd_tbl_helper2

2020-02-12 Thread Liu, Zhan
> -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: 2020/February/11, Tuesday 11:33 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 1/3] drm/amdgpu/display: extend DCN guard in > dal_bios_parser_init_cmd_tbl_helper2 > > To cover DC

Re: [PATCH 2/2] drm/amdgpu/gfx10: disable gfxoff when reading rlc clock

2020-02-12 Thread Yuan, Xiaojie
Series is Reviewed-by: Xiaojie Yuan BR, Xiaojie > On Feb 12, 2020, at 9:53 PM, Alex Deucher wrote: > > Otherwise we readback all ones. Fixes rlc counter > readback while gfxoff is active. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 ++ > 1 file changed

RE: [PATCH 2/3] drm/amdgpu/display: extend DCN guards

2020-02-12 Thread Liu, Zhan
> -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: 2020/February/11, Tuesday 11:33 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 2/3] drm/amdgpu/display: extend DCN guards > > to cover dcn2.x related headers. > > Signed-off-by

RE: [PATCH 3/3] drm/amdgpu/display move get_num_odm_splits() into dc_resource.c

2020-02-12 Thread Liu, Zhan
Please find my reply inline. Thanks, Zhan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: 2020/February/11, Tuesday 11:33 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 3/3] drm/amdgpu/display move get_num_odm_splits() into > d

Re: [PATCH] drm/powerplay: Ratelimit PP_ASSERT warnings

2020-02-12 Thread Alex Deucher
On Wed, Feb 12, 2020 at 9:39 AM Kent Russell wrote: > > In certain situations the message could be reported dozens-to-hundreds of > times, based on how often the function is called. > E.g. If MCLK DPM, any calls to get/set MCLK will result in a failure > message, potentially flooding dmesg. Rateli

Re: [PATCH 3/3] drm/amdgpu/display move get_num_odm_splits() into dc_resource.c

2020-02-12 Thread Alex Deucher
On Wed, Feb 12, 2020 at 10:58 AM Liu, Zhan wrote: > > Please find my reply inline. > > Thanks, > Zhan > > > -Original Message- > > From: amd-gfx On Behalf Of Alex > > Deucher > > Sent: 2020/February/11, Tuesday 11:33 PM > > To: amd-gfx@lists.freedesktop.org > > Cc: Deucher, Alexander > >

RE: [PATCH 3/3] drm/amdgpu/display move get_num_odm_splits() into dc_resource.c

2020-02-12 Thread Liu, Zhan
> -Original Message- > From: Alex Deucher > Sent: 2020/February/12, Wednesday 11:05 AM > To: Liu, Zhan > Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander > > Subject: Re: [PATCH 3/3] drm/amdgpu/display move get_num_odm_splits() > into dc_resource.c > > On Wed, Feb 12, 2020 at 10:

Re: [PATCH 1/2] drm/amdgpu/vcn: fix race condition issue for vcn start

2020-02-12 Thread Zhu, James
Timeout issue are complicated. These patched can fix driver side issue. Acturus SPG timeout issue can be fixed with these patches. For other type of timeout issues are still under investigation. Thanks & Best Regards! James Zhu From: Liu, Leo Sent: Wednesday

Re: [PATCH v4] drm/scheduler: Avoid accessing freed bad job.

2020-02-12 Thread Andrey Grodzovsky
On 2/11/20 7:53 PM, Luben Tuikov wrote: On 2020-02-11 4:27 p.m., Andrey Grodzovsky wrote: On 2/11/20 10:55 AM, Andrey Grodzovsky wrote: On 2/10/20 4:50 PM, Luben Tuikov wrote: Hi Lucas, Thank you for bringing awareness of this issue, publicly. As soon as this patch showed up back in Novembe

Re: [PATCH 1/3] drm/amdgpu/display: extend DCN guard in dal_bios_parser_init_cmd_tbl_helper2

2020-02-12 Thread Rodrigo Siqueira
Tested-by: Rodrigo Siqueira On 02/11, Alex Deucher wrote: > To cover DCN 2.x. > > Signed-off-by: Alex Deucher > --- > .../drm/amd/display/dc/bios/command_table_helper2.c | 13 +++-- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/bios

Re: [PATCH 3/3] drm/amdgpu/display move get_num_odm_splits() into dc_resource.c

2020-02-12 Thread Rodrigo Siqueira
Tested-by: Rodrigo Siqueira On 02/11, Alex Deucher wrote: > It's used by more than just DCN2.0. Fixes missing symbol when > amdgpu is built without DCN support. > > Signed-off-by: Alex Deucher > --- > .../gpu/drm/amd/display/dc/core/dc_resource.c| 16 > .../drm/amd/display

Re: [PATCH 2/3] drm/amdgpu/display: extend DCN guards

2020-02-12 Thread Rodrigo Siqueira
Tested-by: Rodrigo Siqueira On 02/11, Alex Deucher wrote: > to cover dcn2.x related headers. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 4 ++-- > drivers/gpu/drm/amd/display/dc/gpio/hw_factory.c | 2 +- > drivers/gpu/drm/amd/display/dc/gpio/hw

Re: [PATCH] drm/amdgpu: return -EFAULT if copy_to_user() fails

2020-02-12 Thread Alex Deucher
On Wed, Feb 12, 2020 at 7:12 AM Christian König wrote: > > Am 12.02.20 um 13:07 schrieb Dan Carpenter: > > The copy_to_user() function returns the number of bytes remaining to be > > copied, but we want to return a negative error code to the user. > > > > Fixes: 030d5b97a54b ("drm/amdgpu: use amdg

Re: [PATCH] drm/ttm: replace dma_resv object on deleted BOs v3

2020-02-12 Thread Daniel Vetter
On Wed, Feb 12, 2020 at 12:53 PM Christian König wrote: > > Am 12.02.20 um 07:23 schrieb Pan, Xinhui: > > > >> 2020年2月11日 23:43,Christian König 写道: > >> > >> When non-imported BOs are resurrected for delayed delete we replace > >> the dma_resv object to allow for easy reclaiming of the resources.

[pull] amdgpu 5.6 fixes

2020-02-12 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.6. The following changes since commit bb6d3fb354c5ee8d6bde2d576eb7220ea09862b9: Linux 5.6-rc1 (2020-02-09 16:08:48 -0800) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux tags/amd-drm-fixes-5.6-2020-02-12 for you to fetch chang

[PATCH] drm/amdgpu: Move to a per-IB secure flag (TMZ)

2020-02-12 Thread Luben Tuikov
Move from a per-CS secure flag (TMZ) to a per-IB secure flag. Signed-off-by: Luben Tuikov --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 -- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 23 --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.h | 3 --- drivers/gpu/drm/amd/amdgpu/amd

Re: [PATCH] drm/ttm: replace dma_resv object on deleted BOs v3

2020-02-12 Thread Pan, Xinhui
> 2020年2月12日 19:53,Christian König 写道: > > Am 12.02.20 um 07:23 schrieb Pan, Xinhui: >> >>> 2020年2月11日 23:43,Christian König 写道: >>> >>> When non-imported BOs are resurrected for delayed delete we replace >>> the dma_resv object to allow for easy reclaiming of the resources. >>> >>> v2: mo