[PATCH] drm/amdgpu: move xgmi init/fini to xgmi_add/remove_device call

2020-01-29 Thread Frank . Min
From: Hawking Zhang For sriov, psp ip block has to be initialized before ih block for the dynamic register programming interface that needed for vf ih ring buffer. On the other hand, current psp ip block hw_init function will initialize xgmi session which actaully depends on interrupt to return s

[PATCH] drm/amdgpu: move xgmi init/fini to xgmi_add/remove_device call

2020-01-29 Thread Frank . Min
From: Hawking Zhang For sriov, psp ip block has to be initialized before ih block for the dynamic register programming interface that needed for vf ih ring buffer. On the other hand, current psp ip block hw_init function will initialize xgmi session which actaully depends on interrupt to return s

[PATCH] drm/amdgpu: move xgmi init/fini to xgmi_add/remove_device call

2020-01-29 Thread Min, Frank
From: Hawking Zhang Date: Mon, 23 Dec 2019 16:51:42 +0800 Subject: [PATCH] drm/amdgpu: move xgmi init/fini to xgmi_add/remove_device call For sriov, psp ip block has to be initialized before ih block for the dynamic register programming interface that needed for vf ih ring buffer. On the other h

Re: [PATCH v4 08/22] drm/nouveau: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-29 Thread Ben Skeggs
On Fri, 24 Jan 2020 at 00:00, Thomas Zimmermann wrote: > > The callback struct drm_driver.get_scanout_position() is deprecated in > favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert > nouveau over. > > v4: > * add argument names in function declaration > > Signed-off-by

Re: [PATCH v4 09/22] drm/nouveau: Convert to CRTC VBLANK callbacks

2020-01-29 Thread Ben Skeggs
On Fri, 24 Jan 2020 at 00:00, Thomas Zimmermann wrote: > > VBLANK callbacks in struct drm_driver are deprecated in favor of > their equivalents in struct drm_crtc_funcs. Convert nouvean over. > > v4: > * add argument names in function declaration > > Signed-off-by: Thomas Zimmermann Revie

Re: [PATCH 1/2] drm/amdgpu/display: handle multiple numbers of fclks in dcn_calcs.c

2020-01-29 Thread Kazlauskas, Nicholas
On 2020-01-28 2:47 p.m., Alex Deucher wrote: We might get different numbers of clocks from powerplay depending on what the OEM has populated. Bug: https://gitlab.freedesktop.org/drm/amd/issues/963 Signed-off-by: Alex Deucher --- .../gpu/drm/amd/display/dc/calcs/dcn_calcs.c | 31 -

[PATCH 3/3] drm/amdgpu/smu10: fix smu10_get_clock_by_type_with_voltage

2020-01-29 Thread Alex Deucher
Cull out 0 clocks to avoid a warning in DC. Bug: https://gitlab.freedesktop.org/drm/amd/issues/963 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu

[PATCH 2/3] drm/amdgpu/smu10: fix smu10_get_clock_by_type_with_latency

2020-01-29 Thread Alex Deucher
Only send non-0 clocks to DC for validation. This mirrors what the windows driver does. Bug: https://gitlab.freedesktop.org/drm/amd/issues/963 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-)

[PATCH 1/3] drm/amdgpu/display: handle multiple numbers of fclks in dcn_calcs.c (v2)

2020-01-29 Thread Alex Deucher
We might get different numbers of clocks from powerplay depending on what the OEM has populated. v2: add assert for at least one level Bug: https://gitlab.freedesktop.org/drm/amd/issues/963 Reviewed-by: Nicholas Kazlauskas Signed-off-by: Alex Deucher --- .../gpu/drm/amd/display/dc/calcs/dcn_ca

[PATCH 1/3] drm/amdgpu/navi: fix index for OD MCLK

2020-01-29 Thread Alex Deucher
You can only adjust the max mclk, not the min. Bug: https://gitlab.freedesktop.org/drm/amd/issues/1020 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/driv

[PATCH 2/3] drm/amdgpu/navi10: add OD_RANGE for navi overclocking

2020-01-29 Thread Alex Deucher
So users can see the range of valid values. Bug: https://gitlab.freedesktop.org/drm/amd/issues/1020 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 59 ++ 1 file changed, 59 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b

[PATCH 3/3] drm/amdgpu/smu_v11_0: Correct behavior of restoring default tables (v2)

2020-01-29 Thread Alex Deucher
From: Matt Coffin Previously, the syfs functionality for restoring the default powerplay table was sourcing it's information from the currently-staged powerplay table. This patch adds a step to cache the first overdrive table that we see on boot, so that it can be used later to "restore" the pow

Re: [PATCH] drm/amdgpu: correct vram mgr node size calculation

2020-01-29 Thread Philip Yang
Thanks and understand. Philip On 2020-01-28 2:59 p.m., Christian König wrote: Am 28.01.20 um 20:55 schrieb Philip Yang: Use pages_per_node instead of mem->num_pages to alloc vram, this will increase the chance to get vram node after vram fragments. NAK, this is intentional to aid TLB with co

Re: [Patch v1 5/5] drm/amdkfd: refactor runtime pm for baco

2020-01-29 Thread Felix Kuehling
HI Rajneesh, See comments inline ... And a general question: Why do you need to set the autosuspend_delay in so many places? Amdgpu only has a single call to this function during initialization. On 2020-01-27 20:29, Rajneesh Bhardwaj wrote: So far the kfd driver implemented same routines fo

[PATCH] drm/amdkfd: Add queue information to sysfs

2020-01-29 Thread Amber Lin
Provide compute queues information in sysfs under /sys/class/kfd/kfd/proc. The format is /sys/class/kfd/kfd/proc//queues//XX where XX are size, type, and gpuid three files to represent queue size, queue type, and the GPU this queue uses. folder and files underneath are generated when a queue is cr