Re: [PATCH 1/2] drm/amdgpu: Clean up gmc_v9_0_gart_enable

Am 07.10.19 um 22:34 schrieb Zeng, Oak: Many logic in this function are HDP set up, not gart set up. Moved those logic to gmc_v9_0_hw_init. No functional change. Change-Id: Ib00cc1ffd1e486e77571796dce53aa7506c0c55f Signed-off-by: Oak Zeng One minor note on the coding style below, apart from t

Re: [PATCH 2/2] drm/amdgpu: Enable gfx cache probing on HDP write for arcturus

Am 07.10.19 um 22:34 schrieb Zeng, Oak: This allows gfx cache to be probed and invalidated (for none-dirty cache lines) on a HDP write (from either another GPU or CPU). This should work only for the memory mapped as RW memory type newly added for arcturus, to achieve some cache coherence b/t mult

Re: [PATCH v2 03/27] drm/dp_mst: Destroy MSTBs asynchronously

On Fri, Sep 27, 2019 at 09:31:07AM -0400, Sean Paul wrote: > On Wed, Sep 25, 2019 at 04:08:22PM -0400, Lyude Paul wrote: > > On Wed, 2019-09-25 at 14:16 -0400, Sean Paul wrote: > > > On Tue, Sep 03, 2019 at 04:45:41PM -0400, Lyude Paul wrote: > > > > When reprobing an MST topology during resume, we

Re: [PATCH] drm/amdgpu/display: make various arrays static, makes object smaller

On 2019-10-07 5:58 p.m., Colin King wrote: > From: Colin Ian King > > Don't populate the arrays on the stack but instead make them > static. Makes the object code smaller by 158 bytes. > > Before: >text data bss dec hex filename > 32468 2072 0 34540

Re: [PATCH] drm/amdgpu/display: make various arrays static, makes object smaller

On Tue, 2019-10-08 at 13:56 +, Harry Wentland wrote: [] > > diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c > > b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c > [] > > @@ -2745,7 +2745,7 @@ static enum bp_result bios_get_board_layout_info( > > struct bios_parser *bp; >

Re: [PATCH] drm/amdgpu/display: make various arrays static, makes object smaller

On 2019-10-08 10:00 a.m., Joe Perches wrote: > On Tue, 2019-10-08 at 13:56 +, Harry Wentland wrote: > [] >>> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c >>> b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c >> [] >>> @@ -2745,7 +2745,7 @@ static enum bp_result bios_get_boa

Re: [PATCH] drm/amd/display: Use pixel encoding 444 for dongle usb-c to hdmi

Hi, Gentle ping ? Thx Julien On Tue, Oct 1, 2019 at 3:21 PM Julien Isorce wrote: > Fix pinkish color issue around grey areas. This also happens > when not using any dongle so directly with a usb-c to Display > Port cable. Meaning there is something wrong when using pixel > encoding RGB with am

Re: [PATCH 13/14] drm/amd/display: Recalculate VCPI slots for new DSC connectors

... yikes I need to apologize because I was going through my email and I realized you _did_ respond to me earlier regarding some of these questions, it just appears the reply fell through the cracks and somehow I didn't notice it until just now. Sorry about that! I'm still not sure I understand wh

Re: [PATCH 13/14] drm/amd/display: Recalculate VCPI slots for new DSC connectors

On Tue, 2019-10-08 at 12:24 -0400, Lyude Paul wrote: > ... > yikes > I need to apologize because I was going through my email and I realized you > _did_ respond to me earlier regarding some of these questions, it just > appears > the reply fell through the cracks and somehow I didn't notice it unti

Re: [PATCH] drm/amd/display: Use pixel encoding 444 for dongle usb-c to hdmi

+ some display folks. From: amd-gfx on behalf of Julien Isorce Sent: Tuesday, October 8, 2019 12:06 PM To: amd-gfx list Subject: Re: [PATCH] drm/amd/display: Use pixel encoding 444 for dongle usb-c to hdmi Hi, Gentle ping ? Thx Julien On Tue, Oct 1, 2019 at

Re: [PATCH] drm/amd/display: Use pixel encoding 444 for dongle usb-c to hdmi

Hi Julien, curious which monitor you're using. Have you checked whether the driver picks RGB or YCBCR420 without your patch? I'm not sure I understand how the pinkish color issue looks. Do you see a pinkish color at the transition from grey to another color? Or is the entire grey area pinkish?

Re: [PATCH] drm/amd/display: Use pixel encoding 444 for dongle usb-c to hdmi

Thanks for bumping. I replied on the mailing list. On 2019-10-08 1:28 p.m., Deucher, Alexander wrote: + some display folks. From: amd-gfx on behalf of Julien Isorce Sent: Tuesday, O

[PATCH] drm/amdgpu/ras: fix typos in documentation

Fix a couple of spelling typos. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index 0e2ee5869b5f..c0d3edf77901 1006

[PATCH] drm/amdgpu/ras: document the reboot ras option

We recently added it, but never documented it. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index c0d3edf77901..84d8

Re: [PATCH] drm/amdgpu/ras: document the reboot ras option

Reviewed-by: Andrey Grodzovsky Andrey On 10/8/19 2:09 PM, Alex Deucher wrote: > We recently added it, but never documented it. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gp

Re: [PATCH] drm/amdgpu/ras: fix typos in documentation

Reviewed-by: Andrey Grodzovsky Andrey On 10/8/19 2:05 PM, Alex Deucher wrote: > Fix a couple of spelling typos. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amd

Re: [PATCH] drm/amd/display: Use pixel encoding 444 for dongle usb-c to hdmi

Hi Harry, I can reproduce on LG, Samsung and NEC monitors. "Have you checked whether the driver picks RGB or YCBCR420 without your patch?" -> it was selecting RGB . For example on https://commons.wikimedia.org/wiki/File:Gray_scale.jpg , the second band from the left, will be entirely pinkish. Si

Re: [PATCH RFC v4 14/16] drm, cgroup: Introduce lgpu as DRM cgroup resource

On 2019-08-29 2:05 a.m., Kenny Ho wrote: > drm.lgpu > A read-write nested-keyed file which exists on all cgroups. > Each entry is keyed by the DRM device's major:minor. > > lgpu stands for logical GPU, it is an abstraction used to > subdivide a physical DRM devic

Re: [PATCH RFC v4 16/16] drm/amdgpu: Integrate with DRM cgroup

On 2019-08-29 2:05 a.m., Kenny Ho wrote: > The number of logical gpu (lgpu) is defined to be the number of compute > unit (CU) for a device. The lgpu allocation limit only applies to > compute workload for the moment (enforced via kfd queue creation.) Any > cu_mask update is validated against the

[PATCH] drm/amdgpu/display/dcn2.1: drop unused function

It's the same as the dcn2.0 function which it already uses. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c b/drivers/gpu/drm/amd/display/dc/dcn

[PATCH 0/8] low latency memory training for navi

This patch set improves the latency for memory training on navi parts. Tianci.Yin (8): drm/amdgpu: update amdgpu_discovery to handle revision drm/amdgpu: add a generic fb accessing helper function drm/amdgpu: introduce psp_v11_0_is_sos_alive interface drm/amdgpu: update atomfirmware header

[PATCH 1/8] drm/amdgpu: update amdgpu_discovery to handle revision

From: "Tianci.Yin" update amdgpu_discovery to get IP revision. Change-Id: If8152103d03b58e1dc0f32db63625e290f5f08a0 Reviewed-by: Alex Deucher Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h | 2 +- 2 files cha

[PATCH 3/8] drm/amdgpu: introduce psp_v11_0_is_sos_alive interface

From: "Tianci.Yin" introduce psp_v11_0_is_sos_alive func for common use. Change-Id: Iee0a6dd924d6a4b164eb751c0bec49fcb7d79483 Reviewed-by: Alex Deucher Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 22 +- 1 file changed, 13 insertions(+), 9 deletio

[PATCH 5/8] drm/amdgpu/atomfirmware: add memory training related helper functions

From: "Tianci.Yin" parse firmware to get memory training capability and fb location. Change-Id: I147c1d48e255e0191be4beb1ad6b637da607bf75 Reviewed-by: Alex Deucher Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 7 + drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c

[PATCH 6/8] drm/amdgpu: add psp memory training callbacks and macro

From: "Tianci.Yin" add interface for memory training. Change-Id: Ibb6d1d24eb651df796bc2bb3419a44937af60242 Reviewed-by: Alex Deucher Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 18 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 55 + 2 f

[PATCH 2/8] drm/amdgpu: add a generic fb accessing helper function

From: "Tianci.Yin" add a generic helper function for accessing framebuffer via MMIO Change-Id: I4baa0aa53c93a94c2eff98c6211a61f369239982 Reviewed-by: Alex Deucher Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH 4/8] drm/amdgpu: update atomfirmware header with memory training related members

From: "Tianci.Yin" add new vram_reserve_block structure and atomfirmware_internal_constants enumeration Change-Id: I6ba642ecd7ad94250162ae5c322ed8d85de9c35a Reviewed-by: Alex Deucher Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/include/atomfirmware.h | 15 +++ 1 file changed

[PATCH 7/8] drm/amdgpu: reserve vram for memory training

From: "Tianci.Yin" memory training using specific fixed vram segment, reserve these segments before anyone may allocate it. Change-Id: I1436755813a565608a2857a683f535377620a637 Reviewed-by: Alex Deucher Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 96 +++

[PATCH 8/8] drm/amdgpu/psp: add psp memory training implementation

From: "Tianci.Yin" add memory training implementation code to save resume time. Change-Id: I625794a780b11d824ab57ef39cc33b872c6dc6c9 Reviewed-by: Alex Deucher Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 9 ++ drive

Re: [PATCH 4/8] drm/amdgpu: update atomfirmware header with memory training related members

On 10/8/19 2:29 PM, Alex Deucher wrote: > From: "Tianci.Yin" > > add new vram_reserve_block structure and atomfirmware_internal_constants > enumeration > > Change-Id: I6ba642ecd7ad94250162ae5c322ed8d85de9c35a > Reviewed-by: Alex Deucher > Signed-off-by: Tianci.Yin > --- > drivers/gpu/drm/amd

Re: [PATCH 6/8] drm/amdgpu: add psp memory training callbacks and macro

On 10/8/19 2:29 PM, Alex Deucher wrote: > From: "Tianci.Yin" > > add interface for memory training. > > Change-Id: Ibb6d1d24eb651df796bc2bb3419a44937af60242 > Reviewed-by: Alex Deucher > Signed-off-by: Tianci.Yin > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 18 > drivers/gpu/dr

Re: [PATCH 13/14] drm/amd/display: Recalculate VCPI slots for new DSC connectors

On 08.10.2019 12:24, Lyude Paul wrote: > ... > yikes > I need to apologize because I was going through my email and I realized you > _did_ respond to me earlier regarding some of these questions, it just appears > the reply fell through the cracks and somehow I didn't notice it until just > now.

Re: [PATCH 3/8] drm/amdgpu: introduce psp_v11_0_is_sos_alive interface

On 2019-10-08 3:29 p.m., Alex Deucher wrote: > From: "Tianci.Yin" > > introduce psp_v11_0_is_sos_alive func for common use. > > Change-Id: Iee0a6dd924d6a4b164eb751c0bec49fcb7d79483 > Reviewed-by: Alex Deucher > Signed-off-by: Tianci.Yin > --- > drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 22

Re: [PATCH 4/8] drm/amdgpu: update atomfirmware header with memory training related members

On 2019-10-08 3:29 p.m., Alex Deucher wrote: > From: "Tianci.Yin" > > add new vram_reserve_block structure and atomfirmware_internal_constants > enumeration > > Change-Id: I6ba642ecd7ad94250162ae5c322ed8d85de9c35a > Reviewed-by: Alex Deucher > Signed-off-by: Tianci.Yin > --- > drivers/gpu/dr

Re: [PATCH 5/8] drm/amdgpu/atomfirmware: add memory training related helper functions

On 2019-10-08 3:29 p.m., Alex Deucher wrote: > From: "Tianci.Yin" > > parse firmware to get memory training capability and fb location. > > Change-Id: I147c1d48e255e0191be4beb1ad6b637da607bf75 > Reviewed-by: Alex Deucher > Signed-off-by: Tianci.Yin > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h

Re: [PATCH 7/8] drm/amdgpu: reserve vram for memory training

On 2019-10-08 3:29 p.m., Alex Deucher wrote: > From: "Tianci.Yin" > > memory training using specific fixed vram segment, reserve these > segments before anyone may allocate it. > > Change-Id: I1436755813a565608a2857a683f535377620a637 > Reviewed-by: Alex Deucher > Signed-off-by: Tianci.Yin > --

Re: [PATCH 8/8] drm/amdgpu/psp: add psp memory training implementation

On 2019-10-08 3:29 p.m., Alex Deucher wrote: > From: "Tianci.Yin" > > add memory training implementation code to save resume time. > > Change-Id: I625794a780b11d824ab57ef39cc33b872c6dc6c9 > Reviewed-by: Alex Deucher > Signed-off-by: Tianci.Yin > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h |

RE: [PATCH] drm/amdgpu/powerplay: fix typo in mvdd table setup

Reviewed-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, October 3, 2019 10:26 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Robert Strube Subject: [PATCH] drm/amdgpu/powerplay: fix typo in mvdd table setup Polaris and vegam use