RE: [PATCH 4/5] drm/amd/powerplay: add the interfaces for getting and setting profiling dpm clock level

2019-09-24 Thread Liang, Prike
From: Wang, Kevin(Yang) Sent: Monday, September 23, 2019 5:29 PM To: Liang, Prike ; amd-gfx@lists.freedesktop.org Cc: arron@amd.com; Huang, Ray ; Quan, Evan ; Feng, Kenneth Subject: Re: [PATCH 4/5] drm/amd/powerplay: add the interfaces for getting and setting profiling dpm clock level co

Re: [PATCH] drm/amdgpu/gmc10: apply the 'invalidation from sdma' workaround for navi12

2019-09-24 Thread Yuan, Xiaojie
Thanks Evan. Since we currently has only once place to check 'is navi series', I'd prefer not to put into a macro until we have another place to check that. Does the change below looks good to you? - adev->asic_type > CHIP_NAVI14 || + !(adev->asic_type >= CHIP_NAVI10 && adev-

RE: [PATCH] drm/amdgpu/gmc10: apply the 'invalidation from sdma' workaround for navi12

2019-09-24 Thread Quan, Evan
Sure. Free to add my RB with that. -Original Message- From: Yuan, Xiaojie Sent: Tuesday, September 24, 2019 3:20 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Xiao, Jack ; Yin, Tianci (Rico) Subject: Re: [PATCH] drm/amdgpu/gmc10: apply the 'invalidation from sd

[PATCH] drm/amdgpu: fix an UMC hw arbitrator bug(v2)

2019-09-24 Thread Monk Liu
issue: the UMC6 h/w bug is that when MCLK is doing the switch in the middle of a page access being preempted by high priority client (e.g. DISPLAY) then UMC and the mclk switch would stuck there due to deadlock how: fixed by disabling auto PreChg for UMC to avoid high priority client preempting ot

[PATCH] drm/amdgpu/psp: silence response status warning

2019-09-24 Thread S, Shirish
log the response status related error to the driver's debug log since psp response status is not 0 even though there was no problem while the command was submitted. This warning misleads, hence this change. Signed-off-by: Shirish S --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- 1 file cha

RE: [PATCH] drm/amdgpu/psp: silence response status warning

2019-09-24 Thread Xu, Feifei
Reviewed-by: Feifei Xu -Original Message- From: amd-gfx On Behalf Of S, Shirish Sent: Tuesday, September 24, 2019 5:18 PM To: Deucher, Alexander ; Koenig, Christian ; Huang, Ray ; Zhang, Hawking Cc: amd-gfx@lists.freedesktop.org; S, Shirish Subject: [PATCH] drm/amdgpu/psp: silence r

Re: [PATCH 2/2] drm/amdgpu/atomfirmware: simplify the interface to get vram info

2019-09-24 Thread Yuan, Xiaojie
Series is Reviewed-by: Xiaojie Yuan BR, Xiaojie From: amd-gfx on behalf of Alex Deucher Sent: Tuesday, September 24, 2019 4:35 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 2/2] drm/amdgpu/atomfirmware: simplify the interf

RE: [PATCH 14/14] drm/amdgpu: set TMZ bits in PTEs for secure bo (v2)

2019-09-24 Thread Huang, Ray
> -Original Message- > From: Koenig, Christian > Sent: Thursday, September 12, 2019 7:49 PM > To: Huang, Ray > Cc: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > Deucher, Alexander ; Tuikov, Luben > ; Liu, Aaron > Subject: Re: [PATCH 14/14] drm/amdgpu: set TMZ bits in

Re: [PATCH 14/14] drm/amdgpu: set TMZ bits in PTEs for secure bo (v2)

2019-09-24 Thread Koenig, Christian
Am 24.09.19 um 13:48 schrieb Huang, Ray: >> -Original Message- >> From: Koenig, Christian >> Sent: Thursday, September 12, 2019 7:49 PM >> To: Huang, Ray >> Cc: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >> Deucher, Alexander ; Tuikov, Luben >> ; Liu, Aaron >> Subjec

[PATCH] drm7amdgpu: once more fix amdgpu_bo_create_kernel_at

2019-09-24 Thread Christian König
When CPU access is needed we should tell that to amdgpu_bo_create_reserved() or otherwise the access is denied later on. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/

Re: [PATCH] drm7amdgpu: once more fix amdgpu_bo_create_kernel_at

2019-09-24 Thread Alex Deucher
On Tue, Sep 24, 2019 at 7:56 AM Christian König wrote: > > When CPU access is needed we should tell that to > amdgpu_bo_create_reserved() or otherwise the access is denied later on. > > Signed-off-by: Christian König Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c

Re: [PATCH] drm/amdgpu: fix an UMC hw arbitrator bug(v2)

2019-09-24 Thread Alex Deucher
On Tue, Sep 24, 2019 at 4:09 AM Monk Liu wrote: > > issue: > the UMC6 h/w bug is that when MCLK is doing the switch > in the middle of a page access being preempted by high > priority client (e.g. DISPLAY) then UMC and the mclk switch > would stuck there due to deadlock > > how: > fixed by disabli

[PATCH v2 8/9] drm/amdgpu: use drm_debug_enabled() to check for debug categories

2019-09-24 Thread Jani Nikula
Allow better abstraction of the drm_debug global variable in the future. No functional changes. Cc: Alex Deucher Cc: Christian König Cc: David (ChunMing) Zhou Cc: amd-gfx@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c | 4 ++-- 1 file changed,

[PATCH v2 0/9] drm/print: add and use drm_debug_enabled()

2019-09-24 Thread Jani Nikula
Hi all, v2 of [1], a little refactoring around drm_debug access to abstract it better. There shouldn't be any functional changes. I'd appreciate acks for merging the lot via drm-misc. If there are any objections to that, we'll need to postpone the last patch until everything has been merged and co

Re: [PATCH] drm/amdgpu/display: include slab.h in dcn21_resource.c

2019-09-24 Thread Harry Wentland
On 2019-09-23 5:54 p.m., Alex Deucher wrote: > On Mon, Sep 23, 2019 at 5:14 PM Harry Wentland wrote: >> >> On 2019-09-23 4:58 p.m., Alex Deucher wrote: >>> It's apparently needed in some configurations. >> >> Curious which config fails and what compiler errors we get... Sounds >> like our includes

RE: [PATCH v2 3/4] device_cgroup: Export devcgroup_check_permission

2019-09-24 Thread Kasiviswanathan, Harish
Hi Tejun, Can you please review this? You and Roman acked this patch before. It will be great if I can Reviewed-by, so that I can upstream this through Alex Deucher's amd-staging-drm-next and Dave Airlie's drm-next trees Thanks, Harish -Original Message- From: Kasiviswanathan, Harish

[PATCH AUTOSEL 5.3 09/87] drm/amd/display: Power-gate all DSCs at driver init time

2019-09-24 Thread Sasha Levin
From: Nikola Cornij [ Upstream commit 75c35000235f3662f2810e9a59b0c8eed045432e ] [why] DSC should be powered-on only on as-needed basis, i.e. if the mode requires it [how] Loop over all the DSCs at driver init time and power-gate each Signed-off-by: Nikola Cornij Reviewed-by: Nevenko Stupar

[PATCH AUTOSEL 5.3 08/87] drm/amd/display: add monitor patch to add T7 delay

2019-09-24 Thread Sasha Levin
From: Anthony Koo [ Upstream commit 88eac241a1fc500ce5274a09ddc4bd5fc2b5adb6 ] [Why] Specifically to one panel, TCON is able to accept active video signal quickly, but the Source Driver requires 2-3 frames of extra time. It is a Panel issue since TCON needs to take care of all Sink requirements

[PATCH AUTOSEL 5.3 10/87] drm/amd/display: fix not calling ppsmu to trigger PME

2019-09-24 Thread Sasha Levin
From: Su Sung Chung [ Upstream commit 18b401874aee10c80b5745c9b93280dae5a59809 ] [why] dcn20_clk_mgr_construct was not initializing pp_smu, and PME call gets filtered out by the null check [how] initialize pp_smu dcn20_clk_mgr_construct Signed-off-by: Su Sung Chung Reviewed-by: Eric Yang Ack

[PATCH AUTOSEL 5.3 11/87] drm/amd/display: Clear FEC_READY shadow register if DPCD write fails

2019-09-24 Thread Sasha Levin
From: Nikola Cornij [ Upstream commit d68a74541735e030dea56f72746cd26d19986f41 ] [why] As a fail-safe, in case 'set FEC_READY' DPCD write fails, a HW shadow register should be cleared and the internal FEC stat should be set to 'not ready'. This is to make sure HW settings will be consistent with

[PATCH AUTOSEL 5.3 12/87] drm/amd/display: Copy GSL groups when committing a new context

2019-09-24 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit 21ffcc94d5b3dc024fedac700f1e7f9dacf4ab4f ] [Why] DC configures the GSL group for the pipe when pipe_split is enabled and we're switching flip types (buffered <-> immediate flip) on DCN2. In order to record what GSL group the pipe is using DC stores it

[PATCH AUTOSEL 5.3 20/87] drm/amd/display: Use proper enum conversion functions

2019-09-24 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit d196bbbc28fab82624f7686f8b0da8e8644b6e6a ] clang warns: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_pp_smu.c:336:8: warning: implicit conversion from enumeration type 'enum smu_clk_type' to different enumeration type 'enum amd_pp_clock_typ

[PATCH AUTOSEL 5.3 19/87] drm/amdgpu: Fix hard hang for S/G display BOs.

2019-09-24 Thread Sasha Levin
From: Andrey Grodzovsky [ Upstream commit e4c4073b0139d055d43a9568690fc560aab4fa5c ] HW requires for caching to be unset for scanout BO mappings when the BO placement is in GTT memory. Usually the flag to unset is passed from user mode but for FB mode this was missing. v2: Keep all BO placement

[PATCH AUTOSEL 5.3 31/87] drm/amd/display: Fix frames_to_insert math

2019-09-24 Thread Sasha Levin
From: Bayan Zabihiyan [ Upstream commit a463b263032f7c98c5912207db43be1aa34a6438 ] [Why] The math on deciding on how many "frames to insert" sometimes sent us over the max refresh rate. Also integer overflow can occur if we have high refresh rates. [How] Instead of clipping the frame duration

[PATCH AUTOSEL 5.3 35/87] drm/amd/powerplay/smu7: enforce minimal VBITimeout (v2)

2019-09-24 Thread Sasha Levin
From: Ahzo [ Upstream commit f659bb6dae58c113805f92822e4c16ddd3156b79 ] This fixes screen corruption/flickering on 75 Hz displays. v2: make print statement debug only (Alex) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102646 Reviewed-by: Evan Quan Signed-off-by: Ahzo Signed-off-by

[PATCH AUTOSEL 5.3 33/87] drm/amd/display: Register VUPDATE_NO_LOCK interrupts for DCN2

2019-09-24 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit e40837afb9b011757e17e9f71d97853ca574bcff ] [Why] These are needed to send back DRM vblank events in the case where VRR is on. Without the interrupt enabled we're deferring the events into the vblank queue and userspace is left waiting forever to get ba

[PATCH AUTOSEL 5.3 32/87] drm/amd/display: reprogram VM config when system resume

2019-09-24 Thread Sasha Levin
From: Lewis Huang [ Upstream commit e5382701c3520b3ed66169a6e4aa6ce5df8c56e0 ] [Why] The vm config will be clear to 0 when system enter S4. It will cause hubbub didn't know how to fetch data when system resume. The flip always pending because earliest_inuse_address and request_address are differ

[PATCH AUTOSEL 5.3 22/87] gpu: drm: radeon: Fix a possible null-pointer dereference in radeon_connector_set_property()

2019-09-24 Thread Sasha Levin
From: Jia-Ju Bai [ Upstream commit f3eb9b8f67bc28783eddc142ad805ebdc53d6339 ] In radeon_connector_set_property(), there is an if statement on line 743 to check whether connector->encoder is NULL: if (connector->encoder) When connector->encoder is NULL, it is used on line 755: if (connec

[PATCH AUTOSEL 5.3 30/87] drm/amd/display: fix issue where 252-255 values are clipped

2019-09-24 Thread Sasha Levin
From: Anthony Koo [ Upstream commit 1cbcfc975164f397b449efb17f59d81a703090db ] [Why] When endpoint is at the boundary of a region, such as at 2^0=1 we find that the last segment has a sharp slope and some points are clipped at the top. [How] If end point is 1, which is exactly at the 2^0 region

[PATCH AUTOSEL 5.3 21/87] drm/radeon: Fix EEH during kexec

2019-09-24 Thread Sasha Levin
From: KyleMahlkuch [ Upstream commit 6f7fe9a93e6c09bf988c5059403f5f88e17e21e6 ] During kexec some adapters hit an EEH since they are not properly shut down in the radeon_pci_shutdown() function. Adding radeon_suspend_kms() fixes this issue. Signed-off-by: KyleMahlkuch Signed-off-by: Alex Deuch

[PATCH AUTOSEL 5.3 53/87] drm/amdgpu/sdma5: fix number of sdma5 trap irq types for navi1x

2019-09-24 Thread Sasha Levin
From: Xiaojie Yuan [ Upstream commit 9e48495017342c5d445b25eedd86d6fd884a6496 ] v2: set num_types based on num_instances navi1x has 2 sdma engines but commit "e7b58d03b678 drm/amdgpu: reorganize sdma v4 code to support more instances" changes the max number of sdma irq types (AMDGPU_SDMA_IRQ_LA

[PATCH AUTOSEL 5.3 60/87] drm/amd/powerpaly: fix navi series custom peak level value error

2019-09-24 Thread Sasha Levin
From: Kevin Wang [ Upstream commit 706feb26f890e1b8297b5d14975160de361edf4f ] fix other navi asic set peak performance level error. because the navi10_ppt.c will handle navi12 14 asic, it will use navi10 peak value to set other asic, it is not correct. after patch: only navi10 use custom peak v

[PATCH AUTOSEL 5.3 59/87] drm/amd/display: support spdif

2019-09-24 Thread Sasha Levin
From: Charlene Liu [ Upstream commit b5a41620bb88efb9fb31a4fa5e652e3d5bead7d4 ] [Description] port spdif fix to staging: spdif hardwired to afmt inst 1. spdif func pointer spdif resource allocation (reserve last audio endpoint for spdif only) Signed-off-by: Charlene Liu Reviewed-by: Dmytro

[PATCH AUTOSEL 5.3 61/87] drm/amd/display: fix MPO HUBP underflow with Scatter Gather

2019-09-24 Thread Sasha Levin
From: Zi Yu Liao [ Upstream commit 89cb5614736b9b5d3b833ca2237d10da6b4b0395 ] [why] With Scatter Gather enabled, HUBP underflows during MPO enabled video playback. hubp_init has a register write that fixes this problem, but the register is cleared when HUBP gets power gated. [how] Make a call t

[PATCH AUTOSEL 5.3 62/87] drm/amd/display: fix trigger not generated for freesync

2019-09-24 Thread Sasha Levin
From: Yogesh Mohan Marimuthu [ Upstream commit 1e7f100ce8c0640634b794604880d9204480c9f1 ] [Why] In newer hardware MANUAL_FLOW_CONTROL is not a trigger bit. Due to this front porch is fixed and in these hardware freesync does not work. [How] Change the programming to generate a pulse so that the

[PATCH AUTOSEL 5.3 65/87] drm/amdgpu/si: fix ASIC tests

2019-09-24 Thread Sasha Levin
From: Jean Delvare [ Upstream commit 77efe48a729588527afb4d5811b9e0acb29f5e51 ] Comparing adev->family with CHIP constants is not correct. adev->family can only be compared with AMDGPU_FAMILY constants and adev->asic_type is the struct member to compare with CHIP constants. They are separate ide

[PATCH AUTOSEL 5.2 13/70] drm/amdgpu: Fix hard hang for S/G display BOs.

2019-09-24 Thread Sasha Levin
From: Andrey Grodzovsky [ Upstream commit e4c4073b0139d055d43a9568690fc560aab4fa5c ] HW requires for caching to be unset for scanout BO mappings when the BO placement is in GTT memory. Usually the flag to unset is passed from user mode but for FB mode this was missing. v2: Keep all BO placement

[PATCH AUTOSEL 5.2 14/70] drm/radeon: Fix EEH during kexec

2019-09-24 Thread Sasha Levin
From: KyleMahlkuch [ Upstream commit 6f7fe9a93e6c09bf988c5059403f5f88e17e21e6 ] During kexec some adapters hit an EEH since they are not properly shut down in the radeon_pci_shutdown() function. Adding radeon_suspend_kms() fixes this issue. Signed-off-by: KyleMahlkuch Signed-off-by: Alex Deuch

[PATCH AUTOSEL 5.2 07/70] drm/amd/display: add monitor patch to add T7 delay

2019-09-24 Thread Sasha Levin
From: Anthony Koo [ Upstream commit 88eac241a1fc500ce5274a09ddc4bd5fc2b5adb6 ] [Why] Specifically to one panel, TCON is able to accept active video signal quickly, but the Source Driver requires 2-3 frames of extra time. It is a Panel issue since TCON needs to take care of all Sink requirements

[PATCH AUTOSEL 5.2 22/70] drm/amd/display: fix issue where 252-255 values are clipped

2019-09-24 Thread Sasha Levin
From: Anthony Koo [ Upstream commit 1cbcfc975164f397b449efb17f59d81a703090db ] [Why] When endpoint is at the boundary of a region, such as at 2^0=1 we find that the last segment has a sharp slope and some points are clipped at the top. [How] If end point is 1, which is exactly at the 2^0 region

[PATCH AUTOSEL 5.2 15/70] gpu: drm: radeon: Fix a possible null-pointer dereference in radeon_connector_set_property()

2019-09-24 Thread Sasha Levin
From: Jia-Ju Bai [ Upstream commit f3eb9b8f67bc28783eddc142ad805ebdc53d6339 ] In radeon_connector_set_property(), there is an if statement on line 743 to check whether connector->encoder is NULL: if (connector->encoder) When connector->encoder is NULL, it is used on line 755: if (connec

[PATCH AUTOSEL 5.2 24/70] drm/amd/display: reprogram VM config when system resume

2019-09-24 Thread Sasha Levin
From: Lewis Huang [ Upstream commit e5382701c3520b3ed66169a6e4aa6ce5df8c56e0 ] [Why] The vm config will be clear to 0 when system enter S4. It will cause hubbub didn't know how to fetch data when system resume. The flip always pending because earliest_inuse_address and request_address are differ

[PATCH AUTOSEL 5.2 23/70] drm/amd/display: Fix frames_to_insert math

2019-09-24 Thread Sasha Levin
From: Bayan Zabihiyan [ Upstream commit a463b263032f7c98c5912207db43be1aa34a6438 ] [Why] The math on deciding on how many "frames to insert" sometimes sent us over the max refresh rate. Also integer overflow can occur if we have high refresh rates. [How] Instead of clipping the frame duration

[PATCH AUTOSEL 5.2 26/70] drm/amd/powerplay/smu7: enforce minimal VBITimeout (v2)

2019-09-24 Thread Sasha Levin
From: Ahzo [ Upstream commit f659bb6dae58c113805f92822e4c16ddd3156b79 ] This fixes screen corruption/flickering on 75 Hz displays. v2: make print statement debug only (Alex) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102646 Reviewed-by: Evan Quan Signed-off-by: Ahzo Signed-off-by

[PATCH AUTOSEL 5.2 47/70] drm/amd/display: support spdif

2019-09-24 Thread Sasha Levin
From: Charlene Liu [ Upstream commit b5a41620bb88efb9fb31a4fa5e652e3d5bead7d4 ] [Description] port spdif fix to staging: spdif hardwired to afmt inst 1. spdif func pointer spdif resource allocation (reserve last audio endpoint for spdif only) Signed-off-by: Charlene Liu Reviewed-by: Dmytro

[PATCH AUTOSEL 5.2 49/70] drm/amdgpu/si: fix ASIC tests

2019-09-24 Thread Sasha Levin
From: Jean Delvare [ Upstream commit 77efe48a729588527afb4d5811b9e0acb29f5e51 ] Comparing adev->family with CHIP constants is not correct. adev->family can only be compared with AMDGPU_FAMILY constants and adev->asic_type is the struct member to compare with CHIP constants. They are separate ide

[PATCH AUTOSEL 4.19 09/50] drm/radeon: Fix EEH during kexec

2019-09-24 Thread Sasha Levin
From: KyleMahlkuch [ Upstream commit 6f7fe9a93e6c09bf988c5059403f5f88e17e21e6 ] During kexec some adapters hit an EEH since they are not properly shut down in the radeon_pci_shutdown() function. Adding radeon_suspend_kms() fixes this issue. Signed-off-by: KyleMahlkuch Signed-off-by: Alex Deuch

[PATCH AUTOSEL 4.19 15/50] drm/amd/display: fix issue where 252-255 values are clipped

2019-09-24 Thread Sasha Levin
From: Anthony Koo [ Upstream commit 1cbcfc975164f397b449efb17f59d81a703090db ] [Why] When endpoint is at the boundary of a region, such as at 2^0=1 we find that the last segment has a sharp slope and some points are clipped at the top. [How] If end point is 1, which is exactly at the 2^0 region

[PATCH AUTOSEL 4.19 18/50] drm/amd/powerplay/smu7: enforce minimal VBITimeout (v2)

2019-09-24 Thread Sasha Levin
From: Ahzo [ Upstream commit f659bb6dae58c113805f92822e4c16ddd3156b79 ] This fixes screen corruption/flickering on 75 Hz displays. v2: make print statement debug only (Alex) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102646 Reviewed-by: Evan Quan Signed-off-by: Ahzo Signed-off-by

[PATCH AUTOSEL 4.19 16/50] drm/amd/display: reprogram VM config when system resume

2019-09-24 Thread Sasha Levin
From: Lewis Huang [ Upstream commit e5382701c3520b3ed66169a6e4aa6ce5df8c56e0 ] [Why] The vm config will be clear to 0 when system enter S4. It will cause hubbub didn't know how to fetch data when system resume. The flip always pending because earliest_inuse_address and request_address are differ

[PATCH AUTOSEL 4.19 10/50] gpu: drm: radeon: Fix a possible null-pointer dereference in radeon_connector_set_property()

2019-09-24 Thread Sasha Levin
From: Jia-Ju Bai [ Upstream commit f3eb9b8f67bc28783eddc142ad805ebdc53d6339 ] In radeon_connector_set_property(), there is an if statement on line 743 to check whether connector->encoder is NULL: if (connector->encoder) When connector->encoder is NULL, it is used on line 755: if (connec

[PATCH AUTOSEL 4.19 36/50] drm/amdgpu/si: fix ASIC tests

2019-09-24 Thread Sasha Levin
From: Jean Delvare [ Upstream commit 77efe48a729588527afb4d5811b9e0acb29f5e51 ] Comparing adev->family with CHIP constants is not correct. adev->family can only be compared with AMDGPU_FAMILY constants and adev->asic_type is the struct member to compare with CHIP constants. They are separate ide

[PATCH AUTOSEL 4.19 35/50] drm/amd/display: support spdif

2019-09-24 Thread Sasha Levin
From: Charlene Liu [ Upstream commit b5a41620bb88efb9fb31a4fa5e652e3d5bead7d4 ] [Description] port spdif fix to staging: spdif hardwired to afmt inst 1. spdif func pointer spdif resource allocation (reserve last audio endpoint for spdif only) Signed-off-by: Charlene Liu Reviewed-by: Dmytro

[PATCH AUTOSEL 4.14 06/28] drm/radeon: Fix EEH during kexec

2019-09-24 Thread Sasha Levin
From: KyleMahlkuch [ Upstream commit 6f7fe9a93e6c09bf988c5059403f5f88e17e21e6 ] During kexec some adapters hit an EEH since they are not properly shut down in the radeon_pci_shutdown() function. Adding radeon_suspend_kms() fixes this issue. Signed-off-by: KyleMahlkuch Signed-off-by: Alex Deuch

[PATCH AUTOSEL 4.14 07/28] gpu: drm: radeon: Fix a possible null-pointer dereference in radeon_connector_set_property()

2019-09-24 Thread Sasha Levin
From: Jia-Ju Bai [ Upstream commit f3eb9b8f67bc28783eddc142ad805ebdc53d6339 ] In radeon_connector_set_property(), there is an if statement on line 743 to check whether connector->encoder is NULL: if (connector->encoder) When connector->encoder is NULL, it is used on line 755: if (connec

[PATCH AUTOSEL 4.14 11/28] drm/amd/powerplay/smu7: enforce minimal VBITimeout (v2)

2019-09-24 Thread Sasha Levin
From: Ahzo [ Upstream commit f659bb6dae58c113805f92822e4c16ddd3156b79 ] This fixes screen corruption/flickering on 75 Hz displays. v2: make print statement debug only (Alex) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102646 Reviewed-by: Evan Quan Signed-off-by: Ahzo Signed-off-by

[PATCH AUTOSEL 4.14 22/28] drm/amdgpu/si: fix ASIC tests

2019-09-24 Thread Sasha Levin
From: Jean Delvare [ Upstream commit 77efe48a729588527afb4d5811b9e0acb29f5e51 ] Comparing adev->family with CHIP constants is not correct. adev->family can only be compared with AMDGPU_FAMILY constants and adev->asic_type is the struct member to compare with CHIP constants. They are separate ide

[PATCH AUTOSEL 4.9 07/19] drm/amd/powerplay/smu7: enforce minimal VBITimeout (v2)

2019-09-24 Thread Sasha Levin
From: Ahzo [ Upstream commit f659bb6dae58c113805f92822e4c16ddd3156b79 ] This fixes screen corruption/flickering on 75 Hz displays. v2: make print statement debug only (Alex) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102646 Reviewed-by: Evan Quan Signed-off-by: Ahzo Signed-off-by

[PATCH AUTOSEL 4.9 03/19] drm/radeon: Fix EEH during kexec

2019-09-24 Thread Sasha Levin
From: KyleMahlkuch [ Upstream commit 6f7fe9a93e6c09bf988c5059403f5f88e17e21e6 ] During kexec some adapters hit an EEH since they are not properly shut down in the radeon_pci_shutdown() function. Adding radeon_suspend_kms() fixes this issue. Signed-off-by: KyleMahlkuch Signed-off-by: Alex Deuch

[PATCH AUTOSEL 4.9 04/19] gpu: drm: radeon: Fix a possible null-pointer dereference in radeon_connector_set_property()

2019-09-24 Thread Sasha Levin
From: Jia-Ju Bai [ Upstream commit f3eb9b8f67bc28783eddc142ad805ebdc53d6339 ] In radeon_connector_set_property(), there is an if statement on line 743 to check whether connector->encoder is NULL: if (connector->encoder) When connector->encoder is NULL, it is used on line 755: if (connec

[PATCH AUTOSEL 4.9 14/19] drm/amdgpu/si: fix ASIC tests

2019-09-24 Thread Sasha Levin
From: Jean Delvare [ Upstream commit 77efe48a729588527afb4d5811b9e0acb29f5e51 ] Comparing adev->family with CHIP constants is not correct. adev->family can only be compared with AMDGPU_FAMILY constants and adev->asic_type is the struct member to compare with CHIP constants. They are separate ide

[PATCH AUTOSEL 4.4 02/14] gpu: drm: radeon: Fix a possible null-pointer dereference in radeon_connector_set_property()

2019-09-24 Thread Sasha Levin
From: Jia-Ju Bai [ Upstream commit f3eb9b8f67bc28783eddc142ad805ebdc53d6339 ] In radeon_connector_set_property(), there is an if statement on line 743 to check whether connector->encoder is NULL: if (connector->encoder) When connector->encoder is NULL, it is used on line 755: if (connec

Re: [PATCH v2 8/9] drm/amdgpu: use drm_debug_enabled() to check for debug categories

2019-09-24 Thread Alex Deucher
On Tue, Sep 24, 2019 at 9:00 AM Jani Nikula wrote: > > Allow better abstraction of the drm_debug global variable in the > future. No functional changes. > > Cc: Alex Deucher > Cc: Christian König > Cc: David (ChunMing) Zhou > Cc: amd-gfx@lists.freedesktop.org > Signed-off-by: Jani Nikula Acke

Re: [PATCH v2 3/4] device_cgroup: Export devcgroup_check_permission

2019-09-24 Thread Roman Gushchin
On Tue, Sep 24, 2019 at 03:54:47PM +, Kasiviswanathan, Harish wrote: > Hi Tejun, > > Can you please review this? You and Roman acked this patch before. It will be > great if I can Reviewed-by, so that I can upstream this through Alex > Deucher's amd-staging-drm-next and Dave Airlie's drm-nex

[PATCH] drm/amdgpu: Add NAVI12 support from kfd side

2019-09-24 Thread Liu, Shaoyun
Add device info for both navi12 PF and VF Change-Id: Ifb4035e65c12d153fc30e593fe109f9c7e0541f4 Signed-off-by: shaoyunl --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/a

[PATCH] drm/amdkfd: Add NAVI12 support from kfd side

2019-09-24 Thread Liu, Shaoyun
Add device info for both navi12 PF and VF Change-Id: Ifb4035e65c12d153fc30e593fe109f9c7e0541f4 Signed-off-by: shaoyunl --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/a

Re: [PATCH] drm/amdkfd: Add NAVI12 support from kfd side

2019-09-24 Thread Zhao, Yong
Reviewed-by: Yong Zhao Make sure to push to the new 5.3 branch. Yong From: amd-gfx on behalf of Liu, Shaoyun Sent: Tuesday, September 24, 2019 6:16 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Shaoyun Subject: [PATCH] drm/amdkfd: Add NAVI12 support from kf

Re: [PATCH] drm/amdkfd: Add NAVI12 support from kfd side

2019-09-24 Thread Liu, Shaoyun
I will push to drm-next branch . After check the code again , this change will cause issue in the kfd since CHIP_NAVI12 not added in other place where check the device_info->asic_family in kfd code . I think it's better just set the family ID as CHIP_NAVI10 since there is no difference f

[PATCH] drm/amdgpu: return tcc_disabled_mask to userspace

2019-09-24 Thread Marek Olšák
From: Marek Olšák UMDs need this for correct programming of harvested chips. Signed-off-by: Marek Olšák --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 ++ drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c

[PATCH libdrm] include: update amdgpu_drm.h

2019-09-24 Thread Marek Olšák
From: Marek Olšák --- include/drm/amdgpu_drm.h | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index 015bd9f4..bbdad866 100644 --- a/include/drm/amdgpu_drm.h +++ b/include/drm/amdgpu_drm.h @@ -121

Re: [PATCH] drm/amdkfd: Add NAVI12 support from kfd side

2019-09-24 Thread Zhao, Yong
If Navi12 is the same as Navi10, then you can easily add the KFD support first, as it only involves a couple of lines because of recent simplification. Then have this patch next. Regards, Yong From: Liu, Shaoyun Sent: Tuesday, September 24, 2019 6:28 PM To: Zhao

[PATCH] drm/amdkfd: Add NAVI12 support from kfd side

2019-09-24 Thread Liu, Shaoyun
Add device info for both navi12 PF and VF Change-Id: Ifb4035e65c12d153fc30e593fe109f9c7e0541f4 Signed-off-by: shaoyunl --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/a

Re: [PATCH] drm/amdgpu: return tcc_disabled_mask to userspace

2019-09-24 Thread Alex Deucher
On Tue, Sep 24, 2019 at 6:29 PM Marek Olšák wrote: > > From: Marek Olšák > > UMDs need this for correct programming of harvested chips. > > Signed-off-by: Marek Olšák > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 1 + > drivers/gpu/drm/am

[PATCH] drm/amd/display: prevent memory leak

2019-09-24 Thread Navid Emamdoost
In dcn*_create_resource_pool the allocated memory should be released if construct pool fails. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dce112/dce