[PATCH] drm/amdgpu: Fix a typo in the include header guard of 'navi12_ip_offset.h'

2019-08-18 Thread Christophe JAILLET
'_navi10_ip_offset_HEADER' is already used in 'navi10_ip_offset.h', so use '_navi12_ip_offset_HEADER' instead here. Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/amd/include/navi12_ip_offset.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/inc

Re: [PATCH] drm/amdgpu: Fix a typo in the include header guard of 'navi12_ip_offset.h'

2019-08-18 Thread Yuan, Xiaojie
Reviewed-by: Xiaojie Yuan Xiaojie > On Aug 19, 2019, at 12:00 AM, Christophe JAILLET > wrote: > > '_navi10_ip_offset_HEADER' is already used in 'navi10_ip_offset.h', so use > '_navi12_ip_offset_HEADER' instead here. > > Signed-off-by: Christophe JAILLET > --- > drivers/gpu/drm/amd/include/n

RE: [PATCH] drm/amd/powerplay: correct SW smu11 thermal range settings

2019-08-18 Thread Quan, Evan
Comment inline From: Wang, Kevin(Yang) Sent: Friday, August 16, 2019 7:04 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/powerplay: correct SW smu11 thermal range settings Hi Evan, the temperature min value should be 0, not -273 on smu11. you can refrence window

RE: [PATCH] drm/amdgpu: remove redundant argument for psp_funcs::cmd_submit callback

2019-08-18 Thread Quan, Evan
Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > Yuan, Xiaojie > Sent: Friday, August 16, 2019 6:04 PM > To: amd-gfx@lists.freedesktop.org > Cc: Yuan, Xiaojie > Subject: [PATCH] drm/amdgpu: remove redundant argument for > psp_funcs::cmd_submit callback > > Sig

RE: [PATCH libdrm] amdgpu: add mmhub ras inject unit test

2019-08-18 Thread Chen, Guchun
Hi Christian, Yes, we added one configuration file named "amdgpu_ras.json" for RAS inject unit test to drm master branch. This unit test will be maintained to illustrate all the RAS tests we absolutely support in IP modules/submodules. Regards, Guchun -Original Message- From: Christian

RE: [PATCH] drm/amd/powerplay: correct SW smu11 thermal range settings

2019-08-18 Thread Feng, Kenneth
Hi Evan, So due to the below code, we don't get a chance to set -273.15, right? + low = max(SMU_THERMAL_MINIMUM_ALERT_TEMP, + range.min / SMU_TEMPERATURE_UNITS_PER_CENTIGRADES); + high = min(SMU_THERMAL_MAXIMUM_ALERT_TEMP, + range.max / SMU_TE

RE: [PATCH] drm/amd/powerplay: correct SW smu11 thermal range settings

2019-08-18 Thread Quan, Evan
Yes, the lowest settings for thermal controller is 0. Regards Evan From: Feng, Kenneth Sent: Monday, August 19, 2019 1:12 PM To: Quan, Evan ; Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amd/powerplay: correct SW smu11 thermal range settings Hi Evan, So due to the