Re: The issue with page allocation 5.3 rc1-rc2 (seems drm culprit here)

2019-08-06 Thread Hillf Danton
On Tue, 6 Aug 2019 01:15:01 +0800 Mikhail Gavrilov wrote: > > Unfortunately couldn't check this patch because, with the patch, the > kernel did not compile. > Here is compile error messages: > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c: In function > 'dc_create_state': > drivers/gpu/drm/

Issues with hibernation and resume

2019-08-06 Thread Martin Babutzka
Dear AMD Developers,I am building your amd-staging-drm-next kernels for more than 2 years now and patch this up with the official kernel patches and ubuntu's sauce patches: https://github.com/M-Bab/linux-kernel-amdgpu-binariesOne of the kernel users reports about hibernation problems since quite a

[PATCH libdrm 1/3] amdgpu: add gfx ras eject configuration file

2019-08-06 Thread Guchun Chen
This configuration file will be picked up when running gfx ras eject tests by amdgpu_test tool. For the time being, only add those tests that are successfully trafficked. In addition, this file can also be modified by user to add or delete ras eject unit tests for different IP blocks/subblocks. Ch

[PATCH libdrm 0/3] add ras eject test for gfx and umc module

2019-08-06 Thread Guchun Chen
These patches are to support ras eject test for gfx and umc modules. Guchun Chen (3): amdgpu: add gfx ras eject configuration file tests/amdgpu/ras: refine ras eject test amdgpu: add umc ras eject test configuration configure.ac | 18 ++ data/amdgpu_ras.json | 260

[PATCH libdrm 2/3] tests/amdgpu/ras: refine ras eject test

2019-08-06 Thread Guchun Chen
Ras eject test framework is invalid with original codes, so refine it to make it work on top of kernel ras support. Change-Id: I63ac27707a69133cd08fa0da308f255b1b169c1f Signed-off-by: Dennis Li Signed-off-by: Guchun Chen --- configure.ac | 18 ++ meson.build | 1 + t

[PATCH libdrm 3/3] amdgpu: add umc ras eject test configuration

2019-08-06 Thread Guchun Chen
Change-Id: I779f2f4f59c69fb08fdc09b7adba5b36e3af20ce Signed-off-by: Dennis Li Signed-off-by: Guchun Chen --- data/amdgpu_ras.json | 10 ++ 1 file changed, 10 insertions(+) diff --git a/data/amdgpu_ras.json b/data/amdgpu_ras.json index 0863a182..3d090994 100644 --- a/data/amdgpu_ras.json

RE: [PATCH] Revert "drm/amdgpu: fix transform feedback GDS hang on gfx10 (v2)"

2019-08-06 Thread Ma, Le
Reviewed-by: Le Ma -Original Message- From: amd-gfx On Behalf Of Marek Ol?ák Sent: Saturday, August 03, 2019 6:27 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] Revert "drm/amdgpu: fix transform feedback GDS hang on gfx10 (v2)" From: Marek Olšák This reverts commit b41335c6c03

[PATCH] drm/amd/powerplay: check before issuing messages for max sustainable clocks

2019-08-06 Thread Evan Quan
Those messages are not supported on Arcturus and should not be issued. Affected ASIC: Arcturus Change-Id: I391099fc28e00356234fd2ae7b68f5861fd4c147 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/

RE: [PATCH] drm/amd/powerplay: check before issuing messages for max sustainable clocks

2019-08-06 Thread Xu, Feifei
Reviewed-by: Feifei Xu -Original Message- From: amd-gfx On Behalf Of Evan Quan Sent: Tuesday, August 6, 2019 4:21 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: check before issuing messages for max sustainable clocks Those messages are not su

Re: [PATCH hmm] drm/amdkfd: fix a use after free race with mmu_notififer unregister

2019-08-06 Thread Oded Gabbay
On Tue, Aug 6, 2019 at 10:31 AM Christoph Hellwig wrote: > > Btw, who maintains amkfd these days? MAINTAINERS still lists > Oded, but he seems to have moved on to Habanalabs and maintains that > drivers now while not having any action on amdkfd for over a year. I've sent a patch to update the MA

Re: [PATCH 05/13] drm: rockchip: Provide ddc symlink in inno_hdmi sysfs directory

2019-08-06 Thread Heiko Stuebner
Am Mittwoch, 31. Juli 2019, 18:58:14 CEST schrieb Andrzej Pietrasiewicz: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > Acked-by: Sam Ravnborg > Reviewed-by: Emil Velikov Acked-by: Heiko Stuebner

Re: [PATCH 04/13] drm: rockchip: Provide ddc symlink in rk3066_hdmi sysfs directory

2019-08-06 Thread Heiko Stuebner
Am Mittwoch, 31. Juli 2019, 18:58:13 CEST schrieb Andrzej Pietrasiewicz: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > Acked-by: Sam Ravnborg > Reviewed-by: Emil Velikov Acked-by: Heiko Stuebner

RE: [PATCH libdrm 0/3] add ras eject test for gfx and umc module

2019-08-06 Thread Zhang, Hawking
We shall add back umc multi-uncorrectable error injection in default config file. With that fixed, the series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Guchun Chen Sent: 2019年8月6日 15:36 To: amd-gfx@lists.freedesktop.org; Zhang, Hawkin

RE: [PATCH libdrm 0/3] add ras eject test for gfx and umc module

2019-08-06 Thread Zhou1, Tao
Please change all "eject" to "inject" in commit subject and description. -Original Message- From: amd-gfx On Behalf Of Guchun Chen Sent: 2019年8月6日 15:36 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Li, Dennis ; Pan, Xinhui ; Zhou1, Tao Cc: Chen, Guchun Subject: [PATCH libdrm 0/

RE: [PATCH libdrm 2/3] tests/amdgpu/ras: refine ras eject test

2019-08-06 Thread Zhou1, Tao
-Original Message- From: amd-gfx On Behalf Of Guchun Chen Sent: 2019年8月6日 15:36 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Li, Dennis ; Pan, Xinhui ; Zhou1, Tao Cc: Li, Dennis ; Chen, Guchun Subject: [PATCH libdrm 2/3] tests/amdgpu/ras: refine ras eject test Ras eject test

[PATCH] drm/amdgpu: fix compile error about readq/writeq on arm ARCH

2019-08-06 Thread Tao Zhou
readq/writeq can't be found on arm architecture, implement them with 32 bits operations Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_devic

Re: [PATCH] drm/amdgpu: fix compile error about readq/writeq on arm ARCH

2019-08-06 Thread Christian König
Am 06.08.19 um 12:31 schrieb Tao Zhou: readq/writeq can't be found on arm architecture, implement them with 32 bits operations Mhm, wasn't the whole point about using readq/writeq that we needed 64bit atomic operations? Christian. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/

Re: [PATCH hmm] drm/amdkfd: fix a use after free race with mmu_notififer unregister

2019-08-06 Thread Christoph Hellwig
Btw, who maintains amkfd these days? MAINTAINERS still lists Oded, but he seems to have moved on to Habanalabs and maintains that drivers now while not having any action on amdkfd for over a year. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org ht

Re: [PATCH] gpu: drm: amd: powerplay: Remove logically dead code

2019-08-06 Thread Alex Deucher
On Mon, Aug 5, 2019 at 3:01 PM Hariprasad Kelam wrote: > > Result of pointer airthmentic is never null > > fix coverity defect:1451876 > > Signed-off-by: Hariprasad Kelam Applied. thanks! Alex > --- > drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 2 -- > 1 file changed, 2 deletions(-) > > diff

Re: [PATCH] gpu: drm: amd: display: dc: dcn20: Remove redudant condition

2019-08-06 Thread Alex Deucher
On Mon, Aug 5, 2019 at 3:01 PM Hariprasad Kelam wrote: > > Remove redudant codition "dsc_cfg->dc_dsc_cfg.num_slices_v". > > fixes coverity defect 1451853 > > Signed-off-by: Hariprasad Kelam > --- > drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: [PATCH] drm/amd/powerplay: Zero initialize some variables

2019-08-06 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Aug 4, 2019 at 9:21 PM Quan, Evan wrote: > > Thanks Nathan. The patch is reviewed-by: Evan Quan > > > -Original Message- > > From: Nathan Chancellor > > Sent: Monday, August 05, 2019 4:37 AM > > To: Quan, Evan ; Deucher, Alexander > > ; Koenig, Christian

Re: [PATCH] drm/amdgpu: Do gpu reset if we lost some gpu reset requests

2019-08-06 Thread Grodzovsky, Andrey
On 8/5/19 2:02 AM, Pan, Xinhui wrote: > As the race of gpu reset with ras interrupts. we might lose a chance to > do gpu recovery. To guarantee the gpu has recovered successfully, we use > atomic to save the counts of gpu reset requests, and issue another gpu > reset if there are any pending reques

[PATCH 09/15] mm: don't abuse pte_index() in hmm_vma_handle_pmd

2019-08-06 Thread Christoph Hellwig
pte_index is an internal arch helper in various architectures, without consistent semantics. Open code that calculation of a PMD index based on the virtual address instead. Signed-off-by: Christoph Hellwig --- mm/hmm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/hmm.c

[PATCH 12/15] mm: cleanup the hmm_vma_walk_hugetlb_entry stub

2019-08-06 Thread Christoph Hellwig
Stub out the whole function and assign NULL to the .hugetlb_entry method if CONFIG_HUGETLB_PAGE is not set, as the method won't ever be called in that case. Signed-off-by: Christoph Hellwig Reviewed-by: Jason Gunthorpe --- mm/hmm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH 02/15] amdgpu: don't initialize range->list in amdgpu_hmm_init_range

2019-08-06 Thread Christoph Hellwig
The list is used to add the range to another list as an entry in the core hmm code, and intended as a private member not exposed to drivers. There is no need to initialize it in a driver. Signed-off-by: Christoph Hellwig Reviewed-by: Jason Gunthorpe Reviewed-by: Felix Kuehling --- drivers/gpu/

[PATCH 01/15] amdgpu: remove -EAGAIN handling for hmm_range_fault

2019-08-06 Thread Christoph Hellwig
hmm_range_fault can only return -EAGAIN if called with the HMM_FAULT_ALLOW_RETRY flag, which amdgpu never does. Remove the handling for the -EAGAIN case with its non-standard locking scheme. Signed-off-by: Christoph Hellwig Reviewed-by: Jason Gunthorpe Reviewed-by: Felix Kuehling --- drivers/

[PATCH 10/15] mm: only define hmm_vma_walk_pud if needed

2019-08-06 Thread Christoph Hellwig
We only need the special pud_entry walker if PUD-sized hugepages and pte mappings are supported, else the common pagewalk code will take care of the iteration. Not implementing this callback reduced the amount of code compiled for non-x86 platforms, and also fixes compile failures with other archi

[PATCH 08/15] mm: remove the mask variable in hmm_vma_walk_hugetlb_entry

2019-08-06 Thread Christoph Hellwig
The pagewalk code already passes the value as the hmask parameter. Signed-off-by: Christoph Hellwig --- mm/hmm.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/mm/hmm.c b/mm/hmm.c index f26d6abc4ed2..03d37e102e3b 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -771,19 +771,16

[PATCH 05/15] mm: remove the unused vma argument to hmm_range_dma_unmap

2019-08-06 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig Reviewed-by: Jason Gunthorpe --- include/linux/hmm.h | 1 - mm/hmm.c| 2 -- 2 files changed, 3 deletions(-) diff --git a/include/linux/hmm.h b/include/linux/hmm.h index 82265118d94a..59be0aa2476d 100644 --- a/include/linux/hmm.h +++ b/include/linux/h

[PATCH 03/15] nouveau: pass struct nouveau_svmm to nouveau_range_fault

2019-08-06 Thread Christoph Hellwig
We'll need the nouveau_svmm structure to improve the function soon. For now this allows using the svmm->mm reference to unlock the mmap_sem, and thus the same dereference chain that the caller uses to lock and unlock it. Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/nouveau/nouveau_svm.c

[PATCH 06/15] mm: remove superflous arguments from hmm_range_register

2019-08-06 Thread Christoph Hellwig
The start, end and page_shift values are all saved in the range structure, so we might as well use that for argument passing. Signed-off-by: Christoph Hellwig Reviewed-by: Jason Gunthorpe Reviewed-by: Felix Kuehling --- Documentation/vm/hmm.rst| 2 +- drivers/gpu/drm/amd/amdgp

[PATCH 14/15] mm: make HMM_MIRROR an implicit option

2019-08-06 Thread Christoph Hellwig
Make HMM_MIRROR an option that is selected by drivers wanting to use it instead of a user visible option as it is just a low-level implementation detail. Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/amd/amdgpu/Kconfig | 4 +++- drivers/gpu/drm/nouveau/Kconfig| 4 +++- mm/Kconfig

[PATCH 15/15] amdgpu: remove CONFIG_DRM_AMDGPU_USERPTR

2019-08-06 Thread Christoph Hellwig
The option is just used to select HMM mirror support and has a very confusing help text. Just pull in the HMM mirror code by default instead. Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/Kconfig | 2 ++ drivers/gpu/drm/amd/amdgpu/Kconfig | 10 -- drivers/gp

[PATCH 13/15] mm: allow HMM_MIRROR on all architectures with MMU

2019-08-06 Thread Christoph Hellwig
There isn't really any architecture specific code in this page table walk implementation, so drop the dependencies. Signed-off-by: Christoph Hellwig Reviewed-by: Jason Gunthorpe --- mm/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/Kconfig b/mm/Kconfig index 56

[PATCH 04/15] mm: remove the pgmap field from struct hmm_vma_walk

2019-08-06 Thread Christoph Hellwig
There is only a single place where the pgmap is passed over a function call, so replace it with local variables in the places where we deal with the pgmap. Signed-off-by: Christoph Hellwig --- mm/hmm.c | 62 1 file changed, 27 insertions(+

[PATCH 11/15] mm: cleanup the hmm_vma_handle_pmd stub

2019-08-06 Thread Christoph Hellwig
Stub out the whole function when CONFIG_TRANSPARENT_HUGEPAGE is not set to make the function easier to read. Signed-off-by: Christoph Hellwig --- mm/hmm.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/mm/hmm.c b/mm/hmm.c index 5e7afe685213..4aa7135f1094

hmm cleanups, v2

2019-08-06 Thread Christoph Hellwig
Hi Jérôme, Ben, Felix and Jason, below is a series against the hmm tree which cleans up various minor bits and allows HMM_MIRROR to be built on all architectures. Diffstat: 11 files changed, 94 insertions(+), 210 deletions(-) A git tree is also available at: git://git.infradead.org/us

[PATCH 07/15] mm: remove the page_shift member from struct hmm_range

2019-08-06 Thread Christoph Hellwig
All users pass PAGE_SIZE here, and if we wanted to support single entries for huge pages we should really just add a HMM_FAULT_HUGEPAGE flag instead that uses the huge page size instead of having the caller calculate that size once, just for the hmm code to verify it. Signed-off-by: Christoph Hell

Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel

2019-08-06 Thread Will Deacon
On Wed, Jul 24, 2019 at 03:20:59PM +0100, Will Deacon wrote: > On Wed, Jul 24, 2019 at 04:16:49PM +0200, Andrey Konovalov wrote: > > On Wed, Jul 24, 2019 at 4:02 PM Will Deacon wrote: > > > On Tue, Jul 23, 2019 at 08:03:29PM +0200, Andrey Konovalov wrote: > > > > Should this go through the mm or t

[PATCH] drm/amd/display: Add number of slices per line to DSC parameter validation

2019-08-06 Thread Harry Wentland
From: Nikola Cornij [why] Number of slices per line was mistakenly left out Cc: Hariprasad Kelam Signed-off-by: Nikola Cornij Signed-off-by: Harry Wentland Reviewed-by: Harry Wentland --- Thanks, Hariprasad, for your patch. The second condition should actually check for num_slices_h. Harry

Re: [PATCH 15/15] amdgpu: remove CONFIG_DRM_AMDGPU_USERPTR

2019-08-06 Thread Kuehling, Felix
On 2019-08-06 13:44, Jason Gunthorpe wrote: > On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote: >> The option is just used to select HMM mirror support and has a very >> confusing help text. Just pull in the HMM mirror code by default >> instead. >> >> Signed-off-by: Christoph Hel

Re: [PATCH 11/15] mm: cleanup the hmm_vma_handle_pmd stub

2019-08-06 Thread Jason Gunthorpe
On Tue, Aug 06, 2019 at 07:05:49PM +0300, Christoph Hellwig wrote: > Stub out the whole function when CONFIG_TRANSPARENT_HUGEPAGE is not set > to make the function easier to read. > > Signed-off-by: Christoph Hellwig > --- > mm/hmm.c | 18 -- > 1 file changed, 8 insertions(+), 10

Re: [PATCH 14/15] mm: make HMM_MIRROR an implicit option

2019-08-06 Thread Jason Gunthorpe
On Tue, Aug 06, 2019 at 07:05:52PM +0300, Christoph Hellwig wrote: > Make HMM_MIRROR an option that is selected by drivers wanting to use it > instead of a user visible option as it is just a low-level > implementation detail. > > Signed-off-by: Christoph Hellwig > --- > drivers/gpu/drm/amd/amdg

Re: [PATCH 03/15] nouveau: pass struct nouveau_svmm to nouveau_range_fault

2019-08-06 Thread Jason Gunthorpe
On Tue, Aug 06, 2019 at 07:05:41PM +0300, Christoph Hellwig wrote: > We'll need the nouveau_svmm structure to improve the function soon. > For now this allows using the svmm->mm reference to unlock the > mmap_sem, and thus the same dereference chain that the caller uses > to lock and unlock it. >

Re: [PATCH 15/15] amdgpu: remove CONFIG_DRM_AMDGPU_USERPTR

2019-08-06 Thread Jason Gunthorpe
On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote: > The option is just used to select HMM mirror support and has a very > confusing help text. Just pull in the HMM mirror code by default > instead. > > Signed-off-by: Christoph Hellwig > --- > drivers/gpu/drm/Kconfig

Re: [PATCH 08/15] mm: remove the mask variable in hmm_vma_walk_hugetlb_entry

2019-08-06 Thread Jason Gunthorpe
On Tue, Aug 06, 2019 at 07:05:46PM +0300, Christoph Hellwig wrote: > The pagewalk code already passes the value as the hmask parameter. > > Signed-off-by: Christoph Hellwig > mm/hmm.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) Reviewed-by: Jason Gunthorpe Jason ___

Re: [PATCH v2 01/34] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-08-06 Thread Ira Weiny
On Sun, Aug 04, 2019 at 03:48:42PM -0700, john.hubb...@gmail.com wrote: > From: John Hubbard > > Provide a more capable variation of put_user_pages_dirty_lock(), > and delete put_user_pages_dirty(). This is based on the > following: > > 1. Lots of call sites become simpler if a bool is passed >

[PATCH] drm/amdgpu: fix gfx9 soft recovery

2019-08-06 Thread Pelloux-prayer, Pierre-eric
The SOC15_REG_OFFSET() macro wasn't used, making the soft recovery fail. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx

Re: [PATCH v2] drm/amdkfd: Remove GPU ID in GWS queue creation

2019-08-06 Thread Kuehling, Felix
On 2019-08-01 17:14, Greathouse, Joseph wrote: > The gpu_id argument is not needed when enabling GWS on a queue. > The queue can only be associated with one device, so the only > possible situations for the call as previously defined were: > 1) the gpu_id was for the device associated with the targ

Re: [PATCH] drm/amdgpu: fix gfx9 soft recovery

2019-08-06 Thread Alex Deucher
On Tue, Aug 6, 2019 at 2:19 PM Pelloux-prayer, Pierre-eric wrote: > > The SOC15_REG_OFFSET() macro wasn't used, making the soft recovery fail. > > Signed-off-by: Pierre-Eric Pelloux-Prayer > --- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > d

Re: [PATCH 15/15] amdgpu: remove CONFIG_DRM_AMDGPU_USERPTR

2019-08-06 Thread Alex Deucher
On Tue, Aug 6, 2019 at 1:51 PM Kuehling, Felix wrote: > > On 2019-08-06 13:44, Jason Gunthorpe wrote: > > On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote: > >> The option is just used to select HMM mirror support and has a very > >> confusing help text. Just pull in the HMM mirr

Re: [PATCH] drm/amd/display: Add number of slices per line to DSC parameter validation

2019-08-06 Thread Alex Deucher
On Tue, Aug 6, 2019 at 1:45 PM Harry Wentland wrote: > > From: Nikola Cornij > > [why] > Number of slices per line was mistakenly left out > > Cc: Hariprasad Kelam > Signed-off-by: Nikola Cornij > Signed-off-by: Harry Wentland > Reviewed-by: Harry Wentland Acked-by: Alex Deucher > --- > >

Re: [PATCH] drm/amdgpu: fix compile error about readq/writeq on arm ARCH

2019-08-06 Thread Alex Deucher
On Tue, Aug 6, 2019 at 7:26 AM Christian König wrote: > > Am 06.08.19 um 12:31 schrieb Tao Zhou: > > readq/writeq can't be found on arm architecture, implement them > > with 32 bits operations > > Mhm, wasn't the whole point about using readq/writeq that we needed > 64bit atomic operations? It mi

[pull] amdgpu, amdkfd, radeon, ttm drm-next-5.4

2019-08-06 Thread Alex Deucher
Hi Dave, Daniel, The big updates here are support for new asics (navi14, navi12, arcturus). The following changes since commit 41a5a2a8531f95d18bb4efddea581ccb469e8ee5: drm/amd/display: init res_pool dccg_ref, dchub_ref with xtalin_freq (2019-07-18 14:12:08 -0500) are available in the Git re

Re: [PATCH 15/15] amdgpu: remove CONFIG_DRM_AMDGPU_USERPTR

2019-08-06 Thread Jason Gunthorpe
On Tue, Aug 06, 2019 at 02:58:58PM -0400, Alex Deucher wrote: > On Tue, Aug 6, 2019 at 1:51 PM Kuehling, Felix wrote: > > > > On 2019-08-06 13:44, Jason Gunthorpe wrote: > > > On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote: > > >> The option is just used to select HMM mirror sup

Re: [PATCH v2 01/34] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-08-06 Thread John Hubbard
On 8/6/19 10:39 AM, Ira Weiny wrote: > On Sun, Aug 04, 2019 at 03:48:42PM -0700, john.hubb...@gmail.com wrote: >> From: John Hubbard ... >> - >> /** >> - * put_user_pages_dirty() - release and dirty an array of gup-pinned pages >> - * @pages: array of pages to be marked dirty and released. >> +

[PATCH AUTOSEL 5.2 31/59] drm/amdgpu: fix error handling in amdgpu_cs_process_fence_dep

2019-08-06 Thread Sasha Levin
From: Christian König [ Upstream commit 67d0859e2758ef992fd32499747ce4b1038a63c0 ] We always need to drop the ctx reference and should check for errors first and then dereference the fence pointer. Signed-off-by: Christian König Reviewed-by: Chunming Zhou Signed-off-by: Alex Deucher Signed-o

[PATCH AUTOSEL 5.2 29/59] drm/amdkfd: Fix byte align on VegaM

2019-08-06 Thread Sasha Levin
From: Kent Russell [ Upstream commit d65848657c3da5c0d4b685f823d0230f151ab34e ] This was missed during the addition of VegaM support Reviewed-by: Alex Deucher Signed-off-by: Kent Russell Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpu

[PATCH AUTOSEL 5.2 32/59] drm/amdgpu: fix a potential information leaking bug

2019-08-06 Thread Sasha Levin
From: Wang Xiayang [ Upstream commit 929e571c04c285861e0bb049a396a2bdaea63282 ] Coccinelle reports a path that the array "data" is never initialized. The path skips the checks in the conditional branches when either of callback functions, read_wave_vgprs and read_wave_sgprs, is not registered. L

[PATCH AUTOSEL 5.2 30/59] drm/amd/powerplay: fix null pointer dereference around dpm state relates

2019-08-06 Thread Sasha Levin
From: Evan Quan [ Upstream commit 479156f2e5540077377a823eaf5a4263bd329063 ] DPM state relates are not supported on the new SW SMU ASICs. But still it's not OK to trigger null pointer dereference on accessing them. Signed-off-by: Evan Quan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher

[PATCH AUTOSEL 4.19 16/32] drm/amdgpu: fix a potential information leaking bug

2019-08-06 Thread Sasha Levin
From: Wang Xiayang [ Upstream commit 929e571c04c285861e0bb049a396a2bdaea63282 ] Coccinelle reports a path that the array "data" is never initialized. The path skips the checks in the conditional branches when either of callback functions, read_wave_vgprs and read_wave_sgprs, is not registered. L

[PATCH v3 hmm 02/11] mm/mmu_notifiers: do not speculatively allocate a mmu_notifier_mm

2019-08-06 Thread Jason Gunthorpe
From: Jason Gunthorpe A prior commit e0f3c3f78da2 ("mm/mmu_notifier: init notifier if necessary") made an attempt at doing this, but had to be reverted as calling the GFP_KERNEL allocator under the i_mmap_mutex causes deadlock, see commit 35cfa2b0b491 ("mm/mmu_notifier: allocate mmu_notifier in a

[PATCH v3 hmm 07/11] RDMA/odp: remove ib_ucontext from ib_umem

2019-08-06 Thread Jason Gunthorpe
From: Jason Gunthorpe At this point the ucontext is only being stored to access the ib_device, so just store the ib_device directly instead. This is more natural and logical as the umem has nothing to do with the ucontext. Signed-off-by: Jason Gunthorpe --- drivers/infiniband/core/umem.c |

[PATCH v3 hmm 00/11] Add mmu_notifier_get/put for managing mmu notifier registrations

2019-08-06 Thread Jason Gunthorpe
From: Jason Gunthorpe This series introduces a new registration flow for mmu_notifiers based on the idea that the user would like to get a single refcounted piece of memory for a mm, keyed to its use. For instance many users of mmu_notifiers use an interval tree or similar to dispatch notificati

[PATCH v3 hmm 01/11] mm/mmu_notifiers: hoist do_mmu_notifier_register down_write to the caller

2019-08-06 Thread Jason Gunthorpe
From: Jason Gunthorpe This simplifies the code to not have so many one line functions and extra logic. __mmu_notifier_register() simply becomes the entry point to register the notifier, and the other one calls it under lock. Also add a lockdep_assert to check that the callers are holding the loc

[PATCH v3 hmm 03/11] mm/mmu_notifiers: add a get/put scheme for the registration

2019-08-06 Thread Jason Gunthorpe
From: Jason Gunthorpe Many places in the kernel have a flow where userspace will create some object and that object will need to connect to the subsystem's mmu_notifier subscription for the duration of its lifetime. In this case the subsystem is usually tracking multiple mm_structs and it is dif

[PATCH v3 hmm 09/11] drm/amdkfd: fix a use after free race with mmu_notifer unregister

2019-08-06 Thread Jason Gunthorpe
From: Jason Gunthorpe When using mmu_notifer_unregister_no_release() the caller must ensure there is a SRCU synchronize before the mn memory is freed, otherwise use after free races are possible, for instance: CPU0 CPU1

[PATCH v3 hmm 10/11] drm/amdkfd: use mmu_notifier_put

2019-08-06 Thread Jason Gunthorpe
From: Jason Gunthorpe The sequence of mmu_notifier_unregister_no_release(), mmu_notifier_call_srcu() is identical to mmu_notifier_put() with the free_notifier callback. As this is the last user of those APIs, converting it means we can drop them. Signed-off-by: Jason Gunthorpe --- drivers/gpu

[PATCH v3 hmm 08/11] drm/radeon: use mmu_notifier_get/put for struct radeon_mn

2019-08-06 Thread Jason Gunthorpe
From: Jason Gunthorpe radeon is using a device global hash table to track what mmu_notifiers have been registered on struct mm. This is better served with the new get/put scheme instead. radeon has a bug where it was not blocking notifier release() until all the BO's had been invalidated. This c

[PATCH v3 hmm 04/11] misc/sgi-gru: use mmu_notifier_get/put for struct gru_mm_struct

2019-08-06 Thread Jason Gunthorpe
From: Jason Gunthorpe GRU is already using almost the same algorithm as get/put, it even helpfully has a 10 year old comment to make this algorithm common, which is finally happening. There are a few differences and fixes from this conversion: - GRU used rcu not srcu to read the hlist - Unclear

[PATCH v3 hmm 06/11] RDMA/odp: use mmu_notifier_get/put for 'struct ib_ucontext_per_mm'

2019-08-06 Thread Jason Gunthorpe
From: Jason Gunthorpe This is a significant simplification, no extra list is kept per FD, and the interval tree is now shared between all the ucontexts, reducing overhead if there are multiple ucontexts active. Signed-off-by: Jason Gunthorpe --- drivers/infiniband/core/umem_odp.c| 170

[PATCH v3 hmm 05/11] hmm: use mmu_notifier_get/put for 'struct hmm'

2019-08-06 Thread Jason Gunthorpe
From: Jason Gunthorpe This is a significant simplification, it eliminates all the remaining 'hmm' stuff in mm_struct, eliminates krefing along the critical notifier paths, and takes away all the ugly locking and abuse of page_table_lock. mmu_notifier_get() provides the single struct hmm per stru

[PATCH v3 hmm 11/11] mm/mmu_notifiers: remove unregister_no_release

2019-08-06 Thread Jason Gunthorpe
From: Jason Gunthorpe mmu_notifier_unregister_no_release() and mmu_notifier_call_srcu() no longer have any users, they have all been converted to use mmu_notifier_put(). So delete this difficult to use interface. Signed-off-by: Jason Gunthorpe --- include/linux/mmu_notifier.h | 5 - mm/m

Re: [PATCH v3 hmm 10/11] drm/amdkfd: use mmu_notifier_put

2019-08-06 Thread Kuehling, Felix
On 2019-08-06 19:15, Jason Gunthorpe wrote: > From: Jason Gunthorpe > > The sequence of mmu_notifier_unregister_no_release(), > mmu_notifier_call_srcu() is identical to mmu_notifier_put() with the > free_notifier callback. > > As this is the last user of those APIs, converting it means we can drop

RE: [PATCH libdrm 2/3] tests/amdgpu/ras: refine ras eject test

2019-08-06 Thread Chen, Guchun
Thanks for Hawking's and Tao's review. I will post patch v2 to address your comment. Regards, Guchun -Original Message- From: Zhou1, Tao Sent: Tuesday, August 6, 2019 6:07 PM To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Li, Dennis ; Pan, Xinhui Cc: Li, Dennis ;

[PATCH v3 07/41] drm/etnaviv: convert release_pages() to put_user_pages()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 41/41] mm/ksm: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 04/41] net/rds: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 35/41] kernel/events/core.c: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 22/41] xen: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 32/41] crypt: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 14/41] vmci: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 20/41] fbdev/pvr2fb: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 10/41] media/ivtv: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 26/41] futex: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 21/41] fsl_hypervisor: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 11/41] media/v4l2-core/mm: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 27/41] mm/frame_vector.c: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 05/41] net/ceph: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 02/41] drivers/gpu/drm/via: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 24/41] orangefs: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 31/41] mm/process_vm_access.c: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 40/41] mm/mempolicy.c: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 06/41] x86/kvm: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder versions"). Cc: Joe

[PATCH v3 15/41] rapidio: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

Re: [PATCH v3 00/39] put_user_pages(): miscellaneous call sites

2019-08-06 Thread John Hubbard
On 8/6/19 6:32 PM, john.hubb...@gmail.com wrote: > From: John Hubbard > ... > > John Hubbard (38): > mm/gup: add make_dirty arg to put_user_pages_dirty_lock() ... > 54 files changed, 191 insertions(+), 323 deletions(-) > ahem, yes, apparently this is what happens if I add a few patches while

[PATCH v3 28/41] mm/gup_benchmark.c: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 08/41] drm/i915: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 17/41] staging/vc04_services: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 18/41] drivers/tee: convert put_page() to put_user_page*()

2019-08-06 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

  1   2   >