RE: [PATCH] drm/amdgpu: Fix panic during gpu reset

Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Pan, Xinhui Sent: 2019年8月5日 14:58 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Liu, Monk Subject: [PATCH] drm/amdgpu: Fix panic during gpu reset Clear the flag after hw suspend, oth

[PATCH] drm/amd/powerplay: skip pcie params override on Arcturus

This is not supported on Arcturus. Affected ASIC: Arcturus Change-Id: I62a8bce17a070ce4eda5fa22f4b12a7ffa1201cd Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/amdgp

RE: [PATCH] drm/amd/powerplay: skip pcie params override on Arcturus

Please combine the 2 close "if (adev->asic_type != CHIP_ARCTURUS) {". With that fixed: Reviewed-by: Le Ma Regards, Ma Le -Original Message- From: amd-gfx On Behalf Of Evan Quan Sent: Monday, August 05, 2019 3:13 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/

[PATCH] drm/amdgpu: update ras sysfs feature info

remove confused ras error type info Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index d2e8a85f6e38..36

RE: [PATCH] drm/amdgpu: update ras sysfs feature info

Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: 2019年8月5日 16:04 To: amd-gfx@lists.freedesktop.org; Pan, Xinhui ; Zhang, Hawking Cc: Zhou1, Tao Subject: [PATCH] drm/amdgpu: update ras sysfs feature info remove confused ras error

[PATCH] drm/amdgpu/soc15: fix external_rev_id for navi14

From: tiancyin fix the hard code external_rev_id. Change-Id: I7b46f7b49b6d0586d1fa282d4961815fb124379b Signed-off-by: tiancyin --- drivers/gpu/drm/amd/amdgpu/nv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv

Re: [PATCH 1/2] drm/amdgpu: Export function to flush TLB of specific vm hub

Am 02.08.19 um 18:04 schrieb Zeng, Oak: This is for kfd to reuse amdgpu TLB invalidation function. There is already a gmc function flush_gpu_tlb to flush TLB on all vm hub. On gfx10, kfd only needs to flush TLB on gfx hub but not on mm hub. So export a function for KFD flush TLB only on gfx hub.

RE: [PATCH] drm/amdgpu/soc15: fix external_rev_id for navi14

Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Tianci Yin Sent: 2019年8月5日 17:35 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Xiao, Jack ; Yuan, Xiaojie ; Yin, Tianci (Rico) Subject: [PATCH] drm/amdgpu/soc15: fix external_rev_id for navi14 From: tiancyi

RE: [PATCH] drm/amdgpu/soc15: fix external_rev_id for navi14

BTW, please make sure you have the latest drm-next code base. The deleted code seems like in some topic branch. Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Zhang, Hawking Sent: 2019年8月5日 17:45 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Yi

Re: [PATCH] drm/amdgpu/soc15: fix external_rev_id for navi14

Reviewed-by: Xiaojie Yuan BR, Xiaojie From: Tianci Yin Sent: Monday, August 5, 2019 5:35 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking; Xiao, Jack; Yuan, Xiaojie; Yin, Tianci (Rico) Subject: [PATCH] drm/amdgpu/soc15: fix external_rev_id for nav

[PATCH] drm/amdgpu/discovery: move common discovery code out of navi1*_reg_base_init()

move amdgpu_discovery_reg_base_init() from navi1*_reg_base_init() to a common function nv_reg_base_init(). Signed-off-by: Xiaojie Yuan --- drivers/gpu/drm/amd/amdgpu/navi10_reg_init.c | 14 +- drivers/gpu/drm/amd/amdgpu/navi14_reg_init.c | 14 +- drivers/gpu/drm/amd/amdgpu/nv.c

RE: [PATCH] drm/amdgpu/discovery: move common discovery code out of navi1*_reg_base_init()

Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Yuan, Xiaojie Sent: 2019年8月5日 17:55 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Xiao, Jack ; Yuan, Xiaojie Subject: [PATCH] drm/amdgpu/discovery: move common discovery code out of navi1*_reg_base_init()

RE: [PATCH] drm/amdgpu/soc15: fix external_rev_id for navi14

Thanks Hawking, I'll take care of the difference on topic branch and drm-next. -Original Message- From: Zhang, Hawking Sent: Monday, August 5, 2019 5:49 PM To: Zhang, Hawking ; Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Yin, Tianci (Rico) ; Yuan, Xiaojie Subj

[PATCH][drm-next] drm/amd/powerplay: remove redundant duplicated return check

From: Colin Ian King The check on ret is duplicated in two places, it is redundant code. Remove it. Addresses-Coverity: ("Logically dead code") Fixes: b94afb61cdae ("drm/amd/powerplay: honor hw limit on fetching metrics data for navi10") Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/p

Re: next/master build: 230 builds: 5 failed, 225 passed, 6 errors, 1344 warnings (next-20190805)

On Mon, Aug 05, 2019 at 02:40:32AM -0700, kernelci.org bot wrote: Today's -next fails to build an arm allmodconfig due to: > allmodconfig (arm, gcc-8) — FAIL, 2 errors, 16 warnings, 0 section mismatches > > Errors: > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:279:9: error: implicit > declar

[PATCH v5 14/18] drm/amdgpu: switch driver from bo->resv to bo->base.resv

Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 6 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +- drivers/g

[PATCH v5 04/18] drm/radeon: use embedded gem object

Drop drm_gem_object from radeon_bo, use the ttm_buffer_object.base instead. Build tested only. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/radeon/radeon.h | 3 +-- drivers/gpu/drm/radeon/radeon_cs.c | 2 +- drivers/gpu/drm/radeon/radeon_display.

[PATCH v5 05/18] drm/amdgpu: use embedded gem object

Drop drm_gem_object from amdgpu_bo, use the ttm_buffer_object.base instead. Build tested only. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgp

[PATCH v5 08/18] drm/ttm: use gem vma_node

Drop vma_node from ttm_buffer_object, use the gem struct (base.vma_node) instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +- drivers/gpu/drm/qxl/qxl_object.h | 2 +- drivers/gpu/drm/radeon/radeon_object.h | 2 +-

[PATCH v5 12/18] drm/radeon: switch driver from bo->resv to bo->base.resv

Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/radeon/radeon_benchmark.c | 4 ++-- drivers/gpu/drm/radeon/radeon_cs.c| 2 +- drivers/gpu/drm/radeon/radeon_display.c | 2 +- drivers/gpu/drm/radeon/radeon_gem.c | 6 +++--- drivers/gpu/drm/radeon/radeo

[drm:amdgpu_ctx_mgr_entity_fini [amdgpu]] *ERROR* ctx 00000000189dec14 is still alive

Hi All, Sometime dmesg show this log: [10407.720988] [drm:amdgpu_ctx_mgr_entity_fini [amdgpu]] *ERROR* ctx 189dec14 is still alive [10407.721054] [drm:amdgpu_ctx_mgr_entity_fini [amdgpu]] *ERROR* ctx 189dec14 is still alive [10407.721120] [drm:amdgpu_ctx_mgr_entity_fini [amdgp

Re: [PATCH 12/13] drm/tilcdc: Provide ddc symlink in connector sysfs directory

On 31/07/2019 19:58, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > Acked-by: Sam Ravnborg > Reviewed-by: Emil Velikov Acked-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 6 -- > 1 file c

[PATCH v6 04/17] drm/radeon: use embedded gem object

Drop drm_gem_object from radeon_bo, use the ttm_buffer_object.base instead. Build tested only. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/radeon/radeon.h | 3 +-- drivers/gpu/drm/radeon/radeon_cs.c | 2 +- drivers/gpu/drm/radeon/radeon_display.

[PATCH v6 13/17] drm/amdgpu: switch driver from bo->resv to bo->base.resv

Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 6 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +- drivers/g

[PATCH v6 11/17] drm/radeon: switch driver from bo->resv to bo->base.resv

Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/radeon/radeon_benchmark.c | 4 ++-- drivers/gpu/drm/radeon/radeon_cs.c| 2 +- drivers/gpu/drm/radeon/radeon_display.c | 2 +- drivers/gpu/drm/radeon/radeon_gem.c | 6 +++--- drivers/gpu/drm/radeon/radeo

[PATCH v6 05/17] drm/amdgpu: use embedded gem object

Drop drm_gem_object from amdgpu_bo, use the ttm_buffer_object.base instead. Build tested only. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgp

[PATCH v6 08/17] drm/ttm: use gem vma_node

Drop vma_node from ttm_buffer_object, use the gem struct (base.vma_node) instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +- drivers/gpu/drm/qxl/qxl_object.h | 2 +- drivers/gpu/drm/radeon/radeon_object.h | 2 +-

Re: [drm:amdgpu_ctx_mgr_entity_fini [amdgpu]] *ERROR* ctx 00000000189dec14 is still alive

Am 05.08.19 um 14:53 schrieb ??: Hi All, ?0?2 ?0?2 Sometime dmesg show this log: [10407.720988] [drm:amdgpu_ctx_mgr_entity_fini [amdgpu]] *ERROR* ctx 189dec14 is still alive [10407.721054] [drm:amdgpu_ctx_mgr_entity_fini [amdgpu]] *ERROR* ctx 189dec14 is still alive [10407.7

Re: [PATCH v2 06/34] drm/i915: convert put_page() to put_user_page*()

On Sun, Aug 04, 2019 at 03:48:47PM -0700, john.hubb...@gmail.com wrote: > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversio

Re: The issue with page allocation 5.3 rc1-rc2 (seems drm culprit here)

On Mon, 5 Aug 2019 at 08:21, Hillf Danton wrote: > > > > Try to fix the failure above using vmalloc + kmalloc. > > --- a/drivers/gpu/drm/amd/display/dc/core/dc.c > +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c > @@ -1174,8 +1174,12 @@ struct dc_state *dc_create_state(struct > struct dc_st

[PATCH] gpu: drm: amd: powerplay: Remove logically dead code

Result of pointer airthmentic is never null fix coverity defect:1451876 Signed-off-by: Hariprasad Kelam --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c index

[PATCH] gpu: drm: amd: display: dc: dcn20: Remove redudant condition

Remove redudant codition "dsc_cfg->dc_dsc_cfg.num_slices_v". fixes coverity defect 1451853 Signed-off-by: Hariprasad Kelam --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c b

XDC 2019: Schedule published & Workshops CfP reopened!

Hello, The preliminary schedule for XDC 2019 has been published! https://xdc2019.x.org/event/5/timetable/#20191002.detailed XDC 2019 will take place at the Concordia University Conference Centre in Montréal, Canada on October 2-4, 2019. If you haven't already done so, now is the time to book you

[PATCH 00/10] Enable clock gating for Navi12

Alex has helped to reviewed these patches in AMD internally. Re-send them to public mail list. Xiaojie Yuan (10): drm/amdgpu: enable gfx clock gatings for navi12 drm/amdgpu: enable hdp clock gating for navi12 drm/amdgpu/sdma5: set sdma clock gating for navi12 drm/amdgpu: enable sdma clock

[PATCH 01/10] drm/amdgpu: enable gfx clock gatings for navi12

enables following gfx clock gating features: - medium grained clock gating - medium grained light sleep - coarse grained clock gating - cp memory light sleep - rlc memory light sleep CGLS (Coarse Grained Light Sleep) will break s3, so don't enable it. Signed-off-by: Xiaojie Yuan Reviewed-by: Al

[PATCH 10/10] drm/amdgpu: enable vcn clock gating for navi12

enables vcn medium grained clock gating Signed-off-by: Xiaojie Yuan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c index 302c60b14196..a13032fde

[PATCH 06/10] drm/amdgpu: enable mmhub clock gating for navi12

enables mmhub medium grained clock gating and memory light sleep Signed-off-by: Xiaojie Yuan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c ind

[PATCH 03/10] drm/amdgpu/sdma5: set sdma clock gating for navi12

add navi12 define Signed-off-by: Xiaojie Yuan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c index 2a9512132520..a54ee320961e 100644 --- a/d

[PATCH 04/10] drm/amdgpu: enable sdma clock gating for navi12

enables sdma medium grained clock gating and memory light sleep Signed-off-by: Xiaojie Yuan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c inde

[PATCH 05/10] drm/amdgpu/mmhub2: set clock gating for navi12

add navi12 define Signed-off-by: Xiaojie Yuan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c index 9d8acb4c2e22..beef51c3746f 100644 ---

[PATCH 09/10] drm/amdgpu: enable athub clock gating for navi12

enables athub medium grained clock gating and memory light sleep Signed-off-by: Xiaojie Yuan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c ind

[PATCH 02/10] drm/amdgpu: enable hdp clock gating for navi12

enables hdp medium grained clock gating and memory light sleep Signed-off-by: Xiaojie Yuan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c index

[PATCH 07/10] drm/amdgpu: enable ih clock gating for navi12

enables ih clock gating Signed-off-by: Xiaojie Yuan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c index 9b97b2543454..bc529f0a6b5b 100644 --- a/drivers/gpu/drm/a

[PATCH 08/10] drm/amdgpu/athub2: set clock gating for navi12

add navi12 define Signed-off-by: Xiaojie Yuan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/athub_v2_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/athub_v2_0.c b/drivers/gpu/drm/amd/amdgpu/athub_v2_0.c index d3d7c2176933..45f262c6c60f 100644 ---