Re: [PATCH 16/34] drivers/tee: convert put_page() to put_user_page*()

2019-08-02 Thread Jens Wiklander
On Fri, Aug 2, 2019 at 4:20 AM wrote: > > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as described in commit fc1d8e7

Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-02 Thread Peter Zijlstra
On Thu, Aug 01, 2019 at 07:16:19PM -0700, john.hubb...@gmail.com wrote: > This is part a tree-wide conversion, as described in commit fc1d8e7cca2d > ("mm: introduce put_user_page*(), placeholder versions"). That commit > has an extensive description of the problem and the planned steps to > solve

Re: [PATCH 20/34] xen: convert put_page() to put_user_page*()

2019-08-02 Thread John Hubbard
On 8/1/19 9:36 PM, Juergen Gross wrote: On 02.08.19 04:19, john.hubb...@gmail.com wrote: From: John Hubbard ... diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 2f5ce7230a43..29e461dbee2d 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -611,15 +611,10 @@ stat

Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-02 Thread Michal Hocko
On Thu 01-08-19 19:19:31, john.hubb...@gmail.com wrote: [...] > 2) Convert all of the call sites for get_user_pages*(), to > invoke put_user_page*(), instead of put_page(). This involves dozens of > call sites, and will take some time. How do we make sure this is the case and it will remain the ca

Re: [PATCH 06/34] drm/i915: convert put_page() to put_user_page*()

2019-08-02 Thread Joonas Lahtinen
Quoting john.hubb...@gmail.com (2019-08-02 05:19:37) > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as described in

[PATCH] drm/amd/powerplay: correct navi10 vcn powergate

2019-08-02 Thread Evan Quan
vcn dpm on is a prerequisite for vcn power gate control. Change-Id: If89a81bc0709f1c26569e378507a873cfaf6e0ef Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 4 +++- .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 1 + drivers/gpu/drm/amd/powerplay/navi10_ppt.c

RE: [PATCH] drm/amdgpu: remove unpin clear_state_obj for gfx v8

2019-08-02 Thread Huang, Ray
Is the issue triggered on APU? Actually, while we do S3, the vram bo won't be cleared on APU. This patch is to fix the vram bo clearing on the DGPU side. Thanks, Ray > -Original Message- > From: amd-gfx On Behalf Of > Yuan, Xiaojie > Sent: Friday, August 02, 2019 2:12 PM > To: Gao, Lik

RE: [PATCH] drm/amd/powerplay: correct navi10 vcn powergate

2019-08-02 Thread Feng, Kenneth
Reviewed-by: Kenneth Feng -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Evan Quan Sent: Friday, August 02, 2019 5:27 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: correct navi10 vcn powergate [CAU

RE: [PATCH] drm/amdgpu: remove unpin clear_state_obj for gfx v8

2019-08-02 Thread Gao, Likun
This issue occurred on Stoney. Regards, Likun -Original Message- From: Huang, Ray Sent: Friday, August 2, 2019 5:36 PM To: Yuan, Xiaojie ; Gao, Likun ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Paul Gover Subject: RE: [PATCH] drm/amdgpu: remove unpin clear_state_obj for

Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel

2019-08-02 Thread Catalin Marinas
On Thu, Aug 01, 2019 at 08:36:47AM -0700, Dave Hansen wrote: > On 8/1/19 5:48 AM, Andrey Konovalov wrote: > > On Thu, Aug 1, 2019 at 2:11 PM Kevin Brodsky wrote: > >> On 31/07/2019 17:50, Dave Hansen wrote: > >>> On 7/23/19 10:58 AM, Andrey Konovalov wrote: > The mmap and mremap (only new_add

Re: [PATCH 20/34] xen: convert put_page() to put_user_page*()

2019-08-02 Thread Juergen Gross
On 02.08.19 07:48, John Hubbard wrote: On 8/1/19 9:36 PM, Juergen Gross wrote: On 02.08.19 04:19, john.hubb...@gmail.com wrote: From: John Hubbard ... diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 2f5ce7230a43..29e461dbee2d 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/

Re: [PATCH v19 02/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

2019-08-02 Thread Catalin Marinas
On Thu, Aug 01, 2019 at 09:45:05AM -0700, Dave Hansen wrote: > On 8/1/19 5:38 AM, Kevin Brodsky wrote: > > This patch series only changes what is allowed or not at the syscall > > interface. It does not change the address space size. On arm64, TBI (Top > > Byte Ignore) has always been enabled for u

[PATCH AUTOSEL 5.2 19/76] drm/amd/display: fix DMCU hang when going into Modern Standby

2019-08-02 Thread Sasha Levin
From: Zi Yu Liao [ Upstream commit 1ca068ed34d6b39d336c1b0d618ed73ba8f04548 ] [why] When the system is going into suspend, set_backlight gets called after the eDP got blanked. Since smooth brightness is enabled, the driver will make a call into the DMCU to ramp the brightness. The DMCU would try

[PATCH AUTOSEL 5.2 21/76] drm/amd/display: put back front end initialization sequence

2019-08-02 Thread Sasha Levin
From: Eric Yang [ Upstream commit feb7eb522e0a7a22c1e60d386bd3c3bfa1d5e4f7 ] [Why] Seamless boot optimization removed proper front end power off sequence. In driver disable enable case, this causes driver to power gate hubp and dpp while there is still memory fetching going on, this can cause in

[PATCH AUTOSEL 5.2 22/76] drm/amd/display: allocate 4 ddc engines for RV2

2019-08-02 Thread Sasha Levin
From: Derek Lai [ Upstream commit 67fd6c0d2de8e51e84ff3fa6e68bbd524f823e49 ] [Why] Driver will create 0, 1, and 2 ddc engines for RV2, but some platforms used 0, 1, and 3. [How] Still allocate 4 ddc engines for RV2. Signed-off-by: Derek Lai Reviewed-by: Aric Cyr Acked-by: Leo Li Signed-off-

[PATCH AUTOSEL 5.2 23/76] drm/amd/display: Fix dc_create failure handling and 666 color depths

2019-08-02 Thread Sasha Levin
From: Julian Parkin [ Upstream commit 0905f32977268149f06e3ce6ea4bd6d374dd891f ] [Why] It is possible (but very unlikely) that constructing dc fails before current_state is created. We support 666 color depth in some scenarios, but this isn't handled in get_norm_pix_clk. It uses exactly the sam

[PATCH AUTOSEL 5.2 25/76] drm/amd/display: Increase size of audios array

2019-08-02 Thread Sasha Levin
From: Tai Man [ Upstream commit 7352193a33dfc9b69ba3bf6a8caea925b96243b1 ] [Why] The audios array defined in "struct resource_pool" is only 6 (MAX_PIPES) but the max number of audio devices (num_audio) is 7. In some projects, it will run out of audios array. [How] Incraese the audios array size

[PATCH AUTOSEL 5.2 24/76] drm/amd/display: Only enable audio if speaker allocation exists

2019-08-02 Thread Sasha Levin
From: Alvin Lee [ Upstream commit 6ac25e6d5b2fbf251e9fa2f4131d42c815b43867 ] [Why] In dm_helpers_parse_edid_caps, there is a corner case where no speakers can be allocated even though the audio mode count is greater than 0. Enabling audio when no speaker allocations exists can cause issues in t

[PATCH AUTOSEL 5.2 18/76] drm/amd/display: Wait for backlight programming completion in set backlight level

2019-08-02 Thread Sasha Levin
From: SivapiriyanKumarasamy [ Upstream commit c7990daebe71d11a9e360b5c3b0ecd1846a3a4bb ] [WHY] Currently we don't wait for blacklight programming completion in DMCU when setting backlight level. Some sequences such as PSR static screen event trigger reprogramming requires it to be complete. [Ho

[PATCH AUTOSEL 5.2 20/76] drm/amd/display: use encoder's engine id to find matched free audio device

2019-08-02 Thread Sasha Levin
From: Tai Man [ Upstream commit 74eda776d7a4e69ec7aa1ce30a87636f14220fbb ] [Why] On some platforms, the encoder id 3 is not populated. So the encoders are not stored in right order as index (id: 0, 1, 2, 4, 5) at pool. This would cause encoders id 4 & id 5 to fail when finding corresponding audi

[PATCH AUTOSEL 4.19 09/42] drm/amd/display: Fix dc_create failure handling and 666 color depths

2019-08-02 Thread Sasha Levin
From: Julian Parkin [ Upstream commit 0905f32977268149f06e3ce6ea4bd6d374dd891f ] [Why] It is possible (but very unlikely) that constructing dc fails before current_state is created. We support 666 color depth in some scenarios, but this isn't handled in get_norm_pix_clk. It uses exactly the sam

[PATCH AUTOSEL 4.19 07/42] drm/amd/display: Wait for backlight programming completion in set backlight level

2019-08-02 Thread Sasha Levin
From: SivapiriyanKumarasamy [ Upstream commit c7990daebe71d11a9e360b5c3b0ecd1846a3a4bb ] [WHY] Currently we don't wait for blacklight programming completion in DMCU when setting backlight level. Some sequences such as PSR static screen event trigger reprogramming requires it to be complete. [Ho

[PATCH AUTOSEL 4.19 08/42] drm/amd/display: use encoder's engine id to find matched free audio device

2019-08-02 Thread Sasha Levin
From: Tai Man [ Upstream commit 74eda776d7a4e69ec7aa1ce30a87636f14220fbb ] [Why] On some platforms, the encoder id 3 is not populated. So the encoders are not stored in right order as index (id: 0, 1, 2, 4, 5) at pool. This would cause encoders id 4 & id 5 to fail when finding corresponding audi

[PATCH AUTOSEL 4.19 10/42] drm/amd/display: Only enable audio if speaker allocation exists

2019-08-02 Thread Sasha Levin
From: Alvin Lee [ Upstream commit 6ac25e6d5b2fbf251e9fa2f4131d42c815b43867 ] [Why] In dm_helpers_parse_edid_caps, there is a corner case where no speakers can be allocated even though the audio mode count is greater than 0. Enabling audio when no speaker allocations exists can cause issues in t

[PATCH AUTOSEL 4.19 11/42] drm/amd/display: Increase size of audios array

2019-08-02 Thread Sasha Levin
From: Tai Man [ Upstream commit 7352193a33dfc9b69ba3bf6a8caea925b96243b1 ] [Why] The audios array defined in "struct resource_pool" is only 6 (MAX_PIPES) but the max number of audio devices (num_audio) is 7. In some projects, it will run out of audios array. [How] Incraese the audios array size

Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-02 Thread Jan Kara
On Fri 02-08-19 11:12:44, Michal Hocko wrote: > On Thu 01-08-19 19:19:31, john.hubb...@gmail.com wrote: > [...] > > 2) Convert all of the call sites for get_user_pages*(), to > > invoke put_user_page*(), instead of put_page(). This involves dozens of > > call sites, and will take some time. > > Ho

Re: [PATCH 26/34] mm/gup_benchmark.c: convert put_page() to put_user_page*()

2019-08-02 Thread Keith Busch
On Thu, Aug 01, 2019 at 07:19:57PM -0700, john.hubb...@gmail.com wrote: > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversio

Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-02 Thread Matthew Wilcox
On Fri, Aug 02, 2019 at 02:41:46PM +0200, Jan Kara wrote: > On Fri 02-08-19 11:12:44, Michal Hocko wrote: > > On Thu 01-08-19 19:19:31, john.hubb...@gmail.com wrote: > > [...] > > > 2) Convert all of the call sites for get_user_pages*(), to > > > invoke put_user_page*(), instead of put_page(). This

[PATCH 1/2] drm/amd/display: Validate dc_plane_info and dc_plane_size in atomic check

2019-08-02 Thread Nicholas Kazlauskas
[Why] Pitch, DCC, rotation and mirroring can result in updates that are not UPDATE_TYPE_FAST but UPDATE_TYPE_MED instead. DC needs dc_plane_info and dc_plane_size to make this determination and we aren't currently passing this into DC during atomic check. Underflow (visible or non-visible) can occ

[PATCH 2/2] drm/amd/display: Block immediate flips for non-fast updates

2019-08-02 Thread Nicholas Kazlauskas
[Why] Underflow can occur in the case where we change buffer pitch, DCC state, rotation or mirroring for a plane while also performing an immediate flip. It can also generate a p-state warning stack trace on DCN1 which is typically observed during the cursor handler pipe locking because of how freq

Re: [PATCH 2/2] drm/amd/display: Block immediate flips for non-fast updates

2019-08-02 Thread Francis, David
Series is: Reviewed-by: David Francis From: amd-gfx on behalf of Nicholas Kazlauskas Sent: August 2, 2019 11:11:50 AM To: amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo) ; Francis, David ; Lakha, Bhawanpreet ; Kazlauskas, Nicholas Subject: [PATCH 2/2]

[PATCH 2/2] drm/amdkfd/gfx10: Calling amdgpu functions to invalidate TLB

2019-08-02 Thread Zeng, Oak
Calling amdgpu function to invalidate TLB, instead of using a kfd implementation. Delete the kfd local TLB invalidation implementation. Change-Id: Ia16fcf9091a93b8c0acdaf9981f8a5a1f9a5ca1d Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c | 41 ++

[PATCH 1/2] drm/amdgpu: Export function to flush TLB of specific vm hub

2019-08-02 Thread Zeng, Oak
This is for kfd to reuse amdgpu TLB invalidation function. There is already a gmc function flush_gpu_tlb to flush TLB on all vm hub. On gfx10, kfd only needs to flush TLB on gfx hub but not on mm hub. So export a function for KFD flush TLB only on gfx hub. Change-Id: I58ff00969f88438cfd3dc7e9deb7b

[PATCH v2 2/2] drm: drop DRM_AUTH from PRIME_TO/FROM_HANDLE ioctls

2019-08-02 Thread Emil Velikov
From: Emil Velikov As mentioned by Christian, for drivers which support only primary nodes this changes the returned error from -EACCES into -EOPNOTSUPP/-ENOSYS. For others, this check in particular will be a noop. So let's remove it as suggested by Christian. Cc: Alex Deucher Cc: amd-gfx@list

[PATCH] drm/amdgpu: Fix GPU reset crash regression.

2019-08-02 Thread Andrey Grodzovsky
amdgpu_ip_block.status.hw for GMC wasn't set to false on suspend during GPU reset and so on resume gmc_v9_0_resume wasn't called. Caused by 'drm/amdgpu: fix double ucode load by PSP(v3)' Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++- 1 file changed, 2 in

[PATCH] Revert "drm/amdgpu: fix transform feedback GDS hang on gfx10 (v2)"

2019-08-02 Thread Marek Olšák
From: Marek Olšák This reverts commit b41335c6c0303d100abe89c843e52645d1974cd9. SET_CONFIG_REG writes to memory if register shadowing is enabled, causing a VM fault. NGG streamout is unstable anyway, so all UMDs should use legacy streamout. I think Mesa is the only driver using NGG streamout.

Re: [PATCH 03/34] net/ceph: convert put_page() to put_user_page*()

2019-08-02 Thread Jeff Layton
On Thu, 2019-08-01 at 19:19 -0700, john.hubb...@gmail.com wrote: > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as d

Re: [PATCH] drm/amdgpu: Fix GPU reset crash regression.

2019-08-02 Thread Alex Deucher
On Fri, Aug 2, 2019 at 4:53 PM Andrey Grodzovsky wrote: > > amdgpu_ip_block.status.hw for GMC wasn't set to > false on suspend during GPU reset and so on resume gmc_v9_0_resume > wasn't called. > Caused by 'drm/amdgpu: fix double ucode load by PSP(v3)' > > Signed-off-by: Andrey Grodzovsky Review

Re: [PATCH 31/34] nfs: convert put_page() to put_user_page*()

2019-08-02 Thread Calum Mackay
On 02/08/2019 3:20 am, john.hubb...@gmail.com wrote: From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8

Re: [PATCH 31/34] nfs: convert put_page() to put_user_page*()

2019-08-02 Thread John Hubbard
On 8/2/19 6:27 PM, Calum Mackay wrote: > On 02/08/2019 3:20 am, john.hubb...@gmail.com wrote: ... > Since it's static, and only called twice, might it be better to change its > two callers [nfs_direct_{read,write}_schedule_iovec()] to call > put_user_pages() directly, and remove nfs_direct_relea

RE: [PATCH 20/34] xen: convert put_page() to put_user_page*()

2019-08-02 Thread Weiny, Ira
> > On 02.08.19 07:48, John Hubbard wrote: > > On 8/1/19 9:36 PM, Juergen Gross wrote: > >> On 02.08.19 04:19, john.hubb...@gmail.com wrote: > >>> From: John Hubbard > > ... > >>> diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index > >>> 2f5ce7230a43..29e461dbee2d 100644 > >>> --- a/

Re: [PATCH 06/34] drm/i915: convert put_page() to put_user_page*()

2019-08-02 Thread John Hubbard
On 8/2/19 2:19 AM, Joonas Lahtinen wrote: Quoting john.hubb...@gmail.com (2019-08-02 05:19:37) From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wi

Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-02 Thread John Hubbard
On 8/2/19 1:05 AM, Peter Zijlstra wrote: On Thu, Aug 01, 2019 at 07:16:19PM -0700, john.hubb...@gmail.com wrote: This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder versions"). That commit has an extensive description of the pro

Re: [PATCH 20/34] xen: convert put_page() to put_user_page*()

2019-08-02 Thread John Hubbard
On 8/2/19 9:09 AM, Weiny, Ira wrote: On 02.08.19 07:48, John Hubbard wrote: On 8/1/19 9:36 PM, Juergen Gross wrote: On 02.08.19 04:19, john.hubb...@gmail.com wrote: From: John Hubbard ... If that's not the case (both here, and in 3 or 4 other patches in this series, then as you said, I shou

Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-02 Thread John Hubbard
On 8/2/19 7:52 AM, Jan Kara wrote: On Fri 02-08-19 07:24:43, Matthew Wilcox wrote: On Fri, Aug 02, 2019 at 02:41:46PM +0200, Jan Kara wrote: On Fri 02-08-19 11:12:44, Michal Hocko wrote: On Thu 01-08-19 19:19:31, john.hubb...@gmail.com wrote: [...] 2) Convert all of the call sites for get_use

[PATCH hmm] drm/amdkfd: fix a use after free race with mmu_notififer unregister

2019-08-02 Thread Jason Gunthorpe
When using mmu_notififer_unregister_no_release() the caller must ensure there is a SRCU synchronize before the mn memory is freed, otherwise use after free races are possible, for instance: CPU0 CPU1 invalidate_range_s

Re: [PATCH 16/34] drivers/tee: convert put_page() to put_user_page*()

2019-08-02 Thread John Hubbard
On 8/1/19 11:29 PM, Jens Wiklander wrote: On Fri, Aug 2, 2019 at 4:20 AM wrote: From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion

Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-02 Thread Jan Kara
On Fri 02-08-19 07:24:43, Matthew Wilcox wrote: > On Fri, Aug 02, 2019 at 02:41:46PM +0200, Jan Kara wrote: > > On Fri 02-08-19 11:12:44, Michal Hocko wrote: > > > On Thu 01-08-19 19:19:31, john.hubb...@gmail.com wrote: > > > [...] > > > > 2) Convert all of the call sites for get_user_pages*(), to

[PATCH] radeon: Use only a single work queue thread for crt

2019-08-02 Thread Andi Kleen
From: Andi Kleen I got tired of seeing a lot of radeon-crt kernel threads in ps on my workstation, one for each CPU and one for each display, which never use any CPU time. Surely a single kernel thread is enough to handle the display. Signed-off-by: Andi Kleen --- drivers/gpu/drm/radeon/radeo

Re: libdrm patch merge request

2019-08-02 Thread Alex Deucher
Done. Sorry for the delay. Alex On Tue, Jul 30, 2019 at 10:58 PM Ma, Le wrote: > > Hi Alex, > > > > Could you help to merge following 2 reviewed patches on > https://gitlab.freedesktop.org/lema1/drm/commits/lema1/drm into drm master > branch ? > > tests/amdgpu: disable reset test for now > te